mirror of
https://github.com/ansible-collections/kubernetes.core.git
synced 2026-11-21 22:50:20 +00:00
* fix(meta): add missing modules to helm and k8s action groups
`helm_plugin` and `helm_plugin_info` both build their argument spec from
`HELM_AUTH_ARG_SPEC`, and `k8s_taint` builds its own from `AUTH_ARG_SPEC`,
but none of the three were listed in the action groups. Anyone setting
`module_defaults` on `group/kubernetes.core.helm` or
`group/kubernetes.core.k8s` silently got no defaults for them.
Deliberately left out of the groups, since they do not accept the shared
authentication options and would make `module_defaults` fail for every
user of the group:
- `helm_pull` and `helm_template` take only `binary_path`
- `helm_registry_auth` takes `binary_path` plus its own required `host`,
which is an OCI registry URL rather than a Kubernetes API server
- `kubeconfig` writes a kubeconfig file locally and takes no cluster
connection options
Also documents both action groups in the scenario guide, including the
exclusions above and the distinction from the legacy `k8s` group that
ansible-core defines, which is a different group and does not cover this
collection's modules.
Closes #577
* test(meta): guard action group membership against argspec drift
The action groups in `meta/runtime.yml` were maintained by hand, so
`helm_plugin`, `helm_plugin_info` and `k8s_taint` were able to inherit the
shared authentication arg specs without anyone adding them to a group.
Nothing failed, users just silently got no `module_defaults`.
Asserts the invariant in both directions: a module belongs to a group if
and only if it builds its argument spec from that group's shared constant.
The reverse direction matters too, since a member that does not accept the
shared options makes `module_defaults` fail with "Unsupported parameters"
for every user of the group.
Membership is read statically with `ast`, so the test needs no imports and
runs without a cluster or the `kubernetes` package.
The four modules that are deliberately excluded are listed with their
reasons, so restoring one has to be a decision rather than an oversight.
* fix(tests): satisfy pylint disallowed-name and set an explicit license
ansible-test's pylint profile rejects `_` as a name, which the sanity job
flagged three times. Rather than renaming the throwaways, give the entries
in SHARED_ARG_SPECS named keys so there is nothing to discard when reading
them back.
The header was copied from a sibling test that carries Apache-2.0 because
it derives from kubernetes/kubernetes, so it named the wrong copyright
holder. It now names the author, and keeps Apache-2.0 deliberately: the
collection requirements allow code outside plugins/ that imports no
GPL-3.0-or-later code to use any GPL-3.0-compatible license, and this file
imports only ast, os, pytest and yaml, since it reads group membership
statically rather than importing the modules. A comment records that
reasoning so the constraint is visible if an import is ever added.
* fix(doc): update changelog fragment with the manintainer suggestion
* fix(doc): show helm group defaults in the action group example
abikouo asked for the module_defaults example to cover the helm action
group as well, with tasks that actually consume those defaults. Set
binary_path, kubeconfig and context on group/kubernetes.core.helm and
add helm_repository, helm and helm_info tasks that rely on them; the
namespace in the k8s tasks now matches the release namespace so the
playbook reads as one flow.
---------
(cherry picked from commit 0bc99117af)
Co-authored-by: Yuriy Novostavskiy <yuriy@novostavskiy.kyiv.ua>
Co-authored-by: Bikouo Aubin <79859644+abikouo@users.noreply.github.com>
63 lines
2.1 KiB
YAML
63 lines
2.1 KiB
YAML
---
|
|
requires_ansible: '>=2.16.0'
|
|
|
|
# Only modules that accept the shared authentication options belong in these
|
|
# groups: HELM_AUTH_ARG_SPEC for helm, AUTH_ARG_SPEC for k8s. Adding a module
|
|
# that does not accept them makes module_defaults fail for every user of the
|
|
# group. This excludes helm_pull, helm_registry_auth, helm_template and
|
|
# kubeconfig, which only take a subset (or none) of those options.
|
|
action_groups:
|
|
helm:
|
|
- helm
|
|
- helm_info
|
|
- helm_plugin
|
|
- helm_plugin_info
|
|
- helm_repository
|
|
k8s:
|
|
- k8s
|
|
- k8s_cluster_info
|
|
- k8s_cp
|
|
- k8s_drain
|
|
- k8s_exec
|
|
- k8s_info
|
|
- k8s_json_patch
|
|
- k8s_log
|
|
- k8s_rollback
|
|
- k8s_scale
|
|
- k8s_service
|
|
- k8s_taint
|
|
|
|
plugin_routing:
|
|
inventory:
|
|
openshift:
|
|
redirect: community.okd.openshift
|
|
k8s:
|
|
tombstone:
|
|
removal_version: 6.0.0
|
|
warning_text: >-
|
|
The k8s inventory plugin was slated for deprecation in 3.3.0 and has been removed in release 6.0.0. Use kubernetes.core.k8s_info and ansible.builtin.add_host instead.
|
|
modules:
|
|
k8s_auth:
|
|
redirect: community.okd.k8s_auth
|
|
k8s_facts:
|
|
tombstone:
|
|
removal_version: 2.0.0
|
|
warning_text: Use kubernetes.core.k8s_info instead.
|
|
k8s_raw:
|
|
tombstone:
|
|
removal_version: 0.1.0
|
|
warning_text: The k8s_raw module was slated for deprecation in Ansible 2.10 and has been removed. Use kubernetes.core.k8s instead.
|
|
openshift_raw:
|
|
tombstone:
|
|
removal_version: 0.1.0
|
|
warning_text: The openshift_raw module was slated for deprecation in Ansible 2.10 and has been removed. Use kubernetes.core.k8s instead.
|
|
openshift_scale:
|
|
tombstone:
|
|
removal_version: 0.1.0
|
|
warning_text: The openshift_scale module was slated for deprecation in Ansible 2.10 and has been removed. Use kubernetes.core.k8s_scale instead.
|
|
lookup:
|
|
openshift:
|
|
tombstone:
|
|
removal_version: 0.1.0
|
|
warning_text: The openshift lookup plugin was slated for deprecation in Ansible 2.10 and has been removed. Use kubernetes.core.k8s instead.
|