mirror of
https://github.com/ansible-collections/kubernetes.core.git
synced 2026-11-21 14:48:37 +00:00
* add matrix to test run helm tests with multiple version * fix(ci): resolve SonarCloud security findings in helm integration workflow Enforce HTTPS/TLS for the ansible-core download and pin and wheel-lock the selinux_please_lie_to_me install. Suppress the two remaining findings (ansible-core source install and shared test-requirements.txt pins) that cannot be fixed here without breaking CI, following the existing sonar.issue.ignore.multicriteria pattern. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(ci): fix remaining sanity and SonarCloud quality gate failures Remove stale import-3.9!skip entries from tests/sanity/ignore-2.23.txt; ansible-core devel dropped the import-3.9 sanity test target entirely, so referencing it now fails the "ignores" sanity test itself. Switch the e4/e5 sonar.issue.ignore.multicriteria resourceKey patterns in sonar-project.properties from a bare literal filename to a **/ glob, matching the working e1-e3 patterns. The literal path was not matching during analysis, so the two intended suppressions (githubactions:S8541/S8544 on integration-tests-helm.yaml) never took effect and kept failing the new code security rating gate. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * test(helm): add regression coverage for plain_http/helm-diff fix, enable helm_uninstall target helm_diff: replace the unreachable "< 3.13.0" OCI-chart block (plain_http is only ever true for >= 3.13.0, so the two conditions could never both hold) with a ">= 3.13.0" case that installs helm-diff and runs a plain_http diff upgrade, exercising the exact path the plain_http/--plain-http fix touches. helm_plain_http: replace the HTTPS Bitnami-backed test with one that pushes a local chart to the plain-HTTP registry from setup_helm_registry and exercises helm/helm_pull/helm_template against it, so success assertions verify plain HTTP actually works rather than only that the flag was passed. Also drop the now-stale redis* .gitignore entry. helm_uninstall: add the missing aliases file (every sibling helm target has one; without it the target is not picked up by CI target selection) and replace a dead assertion gated on helm < 3.7.0 with one that matches the versions this target actually runs against (>= 3.8.0). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * fix(ci): make the S8541/S8544 SonarCloud suppressions actually take effect The three flagged lines (ansible-core source install, shared requirements.txt install) have been open since before the suppression rules were added, and two prior attempts at the e4/e5 resourceKey pattern (literal filename, then a **/filename glob) left them unresolved across multiple fresh analyses - already-raised issues on unchanged lines do not appear to get re-evaluated against newly added ignore rules. Broaden e4/e5 to the same .github/workflows/**/*.yaml pattern already proven to work for e3 (confirmed: githubactions:S7637 has 20 open issues org-wide but 0 here, despite this repo having @main references e3 is meant to suppress). This is also a more honest scope: all_green_check.yaml has the identical ansible-core-from-source and shared-requirements.txt patterns, not just integration-tests-helm.yaml. Also make a no-op edit to the two flagged lines (reorder the pip flag and the two -r files; verified zero package overlap between requirements.txt and test-requirements.txt) so SonarCloud treats them as changed and re-evaluates them against the fixed suppression rule, rather than carrying forward the stale pre-suppression issue state. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Fix tests and the possibility to run helm tests locally Fix linters errors --------- Co-authored-by: GomathiS <gosriniv@redhat.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
69 lines
3.7 KiB
Properties
69 lines
3.7 KiB
Properties
# SonarCloud project configuration for kubernetes.core
|
|
# Parameters: https://docs.sonarqube.org/latest/analysis/analysis-parameters/
|
|
|
|
sonar.projectKey=ansible-collections_kubernetes.core
|
|
sonar.organization=ansible-collections
|
|
sonar.sources=.
|
|
sonar.projectName=kubernetes.core
|
|
sonar.python.coverage.reportPaths=coverage.xml
|
|
|
|
sonar.tests=tests/unit,tests/integration
|
|
sonar.python.version=3.12
|
|
sonar.newCode.referenceBranch=main
|
|
|
|
sonar.exclusions=tests/**,.tox/**
|
|
|
|
# Exclude test code from copy/paste detection. 'sonar.exclusions' above only
|
|
# filters the *source* set (it disambiguates 'sonar.sources=.' from
|
|
# 'sonar.tests'), so test files are still indexed as tests and still scored for
|
|
# duplication. Unit tests here are unittest.TestCase classes: every class needs
|
|
# its own setUp, and per-case arrange/assert blocks are deliberately repeated so
|
|
# a failing test reads on its own. Because SonarCloud scores only *new code* on
|
|
# a pull request, any PR adding cases to an already-repetitive test module
|
|
# inherits duplication accrued across earlier PRs. Production code under
|
|
# plugins/ stays fully covered by duplication analysis.
|
|
sonar.cpd.exclusions=tests/**
|
|
|
|
# Ansible module argument_spec is conventionally defined with the dict(...)
|
|
# constructor (not {...} literals) for readability and consistency across the
|
|
# collection. Suppress python:S7498 ("prefer literal syntax"), which conflicts
|
|
# with that convention and otherwise re-fires on every new module argument.
|
|
sonar.issue.ignore.multicriteria=e1,e2,e3,e4,e5
|
|
sonar.issue.ignore.multicriteria.e1.ruleKey=python:S7498
|
|
sonar.issue.ignore.multicriteria.e1.resourceKey=**/*.py
|
|
|
|
# Unit tests pass hardcoded '/tmp/...' strings as fake module arguments (e.g.
|
|
# chart_ref) to fully mocked commands; no file is ever created there. Suppress
|
|
# python:S5443 ("temporary files in publicly writable directories") for test
|
|
# code only. Production code creates temp files via tempfile.mkstemp /
|
|
# NamedTemporaryFile and stays covered by the rule.
|
|
sonar.issue.ignore.multicriteria.e2.ruleKey=python:S5443
|
|
sonar.issue.ignore.multicriteria.e2.resourceKey=tests/**/*.py
|
|
|
|
# GitHub Actions workflows in this repo use @main for internal reusable actions
|
|
# (ansible-network/github_actions, ansible-collections/cloud-content-ci-automation)
|
|
# to simplify maintenance. Suppress githubactions:S7637 ("use full commit SHA").
|
|
sonar.issue.ignore.multicriteria.e3.ruleKey=githubactions:S7637
|
|
sonar.issue.ignore.multicriteria.e3.resourceKey=.github/workflows/**/*.yaml
|
|
|
|
# Workflows across this repo install ansible-core from a GitHub source
|
|
# archive (required for devel/milestone builds, which have no published
|
|
# wheel) and install this collection's shared test-requirements.txt /
|
|
# requirements.txt. Suppress githubactions:S8541 ("omitting --only-binary
|
|
# :all:") repo-wide for workflow files: forcing wheel-only installs would
|
|
# break the ansible-core source install and fails outright on the
|
|
# test-requirements.txt pin coverage==4.5.4, which has no Python 3.13 wheel.
|
|
# Scoped the same way as e3 above, since a filename-only resourceKey (as
|
|
# originally used here) does not reliably suppress issues already raised
|
|
# against this project.
|
|
sonar.issue.ignore.multicriteria.e4.ruleKey=githubactions:S8541
|
|
sonar.issue.ignore.multicriteria.e4.resourceKey=.github/workflows/**/*.yaml
|
|
|
|
# Same shared test-requirements.txt / requirements.txt as above are not
|
|
# hash-locked; that is a repo-wide dependency-management concern affecting
|
|
# every existing workflow. Suppress githubactions:S8544 ("dependencies
|
|
# without locking resolved versions") repo-wide for workflow files rather
|
|
# than diverging from established practice.
|
|
sonar.issue.ignore.multicriteria.e5.ruleKey=githubactions:S8544
|
|
sonar.issue.ignore.multicriteria.e5.resourceKey=.github/workflows/**/*.yaml
|