Release 4.8.8.

Fix broken changelog fragment.
(cherry picked from commit c88f0f4ca0)
2026-04-28 17:36:49 +00:00 · 2022-10-24 21:03:23 +02:00 · 2022-10-24 21:02:44 +02:00 · 2022-10-24 20:59:45 +02:00 · 2022-10-23 20:56:12 +02:00 · 2022-10-23 16:43:35 +02:00
157 changed files with 1143 additions and 560 deletions
--- a/.azure-pipelines/azure-pipelines.yml
+++ b/.azure-pipelines/azure-pipelines.yml
@@ -47,20 +47,20 @@ variables:
 resources:
  containers:
    - container: default
-      image: quay.io/ansible/azure-pipelines-test-container:1.9.0
+      image: quay.io/ansible/azure-pipelines-test-container:3.0.0

 pool: Standard

 stages:
 ### Sanity
-  - stage: Sanity_devel
-    displayName: Sanity devel
+  - stage: Sanity_2_14
+    displayName: Sanity 2.14
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
        parameters:
          nameFormat: Test {0}
-          testFormat: devel/sanity/{0}
+          testFormat: 2.14/sanity/{0}
          targets:
            - test: 1
            - test: 2
@@ -133,14 +133,14 @@ stages:
            - test: 3
            - test: 4
 ### Units
-  - stage: Units_devel
-    displayName: Units devel
+  - stage: Units_2_14
+    displayName: Units 2.14
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
        parameters:
          nameFormat: Python {0}
-          testFormat: devel/units/{0}/1
+          testFormat: 2.14/units/{0}/1
          targets:
            - test: 2.7
            - test: 3.5
@@ -211,13 +211,13 @@ stages:
            - test: 3.5

 ## Remote
-  - stage: Remote_devel
-    displayName: Remote devel
+  - stage: Remote_2_14
+    displayName: Remote 2.14
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
        parameters:
-          testFormat: devel/{0}
+          testFormat: 2.14/{0}
          targets:
            - name: macOS 12.0
              test: macos/12.0
@@ -317,18 +317,16 @@ stages:
            - 2

 ### Docker
-  - stage: Docker_devel
-    displayName: Docker devel
+  - stage: Docker_2_14
+    displayName: Docker 2.14
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
        parameters:
-          testFormat: devel/linux/{0}
+          testFormat: 2.14/linux/{0}
          targets:
            - name: CentOS 7
              test: centos7
-            - name: Fedora 35
-              test: fedora35
            - name: Fedora 36
              test: fedora36
            - name: openSUSE 15
@@ -424,13 +422,13 @@ stages:
            - 3

 ### Community Docker
-  - stage: Docker_community_devel
-    displayName: Docker (community images) devel
+  - stage: Docker_community_2_14
+    displayName: Docker (community images) 2.14
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
        parameters:
-          testFormat: devel/linux-community/{0}
+          testFormat: 2.14/linux-community/{0}
          targets:
            - name: Debian Bullseye
              test: debian-bullseye/3.9
@@ -444,14 +442,14 @@ stages:
            - 3

 ### Cloud
-  - stage: Cloud_devel
-    displayName: Cloud devel
+  - stage: Cloud_2_14
+    displayName: Cloud 2.14
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
        parameters:
          nameFormat: Python {0}
-          testFormat: devel/cloud/{0}/1
+          testFormat: 2.14/cloud/{0}/1
          targets:
            - test: 2.7
            - test: '3.10'
@@ -508,32 +506,32 @@ stages:
  - stage: Summary
    condition: succeededOrFailed()
    dependsOn:
-      - Sanity_devel
+      - Sanity_2_14
      - Sanity_2_9
      - Sanity_2_10
      - Sanity_2_11
      - Sanity_2_12
      - Sanity_2_13
-      - Units_devel
+      - Units_2_14
      - Units_2_9
      - Units_2_10
      - Units_2_11
      - Units_2_12
      - Units_2_13
-      - Remote_devel
+      - Remote_2_14
      - Remote_2_9
      - Remote_2_10
      - Remote_2_11
      - Remote_2_12
      - Remote_2_13
-      - Docker_devel
+      - Docker_2_14
      - Docker_2_9
      - Docker_2_10
      - Docker_2_11
      - Docker_2_12
      - Docker_2_13
-      - Docker_community_devel
-      - Cloud_devel
+      - Docker_community_2_14
+      - Cloud_2_14
      - Cloud_2_9
      - Cloud_2_10
      - Cloud_2_11
--- a/.azure-pipelines/scripts/aggregate-coverage.sh
+++ b/.azure-pipelines/scripts/aggregate-coverage.sh
@@ -9,6 +9,10 @@ PATH="${PWD}/bin:${PATH}"

 mkdir "${agent_temp_directory}/coverage/"

+if [[ "$(ansible --version)" =~ \ 2\.9\. ]]; then
+    exit
+fi
+
 options=(--venv --venv-system-site-packages --color -v)

 ansible-test coverage combine --group-by command --export "${agent_temp_directory}/coverage/" "${options[@]}"
--- a/.azure-pipelines/scripts/report-coverage.sh
+++ b/.azure-pipelines/scripts/report-coverage.sh
@@ -5,6 +5,10 @@ set -o pipefail -eu

 PATH="${PWD}/bin:${PATH}"

+if [[ "$(ansible --version)" =~ \ 2\.9\. ]]; then
+    exit
+fi
+
 if ! ansible-test --help >/dev/null 2>&1; then
    # Install the devel version of ansible-test for generating code coverage reports.
    # This is only used by Ansible Collections, which are typically tested against multiple Ansible versions (in separate jobs).
--- a/.github/BOTMETA.yml
+++ b/.github/BOTMETA.yml
@@ -220,7 +220,8 @@ files:
  $lookups/dnstxt.py:
    maintainers: jpmens
  $lookups/dsv.py:
-    maintainers: amigus endlesstrax
+    maintainers: delineaKrehl tylerezimmerman
+    ignore: amigus
  $lookups/etcd3.py:
    maintainers: eric-belhomme
  $lookups/etcd.py:
@@ -257,7 +258,8 @@ files:
    maintainers: RevBits
  $lookups/shelvefile.py: {}
  $lookups/tss.py:
-    maintainers: amigus endlesstrax
+    maintainers: delineaKrehl tylerezimmerman
+    ignore: amigus
  $module_utils/:
    labels: module_utils
  $module_utils/gitlab.py:
@@ -921,7 +923,7 @@ files:
  $modules/packaging/os/xbps.py:
    maintainers: dinoocch the-maldridge
  $modules/packaging/os/yum_versionlock.py:
-    maintainers: florianpaulhoberg aminvakil
+    maintainers: gyptazy aminvakil
  $modules/packaging/os/zypper.py:
    maintainers: $team_suse
    labels: zypper
@@ -1287,5 +1289,5 @@ macros:
  team_rhn: FlossWare alikins barnabycourt vritant
  team_scaleway: remyleone abarbare
  team_solaris: bcoca fishman jasperla jpdasma mator scathatheworm troy2914 xen0l
-  team_suse: commel dcermak evrardjp lrupp toabctl AnderEnder alxgu andytom sealor
+  team_suse: commel evrardjp lrupp toabctl AnderEnder alxgu andytom sealor
  team_virt: joshainglis karmab tleguern Thulium-Drake Ajpantuso
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -6,6 +6,134 @@ Community General Release Notes

 This changelog describes changes after version 3.0.0.

+v4.8.8
+======
+
+Release Summary
+---------------
+
+Regular bugfix release.
+
+Bugfixes
+--------
+
+- archive - avoid crash when ``lzma`` is not present and ``format`` is not ``xz`` (https://github.com/ansible-collections/community.general/pull/5393).
+- opentelemetry callback plugin - support opentelemetry-api 1.13.0 that removed support for ``_time_ns`` (https://github.com/ansible-collections/community.general/pull/5342).
+- pfexec become plugin - remove superflous quotes preventing exe wrap from working as expected (https://github.com/ansible-collections/community.general/issues/3671, https://github.com/ansible-collections/community.general/pull/3889).
+- pkgng - fix case when ``pkg`` fails when trying to upgrade all packages (https://github.com/ansible-collections/community.general/issues/5363).
+- redhat_subscription - make module idempotent when ``pool_ids`` are used (https://github.com/ansible-collections/community.general/issues/5313).
+- xenserver_facts - fix broken ``AnsibleModule`` call that prevented the module from working at all (https://github.com/ansible-collections/community.general/pull/5383).
+
+v4.8.7
+======
+
+Release Summary
+---------------
+
+Regular bugfix release.
+
+Minor Changes
+-------------
+
+- gitlab module util - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_branch - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_deploy_key - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_group - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_group_members - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_group_variable - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_hook - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_project - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_project_members - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_project_variable - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_protected_branch - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_runner - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_user - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+
+Bugfixes
+--------
+
+- locale_gen - fix support for Ubuntu (https://github.com/ansible-collections/community.general/issues/5281).
+- tss lookup plugin - adding support for updated Delinea library (https://github.com/DelineaXPM/python-tss-sdk/issues/9, https://github.com/ansible-collections/community.general/pull/5151).
+
+v4.8.6
+======
+
+Release Summary
+---------------
+
+Bugfix and maintenance release.
+
+Minor Changes
+-------------
+
+- Added MIT license as ``MIT-license.txt`` for ``tests/unit/plugins/modules/packaging/language/test_gem.py`` (https://github.com/ansible-collections/community.general/pull/5065, https://github.com/ansible-collections/community.general/pull/5072).
+
+Bugfixes
+--------
+
+- apache2_mod_proxy - avoid crash when reporting inability to parse balancer_member_page HTML caused by using an undefined variable in the error message (https://github.com/ansible-collections/community.general/pull/5111).
+- dnsimple_info - correctly report missing library as ``requests`` and not ``another_library`` (https://github.com/ansible-collections/community.general/pull/5111).
+- funcd connection plugin - fix signature of ``exec_command`` (https://github.com/ansible-collections/community.general/pull/5111).
+- manageiq_alert_profiles - avoid crash when reporting unknown profile caused by trying to return an undefined variable (https://github.com/ansible-collections/community.general/pull/5111).
+- nsupdate - compatibility with NS records (https://github.com/ansible-collections/community.general/pull/5112).
+- packet_ip_subnet - fix error reporting in case of invalid CIDR prefix lengths (https://github.com/ansible-collections/community.general/pull/5111).
+- pip_package_info - remove usage of global variable (https://github.com/ansible-collections/community.general/pull/5111).
+
+v4.8.5
+======
+
+Release Summary
+---------------
+
+Regular bugfix release.
+
+Bugfixes
+--------
+
+- pacman - fixed name resolution of URL packages (https://github.com/ansible-collections/community.general/pull/4959).
+- proxmox - fix error handling when getting VM by name when ``state=absent`` (https://github.com/ansible-collections/community.general/pull/4945).
+- proxmox inventory plugin - fix crash when ``enabled=1`` is used in agent config string (https://github.com/ansible-collections/community.general/pull/4910).
+- proxmox_kvm - fix error handling when getting VM by name when ``state=absent`` (https://github.com/ansible-collections/community.general/pull/4945).
+- slack - fix incorrect channel prefix ``#`` caused by incomplete pattern detection by adding ``G0`` and ``GF`` as channel ID patterns (https://github.com/ansible-collections/community.general/pull/5019).
+
+v4.8.4
+======
+
+Release Summary
+---------------
+
+Regular bugfix release.
+
+Bugfixes
+--------
+
+- cmd_runner module utils - fix bug caused by using the ``command`` variable instead of ``self.command`` when looking for binary path (https://github.com/ansible-collections/community.general/pull/4903).
+- dsv lookup plugin - do not ignore the ``tld`` parameter (https://github.com/ansible-collections/community.general/pull/4911).
+- lxd connection plugin - fix incorrect ``inventory_hostname`` in ``remote_addr``. This is needed for compatibility with ansible-core 2.13 (https://github.com/ansible-collections/community.general/issues/4886).
+- rax_clb_nodes - fix code to be compatible with Python 3 (https://github.com/ansible-collections/community.general/pull/4933).
+- redfish_info - fix to ``GetChassisPower`` to correctly report power information when multiple chassis exist, but not all chassis report power information (https://github.com/ansible-collections/community.general/issues/4901).
+
+v4.8.3
+======
+
+Release Summary
+---------------
+
+Bugfix release.
+
+Minor Changes
+-------------
+
+- ModuleHelper module utils - improved ``ModuleHelperException``, using ``to_native()`` for the exception message (https://github.com/ansible-collections/community.general/pull/4755).
+
+Bugfixes
+--------
+
+- nmcli - fix error caused by adding undefined module arguments for list options (https://github.com/ansible-collections/community.general/issues/4373, https://github.com/ansible-collections/community.general/pull/4813).
+- redhat_subscription - fix unsubscribing on RHEL 9 (https://github.com/ansible-collections/community.general/issues/4741).
+- sudoers - ensure sudoers config files are created with the permissions requested by sudoers (0440) (https://github.com/ansible-collections/community.general/pull/4814).
+- sudoers - fix incorrect handling of ``state: absent`` (https://github.com/ansible-collections/community.general/issues/4852).
+
 v4.8.2
 ======

--- a/MIT-license.txt
+++ b/MIT-license.txt
@@ -0,0 +1,9 @@
+MIT License
+
+Copyright (c) <year> <copyright holders>
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
--- a/README.md
+++ b/README.md
@@ -17,7 +17,7 @@ If you encounter abusive behavior violating the [Ansible Code of Conduct](https:

 ## Tested with Ansible

-Tested with the current Ansible 2.9, ansible-base 2.10, ansible-core 2.11, ansible-core 2.12, ansible-core 2.13 releases and the current development version of ansible-core. Ansible versions before 2.9.10 are not supported.
+Tested with the current Ansible 2.9, ansible-base 2.10, ansible-core 2.11, ansible-core 2.12, ansible-core 2.13, and ansible-core 2.14 releases of ansible-core. Ansible versions before 2.9.10 are not supported.

 ## External requirements

--- a/changelogs/changelog.yaml
+++ b/changelogs/changelog.yaml
@@ -1835,3 +1835,147 @@ releases:
    - 4733-redis-fail.yml
    - simplified-bsd-license.yml
    release_date: '2022-06-06'
+  4.8.3:
+    changes:
+      bugfixes:
+      - nmcli - fix error caused by adding undefined module arguments for list options
+        (https://github.com/ansible-collections/community.general/issues/4373, https://github.com/ansible-collections/community.general/pull/4813).
+      - redhat_subscription - fix unsubscribing on RHEL 9 (https://github.com/ansible-collections/community.general/issues/4741).
+      - sudoers - ensure sudoers config files are created with the permissions requested
+        by sudoers (0440) (https://github.com/ansible-collections/community.general/pull/4814).
+      - 'sudoers - fix incorrect handling of ``state: absent`` (https://github.com/ansible-collections/community.general/issues/4852).'
+      minor_changes:
+      - ModuleHelper module utils - improved ``ModuleHelperException``, using ``to_native()``
+        for the exception message (https://github.com/ansible-collections/community.general/pull/4755).
+      release_summary: Bugfix release.
+    fragments:
+    - 4.8.3.yml
+    - 4755-mhexception-improvement.yml
+    - 4809-redhat_subscription-unsubscribe.yaml
+    - 4813-fix-nmcli-convert-list.yaml
+    - 4814-sudoers-file-permissions.yml
+    - 4852-sudoers-state-absent.yml
+    release_date: '2022-06-20'
+  4.8.4:
+    changes:
+      bugfixes:
+      - cmd_runner module utils - fix bug caused by using the ``command`` variable
+        instead of ``self.command`` when looking for binary path (https://github.com/ansible-collections/community.general/pull/4903).
+      - dsv lookup plugin - do not ignore the ``tld`` parameter (https://github.com/ansible-collections/community.general/pull/4911).
+      - lxd connection plugin - fix incorrect ``inventory_hostname`` in ``remote_addr``.
+        This is needed for compatibility with ansible-core 2.13 (https://github.com/ansible-collections/community.general/issues/4886).
+      - rax_clb_nodes - fix code to be compatible with Python 3 (https://github.com/ansible-collections/community.general/pull/4933).
+      - redfish_info - fix to ``GetChassisPower`` to correctly report power information
+        when multiple chassis exist, but not all chassis report power information
+        (https://github.com/ansible-collections/community.general/issues/4901).
+      release_summary: Regular bugfix release.
+    fragments:
+    - 4.8.4.yml
+    - 4886-fix-lxd-inventory-hostname.yml
+    - 4901-fix-redfish-chassispower.yml
+    - 4903-cmdrunner-bugfix.yaml
+    - 4911-dsv-honor-tld-option.yml
+    - 4933-fix-rax-clb-nodes.yaml
+    release_date: '2022-07-12'
+  4.8.5:
+    changes:
+      bugfixes:
+      - pacman - fixed name resolution of URL packages (https://github.com/ansible-collections/community.general/pull/4959).
+      - proxmox - fix error handling when getting VM by name when ``state=absent``
+        (https://github.com/ansible-collections/community.general/pull/4945).
+      - proxmox inventory plugin - fix crash when ``enabled=1`` is used in agent config
+        string (https://github.com/ansible-collections/community.general/pull/4910).
+      - proxmox_kvm - fix error handling when getting VM by name when ``state=absent``
+        (https://github.com/ansible-collections/community.general/pull/4945).
+      - slack - fix incorrect channel prefix ``#`` caused by incomplete pattern detection
+        by adding ``G0`` and ``GF`` as channel ID patterns (https://github.com/ansible-collections/community.general/pull/5019).
+      release_summary: Regular bugfix release.
+    fragments:
+    - 4.8.5.yml
+    - 4910-fix-for-agent-enabled.yml
+    - 4945-fix-get_vm-int-parse-handling.yaml
+    - 4959-pacman-fix-url-packages-name.yaml
+    - 5019-slack-support-more-groups.yml
+    release_date: '2022-08-01'
+  4.8.6:
+    changes:
+      bugfixes:
+      - apache2_mod_proxy - avoid crash when reporting inability to parse balancer_member_page
+        HTML caused by using an undefined variable in the error message (https://github.com/ansible-collections/community.general/pull/5111).
+      - dnsimple_info - correctly report missing library as ``requests`` and not ``another_library``
+        (https://github.com/ansible-collections/community.general/pull/5111).
+      - funcd connection plugin - fix signature of ``exec_command`` (https://github.com/ansible-collections/community.general/pull/5111).
+      - manageiq_alert_profiles - avoid crash when reporting unknown profile caused
+        by trying to return an undefined variable (https://github.com/ansible-collections/community.general/pull/5111).
+      - nsupdate - compatibility with NS records (https://github.com/ansible-collections/community.general/pull/5112).
+      - packet_ip_subnet - fix error reporting in case of invalid CIDR prefix lengths
+        (https://github.com/ansible-collections/community.general/pull/5111).
+      - pip_package_info - remove usage of global variable (https://github.com/ansible-collections/community.general/pull/5111).
+      minor_changes:
+      - Added MIT license as ``MIT-license.txt`` for ``tests/unit/plugins/modules/packaging/language/test_gem.py``
+        (https://github.com/ansible-collections/community.general/pull/5065, https://github.com/ansible-collections/community.general/pull/5072).
+      release_summary: Bugfix and maintenance release.
+    fragments:
+    - 4.8.6.yml
+    - 5111-fixes.yml
+    - 5112-fix-nsupdate-ns-entry.yaml
+    - licenses.yml
+    release_date: '2022-08-22'
+  4.8.7:
+    changes:
+      bugfixes:
+      - locale_gen - fix support for Ubuntu (https://github.com/ansible-collections/community.general/issues/5281).
+      - tss lookup plugin - adding support for updated Delinea library (https://github.com/DelineaXPM/python-tss-sdk/issues/9,
+        https://github.com/ansible-collections/community.general/pull/5151).
+      minor_changes:
+      - gitlab module util - minor refactor when checking for installed dependency
+        (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_branch - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_deploy_key - minor refactor when checking for installed dependency
+        (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_group - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_group_members - minor refactor when checking for installed dependency
+        (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_group_variable - minor refactor when checking for installed dependency
+        (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_hook - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_project - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_project_members - minor refactor when checking for installed dependency
+        (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_project_variable - minor refactor when checking for installed dependency
+        (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_protected_branch - minor refactor when checking for installed dependency
+        (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_runner - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_user - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+      release_summary: Regular bugfix release.
+    fragments:
+    - 4.8.7.yml
+    - 5151-add-delinea-support-tss-lookup.yml
+    - 5259-gitlab-imports.yaml
+    - 5282-locale_gen.yaml
+    release_date: '2022-10-03'
+  4.8.8:
+    changes:
+      bugfixes:
+      - archive - avoid crash when ``lzma`` is not present and ``format`` is not ``xz``
+        (https://github.com/ansible-collections/community.general/pull/5393).
+      - opentelemetry callback plugin - support opentelemetry-api 1.13.0 that removed
+        support for ``_time_ns`` (https://github.com/ansible-collections/community.general/pull/5342).
+      - pfexec become plugin - remove superflous quotes preventing exe wrap from working
+        as expected (https://github.com/ansible-collections/community.general/issues/3671,
+        https://github.com/ansible-collections/community.general/pull/3889).
+      - pkgng - fix case when ``pkg`` fails when trying to upgrade all packages (https://github.com/ansible-collections/community.general/issues/5363).
+      - redhat_subscription - make module idempotent when ``pool_ids`` are used (https://github.com/ansible-collections/community.general/issues/5313).
+      - xenserver_facts - fix broken ``AnsibleModule`` call that prevented the module
+        from working at all (https://github.com/ansible-collections/community.general/pull/5383).
+      release_summary: Regular bugfix release.
+    fragments:
+    - 3671-illumos-pfexec.yml
+    - 4.8.8.yml
+    - 5313-fix-redhat_subscription-idempotency-pool_ids.yml
+    - 5342-opentelemetry_bug_fix_opentelemetry-api-1.13.yml
+    - 5369-pkgng-fix-update-all.yaml
+    - 5383-xenserver_facts.yml
+    - 5393-archive.yml
+    release_date: '2022-10-24'
--- a/galaxy.yml
+++ b/galaxy.yml
@@ -1,6 +1,6 @@
 namespace: community
 name: general
-version: 4.8.2
+version: 4.8.8
 readme: README.md
 authors:
  - Ansible (https://github.com/ansible)
--- a/plugins/become/pfexec.py
+++ b/plugins/become/pfexec.py
@@ -101,4 +101,4 @@ class BecomeModule(BecomeBase):

        flags = self.get_option('become_flags')
        noexe = not self.get_option('wrap_exe')
-        return '%s %s "%s"' % (exe, flags, self._build_success_command(cmd, shell, noexe=noexe))
+        return '%s %s %s' % (exe, flags, self._build_success_command(cmd, shell, noexe=noexe))
--- a/plugins/become/sudosu.py
+++ b/plugins/become/sudosu.py
@@ -8,9 +8,9 @@ DOCUMENTATION = """
    name: sudosu
    short_description: Run tasks using sudo su -
    description:
-        - This become plugins allows your remote/login user to execute commands as another user via the C(sudo) and C(su) utilities combined.
+      - This become plugin allows your remote/login user to execute commands as another user via the C(sudo) and C(su) utilities combined.
    author:
-    - Dag Wieers (@dagwieers)
+      - Dag Wieers (@dagwieers)
    version_added: 2.4.0
    options:
        become_user:
--- a/plugins/callback/dense.py
+++ b/plugins/callback/dense.py
@@ -232,13 +232,13 @@ class CallbackModule(CallbackModule_default):
        # Remove non-essential attributes
        for attr in self.removed_attributes:
            if attr in result:
-                del(result[attr])
+                del result[attr]

        # Remove empty attributes (list, dict, str)
        for attr in result.copy():
            if isinstance(result[attr], (MutableSequence, MutableMapping, binary_type, text_type)):
                if not result[attr]:
-                    del(result[attr])
+                    del result[attr]

    def _handle_exceptions(self, result):
        if 'exception' in result:
--- a/plugins/callback/log_plays.py
+++ b/plugins/callback/log_plays.py
@@ -12,7 +12,7 @@ DOCUMENTATION = '''
    type: notification
    short_description: write playbook output to log file
    description:
-      - This callback writes playbook output to a file per host in the `/var/log/ansible/hosts` directory
+      - This callback writes playbook output to a file per host in the C(/var/log/ansible/hosts) directory
    requirements:
     - Whitelist in configuration
     - A writeable /var/log/ansible/hosts directory by the user executing Ansible on the controller
--- a/plugins/callback/opentelemetry.py
+++ b/plugins/callback/opentelemetry.py
@@ -94,13 +94,32 @@ try:
    from opentelemetry.sdk.trace.export import (
        BatchSpanProcessor
    )
-    from opentelemetry.util._time import _time_ns
+
+    # Support for opentelemetry-api <= 1.12
+    try:
+        from opentelemetry.util._time import _time_ns
+    except ImportError as imp_exc:
+        OTEL_LIBRARY_TIME_NS_ERROR = imp_exc
+    else:
+        OTEL_LIBRARY_TIME_NS_ERROR = None
+
 except ImportError as imp_exc:
    OTEL_LIBRARY_IMPORT_ERROR = imp_exc
+    OTEL_LIBRARY_TIME_NS_ERROR = imp_exc
 else:
    OTEL_LIBRARY_IMPORT_ERROR = None


+if sys.version_info >= (3, 7):
+    time_ns = time.time_ns
+elif not OTEL_LIBRARY_TIME_NS_ERROR:
+    time_ns = _time_ns
+else:
+    def time_ns():
+        # Support versions older than 3.7 with opentelemetry-api > 1.12
+        return int(time.time() * 1e9)
+
+
 class TaskData:
    """
    Data about an individual task.
@@ -112,10 +131,7 @@ class TaskData:
        self.path = path
        self.play = play
        self.host_data = OrderedDict()
-        if sys.version_info >= (3, 7):
-            self.start = time.time_ns()
-        else:
-            self.start = _time_ns()
+        self.start = time_ns()
        self.action = action
        self.args = args

@@ -140,10 +156,7 @@ class HostData:
        self.name = name
        self.status = status
        self.result = result
-        if sys.version_info >= (3, 7):
-            self.finish = time.time_ns()
-        else:
-            self.finish = _time_ns()
+        self.finish = time_ns()


 class OpenTelemetrySource(object):
--- a/plugins/callback/selective.py
+++ b/plugins/callback/selective.py
@@ -14,9 +14,9 @@ DOCUMENTATION = '''
      - set as main display callback
    short_description: only print certain tasks
    description:
-      - This callback only prints tasks that have been tagged with `print_action` or that have failed.
+      - This callback only prints tasks that have been tagged with C(print_action) or that have failed.
        This allows operators to focus on the tasks that provide value only.
-      - Tasks that are not printed are placed with a '.'.
+      - Tasks that are not printed are placed with a C(.).
      - If you increase verbosity all tasks are printed.
    options:
      nocolor:
--- a/plugins/connection/funcd.py
+++ b/plugins/connection/funcd.py
@@ -63,7 +63,7 @@ class Connection(ConnectionBase):
        self.client = fc.Client(self.host)
        return self

-    def exec_command(self, cmd, become_user=None, sudoable=False, executable='/bin/sh', in_data=None):
+    def exec_command(self, cmd, in_data=None, sudoable=True):
        """ run a command on the remote minion """

        if in_data:
--- a/plugins/connection/lxd.py
+++ b/plugins/connection/lxd.py
@@ -18,6 +18,7 @@ DOCUMENTATION = '''
            - Container identifier.
        default: inventory_hostname
        vars:
+            - name: inventory_hostname
            - name: ansible_host
            - name: ansible_lxd_host
      executable:
@@ -61,7 +62,6 @@ class Connection(ConnectionBase):
    def __init__(self, play_context, new_stdin, *args, **kwargs):
        super(Connection, self).__init__(play_context, new_stdin, *args, **kwargs)

-        self._host = self._play_context.remote_addr
        try:
            self._lxc_cmd = get_bin_path("lxc")
        except ValueError:
@@ -75,14 +75,14 @@ class Connection(ConnectionBase):
        super(Connection, self)._connect()

        if not self._connected:
-            self._display.vvv(u"ESTABLISH LXD CONNECTION FOR USER: root", host=self._host)
+            self._display.vvv(u"ESTABLISH LXD CONNECTION FOR USER: root", host=self.get_option('remote_addr'))
            self._connected = True

    def exec_command(self, cmd, in_data=None, sudoable=True):
        """ execute a command on the lxd host """
        super(Connection, self).exec_command(cmd, in_data=in_data, sudoable=sudoable)

-        self._display.vvv(u"EXEC {0}".format(cmd), host=self._host)
+        self._display.vvv(u"EXEC {0}".format(cmd), host=self.get_option('remote_addr'))

        local_cmd = [self._lxc_cmd]
        if self.get_option("project"):
@@ -104,10 +104,10 @@ class Connection(ConnectionBase):
        stderr = to_text(stderr)

        if stderr == "error: Container is not running.\n":
-            raise AnsibleConnectionFailure("container not running: %s" % self._host)
+            raise AnsibleConnectionFailure("container not running: %s" % self.get_option('remote_addr'))

        if stderr == "error: not found\n":
-            raise AnsibleConnectionFailure("container not found: %s" % self._host)
+            raise AnsibleConnectionFailure("container not found: %s" % self.get_option('remote_addr'))

        return process.returncode, stdout, stderr

@@ -115,7 +115,7 @@ class Connection(ConnectionBase):
        """ put a file from local to lxd """
        super(Connection, self).put_file(in_path, out_path)

-        self._display.vvv(u"PUT {0} TO {1}".format(in_path, out_path), host=self._host)
+        self._display.vvv(u"PUT {0} TO {1}".format(in_path, out_path), host=self.get_option('remote_addr'))

        if not os.path.isfile(to_bytes(in_path, errors='surrogate_or_strict')):
            raise AnsibleFileNotFound("input path is not a file: %s" % in_path)
@@ -138,7 +138,7 @@ class Connection(ConnectionBase):
        """ fetch a file from lxd to local """
        super(Connection, self).fetch_file(in_path, out_path)

-        self._display.vvv(u"FETCH {0} TO {1}".format(in_path, out_path), host=self._host)
+        self._display.vvv(u"FETCH {0} TO {1}".format(in_path, out_path), host=self.get_option('remote_addr'))

        local_cmd = [self._lxc_cmd]
        if self.get_option("project"):
--- a/plugins/filter/jc.py
+++ b/plugins/filter/jc.py
@@ -51,10 +51,16 @@ DOCUMENTATION = '''
      type: boolean
      default: false
  requirements:
-    - jc (https://github.com/kellyjonbrazil/jc)
+    - jc installed as a Python library (U(https://pypi.org/project/jc/))
 '''

 EXAMPLES = '''
+- name: Install the prereqs of the jc filter (jc Python package) on the Ansible controller
+  delegate_to: localhost
+  ansible.builtin.pip:
+    name: jc
+    state: present
+
 - name: Run command
  ansible.builtin.command: uname -a
  register: result
@@ -107,15 +113,19 @@ def jc(data, parser, quiet=True, raw=False):
        dictionary or list of dictionaries

    Example:
-
        - name: run date command
          hosts: ubuntu
          tasks:
-          - shell: date
+          - name: install the prereqs of the jc filter (jc Python package) on the Ansible controller
+            delegate_to: localhost
+            ansible.builtin.pip:
+              name: jc
+              state: present
+          - ansible.builtin.shell: date
            register: result
-          - set_fact:
+          - ansible.builtin.set_fact:
              myvar: "{{ result.stdout | community.general.jc('date') }}"
-          - debug:
+          - ansible.builtin.debug:
              msg: "{{ myvar }}"

        produces:
@@ -137,7 +147,7 @@ def jc(data, parser, quiet=True, raw=False):
    """

    if not HAS_LIB:
-        raise AnsibleError('You need to install "jc" prior to running jc filter')
+        raise AnsibleError('You need to install "jc" as a Python library on the Ansible controller prior to running jc filter')

    try:
        jc_parser = importlib.import_module('jc.parsers.' + parser)
--- a/plugins/inventory/proxmox.py
+++ b/plugins/inventory/proxmox.py
@@ -400,12 +400,20 @@ class InventoryModule(BaseInventoryPlugin, Constructable, Cacheable):
                        properties[parsed_key] = [tag.strip() for tag in stripped_value.split(",")]

                # The first field in the agent string tells you whether the agent is enabled
-                # the rest of the comma separated string is extra config for the agent
-                if config == 'agent' and int(value.split(',')[0]):
-                    agent_iface_value = self._get_agent_network_interfaces(node, vmid, vmtype)
-                    if agent_iface_value:
-                        agent_iface_key = self.to_safe('%s%s' % (key, "_interfaces"))
-                        properties[agent_iface_key] = agent_iface_value
+                # the rest of the comma separated string is extra config for the agent.
+                # In some (newer versions of proxmox) instances it can be 'enabled=1'.
+                if config == 'agent':
+                    agent_enabled = 0
+                    try:
+                        agent_enabled = int(value.split(',')[0])
+                    except ValueError:
+                        if value.split(',')[0] == "enabled=1":
+                            agent_enabled = 1
+                    if agent_enabled:
+                        agent_iface_value = self._get_agent_network_interfaces(node, vmid, vmtype)
+                        if agent_iface_value:
+                            agent_iface_key = self.to_safe('%s%s' % (key, "_interfaces"))
+                            properties[agent_iface_key] = agent_iface_value

                if config == 'lxc':
                    out_val = {}
--- a/plugins/lookup/chef_databag.py
+++ b/plugins/lookup/chef_databag.py
@@ -16,7 +16,7 @@ DOCUMENTATION = '''
         The lookup order mirrors the one from Chef, all folders in the base path are walked back looking for the following configuration
         file in order : .chef/knife.rb, ~/.chef/knife.rb, /etc/chef/client.rb"
    requirements:
-        - "pychef (python library https://pychef.readthedocs.io `pip install pychef`)"
+        - "pychef (L(Python library, https://pychef.readthedocs.io), C(pip install pychef))"
    options:
        name:
          description:
--- a/plugins/lookup/dsv.py
+++ b/plugins/lookup/dsv.py
@@ -122,6 +122,7 @@ class LookupModule(LookupBase):
                "tenant": self.get_option("tenant"),
                "client_id": self.get_option("client_id"),
                "client_secret": self.get_option("client_secret"),
+                "tld": self.get_option("tld"),
                "url_template": self.get_option("url_template"),
            }
        )
--- a/plugins/lookup/tss.py
+++ b/plugins/lookup/tss.py
@@ -170,19 +170,29 @@ try:

    HAS_TSS_SDK = True
 except ImportError:
-    SecretServer = None
-    SecretServerError = None
-    HAS_TSS_SDK = False
+    try:
+        from delinea.secrets.server import SecretServer, SecretServerError
+
+        HAS_TSS_SDK = True
+    except ImportError:
+        SecretServer = None
+        SecretServerError = None
+        HAS_TSS_SDK = False

 try:
    from thycotic.secrets.server import PasswordGrantAuthorizer, DomainPasswordGrantAuthorizer, AccessTokenAuthorizer

    HAS_TSS_AUTHORIZER = True
 except ImportError:
-    PasswordGrantAuthorizer = None
-    DomainPasswordGrantAuthorizer = None
-    AccessTokenAuthorizer = None
-    HAS_TSS_AUTHORIZER = False
+    try:
+        from delinea.secrets.server import PasswordGrantAuthorizer, DomainPasswordGrantAuthorizer, AccessTokenAuthorizer
+
+        HAS_TSS_AUTHORIZER = True
+    except ImportError:
+        PasswordGrantAuthorizer = None
+        DomainPasswordGrantAuthorizer = None
+        AccessTokenAuthorizer = None
+        HAS_TSS_AUTHORIZER = False


 display = Display()
--- a/plugins/module_utils/cmd_runner.py
+++ b/plugins/module_utils/cmd_runner.py
@@ -191,7 +191,7 @@ class CmdRunner(object):
            environ_update = {}
        self.environ_update = environ_update

-        self.command[0] = module.get_bin_path(command[0], opt_dirs=path_prefix, required=True)
+        self.command[0] = module.get_bin_path(self.command[0], opt_dirs=path_prefix, required=True)

        for mod_param_name, spec in iteritems(module.argument_spec):
            if mod_param_name not in self.arg_formats:
--- a/plugins/module_utils/gitlab.py
+++ b/plugins/module_utils/gitlab.py
@@ -13,10 +13,9 @@ from ansible.module_utils.common.text.converters import to_native
 from ansible_collections.community.general.plugins.module_utils.version import LooseVersion

 try:
-    from urllib import quote_plus  # Python 2.X
    from urlparse import urljoin
 except ImportError:
-    from urllib.parse import quote_plus, urljoin  # Python 3+
+    from urllib.parse import urljoin  # Python 3+

 import traceback

@@ -26,6 +25,7 @@ try:
    import requests
    HAS_GITLAB_PACKAGE = True
 except Exception:
+    gitlab = None
    GITLAB_IMP_ERR = traceback.format_exc()
    HAS_GITLAB_PACKAGE = False

@@ -63,6 +63,14 @@ def find_group(gitlab_instance, identifier):
    return project


+def ensure_gitlab_package(module):
+    if not HAS_GITLAB_PACKAGE:
+        module.fail_json(
+            msg=missing_required_lib("python-gitlab", url='https://python-gitlab.readthedocs.io/en/stable/'),
+            exception=GITLAB_IMP_ERR
+        )
+
+
 def gitlab_authentication(module):
    gitlab_url = module.params['api_url']
    validate_certs = module.params['validate_certs']
@@ -72,8 +80,7 @@ def gitlab_authentication(module):
    gitlab_oauth_token = module.params['api_oauth_token']
    gitlab_job_token = module.params['api_job_token']

-    if not HAS_GITLAB_PACKAGE:
-        module.fail_json(msg=missing_required_lib("python-gitlab"), exception=GITLAB_IMP_ERR)
+    ensure_gitlab_package(module)

    try:
        # python-gitlab library remove support for username/password authentication since 1.13.0
--- a/plugins/module_utils/ilo_redfish_utils.py
+++ b/plugins/module_utils/ilo_redfish_utils.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-

 # Copyright (c) 2021-2022 Hewlett Packard Enterprise, Inc. All rights reserved.
-# GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
@@ -91,7 +91,7 @@ class iLORedfishUtils(RedfishUtils):
        data = response['data']

        ntp_list = data[setkey]
-        if(len(ntp_list) == 2):
+        if len(ntp_list) == 2:
            ntp_list.pop(0)

        ntp_list.append(mgr_attributes['mgr_attr_value'])
--- a/plugins/module_utils/memset.py
+++ b/plugins/module_utils/memset.py
@@ -78,7 +78,7 @@ def memset_api_call(api_key, api_method, payload=None):
    if msg is None:
        msg = response.json()

-    return(has_failed, msg, response)
+    return has_failed, msg, response


 def check_zone_domain(data, domain):
@@ -92,7 +92,7 @@ def check_zone_domain(data, domain):
            if zone_domain['domain'] == domain:
                exists = True

-    return(exists)
+    return exists


 def check_zone(data, name):
@@ -109,7 +109,7 @@ def check_zone(data, name):
        if counter == 1:
            exists = True

-    return(exists, counter)
+    return exists, counter


 def get_zone_id(zone_name, current_zones):
@@ -135,4 +135,4 @@ def get_zone_id(zone_name, current_zones):
        zone_id = None
        msg = 'Zone ID could not be returned as duplicate zone names were detected'

-    return(zone_exists, msg, counter, zone_id)
+    return zone_exists, msg, counter, zone_id
--- a/plugins/module_utils/mh/exceptions.py
+++ b/plugins/module_utils/mh/exceptions.py
@@ -6,17 +6,13 @@
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type

+from ansible.module_utils.common.text.converters import to_native
+

 class ModuleHelperException(Exception):
-    @staticmethod
-    def _get_remove(key, kwargs):
-        if key in kwargs:
-            result = kwargs[key]
-            del kwargs[key]
-            return result
-        return None
-
-    def __init__(self, *args, **kwargs):
-        self.msg = self._get_remove('msg', kwargs) or "Module failed with exception: {0}".format(self)
-        self.update_output = self._get_remove('update_output', kwargs) or {}
+    def __init__(self, msg, update_output=None, *args, **kwargs):
+        self.msg = to_native(msg or "Module failed with exception: {0}".format(self))
+        if update_output is None:
+            update_output = {}
+        self.update_output = update_output
        super(ModuleHelperException, self).__init__(*args)
--- a/plugins/module_utils/rax.py
+++ b/plugins/module_utils/rax.py
@@ -122,8 +122,7 @@ def rax_find_image(module, rax_module, image, exit=True):
    except ValueError:
        try:
            image = cs.images.find(human_id=image)
-        except(cs.exceptions.NotFound,
-               cs.exceptions.NoUniqueMatch):
+        except (cs.exceptions.NotFound, cs.exceptions.NoUniqueMatch):
            try:
                image = cs.images.find(name=image)
            except (cs.exceptions.NotFound,
--- a/plugins/module_utils/redfish_utils.py
+++ b/plugins/module_utils/redfish_utils.py
@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 # Copyright (c) 2017-2018 Dell EMC Inc.
-# GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
@@ -1883,14 +1883,13 @@ class RedfishUtils(object):
                        for property in properties:
                            if property in data:
                                chassis_power_result[property] = data[property]
-                else:
-                    return {'ret': False, 'msg': 'Key PowerControl not found.'}
                chassis_power_results.append(chassis_power_result)
-            else:
-                return {'ret': False, 'msg': 'Key Power not found.'}

-        result['entries'] = chassis_power_results
-        return result
+        if len(chassis_power_results) > 0:
+            result['entries'] = chassis_power_results
+            return result
+        else:
+            return {'ret': False, 'msg': 'Power information not found.'}

    def get_chassis_thermals(self):
        result = {}
@@ -2056,7 +2055,7 @@ class RedfishUtils(object):
            if property in data:
                nic[property] = data[property]
        result['entries'] = nic
-        return(result)
+        return result

    def get_nic_inventory(self, resource_uri):
        result = {}
--- a/plugins/module_utils/redis.py
+++ b/plugins/module_utils/redis.py
@@ -15,6 +15,7 @@ try:
    from redis import Redis
    from redis import __version__ as redis_version
    HAS_REDIS_PACKAGE = True
+    REDIS_IMP_ERR = None
 except ImportError:
    REDIS_IMP_ERR = traceback.format_exc()
    HAS_REDIS_PACKAGE = False
@@ -22,6 +23,7 @@ except ImportError:
 try:
    import certifi
    HAS_CERTIFI_PACKAGE = True
+    CERTIFI_IMPORT_ERROR = None
 except ImportError:
    CERTIFI_IMPORT_ERROR = traceback.format_exc()
    HAS_CERTIFI_PACKAGE = False
--- a/plugins/modules/cloud/alicloud/ali_instance.py
+++ b/plugins/modules/cloud/alicloud/ali_instance.py
@@ -45,12 +45,12 @@ options:
      type: str
    image_id:
      description:
-        - Image ID used to launch instances. Required when C(state=present) and creating new ECS instances.
+        - Image ID used to launch instances. Required when I(state=present) and creating new ECS instances.
      aliases: ['image']
      type: str
    instance_type:
      description:
-        - Instance type used to launch instances. Required when C(state=present) and creating new ECS instances.
+        - Instance type used to launch instances. Required when I(state=present) and creating new ECS instances.
      aliases: ['type']
      type: str
    security_groups:
@@ -89,7 +89,7 @@ options:
    max_bandwidth_out:
      description:
        - Maximum outgoing bandwidth to the public network, measured in Mbps (Megabits per second).
-          Required when C(allocate_public_ip=True). Ignored when C(allocate_public_ip=False).
+          Required when I(allocate_public_ip=true). Ignored when I(allocate_public_ip=false).
      default: 0
      type: int
    host_name:
@@ -153,7 +153,7 @@ options:
      type: str
    period:
      description:
-        - The charge duration of the instance, in month. Required when C(instance_charge_type=PrePaid).
+        - The charge duration of the instance, in months. Required when I(instance_charge_type=PrePaid).
        - The valid value are [1-9, 12, 24, 36].
      default: 1
      type: int
@@ -164,7 +164,7 @@ options:
      default: False
    auto_renew_period:
      description:
-        - The duration of the automatic renew the charge of the instance. Required when C(auto_renew=True).
+        - The duration of the automatic renew the charge of the instance. Required when I(auto_renew=true).
      choices: [1, 2, 3, 6, 12]
      type: int
    instance_ids:
@@ -216,31 +216,31 @@ options:
      version_added: '0.2.0'
    spot_strategy:
      description:
-         - The bidding mode of the pay-as-you-go instance. This parameter is valid when InstanceChargeType is set to PostPaid.
+        - The bidding mode of the pay-as-you-go instance. This parameter is valid when InstanceChargeType is set to PostPaid.
      choices: ['NoSpot', 'SpotWithPriceLimit', 'SpotAsPriceGo']
      default: 'NoSpot'
      type: str
      version_added: '0.2.0'
    period_unit:
      description:
-         - The duration unit that you will buy the resource. It is valid when C(instance_charge_type=PrePaid)
+        - The duration unit that you will buy the resource. It is valid when I(instance_charge_type=PrePaid).
      choices: ['Month', 'Week']
      default: 'Month'
      type: str
      version_added: '0.2.0'
    dry_run:
      description:
-         - Specifies whether to send a dry-run request.
-         - If I(dry_run=True), Only a dry-run request is sent and no instance is created. The system checks whether the
-           required parameters are set, and validates the request format, service permissions, and available ECS instances.
-           If the validation fails, the corresponding error code is returned. If the validation succeeds, the DryRunOperation error code is returned.
-         - If I(dry_run=False), A request is sent. If the validation succeeds, the instance is created.
+        - Specifies whether to send a dry-run request.
+        - If I(dry_run=true), Only a dry-run request is sent and no instance is created. The system checks whether the
+          required parameters are set, and validates the request format, service permissions, and available ECS instances.
+          If the validation fails, the corresponding error code is returned. If the validation succeeds, the DryRunOperation error code is returned.
+        - If I(dry_run=false), A request is sent. If the validation succeeds, the instance is created.
      default: False
      type: bool
      version_added: '0.2.0'
    include_data_disks:
      description:
-         - Whether to change instance disks charge type when changing instance charge type.
+        - Whether to change instance disks charge type when changing instance charge type.
      default: True
      type: bool
      version_added: '0.2.0'
--- a/plugins/modules/cloud/lxd/lxd_container.py
+++ b/plugins/modules/cloud/lxd/lxd_container.py
@@ -191,10 +191,10 @@ notes:
    2.1, the later requires python to be installed in the instance which can
    be done with the command module.
  - You can copy a file from the host to the instance
-    with the Ansible M(ansible.builtin.copy) and M(ansible.builtin.template) module and the `lxd` connection plugin.
+    with the Ansible M(ansible.builtin.copy) and M(ansible.builtin.template) module and the C(community.general.lxd) connection plugin.
    See the example below.
  - You can copy a file in the created instance to the localhost
-    with `command=lxc file pull instance_name/dir/filename filename`.
+    with C(command=lxc file pull instance_name/dir/filename filename).
    See the first example below.
 '''

--- a/plugins/modules/cloud/memset/memset_dns_reload.py
+++ b/plugins/modules/cloud/memset/memset_dns_reload.py
@@ -111,7 +111,7 @@ def poll_reload_status(api_key=None, job_id=None, payload=None):
        memset_api = response.json()
        msg = None

-    return(memset_api, msg, stderr)
+    return memset_api, msg, stderr


 def reload_dns(args=None):
@@ -133,7 +133,7 @@ def reload_dns(args=None):
        retvals['failed'] = has_failed
        retvals['memset_api'] = response.json()
        retvals['msg'] = msg
-        return(retvals)
+        return retvals

    # set changed to true if the reload request was accepted.
    has_changed = True
@@ -153,7 +153,7 @@ def reload_dns(args=None):
        if val is not None:
            retvals[val] = eval(val)

-    return(retvals)
+    return retvals


 def main():
--- a/plugins/modules/cloud/memset/memset_memstore_info.py
+++ b/plugins/modules/cloud/memset/memset_memstore_info.py
@@ -127,7 +127,7 @@ def get_facts(args=None):
        retvals['failed'] = has_failed
        retvals['msg'] = msg
        retvals['stderr'] = "API returned an error: {0}" . format(response.status_code)
-        return(retvals)
+        return retvals

    # we don't want to return the same thing twice
    msg = None
@@ -139,7 +139,7 @@ def get_facts(args=None):
        if val is not None:
            retvals[val] = eval(val)

-    return(retvals)
+    return retvals


 def main():
--- a/plugins/modules/cloud/memset/memset_server_info.py
+++ b/plugins/modules/cloud/memset/memset_server_info.py
@@ -252,7 +252,7 @@ def get_facts(args=None):
        retvals['failed'] = has_failed
        retvals['msg'] = msg
        retvals['stderr'] = "API returned an error: {0}" . format(response.status_code)
-        return(retvals)
+        return retvals

    # we don't want to return the same thing twice
    msg = None
@@ -264,7 +264,7 @@ def get_facts(args=None):
        if val is not None:
            retvals[val] = eval(val)

-    return(retvals)
+    return retvals


 def main():
--- a/plugins/modules/cloud/memset/memset_zone.py
+++ b/plugins/modules/cloud/memset/memset_zone.py
@@ -139,7 +139,7 @@ def check(args=None):
    retvals['changed'] = has_changed
    retvals['failed'] = has_failed

-    return(retvals)
+    return retvals


 def create_zone(args=None, zone_exists=None, payload=None):
@@ -185,7 +185,7 @@ def create_zone(args=None, zone_exists=None, payload=None):
        _has_failed, _msg, response = memset_api_call(api_key=args['api_key'], api_method=api_method, payload=payload)
        memset_api = response.json()

-    return(has_failed, has_changed, memset_api, msg)
+    return has_failed, has_changed, memset_api, msg


 def delete_zone(args=None, zone_exists=None, payload=None):
@@ -233,7 +233,7 @@ def delete_zone(args=None, zone_exists=None, payload=None):
    else:
        has_failed, has_changed = False, False

-    return(has_failed, has_changed, memset_api, msg)
+    return has_failed, has_changed, memset_api, msg


 def create_or_delete(args=None):
@@ -255,7 +255,7 @@ def create_or_delete(args=None):
        retvals['failed'] = _has_failed
        retvals['msg'] = _msg

-        return(retvals)
+        return retvals

    zone_exists, _msg, counter, _zone_id = get_zone_id(zone_name=args['name'], current_zones=response.json())

@@ -271,7 +271,7 @@ def create_or_delete(args=None):
        if val is not None:
            retvals[val] = eval(val)

-    return(retvals)
+    return retvals


 def main():
--- a/plugins/modules/cloud/memset/memset_zone_domain.py
+++ b/plugins/modules/cloud/memset/memset_zone_domain.py
@@ -110,7 +110,7 @@ def check(args=None):
    retvals['changed'] = has_changed
    retvals['failed'] = has_failed

-    return(retvals)
+    return retvals


 def create_zone_domain(args=None, zone_exists=None, zone_id=None, payload=None):
@@ -138,7 +138,7 @@ def create_zone_domain(args=None, zone_exists=None, zone_id=None, payload=None):
        if not has_failed:
            has_changed = True

-    return(has_failed, has_changed, msg)
+    return has_failed, has_changed, msg


 def delete_zone_domain(args=None, payload=None):
@@ -165,7 +165,7 @@ def delete_zone_domain(args=None, payload=None):
            # unset msg as we don't want to return unnecessary info to the user.
            msg = None

-    return(has_failed, has_changed, memset_api, msg)
+    return has_failed, has_changed, memset_api, msg


 def create_or_delete_domain(args=None):
@@ -188,7 +188,7 @@ def create_or_delete_domain(args=None):
        retvals['failed'] = has_failed
        retvals['msg'] = msg
        retvals['stderr'] = "API returned an error: {0}" . format(response.status_code)
-        return(retvals)
+        return retvals

    zone_exists, msg, counter, zone_id = get_zone_id(zone_name=args['zone'], current_zones=response.json())

@@ -203,7 +203,7 @@ def create_or_delete_domain(args=None):

        retvals['failed'] = has_failed
        retvals['msg'] = stderr
-        return(retvals)
+        return retvals

    if args['state'] == 'present':
        has_failed, has_changed, msg = create_zone_domain(args=args, zone_exists=zone_exists, zone_id=zone_id, payload=payload)
@@ -217,7 +217,7 @@ def create_or_delete_domain(args=None):
        if val is not None:
            retvals[val] = eval(val)

-    return(retvals)
+    return retvals


 def main():
--- a/plugins/modules/cloud/memset/memset_zone_record.py
+++ b/plugins/modules/cloud/memset/memset_zone_record.py
@@ -221,7 +221,7 @@ def create_zone_record(args=None, zone_id=None, records=None, payload=None):
                # nothing to do; record is already correct so we populate
                # the return var with the existing record's details.
                memset_api = zone_record
-                return(has_changed, has_failed, memset_api, msg)
+                return has_changed, has_failed, memset_api, msg
            else:
                # merge dicts ensuring we change any updated values
                payload = zone_record.copy()
@@ -231,7 +231,7 @@ def create_zone_record(args=None, zone_id=None, records=None, payload=None):
                    has_changed = True
                    # return the new record to the user in the returned var.
                    memset_api = new_record
-                    return(has_changed, has_failed, memset_api, msg)
+                    return has_changed, has_failed, memset_api, msg
                has_failed, msg, response = memset_api_call(api_key=args['api_key'], api_method=api_method, payload=payload)
                if not has_failed:
                    has_changed = True
@@ -246,7 +246,7 @@ def create_zone_record(args=None, zone_id=None, records=None, payload=None):
            has_changed = True
            # populate the return var with the new record's details.
            memset_api = new_record
-            return(has_changed, has_failed, memset_api, msg)
+            return has_changed, has_failed, memset_api, msg
        has_failed, msg, response = memset_api_call(api_key=args['api_key'], api_method=api_method, payload=payload)
        if not has_failed:
            has_changed = True
@@ -254,7 +254,7 @@ def create_zone_record(args=None, zone_id=None, records=None, payload=None):
            #  empty msg as we don't want to return a boatload of json to the user.
            msg = None

-    return(has_changed, has_failed, memset_api, msg)
+    return has_changed, has_failed, memset_api, msg


 def delete_zone_record(args=None, records=None, payload=None):
@@ -270,7 +270,7 @@ def delete_zone_record(args=None, records=None, payload=None):
        for zone_record in records:
            if args['check_mode']:
                has_changed = True
-                return(has_changed, has_failed, memset_api, msg)
+                return has_changed, has_failed, memset_api, msg
            payload['id'] = zone_record['id']
            api_method = 'dns.zone_record_delete'
            has_failed, msg, response = memset_api_call(api_key=args['api_key'], api_method=api_method, payload=payload)
@@ -280,7 +280,7 @@ def delete_zone_record(args=None, records=None, payload=None):
                #  empty msg as we don't want to return a boatload of json to the user.
                msg = None

-    return(has_changed, has_failed, memset_api, msg)
+    return has_changed, has_failed, memset_api, msg


 def create_or_delete(args=None):
@@ -304,7 +304,7 @@ def create_or_delete(args=None):
        retvals['failed'] = _has_failed
        retvals['msg'] = msg
        retvals['stderr'] = "API returned an error: {0}" . format(response.status_code)
-        return(retvals)
+        return retvals

    zone_exists, _msg, counter, zone_id = get_zone_id(zone_name=args['zone'], current_zones=response.json())

@@ -317,7 +317,7 @@ def create_or_delete(args=None):
        retvals['failed'] = has_failed
        retvals['msg'] = stderr
        retvals['stderr'] = stderr
-        return(retvals)
+        return retvals

    # get a list of all records ( as we can't limit records by zone)
    api_method = 'dns.zone_record_list'
@@ -339,7 +339,7 @@ def create_or_delete(args=None):
        if val is not None:
            retvals[val] = eval(val)

-    return(retvals)
+    return retvals


 def main():
--- a/plugins/modules/cloud/misc/proxmox.py
+++ b/plugins/modules/cloud/misc/proxmox.py
@@ -743,6 +743,8 @@ def main():
            module.fail_json(msg="restarting of VM %s failed with exception: %s" % (vmid, e))

    elif state == 'absent':
+        if not vmid:
+            module.exit_json(changed=False, msg='VM with hostname = %s is already absent' % hostname)
        try:
            vm = proxmox.get_vm(vmid, ignore_missing=True)
            if not vm:
--- a/plugins/modules/cloud/misc/proxmox_kvm.py
+++ b/plugins/modules/cloud/misc/proxmox_kvm.py
@@ -83,7 +83,7 @@ options:
    version_added: 1.3.0
  clone:
    description:
-      - Name of VM to be cloned. If C(vmid) is setted, C(clone) can take arbitrary value but required for initiating the clone.
+      - Name of VM to be cloned. If I(vmid) is set, I(clone) can take an arbitrary value but is required for initiating the clone.
    type: str
  cores:
    description:
@@ -1370,6 +1370,8 @@ def main():

    elif state == 'absent':
        status = {}
+        if not vmid:
+            module.exit_json(changed=False, msg='VM with name = %s is already absent' % name)
        try:
            vm = proxmox.get_vm(vmid, ignore_missing=True)
            if not vm:
--- a/plugins/modules/cloud/misc/rhevm.py
+++ b/plugins/modules/cloud/misc/rhevm.py
@@ -1252,7 +1252,6 @@ def setChanged():


 def setMsg(message):
-    global failed
    msg.append(message)


--- a/plugins/modules/cloud/misc/serverless.py
+++ b/plugins/modules/cloud/misc/serverless.py
@@ -115,7 +115,7 @@ state:
  returned: always
 command:
  type: str
-  description: Full `serverless` command run by this module, in case you want to re-run the command outside the module.
+  description: Full C(serverless) command run by this module, in case you want to re-run the command outside the module.
  returned: always
  sample: serverless deploy --stage production
 '''
--- a/plugins/modules/cloud/misc/terraform.py
+++ b/plugins/modules/cloud/misc/terraform.py
@@ -67,7 +67,7 @@ options:
  state_file:
    description:
      - The path to an existing Terraform state file to use when building plan.
-        If this is not specified, the default `terraform.tfstate` will be used.
+        If this is not specified, the default C(terraform.tfstate) will be used.
      - This option is ignored when plan is specified.
    type: path
  variables_files:
@@ -103,7 +103,7 @@ options:
  force_init:
    description:
      - To avoid duplicating infra, if a state file can't be found this will
-        force a `terraform init`. Generally, this should be turned off unless
+        force a C(terraform init). Generally, this should be turned off unless
        you intend to provision an entirely new Terraform deployment.
    default: false
    type: bool
@@ -149,7 +149,7 @@ options:
    type: int
    version_added: '3.8.0'
 notes:
-   - To just run a `terraform plan`, use check mode.
+   - To just run a C(terraform plan), use check mode.
 requirements: [ "terraform" ]
 author: "Ryan Scott Brown (@ryansb)"
 '''
@@ -205,7 +205,7 @@ EXAMPLES = """
 RETURN = """
 outputs:
  type: complex
-  description: A dictionary of all the TF outputs by their assigned name. Use `.outputs.MyOutputName.value` to access the value.
+  description: A dictionary of all the TF outputs by their assigned name. Use C(.outputs.MyOutputName.value) to access the value.
  returned: on success
  sample: '{"bukkit_arn": {"sensitive": false, "type": "string", "value": "arn:aws:s3:::tf-test-bukkit"}'
  contains:
@@ -223,12 +223,12 @@ outputs:
      description: The value of the output as interpolated by Terraform
 stdout:
  type: str
-  description: Full `terraform` command stdout, in case you want to display it or examine the event log
+  description: Full C(terraform) command stdout, in case you want to display it or examine the event log
  returned: always
  sample: ''
 command:
  type: str
-  description: Full `terraform` command built by this module, in case you want to re-run the command outside the module or debug a problem.
+  description: Full C(terraform) command built by this module, in case you want to re-run the command outside the module or debug a problem.
  returned: always
  sample: terraform apply ...
 """
--- a/plugins/modules/cloud/misc/xenserver_facts.py
+++ b/plugins/modules/cloud/misc/xenserver_facts.py
@@ -161,9 +161,7 @@ def get_srs(session):


 def main():
-    module = AnsibleModule(
-        supports_check_mode=True,
-    )
+    module = AnsibleModule({}, supports_check_mode=True)

    if not HAVE_XENAPI:
        module.fail_json(changed=False, msg="python xen api required for this module")
--- a/plugins/modules/cloud/opennebula/one_image.py
+++ b/plugins/modules/cloud/opennebula/one_image.py
@@ -346,7 +346,7 @@ def get_connection_info(module):
    if not password:
        password = os.environ.get('ONE_PASSWORD')

-    if not(url and username and password):
+    if not (url and username and password):
        module.fail_json(msg="One or more connection parameters (api_url, api_username, api_password) were not specified")
    from collections import namedtuple

--- a/plugins/modules/cloud/opennebula/one_image_info.py
+++ b/plugins/modules/cloud/opennebula/one_image_info.py
@@ -240,7 +240,7 @@ def get_connection_info(module):
    if not password:
        password = os.environ.get('ONE_PASSWORD')

-    if not(url and username and password):
+    if not (url and username and password):
        module.fail_json(msg="One or more connection parameters (api_url, api_username, api_password) were not specified")
    from collections import namedtuple

--- a/plugins/modules/cloud/opennebula/one_service.py
+++ b/plugins/modules/cloud/opennebula/one_service.py
@@ -660,7 +660,7 @@ def get_connection_info(module):
    if not password:
        password = os.environ.get('ONEFLOW_PASSWORD')

-    if not(url and username and password):
+    if not (url and username and password):
        module.fail_json(msg="One or more connection parameters (api_url, api_username, api_password) were not specified")
    from collections import namedtuple

--- a/plugins/modules/cloud/packet/packet_ip_subnet.py
+++ b/plugins/modules/cloud/packet/packet_ip_subnet.py
@@ -216,7 +216,7 @@ def parse_subnet_cidr(cidr):
    try:
        prefixlen = int(prefixlen)
    except ValueError:
-        raise("Wrong prefix length in CIDR expression {0}".format(cidr))
+        raise Exception("Wrong prefix length in CIDR expression {0}".format(cidr))
    return addr, prefixlen


--- a/plugins/modules/cloud/profitbricks/profitbricks_datacenter.py
+++ b/plugins/modules/cloud/profitbricks/profitbricks_datacenter.py
@@ -183,7 +183,7 @@ def remove_datacenter(module, profitbricks):
    name = module.params.get('name')
    changed = False

-    if(uuid_match.match(name)):
+    if uuid_match.match(name):
        _remove_datacenter(module, profitbricks, name)
        changed = True
    else:
--- a/plugins/modules/cloud/profitbricks/profitbricks_volume.py
+++ b/plugins/modules/cloud/profitbricks/profitbricks_volume.py
@@ -324,7 +324,7 @@ def delete_volume(module, profitbricks):
                break

    for n in instance_ids:
-        if(uuid_match.match(n)):
+        if uuid_match.match(n):
            _delete_volume(module, profitbricks, datacenter, n)
            changed = True
        else:
--- a/plugins/modules/cloud/rackspace/rax_clb_nodes.py
+++ b/plugins/modules/cloud/rackspace/rax_clb_nodes.py
@@ -252,7 +252,8 @@ def main():
                'weight': weight,
            }

-            for name, value in mutable.items():
+            for name in list(mutable):
+                value = mutable[name]
                if value is None or value == getattr(node, name):
                    mutable.pop(name)

--- a/plugins/modules/cloud/rackspace/rax_mon_check.py
+++ b/plugins/modules/cloud/rackspace/rax_mon_check.py
@@ -75,15 +75,15 @@ options:
  target_hostname:
    type: str
    description:
-    - One of `target_hostname` and `target_alias` is required for remote.* checks,
+    - One of I(target_hostname) and I(target_alias) is required for remote.* checks,
      but prohibited for agent.* checks. The hostname this check should target.
      Must be a valid IPv4, IPv6, or FQDN.
  target_alias:
    type: str
    description:
-    - One of `target_alias` and `target_hostname` is required for remote.* checks,
+    - One of I(target_alias) and I(target_hostname) is required for remote.* checks,
      but prohibited for agent.* checks. Use the corresponding key in the entity's
-      `ip_addresses` hash to resolve an IP address to target.
+      I(ip_addresses) hash to resolve an IP address to target.
  details:
    type: dict
    description:
--- a/plugins/modules/cloud/scaleway/scaleway_security_group_rule.py
+++ b/plugins/modules/cloud/scaleway/scaleway_security_group_rule.py
@@ -143,6 +143,7 @@ except ImportError:
    IPADDRESS_IMP_ERR = traceback.format_exc()
    HAS_IPADDRESS = False
 else:
+    IPADDRESS_IMP_ERR = None
    HAS_IPADDRESS = True


--- a/plugins/modules/cloud/scaleway/scaleway_user_data.py
+++ b/plugins/modules/cloud/scaleway/scaleway_user_data.py
@@ -35,7 +35,7 @@ options:
  user_data:
    type: dict
    description:
-    - User defined data. Typically used with `cloud-init`.
+    - User defined data. Typically used with C(cloud-init).
    - Pass your cloud-init script here as a string
    required: false

--- a/plugins/modules/clustering/consul/consul_kv.py
+++ b/plugins/modules/clustering/consul/consul_kv.py
@@ -28,14 +28,14 @@ author:
 options:
    state:
        description:
-          - The action to take with the supplied key and value. If the state is 'present' and `value` is set, the key
-            contents will be set to the value supplied and `changed` will be set to `true` only if the value was
-            different to the current contents. If the state is 'present' and `value` is not set, the existing value
-            associated to the key will be returned. The state 'absent' will remove the key/value pair,
-            again 'changed' will be set to true only if the key actually existed
+          - The action to take with the supplied key and value. If the state is C(present) and I(value) is set, the key
+            contents will be set to the value supplied and C(changed) will be set to C(true) only if the value was
+            different to the current contents. If the state is C(present) and I(value) is not set, the existing value
+            associated to the key will be returned. The state C(absent) will remove the key/value pair,
+            again C(changed) will be set to true only if the key actually existed
            prior to the removal. An attempt can be made to obtain or free the
-            lock associated with a key/value pair with the states 'acquire' or
-            'release' respectively. a valid session must be supplied to make the
+            lock associated with a key/value pair with the states C(acquire) or
+            C(release) respectively. a valid session must be supplied to make the
            attempt changed will be true if the attempt is successful, false
            otherwise.
        type: str
--- a/plugins/modules/clustering/etcd3.py
+++ b/plugins/modules/clustering/etcd3.py
@@ -126,6 +126,7 @@ from ansible.module_utils.common.text.converters import to_native
 try:
    import etcd3
    HAS_ETCD = True
+    ETCD_IMP_ERR = None
 except ImportError:
    ETCD_IMP_ERR = traceback.format_exc()
    HAS_ETCD = False
--- a/plugins/modules/files/archive.py
+++ b/plugins/modules/files/archive.py
@@ -65,13 +65,15 @@ options:
    type: bool
    default: no
 notes:
-    - Requires tarfile, zipfile, gzip and bzip2 packages on target host.
-    - Requires lzma or backports.lzma if using xz format.
-    - Can produce I(gzip), I(bzip2), I(lzma) and I(zip) compressed files or archives.
+    - Can produce I(gzip), I(bzip2), I(lzma), and I(zip) compressed files or archives.
+    - This module uses C(tarfile), C(zipfile), C(gzip), and C(bz2) packages on the target host to create archives.
+      These are part of the Python standard library for Python 2 and 3.
+requirements:
+    - Requires C(lzma) (standard library of Python 3) or L(backports.lzma, https://pypi.org/project/backports.lzma/) (Python 2) if using C(xz) format.
 seealso:
- module: ansible.builtin.unarchive
+    - module: ansible.builtin.unarchive
 author:
- Ben Doherty (@bendoh)
+    - Ben Doherty (@bendoh)
 '''

 EXAMPLES = r'''
@@ -581,6 +583,11 @@ class TarArchive(Archive):
            self.file.add(path, archive_name, recursive=False, exclude=py26_filter)

    def _get_checksums(self, path):
+        if HAS_LZMA:
+            LZMAError = lzma.LZMAError
+        else:
+            # Just picking another exception that's also listed below
+            LZMAError = tarfile.ReadError
        try:
            if self.format == 'xz':
                with lzma.open(_to_native_ascii(path), 'r') as f:
@@ -591,7 +598,7 @@ class TarArchive(Archive):
                archive = tarfile.open(_to_native_ascii(path), 'r|' + self.format)
                checksums = set((info.name, info.chksum) for info in archive.getmembers())
                archive.close()
-        except (lzma.LZMAError, tarfile.ReadError, tarfile.CompressionError):
+        except (LZMAError, tarfile.ReadError, tarfile.CompressionError):
            try:
                # The python implementations of gzip, bz2, and lzma do not support restoring compressed files
                # to their original names so only file checksum is returned
--- a/plugins/modules/files/ini_file.py
+++ b/plugins/modules/files/ini_file.py
@@ -309,7 +309,7 @@ def do_ini(module, filename, section=None, option=None, values=None,
        # override option with no value to option with value if not allow_no_value
        if len(values) > 0:
            for index, line in enumerate(section_lines):
-                if not changed_lines[index] and match_active_opt(option, section_lines[index]):
+                if not changed_lines[index] and match_active_opt(option, section_lines[index]):  # pylint: disable=unnecessary-list-index-lookup
                    newline = assignment_format % (option, values.pop(0))
                    (changed, msg) = update_section_line(changed, section_lines, index, changed_lines, newline, msg)
                    if len(values) == 0:
--- a/plugins/modules/identity/ipa/ipa_otptoken.py
+++ b/plugins/modules/identity/ipa/ipa_otptoken.py
@@ -445,8 +445,8 @@ def ensure(module, client):
                module_otptoken['all'] = True
                ipa_otptoken = client.otptoken_add(name=uniqueid, item=module_otptoken)
        else:
-            if not(validate_modifications(ansible_to_ipa, module, ipa_otptoken,
-                                          module_otptoken, unmodifiable_after_creation)):
+            if not validate_modifications(ansible_to_ipa, module, ipa_otptoken,
+                                          module_otptoken, unmodifiable_after_creation):
                module.fail_json(msg="Modifications requested in module are not valid")

            # IPA will reject 'modifications' that do not actually modify anything
--- a/plugins/modules/identity/keycloak/keycloak_user_federation.py
+++ b/plugins/modules/identity/keycloak/keycloak_user_federation.py
@@ -129,6 +129,7 @@ options:
            vendor:
                description:
                    - LDAP vendor (provider).
+                    - Use short name. For instance, write C(rhds) for "Red Hat Directory Server".
                type: str

            usernameLDAPAttribute:
--- a/plugins/modules/monitoring/datadog/datadog_event.py
+++ b/plugins/modules/monitoring/datadog/datadog_event.py
@@ -20,7 +20,7 @@ description:
 - "Allows to post events to Datadog (www.datadoghq.com) service."
 - "Uses http://docs.datadoghq.com/api/#events API."
 author:
- "Artūras `arturaz` Šlajus (@arturaz)"
+- "Artūras 'arturaz' Šlajus (@arturaz)"
 - "Naoya Nakazawa (@n0ts)"
 options:
    api_key:
--- a/plugins/modules/monitoring/pagerduty_user.py
+++ b/plugins/modules/monitoring/pagerduty_user.py
@@ -86,6 +86,7 @@ from os import path
 try:
    from pdpyras import APISession
    HAS_PD_PY = True
+    PD_IMPORT_ERR = None
 except ImportError:
    HAS_PD_PY = False
    PD_IMPORT_ERR = traceback.format_exc()
@@ -93,6 +94,7 @@ except ImportError:
 try:
    from pdpyras import PDClientError
    HAS_PD_CLIENT_ERR = True
+    PD_CLIENT_ERR_IMPORT_ERR = None
 except ImportError:
    HAS_PD_CLIENT_ERR = False
    PD_CLIENT_ERR_IMPORT_ERR = traceback.format_exc()
--- a/plugins/modules/net_tools/dnsimple_info.py
+++ b/plugins/modules/net_tools/dnsimple_info.py
@@ -233,10 +233,11 @@ import json
 try:
    from requests import Request, Session
 except ImportError:
-    HAS_ANOTHER_LIBRARY = False
-    ANOTHER_LIBRARY_IMPORT_ERROR = traceback.format_exc()
+    HAS_REQUESTS = False
+    REQUESTS_IMPORT_ERROR = traceback.format_exc()
 else:
-    HAS_ANOTHER_LIBRARY = True
+    HAS_REQUESTS = True
+    REQUESTS_IMPORT_ERROR = None


 def build_url(account, key, is_sandbox):
@@ -261,7 +262,7 @@ def iterate_data(module, request_object):
                request_object.url = base_url + '&page=' + str(page)
                new_results = Session().send(request_object)
                data = data + new_results.json()["data"]
-        return(data)
+        return data
    else:
        module.fail_json('API Call failed, check ID, key and sandbox values')

@@ -305,11 +306,10 @@ def main():
                    params['api_key'],
                    params['sandbox'])

-    if not HAS_ANOTHER_LIBRARY:
-        # Needs: from ansible.module_utils.basic import missing_required_lib
+    if not HAS_REQUESTS:
        module.exit_json(
-            msg=missing_required_lib('another_library'),
-            exception=ANOTHER_LIBRARY_IMPORT_ERROR)
+            msg=missing_required_lib('requests'),
+            exception=REQUESTS_IMPORT_ERROR)

    # At minimum we need account and key
    if params['account_id'] and params['api_key']:
--- a/plugins/modules/net_tools/haproxy.py
+++ b/plugins/modules/net_tools/haproxy.py
@@ -99,7 +99,7 @@ options:
  weight:
    description:
      - The value passed in argument.
-      - If the value ends with the `%` sign, then the new weight will be
+      - If the value ends with the C(%) sign, then the new weight will be
        relative to the initially configured weight.
      - Relative weights are only permitted between 0 and 100% and absolute
        weights are permitted between 0 and 256.
--- a/plugins/modules/net_tools/ipwcli_dns.py
+++ b/plugins/modules/net_tools/ipwcli_dns.py
@@ -44,7 +44,7 @@ options:
    address:
        description:
            - The IP address for the A or AAAA record.
-            - Required for C(type=A) or C(type=AAAA)
+            - Required for I(type=A) or I(type=AAAA).
        type: str
    ttl:
        description:
@@ -70,38 +70,38 @@ options:
    port:
        description:
            - Sets the port of the SRV record.
-            - Required for C(type=SRV)
+            - Required for I(type=SRV).
        type: int
    target:
        description:
            - Sets the target of the SRV record.
-            - Required for C(type=SRV)
+            - Required for I(type=SRV).
        type: str
    order:
        description:
            - Sets the order of the NAPTR record.
-            - Required for C(type=NAPTR)
+            - Required for I(type=NAPTR).
        type: int
    preference:
        description:
            - Sets the preference of the NAPTR record.
-            - Required for C(type=NAPTR)
+            - Required for I(type=NAPTR).
        type: int
    flags:
        description:
            - Sets one of the possible flags of NAPTR record.
-            - Required for C(type=NAPTR)
+            - Required for I(type=NAPTR).
        type: str
        choices: ['S', 'A', 'U', 'P']
    service:
        description:
            - Sets the service of the NAPTR record.
-            - Required for C(type=NAPTR)
+            - Required for I(type=NAPTR).
        type: str
    replacement:
        description:
            - Sets the replacement of the NAPTR record.
-            - Required for C(type=NAPTR)
+            - Required for I(type=NAPTR).
        type: str
    username:
        description:
--- a/plugins/modules/net_tools/nmcli.py
+++ b/plugins/modules/net_tools/nmcli.py
@@ -1742,7 +1742,10 @@ class Nmcli(object):

    @staticmethod
    def list_to_string(lst):
-        return ",".join(lst or [""])
+        if lst is None:
+            return None
+        else:
+            return ",".join(lst)

    @staticmethod
    def settings_type(setting):
--- a/plugins/modules/net_tools/nsupdate.py
+++ b/plugins/modules/net_tools/nsupdate.py
@@ -426,7 +426,10 @@ class RecordManager(object):
        if lookup.rcode() != dns.rcode.NOERROR:
            self.module.fail_json(msg='Failed to lookup TTL of existing matching record.')

-        current_ttl = lookup.answer[0].ttl
+        if self.module.params['type'] == 'NS':
+            current_ttl = lookup.answer[0].ttl if lookup.answer else lookup.authority[0].ttl
+        else:
+            current_ttl = lookup.answer[0].ttl
        return current_ttl != self.module.params['ttl']


--- a/plugins/modules/notification/slack.py
+++ b/plugins/modules/notification/slack.py
@@ -293,7 +293,7 @@ def build_payload_for_slack(text, channel, thread_id, username, icon_url, icon_e
        # With a custom color we have to set the message as attachment, and explicitly turn markdown parsing on for it.
        payload = dict(attachments=[dict(text=escape_quotes(text), color=color, mrkdwn_in=["text"])])
    if channel is not None:
-        if channel.startswith(('#', '@', 'C0')):
+        if channel.startswith(('#', '@', 'C0', 'GF', 'G0')):
            payload['channel'] = channel
        else:
            payload['channel'] = '#' + channel
--- a/plugins/modules/packaging/language/pip_package_info.py
+++ b/plugins/modules/packaging/language/pip_package_info.py
@@ -17,7 +17,7 @@ options:
  clients:
    description:
      - A list of the pip executables that will be used to get the packages.
-        They can be supplied with the full path or just the executable name, i.e `pip3.7`.
+        They can be supplied with the full path or just the executable name, for example C(pip3.7).
    default: ['pip']
    required: False
    type: list
@@ -97,13 +97,13 @@ from ansible.module_utils.facts.packages import CLIMgr

 class PIP(CLIMgr):

-    def __init__(self, pip):
+    def __init__(self, pip, module):

        self.CLI = pip
+        self.module = module

    def list_installed(self):
-        global module
-        rc, out, err = module.run_command([self._cli, 'list', '-l', '--format=json'])
+        rc, out, err = self.module.run_command([self._cli, 'list', '-l', '--format=json'])
        if rc != 0:
            raise Exception("Unable to list packages rc=%s : %s" % (rc, err))
        return json.loads(out)
@@ -116,7 +116,6 @@ class PIP(CLIMgr):
 def main():

    # start work
-    global module
    module = AnsibleModule(
        argument_spec=dict(
            clients=dict(type='list', elements='path', default=['pip']),
@@ -133,7 +132,7 @@ def main():
            module.warn('Skipping invalid pip client: %s' % (pip))
            continue
        try:
-            pip_mgr = PIP(pip)
+            pip_mgr = PIP(pip, module)
            if pip_mgr.is_available():
                found += 1
                packages[pip] = pip_mgr.get_packages()
--- a/plugins/modules/packaging/language/yarn.py
+++ b/plugins/modules/packaging/language/yarn.py
@@ -224,7 +224,7 @@ class Yarn(object):
            rc, out, err = self.module.run_command(cmd, check_rc=check_rc, cwd=cwd)
            return out, err

-        return(None, None)
+        return None, None

    def list(self):
        cmd = ['list', '--depth=0', '--json']
--- a/plugins/modules/packaging/os/apk.py
+++ b/plugins/modules/packaging/os/apk.py
@@ -62,8 +62,8 @@ options:
    type: bool
    default: no
 notes:
-  - '"name" and "upgrade" are mutually exclusive.'
-  - When used with a `loop:` each package will be processed individually, it is much more efficient to pass the list directly to the `name` option.
+  - 'I(name) and I(upgrade) are mutually exclusive.'
+  - When used with a C(loop:) each package will be processed individually, it is much more efficient to pass the list directly to the I(name) option.
 '''

 EXAMPLES = '''
--- a/plugins/modules/packaging/os/copr.py
+++ b/plugins/modules/packaging/os/copr.py
@@ -84,6 +84,7 @@ try:
    import dnf.repodict
    from dnf.conf import Conf
    HAS_DNF_PACKAGES = True
+    DNF_IMP_ERR = None
 except ImportError:
    DNF_IMP_ERR = traceback.format_exc()
    HAS_DNF_PACKAGES = False
--- a/plugins/modules/packaging/os/flatpak.py
+++ b/plugins/modules/packaging/os/flatpak.py
@@ -162,7 +162,7 @@ OUTDATED_FLATPAK_VERSION_ERROR_MESSAGE = "Unknown option --columns=application"

 def install_flat(module, binary, remote, names, method, no_dependencies):
    """Add new flatpaks."""
-    global result
+    global result  # pylint: disable=global-variable-not-assigned
    uri_names = []
    id_names = []
    for name in names:
@@ -189,7 +189,7 @@ def install_flat(module, binary, remote, names, method, no_dependencies):

 def uninstall_flat(module, binary, names, method):
    """Remove existing flatpaks."""
-    global result
+    global result  # pylint: disable=global-variable-not-assigned
    installed_flat_names = [
        _match_installed_flat_name(module, binary, name, method)
        for name in names
@@ -224,7 +224,7 @@ def _match_installed_flat_name(module, binary, name, method):
    # This is a difficult function, since if the user supplies a flatpakref url,
    # we have to rely on a naming convention:
    # The flatpakref file name needs to match the flatpak name
-    global result
+    global result  # pylint: disable=global-variable-not-assigned
    parsed_name = _parse_flatpak_name(name)
    # Try running flatpak list with columns feature
    command = [binary, "list", "--{0}".format(method), "--app", "--columns=application"]
@@ -248,7 +248,7 @@ def _match_installed_flat_name(module, binary, name, method):


 def _match_flat_using_outdated_flatpak_format(module, binary, parsed_name, method):
-    global result
+    global result  # pylint: disable=global-variable-not-assigned
    command = [binary, "list", "--{0}".format(method), "--app", "--columns=application"]
    output = _flatpak_command(module, False, command)
    for row in output.split('\n'):
@@ -257,7 +257,7 @@ def _match_flat_using_outdated_flatpak_format(module, binary, parsed_name, metho


 def _match_flat_using_flatpak_column_feature(module, binary, parsed_name, method):
-    global result
+    global result  # pylint: disable=global-variable-not-assigned
    command = [binary, "list", "--{0}".format(method), "--app"]
    output = _flatpak_command(module, False, command)
    for row in output.split('\n'):
@@ -276,7 +276,7 @@ def _parse_flatpak_name(name):


 def _flatpak_version(module, binary):
-    global result
+    global result  # pylint: disable=global-variable-not-assigned
    command = [binary, "--version"]
    output = _flatpak_command(module, False, command)
    version_number = output.split()[1]
@@ -284,7 +284,7 @@ def _flatpak_version(module, binary):


 def _flatpak_command(module, noop, command, ignore_failure=False):
-    global result
+    global result  # pylint: disable=global-variable-not-assigned
    result['command'] = ' '.join(command)
    if noop:
        result['rc'] = 0
--- a/plugins/modules/packaging/os/flatpak_remote.py
+++ b/plugins/modules/packaging/os/flatpak_remote.py
@@ -124,7 +124,7 @@ from ansible.module_utils.common.text.converters import to_bytes, to_native

 def add_remote(module, binary, name, flatpakrepo_url, method):
    """Add a new remote."""
-    global result
+    global result  # pylint: disable=global-variable-not-assigned
    command = [binary, "remote-add", "--{0}".format(method), name, flatpakrepo_url]
    _flatpak_command(module, module.check_mode, command)
    result['changed'] = True
@@ -132,7 +132,7 @@ def add_remote(module, binary, name, flatpakrepo_url, method):

 def remove_remote(module, binary, name, method):
    """Remove an existing remote."""
-    global result
+    global result  # pylint: disable=global-variable-not-assigned
    command = [binary, "remote-delete", "--{0}".format(method), "--force", name]
    _flatpak_command(module, module.check_mode, command)
    result['changed'] = True
@@ -153,7 +153,7 @@ def remote_exists(module, binary, name, method):


 def _flatpak_command(module, noop, command):
-    global result
+    global result  # pylint: disable=global-variable-not-assigned
    result['command'] = ' '.join(command)
    if noop:
        result['rc'] = 0
--- a/plugins/modules/packaging/os/homebrew.py
+++ b/plugins/modules/packaging/os/homebrew.py
@@ -35,7 +35,7 @@ options:
        elements: str
    path:
        description:
-            - "A ':' separated list of paths to search for 'brew' executable.
+            - "A C(:) separated list of paths to search for C(brew) executable.
              Since a package (I(formula) in homebrew parlance) location is prefixed relative to the actual path of I(brew) command,
              providing an alternative I(brew) path enables managing different set of packages in an alternative location in the system."
        default: '/usr/local/bin:/opt/homebrew/bin'
@@ -72,8 +72,8 @@ options:
        elements: str
        version_added: '0.2.0'
 notes:
-  - When used with a `loop:` each package will be processed individually,
-    it is much more efficient to pass the list directly to the `name` option.
+  - When used with a C(loop:) each package will be processed individually,
+    it is much more efficient to pass the list directly to the I(name) option.
 '''

 EXAMPLES = '''
--- a/plugins/modules/packaging/os/openbsd_pkg.py
+++ b/plugins/modules/packaging/os/openbsd_pkg.py
@@ -70,8 +70,8 @@ options:
        type: bool
        default: no
 notes:
-  - When used with a `loop:` each package will be processed individually,
-    it is much more efficient to pass the list directly to the `name` option.
+  - When used with a C(loop:) each package will be processed individually,
+    it is much more efficient to pass the list directly to the I(name) option.
 '''

 EXAMPLES = '''
--- a/plugins/modules/packaging/os/pacman.py
+++ b/plugins/modules/packaging/os/pacman.py
@@ -636,8 +636,9 @@ class Pacman(object):
                                stderr=stderr,
                                rc=rc,
                            )
-                    # With Pacman v6.0.1 - libalpm v13.0.1, --upgrade outputs "loading packages..." on stdout. strip that
-                    stdout = stdout.replace("loading packages...\n", "")
+                    # With Pacman v6.0.1 - libalpm v13.0.1, --upgrade outputs " filename_without_extension downloading..." if the URL is unseen.
+                    # In all cases, pacman outputs "loading packages..." on stdout. strip both
+                    stdout = stdout.splitlines()[-1]
                    is_URL = True
                pkg_name = stdout.strip()
                pkg_list.append(Package(name=pkg_name, source=pkg, source_is_URL=is_URL))
--- a/plugins/modules/packaging/os/pkgng.py
+++ b/plugins/modules/packaging/os/pkgng.py
@@ -37,7 +37,7 @@ options:
    state:
        description:
            - State of the package.
-            - 'Note: "latest" added in 2.7'
+            - 'Note: C(latest) added in 2.7.'
        choices: [ 'present', 'latest', 'absent' ]
        required: false
        default: present
@@ -102,8 +102,8 @@ options:
 author: "bleader (@bleader)"
 notes:
  - When using pkgsite, be careful that already in cache packages won't be downloaded again.
-  - When used with a `loop:` each package will be processed individually,
-    it is much more efficient to pass the list directly to the `name` option.
+  - When used with a C(loop:) each package will be processed individually,
+    it is much more efficient to pass the list directly to the I(name) option.
 '''

 EXAMPLES = '''
@@ -148,10 +148,7 @@ def query_package(module, run_pkgng, name):

    rc, out, err = run_pkgng('info', '-g', '-e', name)

-    if rc == 0:
-        return True
-
-    return False
+    return rc == 0


 def query_update(module, run_pkgng, name):
@@ -161,10 +158,7 @@ def query_update(module, run_pkgng, name):
    # rc = 1, updates available
    rc, out, err = run_pkgng('upgrade', '-g', '-n', name)

-    if rc == 1:
-        return True
-
-    return False
+    return rc == 1


 def pkgng_older_than(module, pkgng_path, compare_version):
@@ -190,7 +184,7 @@ def upgrade_packages(module, run_pkgng):

    pkgng_args = ['upgrade']
    pkgng_args.append('-n' if module.check_mode else '-y')
-    rc, out, err = run_pkgng(*pkgng_args)
+    rc, out, err = run_pkgng(*pkgng_args, check_rc=(not module.check_mode))

    matches = re.findall('^Number of packages to be (?:upgraded|reinstalled): ([0-9]+)', out, re.MULTILINE)
    for match in matches:
--- a/plugins/modules/packaging/os/pulp_repo.py
+++ b/plugins/modules/packaging/os/pulp_repo.py
@@ -119,7 +119,7 @@ options:
  repoview:
    description:
      - Whether to generate repoview files for a published repository. Setting
-        this to "yes" automatically activates `generate_sqlite`.
+        this to "yes" automatically activates C(generate_sqlite).
    required: false
    type: bool
    default: no
--- a/plugins/modules/packaging/os/redhat_subscription.py
+++ b/plugins/modules/packaging/os/redhat_subscription.py
@@ -468,7 +468,7 @@ class Rhsm(RegistrationBase):
            items = ["--all"]

        if items:
-            args = [SUBMAN_CMD, 'unsubscribe'] + items
+            args = [SUBMAN_CMD, 'remove'] + items
            rc, stderr, stdout = self.module.run_command(args, check_rc=True)
        return serials

@@ -592,15 +592,22 @@ class Rhsm(RegistrationBase):
        consumed_pools = RhsmPools(self.module, consumed=True)

        existing_pools = {}
+        serials_to_remove = []
        for p in consumed_pools:
-            existing_pools[p.get_pool_id()] = p.QuantityUsed
+            pool_id = p.get_pool_id()
+            quantity_used = p.get_quantity_used()
+            existing_pools[pool_id] = quantity_used
+
+            quantity = pool_ids.get(pool_id, 0)
+            if quantity is not None and quantity != quantity_used:
+                serials_to_remove.append(p.Serial)

-        serials_to_remove = [p.Serial for p in consumed_pools if pool_ids.get(p.get_pool_id(), 0) != p.QuantityUsed]
        serials = self.unsubscribe(serials=serials_to_remove)

        missing_pools = {}
        for pool_id, quantity in sorted(pool_ids.items()):
-            if existing_pools.get(pool_id, 0) != quantity:
+            quantity_used = existing_pools.get(pool_id, 0)
+            if quantity is None and quantity_used == 0 or quantity not in (None, 0, quantity_used):
                missing_pools[pool_id] = quantity

        self.subscribe_by_pool_ids(missing_pools)
@@ -634,6 +641,9 @@ class RhsmPool(object):
    def get_pool_id(self):
        return getattr(self, 'PoolId', getattr(self, 'PoolID'))

+    def get_quantity_used(self):
+        return int(getattr(self, 'QuantityUsed'))
+
    def subscribe(self):
        args = "subscription-manager attach --pool %s" % self.get_pool_id()
        rc, stdout, stderr = self.module.run_command(args, check_rc=True)
--- a/plugins/modules/packaging/os/xbps.py
+++ b/plugins/modules/packaging/os/xbps.py
@@ -160,7 +160,7 @@ def upgrade(module, xbps_path):

    rc, stdout, stderr = module.run_command(cmdneedupgrade, check_rc=False)
    if rc == 0:
-        if(len(stdout.splitlines()) == 0):
+        if len(stdout.splitlines()) == 0:
            module.exit_json(changed=False, msg='Nothing to upgrade')
        elif module.check_mode:
            module.exit_json(changed=True, msg='Would have performed upgrade')
--- a/plugins/modules/packaging/os/yum_versionlock.py
+++ b/plugins/modules/packaging/os/yum_versionlock.py
@@ -1,6 +1,6 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
-# Copyright: (c) 2018, Florian Paul Hoberg <florian.hoberg@credativ.de>
+# Copyright: (c) 2018, Florian Paul Azim Hoberg <florian.hoberg@credativ.de>
 #
 # GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

@@ -35,7 +35,7 @@ requirements:
 - yum
 - yum-versionlock
 author:
-    - Florian Paul Hoberg (@florianpaulhoberg)
+    - Florian Paul Azim Hoberg (@gyptazy)
    - Amin Vakil (@aminvakil)
 '''

--- a/plugins/modules/packaging/os/zypper.py
+++ b/plugins/modules/packaging/os/zypper.py
@@ -136,8 +136,8 @@ options:
          - Adds C(--clean-deps) option to I(zypper) remove command.
        version_added: '4.6.0'
 notes:
-  - When used with a `loop:` each package will be processed individually,
-    it is much more efficient to pass the list directly to the `name` option.
+  - When used with a C(loop:) each package will be processed individually,
+    it is much more efficient to pass the list directly to the I(name) option.
 # informational: requirements for nodes
 requirements:
    - "zypper >= 1.0  # included in openSUSE >= 11.1 or SUSE Linux Enterprise Server/Desktop >= 11.0"
--- a/plugins/modules/remote_management/hpilo/hponcfg.py
+++ b/plugins/modules/remote_management/hpilo/hponcfg.py
@@ -27,7 +27,7 @@ options:
    required: false
  executable:
    description:
-    - Path to the hponcfg executable (`hponcfg` which uses $PATH).
+    - Path to the hponcfg executable (C(hponcfg) which uses $PATH).
    default: hponcfg
  verbose:
    description:
--- a/plugins/modules/remote_management/lenovoxcc/xcc_redfish_command.py
+++ b/plugins/modules/remote_management/lenovoxcc/xcc_redfish_command.py
@@ -1,7 +1,7 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
 #
-# GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/modules/remote_management/manageiq/manageiq_alert_profiles.py
+++ b/plugins/modules/remote_management/manageiq/manageiq_alert_profiles.py
@@ -238,7 +238,7 @@ class ManageIQAlertProfiles(object):
            except Exception as e:
                msg = "Updating profile '{name}' failed: {error}"
                msg = msg.format(name=old_profile['name'], error=e)
-                self.module.fail_json(msg=msg, result=result)
+                self.module.fail_json(msg=msg)

        if changed:
            msg = "Profile {name} updated successfully".format(name=desired_profile['name'])
--- a/plugins/modules/remote_management/redfish/idrac_redfish_command.py
+++ b/plugins/modules/remote_management/redfish/idrac_redfish_command.py
@@ -2,7 +2,7 @@
 # -*- coding: utf-8 -*-

 # Copyright (c) 2018 Dell EMC Inc.
-# GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/modules/remote_management/redfish/idrac_redfish_config.py
+++ b/plugins/modules/remote_management/redfish/idrac_redfish_config.py
@@ -2,7 +2,7 @@
 # -*- coding: utf-8 -*-

 # Copyright (c) 2019 Dell EMC Inc.
-# GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/modules/remote_management/redfish/idrac_redfish_info.py
+++ b/plugins/modules/remote_management/redfish/idrac_redfish_info.py
@@ -2,7 +2,7 @@
 # -*- coding: utf-8 -*-

 # Copyright (c) 2019 Dell EMC Inc.
-# GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/modules/remote_management/redfish/ilo_redfish_config.py
+++ b/plugins/modules/remote_management/redfish/ilo_redfish_config.py
@@ -1,7 +1,7 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
 # Copyright (c) 2021-2022 Hewlett Packard Enterprise, Inc. All rights reserved.
-# GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type

--- a/plugins/modules/remote_management/redfish/ilo_redfish_info.py
+++ b/plugins/modules/remote_management/redfish/ilo_redfish_info.py
@@ -1,7 +1,7 @@
 #!/usr/bin/python
 # -*- coding: utf-8 -*-
 # Copyright (c) 2021-2022 Hewlett Packard Enterprise, Inc. All rights reserved.
-# GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
 from __future__ import absolute_import, division, print_function
 __metaclass__ = type

--- a/plugins/modules/remote_management/redfish/redfish_command.py
+++ b/plugins/modules/remote_management/redfish/redfish_command.py
@@ -2,7 +2,7 @@
 # -*- coding: utf-8 -*-

 # Copyright (c) 2017-2018 Dell EMC Inc.
-# GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/modules/remote_management/redfish/redfish_config.py
+++ b/plugins/modules/remote_management/redfish/redfish_config.py
@@ -2,7 +2,7 @@
 # -*- coding: utf-8 -*-

 # Copyright (c) 2017-2018 Dell EMC Inc.
-# GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/modules/remote_management/redfish/redfish_info.py
+++ b/plugins/modules/remote_management/redfish/redfish_info.py
@@ -2,7 +2,7 @@
 # -*- coding: utf-8 -*-

 # Copyright (c) 2017-2018 Dell EMC Inc.
-# GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/modules/source_control/gitlab/gitlab_branch.py
+++ b/plugins/modules/source_control/gitlab/gitlab_branch.py
@@ -71,20 +71,13 @@ RETURN = '''

 import traceback

-from ansible.module_utils.basic import AnsibleModule, missing_required_lib
+from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.api import basic_auth_argument_spec

 from ansible_collections.community.general.plugins.module_utils.version import LooseVersion
-
-GITLAB_IMP_ERR = None
-try:
-    import gitlab
-    HAS_GITLAB_PACKAGE = True
-except Exception:
-    GITLAB_IMP_ERR = traceback.format_exc()
-    HAS_GITLAB_PACKAGE = False
-
-from ansible_collections.community.general.plugins.module_utils.gitlab import auth_argument_spec, gitlab_authentication
+from ansible_collections.community.general.plugins.module_utils.gitlab import (
+    auth_argument_spec, gitlab_authentication, gitlab, ensure_gitlab_package
+)


 class GitlabBranch(object):
@@ -143,15 +136,13 @@ def main():
        ],
        supports_check_mode=False
    )
+    ensure_gitlab_package(module)

    project = module.params['project']
    branch = module.params['branch']
    ref_branch = module.params['ref_branch']
    state = module.params['state']

-    if not HAS_GITLAB_PACKAGE:
-        module.fail_json(msg=missing_required_lib("python-gitlab"), exception=GITLAB_IMP_ERR)
-
    gitlab_version = gitlab.__version__
    if LooseVersion(gitlab_version) < LooseVersion('2.3.0'):
        module.fail_json(msg="community.general.gitlab_proteched_branch requires python-gitlab Python module >= 2.3.0 (installed version: [%s])."
--- a/plugins/modules/source_control/gitlab/gitlab_deploy_key.py
+++ b/plugins/modules/source_control/gitlab/gitlab_deploy_key.py
@@ -108,22 +108,13 @@ deploy_key:
  type: dict
 '''

-import re
-import traceback
-
-GITLAB_IMP_ERR = None
-try:
-    import gitlab
-    HAS_GITLAB_PACKAGE = True
-except Exception:
-    GITLAB_IMP_ERR = traceback.format_exc()
-    HAS_GITLAB_PACKAGE = False
-
 from ansible.module_utils.api import basic_auth_argument_spec
-from ansible.module_utils.basic import AnsibleModule, missing_required_lib
+from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.common.text.converters import to_native

-from ansible_collections.community.general.plugins.module_utils.gitlab import auth_argument_spec, find_project, gitlab_authentication
+from ansible_collections.community.general.plugins.module_utils.gitlab import (
+    auth_argument_spec, find_project, gitlab_authentication, gitlab, ensure_gitlab_package
+)


 class GitLabDeployKey(object):
@@ -261,6 +252,7 @@ def main():
        ],
        supports_check_mode=True,
    )
+    ensure_gitlab_package(module)

    state = module.params['state']
    project_identifier = module.params['project']
@@ -268,9 +260,6 @@ def main():
    key_keyfile = module.params['key']
    key_can_push = module.params['can_push']

-    if not HAS_GITLAB_PACKAGE:
-        module.fail_json(msg=missing_required_lib("python-gitlab"), exception=GITLAB_IMP_ERR)
-
    gitlab_instance = gitlab_authentication(module)

    gitlab_deploy_key = GitLabDeployKey(module, gitlab_instance)
--- a/plugins/modules/source_control/gitlab/gitlab_group.py
+++ b/plugins/modules/source_control/gitlab/gitlab_group.py
@@ -158,21 +158,13 @@ group:
  type: dict
 '''

-import traceback
-
-GITLAB_IMP_ERR = None
-try:
-    import gitlab
-    HAS_GITLAB_PACKAGE = True
-except Exception:
-    GITLAB_IMP_ERR = traceback.format_exc()
-    HAS_GITLAB_PACKAGE = False
-
 from ansible.module_utils.api import basic_auth_argument_spec
-from ansible.module_utils.basic import AnsibleModule, missing_required_lib
+from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.common.text.converters import to_native

-from ansible_collections.community.general.plugins.module_utils.gitlab import auth_argument_spec, find_group, gitlab_authentication
+from ansible_collections.community.general.plugins.module_utils.gitlab import (
+    auth_argument_spec, find_group, gitlab_authentication, gitlab, ensure_gitlab_package
+)


 class GitLabGroup(object):
@@ -338,6 +330,7 @@ def main():
        ],
        supports_check_mode=True,
    )
+    ensure_gitlab_package(module)

    group_name = module.params['name']
    group_path = module.params['path']
@@ -351,9 +344,6 @@ def main():
    require_two_factor_authentication = module.params['require_two_factor_authentication']
    avatar_path = module.params['avatar_path']

-    if not HAS_GITLAB_PACKAGE:
-        module.fail_json(msg=missing_required_lib("python-gitlab"), exception=GITLAB_IMP_ERR)
-
    gitlab_instance = gitlab_authentication(module)

    # Define default group_path based on group_name
--- a/plugins/modules/source_control/gitlab/gitlab_group_members.py
+++ b/plugins/modules/source_control/gitlab/gitlab_group_members.py
@@ -151,18 +151,11 @@ EXAMPLES = r'''
 RETURN = r''' # '''

 from ansible.module_utils.api import basic_auth_argument_spec
-from ansible.module_utils.basic import AnsibleModule, missing_required_lib
+from ansible.module_utils.basic import AnsibleModule

-from ansible_collections.community.general.plugins.module_utils.gitlab import auth_argument_spec, gitlab_authentication
-
-import traceback
-
-try:
-    import gitlab
-    HAS_PY_GITLAB = True
-except ImportError:
-    GITLAB_IMP_ERR = traceback.format_exc()
-    HAS_PY_GITLAB = False
+from ansible_collections.community.general.plugins.module_utils.gitlab import (
+    auth_argument_spec, gitlab_authentication, gitlab, ensure_gitlab_package
+)


 class GitLabGroup(object):
@@ -280,9 +273,7 @@ def main():
        ],
        supports_check_mode=True,
    )
-
-    if not HAS_PY_GITLAB:
-        module.fail_json(msg=missing_required_lib('python-gitlab', url='https://python-gitlab.readthedocs.io/en/stable/'), exception=GITLAB_IMP_ERR)
+    ensure_gitlab_package(module)

    access_level_int = {
        'guest': gitlab.GUEST_ACCESS,
--- a/plugins/modules/source_control/gitlab/gitlab_group_variable.py
+++ b/plugins/modules/source_control/gitlab/gitlab_group_variable.py
@@ -158,21 +158,14 @@ group_variable:
      sample: "['ACCESS_KEY_ID', 'SECRET_ACCESS_KEY']"
 '''

-import traceback
-from ansible.module_utils.basic import AnsibleModule, missing_required_lib
+from ansible.module_utils.basic import AnsibleModule
 from ansible.module_utils.api import basic_auth_argument_spec
 from ansible.module_utils.six import string_types
 from ansible.module_utils.six import integer_types

-GITLAB_IMP_ERR = None
-try:
-    import gitlab
-    HAS_GITLAB_PACKAGE = True
-except Exception:
-    GITLAB_IMP_ERR = traceback.format_exc()
-    HAS_GITLAB_PACKAGE = False
-
-from ansible_collections.community.general.plugins.module_utils.gitlab import auth_argument_spec, gitlab_authentication
+from ansible_collections.community.general.plugins.module_utils.gitlab import (
+    auth_argument_spec, gitlab_authentication, ensure_gitlab_package
+)


 def vars_to_variables(vars, module):
@@ -415,9 +408,7 @@ def main():
        ],
        supports_check_mode=True
    )
-
-    if not HAS_GITLAB_PACKAGE:
-        module.fail_json(msg=missing_required_lib("python-gitlab"), exception=GITLAB_IMP_ERR)
+    ensure_gitlab_package(module)

    purge = module.params['purge']
    var_list = module.params['vars']
--- a/plugins/modules/source_control/gitlab/gitlab_hook.py
+++ b/plugins/modules/source_control/gitlab/gitlab_hook.py
@@ -158,22 +158,12 @@ hook:
  type: dict
 '''

-import re
-import traceback
-
-GITLAB_IMP_ERR = None
-try:
-    import gitlab
-    HAS_GITLAB_PACKAGE = True
-except Exception:
-    GITLAB_IMP_ERR = traceback.format_exc()
-    HAS_GITLAB_PACKAGE = False
-
 from ansible.module_utils.api import basic_auth_argument_spec
-from ansible.module_utils.basic import AnsibleModule, missing_required_lib
-from ansible.module_utils.common.text.converters import to_native
+from ansible.module_utils.basic import AnsibleModule

-from ansible_collections.community.general.plugins.module_utils.gitlab import auth_argument_spec, find_project, gitlab_authentication
+from ansible_collections.community.general.plugins.module_utils.gitlab import (
+    auth_argument_spec, find_project, gitlab_authentication, ensure_gitlab_package
+)


 class GitLabHook(object):
@@ -329,6 +319,7 @@ def main():
        ],
        supports_check_mode=True,
    )
+    ensure_gitlab_package(module)

    state = module.params['state']
    project_identifier = module.params['project']
@@ -345,9 +336,6 @@ def main():
    enable_ssl_verification = module.params['hook_validate_certs']
    hook_token = module.params['token']

-    if not HAS_GITLAB_PACKAGE:
-        module.fail_json(msg=missing_required_lib("python-gitlab"), exception=GITLAB_IMP_ERR)
-
    gitlab_instance = gitlab_authentication(module)

    gitlab_hook = GitLabHook(module, gitlab_instance)
--- a/Show More
+++ b/Show More