Release 4.8.10.

Change release summary to maintenance release.
[PR #6175/1ddcdc63 backport][stable-4] Mark monit integration tests as unstable (#6176 )
2026-04-28 09:26:44 +00:00 · 2023-03-26 11:10:29 +02:00 · 2023-03-26 10:23:09 +02:00 · 2023-03-12 12:06:27 +00:00 · 2023-02-24 14:41:59 +01:00 · 2023-02-22 22:39:44 +01:00
306 changed files with 2181 additions and 1026 deletions
--- a/.azure-pipelines/azure-pipelines.yml
+++ b/.azure-pipelines/azure-pipelines.yml
@@ -24,15 +24,13 @@ schedules:
    always: true
    branches:
      include:
-        - stable-3
-        - stable-4
+        - stable-5
  - cron: 0 11 * * 0
    displayName: Weekly (old stable branches)
    always: true
    branches:
      include:
-        - stable-1
-        - stable-2
+        - stable-4

 variables:
  - name: checkoutPath
@@ -49,20 +47,20 @@ variables:
 resources:
  containers:
    - container: default
-      image: quay.io/ansible/azure-pipelines-test-container:1.9.0
+      image: quay.io/ansible/azure-pipelines-test-container:3.0.0

 pool: Standard

 stages:
 ### Sanity
-  - stage: Sanity_devel
-    displayName: Sanity devel
+  - stage: Sanity_2_14
+    displayName: Sanity 2.14
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
        parameters:
          nameFormat: Test {0}
-          testFormat: devel/sanity/{0}
+          testFormat: 2.14/sanity/{0}
          targets:
            - test: 1
            - test: 2
@@ -95,54 +93,15 @@ stages:
            - test: 2
            - test: 3
            - test: 4
-  - stage: Sanity_2_11
-    displayName: Sanity 2.11
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Test {0}
-          testFormat: 2.11/sanity/{0}
-          targets:
-            - test: 1
-            - test: 2
-            - test: 3
-            - test: 4
-  - stage: Sanity_2_10
-    displayName: Sanity 2.10
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Test {0}
-          testFormat: 2.10/sanity/{0}
-          targets:
-            - test: 1
-            - test: 2
-            - test: 3
-            - test: 4
-  - stage: Sanity_2_9
-    displayName: Sanity 2.9
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Test {0}
-          testFormat: 2.9/sanity/{0}
-          targets:
-            - test: 1
-            - test: 2
-            - test: 3
-            - test: 4
 ### Units
-  - stage: Units_devel
-    displayName: Units devel
+  - stage: Units_2_14
+    displayName: Units 2.14
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
        parameters:
          nameFormat: Python {0}
-          testFormat: devel/units/{0}/1
+          testFormat: 2.14/units/{0}/1
          targets:
            - test: 2.7
            - test: 3.5
@@ -176,61 +135,26 @@ stages:
            - test: 2.6
            - test: 3.5
            - test: 3.8
-  - stage: Units_2_11
-    displayName: Units 2.11
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: 2.11/units/{0}/1
-          targets:
-            - test: 2.6
-            - test: 2.7
-            - test: 3.5
-            - test: 3.9
-  - stage: Units_2_10
-    displayName: Units 2.10
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: 2.10/units/{0}/1
-          targets:
-            - test: 2.7
-            - test: 3.6
-  - stage: Units_2_9
-    displayName: Units 2.9
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: 2.9/units/{0}/1
-          targets:
-            - test: 2.6
-            - test: 3.5

 ## Remote
-  - stage: Remote_devel
-    displayName: Remote devel
+  - stage: Remote_2_14
+    displayName: Remote 2.14
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
        parameters:
-          testFormat: devel/{0}
+          testFormat: 2.14/{0}
          targets:
            - name: macOS 12.0
              test: macos/12.0
            - name: RHEL 7.9
              test: rhel/7.9
-            - name: RHEL 8.5
-              test: rhel/8.5
+            - name: RHEL 9.0
+              test: rhel/9.0
            - name: FreeBSD 12.3
              test: freebsd/12.3
-            - name: FreeBSD 13.0
-              test: freebsd/13.0
+            - name: FreeBSD 13.1
+              test: freebsd/13.1
          groups:
            - 1
            - 2
@@ -268,77 +192,26 @@ stages:
          groups:
            - 1
            - 2
-  - stage: Remote_2_11
-    displayName: Remote 2.11
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.11/{0}
-          targets:
-            - name: RHEL 7.9
-              test: rhel/7.9
-            - name: RHEL 8.3
-              test: rhel/8.3
-            #- name: FreeBSD 12.2
-            #  test: freebsd/12.2
-          groups:
-            - 1
-            - 2
-  - stage: Remote_2_10
-    displayName: Remote 2.10
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.10/{0}
-          targets:
-            - name: OS X 10.11
-              test: osx/10.11
-            - name: macOS 10.15
-              test: macos/10.15
-          groups:
-            - 1
-            - 2
-  - stage: Remote_2_9
-    displayName: Remote 2.9
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.9/{0}
-          targets:
-            - name: RHEL 8.2
-              test: rhel/8.2
-            - name: RHEL 7.8
-              test: rhel/7.8
-            #- name: FreeBSD 12.0
-            #  test: freebsd/12.0
-          groups:
-            - 1
-            - 2

 ### Docker
-  - stage: Docker_devel
-    displayName: Docker devel
+  - stage: Docker_2_14
+    displayName: Docker 2.14
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
        parameters:
-          testFormat: devel/linux/{0}
+          testFormat: 2.14/linux/{0}
          targets:
            - name: CentOS 7
              test: centos7
-            - name: Fedora 34
-              test: fedora34
-            - name: Fedora 35
-              test: fedora35
+            - name: Fedora 36
+              test: fedora36
            - name: openSUSE 15
              test: opensuse15
-            - name: Ubuntu 18.04
-              test: ubuntu1804
            - name: Ubuntu 20.04
              test: ubuntu2004
+            - name: Ubuntu 22.04
+              test: ubuntu2204
            - name: Alpine 3
              test: alpine3
          groups:
@@ -375,85 +248,42 @@ stages:
              test: centos6
            - name: Fedora 34
              test: fedora34
-            - name: Ubuntu 20.04
-              test: ubuntu2004
+            - name: Ubuntu 18.04
+              test: ubuntu1804
          groups:
            - 1
            - 2
            - 3
-  - stage: Docker_2_11
-    displayName: Docker 2.11
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.11/linux/{0}
-          targets:
-            - name: Fedora 33
-              test: fedora33
-            - name: Alpine 3
-              test: alpine3
-          groups:
-            - 2
-            - 3
-  - stage: Docker_2_10
-    displayName: Docker 2.10
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.10/linux/{0}
-          targets:
-            - name: Fedora 32
-              test: fedora32
-            - name: Ubuntu 16.04
-              test: ubuntu1604
-          groups:
-            - 2
-            - 3
-  - stage: Docker_2_9
-    displayName: Docker 2.9
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.9/linux/{0}
-          targets:
-            - name: Fedora 31
-              test: fedora31
-          groups:
-            - 2
-            - 3

 ### Community Docker
-  - stage: Docker_community_devel
-    displayName: Docker (community images) devel
+  - stage: Docker_community_2_14
+    displayName: Docker (community images) 2.14
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
        parameters:
-          testFormat: devel/linux-community/{0}
+          testFormat: 2.14/linux-community/{0}
          targets:
            - name: Debian Bullseye
              test: debian-bullseye/3.9
            - name: ArchLinux
              test: archlinux/3.10
            - name: CentOS Stream 8
-              test: centos-stream8/3.8
+              test: centos-stream8/3.9
          groups:
            - 1
            - 2
            - 3

 ### Cloud
-  - stage: Cloud_devel
-    displayName: Cloud devel
+  - stage: Cloud_2_14
+    displayName: Cloud 2.14
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
        parameters:
          nameFormat: Python {0}
-          testFormat: devel/cloud/{0}/1
+          testFormat: 2.14/cloud/{0}/1
          targets:
            - test: 2.7
            - test: '3.10'
@@ -477,68 +307,23 @@ stages:
          testFormat: 2.12/cloud/{0}/1
          targets:
            - test: 3.8
-  - stage: Cloud_2_11
-    displayName: Cloud 2.11
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: 2.11/cloud/{0}/1
-          targets:
-            - test: 3.6
-  - stage: Cloud_2_10
-    displayName: Cloud 2.10
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: 2.10/cloud/{0}/1
-          targets:
-            - test: 3.5
-  - stage: Cloud_2_9
-    displayName: Cloud 2.9
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: 2.9/cloud/{0}/1
-          targets:
-            - test: 2.7
  - stage: Summary
    condition: succeededOrFailed()
    dependsOn:
-      - Sanity_devel
-      - Sanity_2_9
-      - Sanity_2_10
-      - Sanity_2_11
+      - Sanity_2_14
      - Sanity_2_12
      - Sanity_2_13
-      - Units_devel
-      - Units_2_9
-      - Units_2_10
-      - Units_2_11
+      - Units_2_14
      - Units_2_12
      - Units_2_13
-      - Remote_devel
-      - Remote_2_9
-      - Remote_2_10
-      - Remote_2_11
+      - Remote_2_14
      - Remote_2_12
      - Remote_2_13
-      - Docker_devel
-      - Docker_2_9
-      - Docker_2_10
-      - Docker_2_11
+      - Docker_2_14
      - Docker_2_12
      - Docker_2_13
-      - Docker_community_devel
-      - Cloud_devel
-      - Cloud_2_9
-      - Cloud_2_10
-      - Cloud_2_11
+      - Docker_community_2_14
+      - Cloud_2_14
      - Cloud_2_12
      - Cloud_2_13
    jobs:
--- a/.azure-pipelines/scripts/aggregate-coverage.sh
+++ b/.azure-pipelines/scripts/aggregate-coverage.sh
@@ -9,6 +9,10 @@ PATH="${PWD}/bin:${PATH}"

 mkdir "${agent_temp_directory}/coverage/"

+if [[ "$(ansible --version)" =~ \ 2\.9\. ]]; then
+    exit
+fi
+
 options=(--venv --venv-system-site-packages --color -v)

 ansible-test coverage combine --group-by command --export "${agent_temp_directory}/coverage/" "${options[@]}"
--- a/.azure-pipelines/scripts/report-coverage.sh
+++ b/.azure-pipelines/scripts/report-coverage.sh
@@ -5,6 +5,10 @@ set -o pipefail -eu

 PATH="${PWD}/bin:${PATH}"

+if [[ "$(ansible --version)" =~ \ 2\.9\. ]]; then
+    exit
+fi
+
 if ! ansible-test --help >/dev/null 2>&1; then
    # Install the devel version of ansible-test for generating code coverage reports.
    # This is only used by Ansible Collections, which are typically tested against multiple Ansible versions (in separate jobs).
--- a/.github/BOTMETA.yml
+++ b/.github/BOTMETA.yml
@@ -220,7 +220,8 @@ files:
  $lookups/dnstxt.py:
    maintainers: jpmens
  $lookups/dsv.py:
-    maintainers: amigus endlesstrax
+    maintainers: delineaKrehl tylerezimmerman
+    ignore: amigus
  $lookups/etcd3.py:
    maintainers: eric-belhomme
  $lookups/etcd.py:
@@ -257,7 +258,8 @@ files:
    maintainers: RevBits
  $lookups/shelvefile.py: {}
  $lookups/tss.py:
-    maintainers: amigus endlesstrax
+    maintainers: delineaKrehl tylerezimmerman
+    ignore: amigus
  $module_utils/:
    labels: module_utils
  $module_utils/gitlab.py:
@@ -621,7 +623,7 @@ files:
  $modules/monitoring/nagios.py:
    maintainers: tbielawa tgoetheyn
  $modules/monitoring/newrelic_deployment.py:
-    maintainers: mcodd
+    ignore: mcodd
  $modules/monitoring/pagerduty.py:
    maintainers: suprememoocow thaumos
    labels: pagerduty
@@ -713,7 +715,7 @@ files:
  $modules/notification/discord.py:
    maintainers: cwollinger
  $modules/notification/flowdock.py:
-    maintainers: mcodd
+    ignore: mcodd
  $modules/notification/grove.py:
    maintainers: zimbatm
  $modules/notification/hipchat.py:
@@ -745,7 +747,8 @@ files:
    labels: rocketchat
    ignore: ramondelafuente
  $modules/notification/say.py:
-    maintainers: $team_ansible_core mpdehaan
+    maintainers: $team_ansible_core
+    ignore: mpdehaan
  $modules/notification/sendgrid.py:
    maintainers: makaimc
  $modules/notification/slack.py:
@@ -921,7 +924,7 @@ files:
  $modules/packaging/os/xbps.py:
    maintainers: dinoocch the-maldridge
  $modules/packaging/os/yum_versionlock.py:
-    maintainers: florianpaulhoberg aminvakil
+    maintainers: gyptazy aminvakil
  $modules/packaging/os/zypper.py:
    maintainers: $team_suse
    labels: zypper
@@ -1097,7 +1100,8 @@ files:
  $modules/system/nosh.py:
    maintainers: tacatac
  $modules/system/ohai.py:
-    maintainers: $team_ansible_core mpdehaan
+    maintainers: $team_ansible_core
+    ignore: mpdehaan
    labels: ohai
  $modules/system/open_iscsi.py:
    maintainers: srvg
@@ -1287,5 +1291,5 @@ macros:
  team_rhn: FlossWare alikins barnabycourt vritant
  team_scaleway: remyleone abarbare
  team_solaris: bcoca fishman jasperla jpdasma mator scathatheworm troy2914 xen0l
-  team_suse: commel dcermak evrardjp lrupp toabctl AnderEnder alxgu andytom sealor
+  team_suse: commel evrardjp lrupp toabctl AnderEnder alxgu andytom sealor
  team_virt: joshainglis karmab tleguern Thulium-Drake Ajpantuso
--- a/.github/workflows/ansible-test.yml
+++ b/.github/workflows/ansible-test.yml
@@ -0,0 +1,220 @@
+---
+# Copyright (c) Ansible Project
+# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
+# SPDX-License-Identifier: GPL-3.0-or-later
+
+# For the comprehensive list of the inputs supported by the ansible-community/ansible-test-gh-action GitHub Action, see
+# https://github.com/marketplace/actions/ansible-test
+
+name: EOL CI
+on:
+  # Run EOL CI against all pushes (direct commits, also merged PRs), Pull Requests
+  push:
+    branches:
+      - main
+      - stable-*
+  pull_request:
+  # Run EOL CI once per week (at 11:00 UTC)
+  schedule:
+    - cron: '0 11 * * 0'
+
+concurrency:
+  # Make sure there is at most one active run per PR, but do not cancel any non-PR runs
+  group: ${{ github.workflow }}-${{ (github.head_ref && github.event.number) || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  sanity:
+    name: EOL Sanity (Ⓐ${{ matrix.ansible }})
+    strategy:
+      matrix:
+        ansible:
+          - '2.11'
+          - '2.10'
+          - '2.9'
+    # Ansible-test on various stable branches does not yet work well with cgroups v2.
+    # Since ubuntu-latest now uses Ubuntu 22.04, we need to fall back to the ubuntu-20.04
+    # image for these stable branches. The list of branches where this is necessary will
+    # shrink over time, check out https://github.com/ansible-collections/news-for-maintainers/issues/28
+    # for the latest list.
+    runs-on: >-
+      ${{ contains(fromJson(
+          '["2.9", "2.10", "2.11"]'
+      ), matrix.ansible) && 'ubuntu-20.04' || 'ubuntu-latest' }}
+    steps:
+      - name: Perform sanity testing
+        uses: felixfontein/ansible-test-gh-action@main
+        with:
+          ansible-core-github-repository-slug: felixfontein/ansible
+          ansible-core-version: stable-${{ matrix.ansible }}
+          coverage: ${{ github.event_name == 'schedule' && 'always' || 'never' }}
+          pull-request-change-detection: 'true'
+          testing-type: sanity
+
+  units:
+    # Ansible-test on various stable branches does not yet work well with cgroups v2.
+    # Since ubuntu-latest now uses Ubuntu 22.04, we need to fall back to the ubuntu-20.04
+    # image for these stable branches. The list of branches where this is necessary will
+    # shrink over time, check out https://github.com/ansible-collections/news-for-maintainers/issues/28
+    # for the latest list.
+    runs-on: >-
+      ${{ contains(fromJson(
+          '["2.9", "2.10", "2.11"]'
+      ), matrix.ansible) && 'ubuntu-20.04' || 'ubuntu-latest' }}
+    name: EOL Units (Ⓐ${{ matrix.ansible }}+py${{ matrix.python }})
+    strategy:
+      # As soon as the first unit test fails, cancel the others to free up the CI queue
+      fail-fast: true
+      matrix:
+        ansible:
+          - ''
+        python:
+          - ''
+        exclude:
+          - ansible: ''
+        include:
+          - ansible: '2.11'
+            python: '2.6'
+          - ansible: '2.11'
+            python: '2.7'
+          - ansible: '2.11'
+            python: '3.5'
+          - ansible: '2.11'
+            python: '3.9'
+          - ansible: '2.10'
+            python: '2.7'
+          - ansible: '2.10'
+            python: '3.6'
+          - ansible: '2.9'
+            python: '2.6'
+          - ansible: '2.9'
+            python: '3.5'
+
+    steps:
+      - name: >-
+          Perform unit testing against
+          Ansible version ${{ matrix.ansible }}
+        uses: felixfontein/ansible-test-gh-action@main
+        with:
+          ansible-core-github-repository-slug: felixfontein/ansible
+          ansible-core-version: stable-${{ matrix.ansible }}
+          coverage: ${{ github.event_name == 'schedule' && 'always' || 'never' }}
+          pre-test-cmd: >-
+            mkdir -p ../../ansible
+            ;
+            git clone --depth=1 --single-branch https://github.com/ansible-collections/community.internal_test_tools.git ../../community/internal_test_tools
+            ;
+            if [ ${{ matrix.ansible }} == "2.9" ]; then cp tests/unit/requirements-2.9.txt tests/unit/requirements.txt; fi
+            ;
+            if [ ${{ matrix.ansible }} == "2.10" ]; then cp tests/unit/requirements-2.10.txt tests/unit/requirements.txt; fi
+          pull-request-change-detection: 'true'
+          target-python-version: ${{ matrix.python }}
+          testing-type: units
+
+  integration:
+    # Ansible-test on various stable branches does not yet work well with cgroups v2.
+    # Since ubuntu-latest now uses Ubuntu 22.04, we need to fall back to the ubuntu-20.04
+    # image for these stable branches. The list of branches where this is necessary will
+    # shrink over time, check out https://github.com/ansible-collections/news-for-maintainers/issues/28
+    # for the latest list.
+    runs-on: >-
+      ${{ contains(fromJson(
+          '["2.9", "2.10", "2.11"]'
+      ), matrix.ansible) && 'ubuntu-20.04' || 'ubuntu-latest' }}
+    name: EOL I (Ⓐ${{ matrix.ansible }}+${{ matrix.docker }}+py${{ matrix.python }}:${{ matrix.target }})
+    strategy:
+      fail-fast: false
+      matrix:
+        ansible:
+          - ''
+        docker:
+          - ''
+        python:
+          - ''
+        target:
+          - ''
+        exclude:
+          - ansible: ''
+        include:
+          # 2.11
+          - ansible: '2.11'
+            docker: fedora33
+            python: ''
+            target: shippable/posix/group2/
+          - ansible: '2.11'
+            docker: fedora33
+            python: ''
+            target: shippable/posix/group3/
+          - ansible: '2.11'
+            docker: alpine3
+            python: ''
+            target: shippable/posix/group2/
+          - ansible: '2.11'
+            docker: alpine3
+            python: ''
+            target: shippable/posix/group3/
+          - ansible: '2.11'
+            docker: default
+            python: '3.6'
+            target: shippable/cloud/group1/
+          # 2.10
+          - ansible: '2.10'
+            docker: fedora32
+            python: ''
+            target: shippable/posix/group2/
+          - ansible: '2.10'
+            docker: fedora32
+            python: ''
+            target: shippable/posix/group3/
+          - ansible: '2.10'
+            docker: ubuntu1604
+            python: ''
+            target: shippable/posix/group2/
+          - ansible: '2.10'
+            docker: ubuntu1604
+            python: ''
+            target: shippable/posix/group3/
+          - ansible: '2.10'
+            docker: default
+            python: '3.5'
+            target: shippable/cloud/group1/
+          # 2.9
+          - ansible: '2.9'
+            docker: fedora31
+            python: ''
+            target: shippable/posix/group2/
+          - ansible: '2.9'
+            docker: fedora31
+            python: ''
+            target: shippable/posix/group3/
+          - ansible: '2.9'
+            docker: default
+            python: '2.7'
+            target: shippable/cloud/group1/
+
+    steps:
+      - name: >-
+          Perform integration testing against
+          Ansible version ${{ matrix.ansible }}
+          under Python ${{ matrix.python }}
+        uses: felixfontein/ansible-test-gh-action@main
+        with:
+          ansible-core-github-repository-slug: felixfontein/ansible
+          ansible-core-version: stable-${{ matrix.ansible }}
+          coverage: ${{ github.event_name == 'schedule' && 'always' || 'never' }}
+          docker-image: ${{ matrix.docker }}
+          integration-continue-on-error: 'false'
+          integration-diff: 'false'
+          integration-retry-on-error: 'true'
+          pre-test-cmd: >-
+            mkdir -p ../../ansible
+            ;
+            git clone --depth=1 --single-branch https://github.com/ansible-collections/ansible.posix.git ../../ansible/posix
+            ;
+            git clone --depth=1 ${{ matrix.docker == 'ubuntu1604' && '--branch stable-1' || '' }} --single-branch https://github.com/ansible-collections/community.crypto.git ../../community/crypto
+            ;
+            git clone --depth=1 --single-branch https://github.com/ansible-collections/community.internal_test_tools.git ../../community/internal_test_tools
+          pull-request-change-detection: 'true'
+          target: ${{ matrix.target }}
+          target-python-version: ${{ matrix.python }}
+          testing-type: integration
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -6,6 +6,190 @@ Community General Release Notes

 This changelog describes changes after version 3.0.0.

+v4.8.10
+=======
+
+Release Summary
+---------------
+
+Maintenance release.
+
+Bugfixes
+--------
+
+- ModuleHelper - fix bug when adjusting the name of reserved output variables (https://github.com/ansible-collections/community.general/pull/5755).
+- loganalytics callback plugin - adjust type of callback to ``notification``, it was incorrectly classified as ``aggregate`` before (https://github.com/ansible-collections/community.general/pull/5761).
+- logdna callback plugin - adjust type of callback to ``notification``, it was incorrectly classified as ``aggregate`` before (https://github.com/ansible-collections/community.general/pull/5761).
+- logstash callback plugin - adjust type of callback to ``notification``, it was incorrectly classified as ``aggregate`` before (https://github.com/ansible-collections/community.general/pull/5761).
+- splunk callback plugin - adjust type of callback to ``notification``, it was incorrectly classified as ``aggregate`` before (https://github.com/ansible-collections/community.general/pull/5761).
+- sumologic callback plugin - adjust type of callback to ``notification``, it was incorrectly classified as ``aggregate`` before (https://github.com/ansible-collections/community.general/pull/5761).
+- syslog_json callback plugin - adjust type of callback to ``notification``, it was incorrectly classified as ``aggregate`` before (https://github.com/ansible-collections/community.general/pull/5761).
+- terraform and timezone - slight refactoring to avoid linter reporting potentially undefined variables (https://github.com/ansible-collections/community.general/pull/5933).
+
+v4.8.9
+======
+
+Release Summary
+---------------
+
+Bugfix release.
+
+Note that from now on, community.general 4.x.y only receives security fixes and major bugfixes, but no longer regular bugfixes.
+
+Bugfixes
+--------
+
+- ldap_attrs - fix bug which caused a ``Bad search filter`` error. The error was occuring when the ldap attribute value contained special characters such as ``(`` or ``*`` (https://github.com/ansible-collections/community.general/issues/5434, https://github.com/ansible-collections/community.general/pull/5435).
+- ldap_attrs - fix ordering issue by ignoring the ``{x}`` prefix on attribute values (https://github.com/ansible-collections/community.general/issues/977, https://github.com/ansible-collections/community.general/pull/5385).
+
+v4.8.8
+======
+
+Release Summary
+---------------
+
+Regular bugfix release.
+
+Bugfixes
+--------
+
+- archive - avoid crash when ``lzma`` is not present and ``format`` is not ``xz`` (https://github.com/ansible-collections/community.general/pull/5393).
+- opentelemetry callback plugin - support opentelemetry-api 1.13.0 that removed support for ``_time_ns`` (https://github.com/ansible-collections/community.general/pull/5342).
+- pfexec become plugin - remove superflous quotes preventing exe wrap from working as expected (https://github.com/ansible-collections/community.general/issues/3671, https://github.com/ansible-collections/community.general/pull/3889).
+- pkgng - fix case when ``pkg`` fails when trying to upgrade all packages (https://github.com/ansible-collections/community.general/issues/5363).
+- redhat_subscription - make module idempotent when ``pool_ids`` are used (https://github.com/ansible-collections/community.general/issues/5313).
+- xenserver_facts - fix broken ``AnsibleModule`` call that prevented the module from working at all (https://github.com/ansible-collections/community.general/pull/5383).
+
+v4.8.7
+======
+
+Release Summary
+---------------
+
+Regular bugfix release.
+
+Minor Changes
+-------------
+
+- gitlab module util - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_branch - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_deploy_key - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_group - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_group_members - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_group_variable - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_hook - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_project - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_project_members - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_project_variable - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_protected_branch - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_runner - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+- gitlab_user - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+
+Bugfixes
+--------
+
+- locale_gen - fix support for Ubuntu (https://github.com/ansible-collections/community.general/issues/5281).
+- tss lookup plugin - adding support for updated Delinea library (https://github.com/DelineaXPM/python-tss-sdk/issues/9, https://github.com/ansible-collections/community.general/pull/5151).
+
+v4.8.6
+======
+
+Release Summary
+---------------
+
+Bugfix and maintenance release.
+
+Minor Changes
+-------------
+
+- Added MIT license as ``MIT-license.txt`` for ``tests/unit/plugins/modules/packaging/language/test_gem.py`` (https://github.com/ansible-collections/community.general/pull/5065, https://github.com/ansible-collections/community.general/pull/5072).
+
+Bugfixes
+--------
+
+- apache2_mod_proxy - avoid crash when reporting inability to parse balancer_member_page HTML caused by using an undefined variable in the error message (https://github.com/ansible-collections/community.general/pull/5111).
+- dnsimple_info - correctly report missing library as ``requests`` and not ``another_library`` (https://github.com/ansible-collections/community.general/pull/5111).
+- funcd connection plugin - fix signature of ``exec_command`` (https://github.com/ansible-collections/community.general/pull/5111).
+- manageiq_alert_profiles - avoid crash when reporting unknown profile caused by trying to return an undefined variable (https://github.com/ansible-collections/community.general/pull/5111).
+- nsupdate - compatibility with NS records (https://github.com/ansible-collections/community.general/pull/5112).
+- packet_ip_subnet - fix error reporting in case of invalid CIDR prefix lengths (https://github.com/ansible-collections/community.general/pull/5111).
+- pip_package_info - remove usage of global variable (https://github.com/ansible-collections/community.general/pull/5111).
+
+v4.8.5
+======
+
+Release Summary
+---------------
+
+Regular bugfix release.
+
+Bugfixes
+--------
+
+- pacman - fixed name resolution of URL packages (https://github.com/ansible-collections/community.general/pull/4959).
+- proxmox - fix error handling when getting VM by name when ``state=absent`` (https://github.com/ansible-collections/community.general/pull/4945).
+- proxmox inventory plugin - fix crash when ``enabled=1`` is used in agent config string (https://github.com/ansible-collections/community.general/pull/4910).
+- proxmox_kvm - fix error handling when getting VM by name when ``state=absent`` (https://github.com/ansible-collections/community.general/pull/4945).
+- slack - fix incorrect channel prefix ``#`` caused by incomplete pattern detection by adding ``G0`` and ``GF`` as channel ID patterns (https://github.com/ansible-collections/community.general/pull/5019).
+
+v4.8.4
+======
+
+Release Summary
+---------------
+
+Regular bugfix release.
+
+Bugfixes
+--------
+
+- cmd_runner module utils - fix bug caused by using the ``command`` variable instead of ``self.command`` when looking for binary path (https://github.com/ansible-collections/community.general/pull/4903).
+- dsv lookup plugin - do not ignore the ``tld`` parameter (https://github.com/ansible-collections/community.general/pull/4911).
+- lxd connection plugin - fix incorrect ``inventory_hostname`` in ``remote_addr``. This is needed for compatibility with ansible-core 2.13 (https://github.com/ansible-collections/community.general/issues/4886).
+- rax_clb_nodes - fix code to be compatible with Python 3 (https://github.com/ansible-collections/community.general/pull/4933).
+- redfish_info - fix to ``GetChassisPower`` to correctly report power information when multiple chassis exist, but not all chassis report power information (https://github.com/ansible-collections/community.general/issues/4901).
+
+v4.8.3
+======
+
+Release Summary
+---------------
+
+Bugfix release.
+
+Minor Changes
+-------------
+
+- ModuleHelper module utils - improved ``ModuleHelperException``, using ``to_native()`` for the exception message (https://github.com/ansible-collections/community.general/pull/4755).
+
+Bugfixes
+--------
+
+- nmcli - fix error caused by adding undefined module arguments for list options (https://github.com/ansible-collections/community.general/issues/4373, https://github.com/ansible-collections/community.general/pull/4813).
+- redhat_subscription - fix unsubscribing on RHEL 9 (https://github.com/ansible-collections/community.general/issues/4741).
+- sudoers - ensure sudoers config files are created with the permissions requested by sudoers (0440) (https://github.com/ansible-collections/community.general/pull/4814).
+- sudoers - fix incorrect handling of ``state: absent`` (https://github.com/ansible-collections/community.general/issues/4852).
+
+v4.8.2
+======
+
+Release Summary
+---------------
+
+Regular maintenance and bugfix release.
+
+Bugfixes
+--------
+
+- Include ``simplified_bsd.txt`` license file for various module utils, the ``lxca_common`` docs fragment, and the ``utm_utils`` unit tests.
+- consul - fixed bug introduced in PR 4590 (https://github.com/ansible-collections/community.general/issues/4680).
+- filesystem - handle ``fatresize --info`` output lines without ``:`` (https://github.com/ansible-collections/community.general/pull/4700).
+- filesystem - improve error messages when output cannot be parsed by including newlines in escaped form (https://github.com/ansible-collections/community.general/pull/4700).
+- gitlab_hook - avoid errors during idempotency check when an attribute does not exist (https://github.com/ansible-collections/community.general/pull/4668).
+- keycloak_realm - fix default groups and roles (https://github.com/ansible-collections/community.general/issues/4241).
+- redis* modules - fix call to ``module.fail_json`` when failing because of missing Python libraries (https://github.com/ansible-collections/community.general/pull/4733).
+- xcc_redfish_command - for compatibility due to Redfish spec changes the virtualMedia resource location changed from Manager to System (https://github.com/ansible-collections/community.general/pull/4682).
+
 v4.8.1
 ======

--- a/MIT-license.txt
+++ b/MIT-license.txt
@@ -0,0 +1,9 @@
+MIT License
+
+Copyright (c) <year> <copyright holders>
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
--- a/README.md
+++ b/README.md
@@ -1,6 +1,7 @@
 # Community General Collection

 [![Build Status](https://dev.azure.com/ansible/community.general/_apis/build/status/CI?branchName=stable-4)](https://dev.azure.com/ansible/community.general/_build?definitionId=31)
+[![EOL CI](https://github.com/ansible-collections/community.general/workflows/EOL%20CI/badge.svg?event=push)](https://github.com/ansible-collections/community.general/actions)
 [![Codecov](https://img.shields.io/codecov/c/github/ansible-collections/community.general)](https://codecov.io/gh/ansible-collections/community.general)

 This repository contains the `community.general` Ansible Collection. The collection is a part of the Ansible package and includes many modules and plugins supported by Ansible community which are not part of more specialized community collections.
@@ -17,7 +18,7 @@ If you encounter abusive behavior violating the [Ansible Code of Conduct](https:

 ## Tested with Ansible

-Tested with the current Ansible 2.9, ansible-base 2.10, ansible-core 2.11, ansible-core 2.12, ansible-core 2.13 releases and the current development version of ansible-core. Ansible versions before 2.9.10 are not supported.
+Tested with the current Ansible 2.9, ansible-base 2.10, ansible-core 2.11, ansible-core 2.12, ansible-core 2.13, and ansible-core 2.14 releases of ansible-core. Ansible versions before 2.9.10 are not supported.

 ## External requirements

--- a/changelogs/changelog.yaml
+++ b/changelogs/changelog.yaml
@@ -1808,3 +1808,220 @@ releases:
    - 4647-gconftool2-command-arg.yaml
    - psf-license.yml
    release_date: '2022-05-16'
+  4.8.10:
+    changes:
+      bugfixes:
+      - ModuleHelper - fix bug when adjusting the name of reserved output variables
+        (https://github.com/ansible-collections/community.general/pull/5755).
+      - loganalytics callback plugin - adjust type of callback to ``notification``,
+        it was incorrectly classified as ``aggregate`` before (https://github.com/ansible-collections/community.general/pull/5761).
+      - logdna callback plugin - adjust type of callback to ``notification``, it was
+        incorrectly classified as ``aggregate`` before (https://github.com/ansible-collections/community.general/pull/5761).
+      - logstash callback plugin - adjust type of callback to ``notification``, it
+        was incorrectly classified as ``aggregate`` before (https://github.com/ansible-collections/community.general/pull/5761).
+      - splunk callback plugin - adjust type of callback to ``notification``, it was
+        incorrectly classified as ``aggregate`` before (https://github.com/ansible-collections/community.general/pull/5761).
+      - sumologic callback plugin - adjust type of callback to ``notification``, it
+        was incorrectly classified as ``aggregate`` before (https://github.com/ansible-collections/community.general/pull/5761).
+      - syslog_json callback plugin - adjust type of callback to ``notification``,
+        it was incorrectly classified as ``aggregate`` before (https://github.com/ansible-collections/community.general/pull/5761).
+      - terraform and timezone - slight refactoring to avoid linter reporting potentially
+        undefined variables (https://github.com/ansible-collections/community.general/pull/5933).
+      release_summary: Maintenance release.
+    fragments:
+    - 4.8.10.yml
+    - 5755-mh-fix-output-conflict.yml
+    - 5761-callback-types.yml
+    - 5933-linting.yml
+    release_date: '2023-03-26'
+  4.8.2:
+    changes:
+      bugfixes:
+      - Include ``simplified_bsd.txt`` license file for various module utils, the
+        ``lxca_common`` docs fragment, and the ``utm_utils`` unit tests.
+      - consul - fixed bug introduced in PR 4590 (https://github.com/ansible-collections/community.general/issues/4680).
+      - filesystem - handle ``fatresize --info`` output lines without ``:`` (https://github.com/ansible-collections/community.general/pull/4700).
+      - filesystem - improve error messages when output cannot be parsed by including
+        newlines in escaped form (https://github.com/ansible-collections/community.general/pull/4700).
+      - gitlab_hook - avoid errors during idempotency check when an attribute does
+        not exist (https://github.com/ansible-collections/community.general/pull/4668).
+      - keycloak_realm - fix default groups and roles (https://github.com/ansible-collections/community.general/issues/4241).
+      - redis* modules - fix call to ``module.fail_json`` when failing because of
+        missing Python libraries (https://github.com/ansible-collections/community.general/pull/4733).
+      - xcc_redfish_command - for compatibility due to Redfish spec changes the virtualMedia
+        resource location changed from Manager to System (https://github.com/ansible-collections/community.general/pull/4682).
+      release_summary: Regular maintenance and bugfix release.
+    fragments:
+    - 4.8.2.yml
+    - 4668-gitlab_hook-use-None-for-non-existent-attr.yml
+    - 4682-compatibility-virtualmedia-resource-location.yaml
+    - 4700-code-changes.yml
+    - 4712-consul-bugfix.yaml
+    - 4719-fix-keycloak-realm.yaml
+    - 4733-redis-fail.yml
+    - simplified-bsd-license.yml
+    release_date: '2022-06-06'
+  4.8.3:
+    changes:
+      bugfixes:
+      - nmcli - fix error caused by adding undefined module arguments for list options
+        (https://github.com/ansible-collections/community.general/issues/4373, https://github.com/ansible-collections/community.general/pull/4813).
+      - redhat_subscription - fix unsubscribing on RHEL 9 (https://github.com/ansible-collections/community.general/issues/4741).
+      - sudoers - ensure sudoers config files are created with the permissions requested
+        by sudoers (0440) (https://github.com/ansible-collections/community.general/pull/4814).
+      - 'sudoers - fix incorrect handling of ``state: absent`` (https://github.com/ansible-collections/community.general/issues/4852).'
+      minor_changes:
+      - ModuleHelper module utils - improved ``ModuleHelperException``, using ``to_native()``
+        for the exception message (https://github.com/ansible-collections/community.general/pull/4755).
+      release_summary: Bugfix release.
+    fragments:
+    - 4.8.3.yml
+    - 4755-mhexception-improvement.yml
+    - 4809-redhat_subscription-unsubscribe.yaml
+    - 4813-fix-nmcli-convert-list.yaml
+    - 4814-sudoers-file-permissions.yml
+    - 4852-sudoers-state-absent.yml
+    release_date: '2022-06-20'
+  4.8.4:
+    changes:
+      bugfixes:
+      - cmd_runner module utils - fix bug caused by using the ``command`` variable
+        instead of ``self.command`` when looking for binary path (https://github.com/ansible-collections/community.general/pull/4903).
+      - dsv lookup plugin - do not ignore the ``tld`` parameter (https://github.com/ansible-collections/community.general/pull/4911).
+      - lxd connection plugin - fix incorrect ``inventory_hostname`` in ``remote_addr``.
+        This is needed for compatibility with ansible-core 2.13 (https://github.com/ansible-collections/community.general/issues/4886).
+      - rax_clb_nodes - fix code to be compatible with Python 3 (https://github.com/ansible-collections/community.general/pull/4933).
+      - redfish_info - fix to ``GetChassisPower`` to correctly report power information
+        when multiple chassis exist, but not all chassis report power information
+        (https://github.com/ansible-collections/community.general/issues/4901).
+      release_summary: Regular bugfix release.
+    fragments:
+    - 4.8.4.yml
+    - 4886-fix-lxd-inventory-hostname.yml
+    - 4901-fix-redfish-chassispower.yml
+    - 4903-cmdrunner-bugfix.yaml
+    - 4911-dsv-honor-tld-option.yml
+    - 4933-fix-rax-clb-nodes.yaml
+    release_date: '2022-07-12'
+  4.8.5:
+    changes:
+      bugfixes:
+      - pacman - fixed name resolution of URL packages (https://github.com/ansible-collections/community.general/pull/4959).
+      - proxmox - fix error handling when getting VM by name when ``state=absent``
+        (https://github.com/ansible-collections/community.general/pull/4945).
+      - proxmox inventory plugin - fix crash when ``enabled=1`` is used in agent config
+        string (https://github.com/ansible-collections/community.general/pull/4910).
+      - proxmox_kvm - fix error handling when getting VM by name when ``state=absent``
+        (https://github.com/ansible-collections/community.general/pull/4945).
+      - slack - fix incorrect channel prefix ``#`` caused by incomplete pattern detection
+        by adding ``G0`` and ``GF`` as channel ID patterns (https://github.com/ansible-collections/community.general/pull/5019).
+      release_summary: Regular bugfix release.
+    fragments:
+    - 4.8.5.yml
+    - 4910-fix-for-agent-enabled.yml
+    - 4945-fix-get_vm-int-parse-handling.yaml
+    - 4959-pacman-fix-url-packages-name.yaml
+    - 5019-slack-support-more-groups.yml
+    release_date: '2022-08-01'
+  4.8.6:
+    changes:
+      bugfixes:
+      - apache2_mod_proxy - avoid crash when reporting inability to parse balancer_member_page
+        HTML caused by using an undefined variable in the error message (https://github.com/ansible-collections/community.general/pull/5111).
+      - dnsimple_info - correctly report missing library as ``requests`` and not ``another_library``
+        (https://github.com/ansible-collections/community.general/pull/5111).
+      - funcd connection plugin - fix signature of ``exec_command`` (https://github.com/ansible-collections/community.general/pull/5111).
+      - manageiq_alert_profiles - avoid crash when reporting unknown profile caused
+        by trying to return an undefined variable (https://github.com/ansible-collections/community.general/pull/5111).
+      - nsupdate - compatibility with NS records (https://github.com/ansible-collections/community.general/pull/5112).
+      - packet_ip_subnet - fix error reporting in case of invalid CIDR prefix lengths
+        (https://github.com/ansible-collections/community.general/pull/5111).
+      - pip_package_info - remove usage of global variable (https://github.com/ansible-collections/community.general/pull/5111).
+      minor_changes:
+      - Added MIT license as ``MIT-license.txt`` for ``tests/unit/plugins/modules/packaging/language/test_gem.py``
+        (https://github.com/ansible-collections/community.general/pull/5065, https://github.com/ansible-collections/community.general/pull/5072).
+      release_summary: Bugfix and maintenance release.
+    fragments:
+    - 4.8.6.yml
+    - 5111-fixes.yml
+    - 5112-fix-nsupdate-ns-entry.yaml
+    - licenses.yml
+    release_date: '2022-08-22'
+  4.8.7:
+    changes:
+      bugfixes:
+      - locale_gen - fix support for Ubuntu (https://github.com/ansible-collections/community.general/issues/5281).
+      - tss lookup plugin - adding support for updated Delinea library (https://github.com/DelineaXPM/python-tss-sdk/issues/9,
+        https://github.com/ansible-collections/community.general/pull/5151).
+      minor_changes:
+      - gitlab module util - minor refactor when checking for installed dependency
+        (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_branch - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_deploy_key - minor refactor when checking for installed dependency
+        (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_group - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_group_members - minor refactor when checking for installed dependency
+        (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_group_variable - minor refactor when checking for installed dependency
+        (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_hook - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_project - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_project_members - minor refactor when checking for installed dependency
+        (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_project_variable - minor refactor when checking for installed dependency
+        (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_protected_branch - minor refactor when checking for installed dependency
+        (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_runner - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+      - gitlab_user - minor refactor when checking for installed dependency (https://github.com/ansible-collections/community.general/pull/5259).
+      release_summary: Regular bugfix release.
+    fragments:
+    - 4.8.7.yml
+    - 5151-add-delinea-support-tss-lookup.yml
+    - 5259-gitlab-imports.yaml
+    - 5282-locale_gen.yaml
+    release_date: '2022-10-03'
+  4.8.8:
+    changes:
+      bugfixes:
+      - archive - avoid crash when ``lzma`` is not present and ``format`` is not ``xz``
+        (https://github.com/ansible-collections/community.general/pull/5393).
+      - opentelemetry callback plugin - support opentelemetry-api 1.13.0 that removed
+        support for ``_time_ns`` (https://github.com/ansible-collections/community.general/pull/5342).
+      - pfexec become plugin - remove superflous quotes preventing exe wrap from working
+        as expected (https://github.com/ansible-collections/community.general/issues/3671,
+        https://github.com/ansible-collections/community.general/pull/3889).
+      - pkgng - fix case when ``pkg`` fails when trying to upgrade all packages (https://github.com/ansible-collections/community.general/issues/5363).
+      - redhat_subscription - make module idempotent when ``pool_ids`` are used (https://github.com/ansible-collections/community.general/issues/5313).
+      - xenserver_facts - fix broken ``AnsibleModule`` call that prevented the module
+        from working at all (https://github.com/ansible-collections/community.general/pull/5383).
+      release_summary: Regular bugfix release.
+    fragments:
+    - 3671-illumos-pfexec.yml
+    - 4.8.8.yml
+    - 5313-fix-redhat_subscription-idempotency-pool_ids.yml
+    - 5342-opentelemetry_bug_fix_opentelemetry-api-1.13.yml
+    - 5369-pkgng-fix-update-all.yaml
+    - 5383-xenserver_facts.yml
+    - 5393-archive.yml
+    release_date: '2022-10-24'
+  4.8.9:
+    changes:
+      bugfixes:
+      - ldap_attrs - fix bug which caused a ``Bad search filter`` error. The error
+        was occuring when the ldap attribute value contained special characters such
+        as ``(`` or ``*`` (https://github.com/ansible-collections/community.general/issues/5434,
+        https://github.com/ansible-collections/community.general/pull/5435).
+      - ldap_attrs - fix ordering issue by ignoring the ``{x}`` prefix on attribute
+        values (https://github.com/ansible-collections/community.general/issues/977,
+        https://github.com/ansible-collections/community.general/pull/5385).
+      release_summary: 'Bugfix release.
+
+
+        Note that from now on, community.general 4.x.y only receives security fixes
+        and major bugfixes, but no longer regular bugfixes.'
+    fragments:
+    - 4.8.9.yml
+    - 5385-search_s-based-_is_value_present.yaml
+    - 5435-escape-ldap-param.yml
+    release_date: '2022-11-06'
--- a/galaxy.yml
+++ b/galaxy.yml
@@ -1,6 +1,6 @@
 namespace: community
 name: general
-version: 4.8.1
+version: 4.8.10
 readme: README.md
 authors:
  - Ansible (https://github.com/ansible)
--- a/plugins/become/pfexec.py
+++ b/plugins/become/pfexec.py
@@ -101,4 +101,4 @@ class BecomeModule(BecomeBase):

        flags = self.get_option('become_flags')
        noexe = not self.get_option('wrap_exe')
-        return '%s %s "%s"' % (exe, flags, self._build_success_command(cmd, shell, noexe=noexe))
+        return '%s %s %s' % (exe, flags, self._build_success_command(cmd, shell, noexe=noexe))
--- a/plugins/become/sudosu.py
+++ b/plugins/become/sudosu.py
@@ -8,9 +8,9 @@ DOCUMENTATION = """
    name: sudosu
    short_description: Run tasks using sudo su -
    description:
-        - This become plugins allows your remote/login user to execute commands as another user via the C(sudo) and C(su) utilities combined.
+      - This become plugin allows your remote/login user to execute commands as another user via the C(sudo) and C(su) utilities combined.
    author:
-    - Dag Wieers (@dagwieers)
+      - Dag Wieers (@dagwieers)
    version_added: 2.4.0
    options:
        become_user:
--- a/plugins/callback/dense.py
+++ b/plugins/callback/dense.py
@@ -232,13 +232,13 @@ class CallbackModule(CallbackModule_default):
        # Remove non-essential attributes
        for attr in self.removed_attributes:
            if attr in result:
-                del(result[attr])
+                del result[attr]

        # Remove empty attributes (list, dict, str)
        for attr in result.copy():
            if isinstance(result[attr], (MutableSequence, MutableMapping, binary_type, text_type)):
                if not result[attr]:
-                    del(result[attr])
+                    del result[attr]

    def _handle_exceptions(self, result):
        if 'exception' in result:
--- a/plugins/callback/log_plays.py
+++ b/plugins/callback/log_plays.py
@@ -12,7 +12,7 @@ DOCUMENTATION = '''
    type: notification
    short_description: write playbook output to log file
    description:
-      - This callback writes playbook output to a file per host in the `/var/log/ansible/hosts` directory
+      - This callback writes playbook output to a file per host in the C(/var/log/ansible/hosts) directory
    requirements:
     - Whitelist in configuration
     - A writeable /var/log/ansible/hosts directory by the user executing Ansible on the controller
--- a/plugins/callback/loganalytics.py
+++ b/plugins/callback/loganalytics.py
@@ -6,7 +6,7 @@ __metaclass__ = type

 DOCUMENTATION = '''
    name: loganalytics
-    type: aggregate
+    type: notification
    short_description: Posts task results to Azure Log Analytics
    author: "Cyrus Li (@zhcli) <cyrus1006@gmail.com>"
    description:
@@ -153,7 +153,7 @@ class AzureLogAnalyticsSource(object):

 class CallbackModule(CallbackBase):
    CALLBACK_VERSION = 2.0
-    CALLBACK_TYPE = 'aggregate'
+    CALLBACK_TYPE = 'notification'
    CALLBACK_NAME = 'loganalytics'
    CALLBACK_NEEDS_WHITELIST = True

--- a/plugins/callback/logdna.py
+++ b/plugins/callback/logdna.py
@@ -8,7 +8,7 @@ __metaclass__ = type
 DOCUMENTATION = '''
    author: Unknown (!UNKNOWN)
    name: logdna
-    type: aggregate
+    type: notification
    short_description: Sends playbook logs to LogDNA
    description:
      - This callback will report logs from playbook actions, tasks, and events to LogDNA (https://app.logdna.com)
@@ -110,7 +110,7 @@ def isJSONable(obj):
 class CallbackModule(CallbackBase):

    CALLBACK_VERSION = 0.1
-    CALLBACK_TYPE = 'aggregate'
+    CALLBACK_TYPE = 'notification'
    CALLBACK_NAME = 'community.general.logdna'
    CALLBACK_NEEDS_WHITELIST = True

--- a/plugins/callback/logstash.py
+++ b/plugins/callback/logstash.py
@@ -112,7 +112,7 @@ from ansible.plugins.callback import CallbackBase
 class CallbackModule(CallbackBase):

    CALLBACK_VERSION = 2.0
-    CALLBACK_TYPE = 'aggregate'
+    CALLBACK_TYPE = 'notification'
    CALLBACK_NAME = 'community.general.logstash'
    CALLBACK_NEEDS_WHITELIST = True

--- a/plugins/callback/opentelemetry.py
+++ b/plugins/callback/opentelemetry.py
@@ -94,13 +94,32 @@ try:
    from opentelemetry.sdk.trace.export import (
        BatchSpanProcessor
    )
-    from opentelemetry.util._time import _time_ns
+
+    # Support for opentelemetry-api <= 1.12
+    try:
+        from opentelemetry.util._time import _time_ns
+    except ImportError as imp_exc:
+        OTEL_LIBRARY_TIME_NS_ERROR = imp_exc
+    else:
+        OTEL_LIBRARY_TIME_NS_ERROR = None
+
 except ImportError as imp_exc:
    OTEL_LIBRARY_IMPORT_ERROR = imp_exc
+    OTEL_LIBRARY_TIME_NS_ERROR = imp_exc
 else:
    OTEL_LIBRARY_IMPORT_ERROR = None


+if sys.version_info >= (3, 7):
+    time_ns = time.time_ns
+elif not OTEL_LIBRARY_TIME_NS_ERROR:
+    time_ns = _time_ns
+else:
+    def time_ns():
+        # Support versions older than 3.7 with opentelemetry-api > 1.12
+        return int(time.time() * 1e9)
+
+
 class TaskData:
    """
    Data about an individual task.
@@ -112,10 +131,7 @@ class TaskData:
        self.path = path
        self.play = play
        self.host_data = OrderedDict()
-        if sys.version_info >= (3, 7):
-            self.start = time.time_ns()
-        else:
-            self.start = _time_ns()
+        self.start = time_ns()
        self.action = action
        self.args = args

@@ -140,10 +156,7 @@ class HostData:
        self.name = name
        self.status = status
        self.result = result
-        if sys.version_info >= (3, 7):
-            self.finish = time.time_ns()
-        else:
-            self.finish = _time_ns()
+        self.finish = time_ns()


 class OpenTelemetrySource(object):
--- a/plugins/callback/selective.py
+++ b/plugins/callback/selective.py
@@ -14,9 +14,9 @@ DOCUMENTATION = '''
      - set as main display callback
    short_description: only print certain tasks
    description:
-      - This callback only prints tasks that have been tagged with `print_action` or that have failed.
+      - This callback only prints tasks that have been tagged with C(print_action) or that have failed.
        This allows operators to focus on the tasks that provide value only.
-      - Tasks that are not printed are placed with a '.'.
+      - Tasks that are not printed are placed with a C(.).
      - If you increase verbosity all tasks are printed.
    options:
      nocolor:
--- a/plugins/callback/splunk.py
+++ b/plugins/callback/splunk.py
@@ -19,7 +19,7 @@ __metaclass__ = type

 DOCUMENTATION = '''
    name: splunk
-    type: aggregate
+    type: notification
    short_description: Sends task result events to Splunk HTTP Event Collector
    author: "Stuart Hirst (!UNKNOWN) <support@convergingdata.com>"
    description:
@@ -176,7 +176,7 @@ class SplunkHTTPCollectorSource(object):

 class CallbackModule(CallbackBase):
    CALLBACK_VERSION = 2.0
-    CALLBACK_TYPE = 'aggregate'
+    CALLBACK_TYPE = 'notification'
    CALLBACK_NAME = 'community.general.splunk'
    CALLBACK_NEEDS_WHITELIST = True

--- a/plugins/callback/sumologic.py
+++ b/plugins/callback/sumologic.py
@@ -19,7 +19,7 @@ __metaclass__ = type

 DOCUMENTATION = '''
 name: sumologic
-type: aggregate
+type: notification
 short_description: Sends task result events to Sumologic
 author: "Ryan Currah (@ryancurrah)"
 description:
@@ -122,7 +122,7 @@ class SumologicHTTPCollectorSource(object):

 class CallbackModule(CallbackBase):
    CALLBACK_VERSION = 2.0
-    CALLBACK_TYPE = 'aggregate'
+    CALLBACK_TYPE = 'notification'
    CALLBACK_NAME = 'community.general.sumologic'
    CALLBACK_NEEDS_WHITELIST = True

--- a/plugins/callback/syslog_json.py
+++ b/plugins/callback/syslog_json.py
@@ -70,7 +70,7 @@ class CallbackModule(CallbackBase):
    """

    CALLBACK_VERSION = 2.0
-    CALLBACK_TYPE = 'aggregate'
+    CALLBACK_TYPE = 'notification'
    CALLBACK_NAME = 'community.general.syslog_json'
    CALLBACK_NEEDS_WHITELIST = True

--- a/plugins/connection/funcd.py
+++ b/plugins/connection/funcd.py
@@ -63,7 +63,7 @@ class Connection(ConnectionBase):
        self.client = fc.Client(self.host)
        return self

-    def exec_command(self, cmd, become_user=None, sudoable=False, executable='/bin/sh', in_data=None):
+    def exec_command(self, cmd, in_data=None, sudoable=True):
        """ run a command on the remote minion """

        if in_data:
--- a/plugins/connection/lxd.py
+++ b/plugins/connection/lxd.py
@@ -18,6 +18,7 @@ DOCUMENTATION = '''
            - Container identifier.
        default: inventory_hostname
        vars:
+            - name: inventory_hostname
            - name: ansible_host
            - name: ansible_lxd_host
      executable:
@@ -61,7 +62,6 @@ class Connection(ConnectionBase):
    def __init__(self, play_context, new_stdin, *args, **kwargs):
        super(Connection, self).__init__(play_context, new_stdin, *args, **kwargs)

-        self._host = self._play_context.remote_addr
        try:
            self._lxc_cmd = get_bin_path("lxc")
        except ValueError:
@@ -75,14 +75,14 @@ class Connection(ConnectionBase):
        super(Connection, self)._connect()

        if not self._connected:
-            self._display.vvv(u"ESTABLISH LXD CONNECTION FOR USER: root", host=self._host)
+            self._display.vvv(u"ESTABLISH LXD CONNECTION FOR USER: root", host=self.get_option('remote_addr'))
            self._connected = True

    def exec_command(self, cmd, in_data=None, sudoable=True):
        """ execute a command on the lxd host """
        super(Connection, self).exec_command(cmd, in_data=in_data, sudoable=sudoable)

-        self._display.vvv(u"EXEC {0}".format(cmd), host=self._host)
+        self._display.vvv(u"EXEC {0}".format(cmd), host=self.get_option('remote_addr'))

        local_cmd = [self._lxc_cmd]
        if self.get_option("project"):
@@ -104,10 +104,10 @@ class Connection(ConnectionBase):
        stderr = to_text(stderr)

        if stderr == "error: Container is not running.\n":
-            raise AnsibleConnectionFailure("container not running: %s" % self._host)
+            raise AnsibleConnectionFailure("container not running: %s" % self.get_option('remote_addr'))

        if stderr == "error: not found\n":
-            raise AnsibleConnectionFailure("container not found: %s" % self._host)
+            raise AnsibleConnectionFailure("container not found: %s" % self.get_option('remote_addr'))

        return process.returncode, stdout, stderr

@@ -115,7 +115,7 @@ class Connection(ConnectionBase):
        """ put a file from local to lxd """
        super(Connection, self).put_file(in_path, out_path)

-        self._display.vvv(u"PUT {0} TO {1}".format(in_path, out_path), host=self._host)
+        self._display.vvv(u"PUT {0} TO {1}".format(in_path, out_path), host=self.get_option('remote_addr'))

        if not os.path.isfile(to_bytes(in_path, errors='surrogate_or_strict')):
            raise AnsibleFileNotFound("input path is not a file: %s" % in_path)
@@ -138,7 +138,7 @@ class Connection(ConnectionBase):
        """ fetch a file from lxd to local """
        super(Connection, self).fetch_file(in_path, out_path)

-        self._display.vvv(u"FETCH {0} TO {1}".format(in_path, out_path), host=self._host)
+        self._display.vvv(u"FETCH {0} TO {1}".format(in_path, out_path), host=self.get_option('remote_addr'))

        local_cmd = [self._lxc_cmd]
        if self.get_option("project"):
--- a/plugins/doc_fragments/influxdb.py
+++ b/plugins/doc_fragments/influxdb.py
@@ -42,6 +42,7 @@ options:
    - The path on which InfluxDB server is accessible
    - Only available when using python-influxdb >= 5.1.0
    type: str
+    default: ''
    version_added: '0.2.0'
  validate_certs:
    description:
@@ -79,4 +80,5 @@ options:
    description:
    - HTTP(S) proxy to use for Requests to connect to InfluxDB server.
    type: dict
+    default: {}
 '''
--- a/plugins/doc_fragments/ldap.py
+++ b/plugins/doc_fragments/ldap.py
@@ -22,6 +22,7 @@ options:
    description:
      - The password to use with I(bind_dn).
    type: str
+    default: ''
  dn:
    required: true
    description:
@@ -58,7 +59,7 @@ options:
  sasl_class:
    description:
      - The class to use for SASL authentication.
-      - possible choices are C(external), C(gssapi).
+      - Possible choices are C(external), C(gssapi).
    type: str
    choices: ['external', 'gssapi']
    default: external
--- a/plugins/doc_fragments/lxca_common.py
+++ b/plugins/doc_fragments/lxca_common.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-

 # Copyright (C) 2017 Lenovo, Inc.
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/doc_fragments/utm.py
+++ b/plugins/doc_fragments/utm.py
@@ -16,6 +16,7 @@ options:
          - Is needed for some modules
        type: dict
        required: false
+        default: {}
    utm_host:
        description:
          - The REST Endpoint of the Sophos UTM.
--- a/plugins/filter/jc.py
+++ b/plugins/filter/jc.py
@@ -51,10 +51,16 @@ DOCUMENTATION = '''
      type: boolean
      default: false
  requirements:
-    - jc (https://github.com/kellyjonbrazil/jc)
+    - jc installed as a Python library (U(https://pypi.org/project/jc/))
 '''

 EXAMPLES = '''
+- name: Install the prereqs of the jc filter (jc Python package) on the Ansible controller
+  delegate_to: localhost
+  ansible.builtin.pip:
+    name: jc
+    state: present
+
 - name: Run command
  ansible.builtin.command: uname -a
  register: result
@@ -107,15 +113,19 @@ def jc(data, parser, quiet=True, raw=False):
        dictionary or list of dictionaries

    Example:
-
        - name: run date command
          hosts: ubuntu
          tasks:
-          - shell: date
+          - name: install the prereqs of the jc filter (jc Python package) on the Ansible controller
+            delegate_to: localhost
+            ansible.builtin.pip:
+              name: jc
+              state: present
+          - ansible.builtin.shell: date
            register: result
-          - set_fact:
+          - ansible.builtin.set_fact:
              myvar: "{{ result.stdout | community.general.jc('date') }}"
-          - debug:
+          - ansible.builtin.debug:
              msg: "{{ myvar }}"

        produces:
@@ -137,7 +147,7 @@ def jc(data, parser, quiet=True, raw=False):
    """

    if not HAS_LIB:
-        raise AnsibleError('You need to install "jc" prior to running jc filter')
+        raise AnsibleError('You need to install "jc" as a Python library on the Ansible controller prior to running jc filter')

    try:
        jc_parser = importlib.import_module('jc.parsers.' + parser)
--- a/plugins/inventory/proxmox.py
+++ b/plugins/inventory/proxmox.py
@@ -400,12 +400,20 @@ class InventoryModule(BaseInventoryPlugin, Constructable, Cacheable):
                        properties[parsed_key] = [tag.strip() for tag in stripped_value.split(",")]

                # The first field in the agent string tells you whether the agent is enabled
-                # the rest of the comma separated string is extra config for the agent
-                if config == 'agent' and int(value.split(',')[0]):
-                    agent_iface_value = self._get_agent_network_interfaces(node, vmid, vmtype)
-                    if agent_iface_value:
-                        agent_iface_key = self.to_safe('%s%s' % (key, "_interfaces"))
-                        properties[agent_iface_key] = agent_iface_value
+                # the rest of the comma separated string is extra config for the agent.
+                # In some (newer versions of proxmox) instances it can be 'enabled=1'.
+                if config == 'agent':
+                    agent_enabled = 0
+                    try:
+                        agent_enabled = int(value.split(',')[0])
+                    except ValueError:
+                        if value.split(',')[0] == "enabled=1":
+                            agent_enabled = 1
+                    if agent_enabled:
+                        agent_iface_value = self._get_agent_network_interfaces(node, vmid, vmtype)
+                        if agent_iface_value:
+                            agent_iface_key = self.to_safe('%s%s' % (key, "_interfaces"))
+                            properties[agent_iface_key] = agent_iface_value

                if config == 'lxc':
                    out_val = {}
--- a/plugins/lookup/chef_databag.py
+++ b/plugins/lookup/chef_databag.py
@@ -16,7 +16,7 @@ DOCUMENTATION = '''
         The lookup order mirrors the one from Chef, all folders in the base path are walked back looking for the following configuration
         file in order : .chef/knife.rb, ~/.chef/knife.rb, /etc/chef/client.rb"
    requirements:
-        - "pychef (python library https://pychef.readthedocs.io `pip install pychef`)"
+        - "pychef (L(Python library, https://pychef.readthedocs.io), C(pip install pychef))"
    options:
        name:
          description:
--- a/plugins/lookup/dsv.py
+++ b/plugins/lookup/dsv.py
@@ -122,6 +122,7 @@ class LookupModule(LookupBase):
                "tenant": self.get_option("tenant"),
                "client_id": self.get_option("client_id"),
                "client_secret": self.get_option("client_secret"),
+                "tld": self.get_option("tld"),
                "url_template": self.get_option("url_template"),
            }
        )
--- a/plugins/lookup/keyring.py
+++ b/plugins/lookup/keyring.py
@@ -18,7 +18,7 @@ DOCUMENTATION = '''
 '''

 EXAMPLES = """
- name : output secrets to screen (BAD IDEA)
+- name: output secrets to screen (BAD IDEA)
  ansible.builtin.debug:
    msg: "Password: {{item}}"
  with_community.general.keyring:
--- a/plugins/lookup/tss.py
+++ b/plugins/lookup/tss.py
@@ -170,19 +170,29 @@ try:

    HAS_TSS_SDK = True
 except ImportError:
-    SecretServer = None
-    SecretServerError = None
-    HAS_TSS_SDK = False
+    try:
+        from delinea.secrets.server import SecretServer, SecretServerError
+
+        HAS_TSS_SDK = True
+    except ImportError:
+        SecretServer = None
+        SecretServerError = None
+        HAS_TSS_SDK = False

 try:
    from thycotic.secrets.server import PasswordGrantAuthorizer, DomainPasswordGrantAuthorizer, AccessTokenAuthorizer

    HAS_TSS_AUTHORIZER = True
 except ImportError:
-    PasswordGrantAuthorizer = None
-    DomainPasswordGrantAuthorizer = None
-    AccessTokenAuthorizer = None
-    HAS_TSS_AUTHORIZER = False
+    try:
+        from delinea.secrets.server import PasswordGrantAuthorizer, DomainPasswordGrantAuthorizer, AccessTokenAuthorizer
+
+        HAS_TSS_AUTHORIZER = True
+    except ImportError:
+        PasswordGrantAuthorizer = None
+        DomainPasswordGrantAuthorizer = None
+        AccessTokenAuthorizer = None
+        HAS_TSS_AUTHORIZER = False


 display = Display()
--- a/plugins/module_utils/alicloud_ecs.py
+++ b/plugins/module_utils/alicloud_ecs.py
@@ -7,7 +7,7 @@
 #
 # Copyright (c) 2017-present Alibaba Group Holding Limited. He Guimin <heguimin36@163.com>
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/cmd_runner.py
+++ b/plugins/module_utils/cmd_runner.py
@@ -191,7 +191,7 @@ class CmdRunner(object):
            environ_update = {}
        self.environ_update = environ_update

-        self.command[0] = module.get_bin_path(command[0], opt_dirs=path_prefix, required=True)
+        self.command[0] = module.get_bin_path(self.command[0], opt_dirs=path_prefix, required=True)

        for mod_param_name, spec in iteritems(module.argument_spec):
            if mod_param_name not in self.arg_formats:
--- a/plugins/module_utils/database.py
+++ b/plugins/module_utils/database.py
@@ -7,7 +7,7 @@
 #
 # Copyright (c) 2014, Toshio Kuratomi <tkuratomi@ansible.com>
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/gandi_livedns_api.py
+++ b/plugins/module_utils/gandi_livedns_api.py
@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 # Copyright: (c) 2019 Gregory Thiemonge <gregory.thiemonge@gmail.com>
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/module_utils/gitlab.py
+++ b/plugins/module_utils/gitlab.py
@@ -13,10 +13,9 @@ from ansible.module_utils.common.text.converters import to_native
 from ansible_collections.community.general.plugins.module_utils.version import LooseVersion

 try:
-    from urllib import quote_plus  # Python 2.X
    from urlparse import urljoin
 except ImportError:
-    from urllib.parse import quote_plus, urljoin  # Python 3+
+    from urllib.parse import urljoin  # Python 3+

 import traceback

@@ -26,6 +25,7 @@ try:
    import requests
    HAS_GITLAB_PACKAGE = True
 except Exception:
+    gitlab = None
    GITLAB_IMP_ERR = traceback.format_exc()
    HAS_GITLAB_PACKAGE = False

@@ -63,6 +63,14 @@ def find_group(gitlab_instance, identifier):
    return project


+def ensure_gitlab_package(module):
+    if not HAS_GITLAB_PACKAGE:
+        module.fail_json(
+            msg=missing_required_lib("python-gitlab", url='https://python-gitlab.readthedocs.io/en/stable/'),
+            exception=GITLAB_IMP_ERR
+        )
+
+
 def gitlab_authentication(module):
    gitlab_url = module.params['api_url']
    validate_certs = module.params['validate_certs']
@@ -72,8 +80,7 @@ def gitlab_authentication(module):
    gitlab_oauth_token = module.params['api_oauth_token']
    gitlab_job_token = module.params['api_job_token']

-    if not HAS_GITLAB_PACKAGE:
-        module.fail_json(msg=missing_required_lib("python-gitlab"), exception=GITLAB_IMP_ERR)
+    ensure_gitlab_package(module)

    try:
        # python-gitlab library remove support for username/password authentication since 1.13.0
--- a/plugins/module_utils/heroku.py
+++ b/plugins/module_utils/heroku.py
@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 # Copyright: (c) 2018, Ansible Project
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/module_utils/hwc_utils.py
+++ b/plugins/module_utils/hwc_utils.py
@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 # Copyright (c), Google Inc, 2017
-# Simplified BSD License (see licenses/simplified_bsd.txt or
+# Simplified BSD License (see simplified_bsd.txt or
 # https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
--- a/plugins/module_utils/ibm_sa_utils.py
+++ b/plugins/module_utils/ibm_sa_utils.py
@@ -2,7 +2,7 @@
 # Copyright (C) 2018 IBM CORPORATION
 # Author(s): Tzur Eliyahu <tzure@il.ibm.com>
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/module_utils/ilo_redfish_utils.py
+++ b/plugins/module_utils/ilo_redfish_utils.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-

 # Copyright (c) 2021-2022 Hewlett Packard Enterprise, Inc. All rights reserved.
-# GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
@@ -91,7 +91,7 @@ class iLORedfishUtils(RedfishUtils):
        data = response['data']

        ntp_list = data[setkey]
-        if(len(ntp_list) == 2):
+        if len(ntp_list) == 2:
            ntp_list.pop(0)

        ntp_list.append(mgr_attributes['mgr_attr_value'])
--- a/plugins/module_utils/influxdb.py
+++ b/plugins/module_utils/influxdb.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-

 # Copyright: (c) 2017, Ansible Project
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/module_utils/ipa.py
+++ b/plugins/module_utils/ipa.py
@@ -7,7 +7,7 @@
 #
 # Copyright (c) 2016 Thomas Krahn (@Nosmoht)
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/known_hosts.py
+++ b/plugins/module_utils/known_hosts.py
@@ -7,7 +7,7 @@
 #
 # Copyright (c), Michael DeHaan <michael.dehaan@gmail.com>, 2012-2013
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/linode.py
+++ b/plugins/module_utils/linode.py
@@ -7,7 +7,7 @@
 #
 # Copyright (c), Luke Murphy @decentral1se
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/lxd.py
+++ b/plugins/module_utils/lxd.py
@@ -8,7 +8,7 @@
 # still belong to the author of the module, and may assign their own license
 # to the complete work.
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/manageiq.py
+++ b/plugins/module_utils/manageiq.py
@@ -8,7 +8,7 @@
 # still belong to the author of the module, and may assign their own license
 # to the complete work.
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/memset.py
+++ b/plugins/module_utils/memset.py
@@ -7,7 +7,7 @@
 #
 # Copyright (c) 2018, Simon Weald <ansible@simonweald.com>
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
@@ -78,7 +78,7 @@ def memset_api_call(api_key, api_method, payload=None):
    if msg is None:
        msg = response.json()

-    return(has_failed, msg, response)
+    return has_failed, msg, response


 def check_zone_domain(data, domain):
@@ -92,7 +92,7 @@ def check_zone_domain(data, domain):
            if zone_domain['domain'] == domain:
                exists = True

-    return(exists)
+    return exists


 def check_zone(data, name):
@@ -109,7 +109,7 @@ def check_zone(data, name):
        if counter == 1:
            exists = True

-    return(exists, counter)
+    return exists, counter


 def get_zone_id(zone_name, current_zones):
@@ -135,4 +135,4 @@ def get_zone_id(zone_name, current_zones):
        zone_id = None
        msg = 'Zone ID could not be returned as duplicate zone names were detected'

-    return(zone_exists, msg, counter, zone_id)
+    return zone_exists, msg, counter, zone_id
--- a/plugins/module_utils/mh/base.py
+++ b/plugins/module_utils/mh/base.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # (c) 2020, Alexei Znamensky <russoz@gmail.com>
 # Copyright: (c) 2020, Ansible Project
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/module_utils/mh/deco.py
+++ b/plugins/module_utils/mh/deco.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # (c) 2020, Alexei Znamensky <russoz@gmail.com>
 # Copyright: (c) 2020, Ansible Project
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/module_utils/mh/exceptions.py
+++ b/plugins/module_utils/mh/exceptions.py
@@ -1,22 +1,18 @@
 # -*- coding: utf-8 -*-
 # (c) 2020, Alexei Znamensky <russoz@gmail.com>
 # Copyright: (c) 2020, Ansible Project
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type

+from ansible.module_utils.common.text.converters import to_native
+

 class ModuleHelperException(Exception):
-    @staticmethod
-    def _get_remove(key, kwargs):
-        if key in kwargs:
-            result = kwargs[key]
-            del kwargs[key]
-            return result
-        return None
-
-    def __init__(self, *args, **kwargs):
-        self.msg = self._get_remove('msg', kwargs) or "Module failed with exception: {0}".format(self)
-        self.update_output = self._get_remove('update_output', kwargs) or {}
+    def __init__(self, msg, update_output=None, *args, **kwargs):
+        self.msg = to_native(msg or "Module failed with exception: {0}".format(self))
+        if update_output is None:
+            update_output = {}
+        self.update_output = update_output
        super(ModuleHelperException, self).__init__(*args)
--- a/plugins/module_utils/mh/mixins/cmd.py
+++ b/plugins/module_utils/mh/mixins/cmd.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # (c) 2020, Alexei Znamensky <russoz@gmail.com>
 # Copyright: (c) 2020, Ansible Project
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/module_utils/mh/mixins/deprecate_attrs.py
+++ b/plugins/module_utils/mh/mixins/deprecate_attrs.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # (c) 2020, Alexei Znamensky <russoz@gmail.com>
 # Copyright: (c) 2020, Ansible Project
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/module_utils/mh/mixins/deps.py
+++ b/plugins/module_utils/mh/mixins/deps.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # (c) 2020, Alexei Znamensky <russoz@gmail.com>
 # Copyright: (c) 2020, Ansible Project
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/module_utils/mh/mixins/state.py
+++ b/plugins/module_utils/mh/mixins/state.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # (c) 2020, Alexei Znamensky <russoz@gmail.com>
 # Copyright: (c) 2020, Ansible Project
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/module_utils/mh/mixins/vars.py
+++ b/plugins/module_utils/mh/mixins/vars.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # (c) 2020, Alexei Znamensky <russoz@gmail.com>
 # Copyright: (c) 2020, Ansible Project
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/module_utils/mh/module_helper.py
+++ b/plugins/module_utils/mh/module_helper.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # (c) 2020, Alexei Znamensky <russoz@gmail.com>
 # Copyright: (c) 2020, Ansible Project
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
@@ -70,7 +70,7 @@ class ModuleHelper(DeprecateAttrsMixin, VarsMixin, DependencyMixin, ModuleHelper
            vars_diff = self.vars.diff() or {}
            result['diff'] = dict_merge(dict(diff), vars_diff)

-        for varname in result:
+        for varname in list(result):
            if varname in self._output_conflict_list:
                result["_" + varname] = result[varname]
                del result[varname]
--- a/plugins/module_utils/module_helper.py
+++ b/plugins/module_utils/module_helper.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 # (c) 2020, Alexei Znamensky <russoz@gmail.com>
 # Copyright: (c) 2020, Ansible Project
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
--- a/plugins/module_utils/oneandone.py
+++ b/plugins/module_utils/oneandone.py
@@ -5,7 +5,7 @@
 # still belong to the author of the module, and may assign their own license
 # to the complete work.
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/onepassword.py
+++ b/plugins/module_utils/onepassword.py
@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/oneview.py
+++ b/plugins/module_utils/oneview.py
@@ -7,7 +7,7 @@
 #
 # Copyright (2016-2017) Hewlett Packard Enterprise Development LP
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/online.py
+++ b/plugins/module_utils/online.py
@@ -1,5 +1,5 @@
 # -*- coding: utf-8 -*-
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/opennebula.py
+++ b/plugins/module_utils/opennebula.py
@@ -2,7 +2,7 @@
 #
 # Copyright 2018 www.privaz.io Valletech AB
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/pure.py
+++ b/plugins/module_utils/pure.py
@@ -7,7 +7,7 @@
 # to the complete work.
 #
 # Copyright (c), Simon Dodsley <simon@purestorage.com>,2017
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/rax.py
+++ b/plugins/module_utils/rax.py
@@ -7,7 +7,7 @@
 #
 # Copyright (c), Michael DeHaan <michael.dehaan@gmail.com>, 2012-2013
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
@@ -122,8 +122,7 @@ def rax_find_image(module, rax_module, image, exit=True):
    except ValueError:
        try:
            image = cs.images.find(human_id=image)
-        except(cs.exceptions.NotFound,
-               cs.exceptions.NoUniqueMatch):
+        except (cs.exceptions.NotFound, cs.exceptions.NoUniqueMatch):
            try:
                image = cs.images.find(name=image)
            except (cs.exceptions.NotFound,
--- a/plugins/module_utils/redfish_utils.py
+++ b/plugins/module_utils/redfish_utils.py
@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 # Copyright (c) 2017-2018 Dell EMC Inc.
-# GNU General Public License v3.0+ (see LICENSE or https://www.gnu.org/licenses/gpl-3.0.txt)
+# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

 from __future__ import absolute_import, division, print_function
 __metaclass__ = type
@@ -1883,14 +1883,13 @@ class RedfishUtils(object):
                        for property in properties:
                            if property in data:
                                chassis_power_result[property] = data[property]
-                else:
-                    return {'ret': False, 'msg': 'Key PowerControl not found.'}
                chassis_power_results.append(chassis_power_result)
-            else:
-                return {'ret': False, 'msg': 'Key Power not found.'}

-        result['entries'] = chassis_power_results
-        return result
+        if len(chassis_power_results) > 0:
+            result['entries'] = chassis_power_results
+            return result
+        else:
+            return {'ret': False, 'msg': 'Power information not found.'}

    def get_chassis_thermals(self):
        result = {}
@@ -2056,7 +2055,7 @@ class RedfishUtils(object):
            if property in data:
                nic[property] = data[property]
        result['entries'] = nic
-        return(result)
+        return result

    def get_nic_inventory(self, resource_uri):
        result = {}
--- a/plugins/module_utils/redhat.py
+++ b/plugins/module_utils/redhat.py
@@ -7,7 +7,7 @@
 #
 # Copyright (c), James Laska
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/redis.py
+++ b/plugins/module_utils/redis.py
@@ -15,6 +15,7 @@ try:
    from redis import Redis
    from redis import __version__ as redis_version
    HAS_REDIS_PACKAGE = True
+    REDIS_IMP_ERR = None
 except ImportError:
    REDIS_IMP_ERR = traceback.format_exc()
    HAS_REDIS_PACKAGE = False
@@ -22,6 +23,7 @@ except ImportError:
 try:
    import certifi
    HAS_CERTIFI_PACKAGE = True
+    CERTIFI_IMPORT_ERROR = None
 except ImportError:
    CERTIFI_IMPORT_ERROR = traceback.format_exc()
    HAS_CERTIFI_PACKAGE = False
@@ -37,7 +39,7 @@ def fail_imports(module, needs_certifi=True):
        errors.append(missing_required_lib('certifi'))
        traceback.append(CERTIFI_IMPORT_ERROR)
    if errors:
-        module.fail_json(errors=errors, traceback='\n'.join(traceback))
+        module.fail_json(msg='\n'.join(errors), traceback='\n'.join(traceback))


 def redis_auth_argument_spec(tls_default=True):
--- a/plugins/module_utils/remote_management/lxca/common.py
+++ b/plugins/module_utils/remote_management/lxca/common.py
@@ -6,7 +6,7 @@
 # own license to the complete work.
 #
 # Copyright (C) 2017 Lenovo, Inc.
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
 #
 # Contains LXCA common class
 # Lenovo xClarity Administrator (LXCA)
--- a/plugins/module_utils/saslprep.py
+++ b/plugins/module_utils/saslprep.py
@@ -8,7 +8,7 @@

 # Copyright: (c) 2020, Andrew Klychkov (@Andersson007) <aaklychkov@mail.ru>
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/source_control/bitbucket.py
+++ b/plugins/module_utils/source_control/bitbucket.py
@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-

-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/storage/emc/emc_vnx.py
+++ b/plugins/module_utils/storage/emc/emc_vnx.py
@@ -7,7 +7,7 @@
 #
 # (c) 2018 Luca 'remix_tj' Lorenzetto
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/storage/hpe3par/hpe3par.py
+++ b/plugins/module_utils/storage/hpe3par/hpe3par.py
@@ -1,6 +1,6 @@
 # -*- coding: utf-8 -*-
 # Copyright: (c) 2018, Hewlett Packard Enterprise Development LP
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/univention_umc.py
+++ b/plugins/module_utils/univention_umc.py
@@ -9,7 +9,7 @@
 # Copyright (c) 2016, Adfinis SyGroup AG
 # Tobias Rueetschi <tobias.ruetschi@adfinis-sygroup.ch>
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/utm_utils.py
+++ b/plugins/module_utils/utm_utils.py
@@ -7,7 +7,7 @@
 #
 # Copyright: (c) 2018, Johannes Brunswicker <johannes.brunswicker@gmail.com>
 #
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/module_utils/vexata.py
+++ b/plugins/module_utils/vexata.py
@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 #
 # Copyright: (c) 2019, Sandeep Kasargod <sandeep@vexata.com>
-# Simplified BSD License (see licenses/simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)
+# Simplified BSD License (see simplified_bsd.txt or https://opensource.org/licenses/BSD-2-Clause)

 from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
--- a/plugins/modules/cloud/alicloud/ali_instance.py
+++ b/plugins/modules/cloud/alicloud/ali_instance.py
@@ -45,12 +45,12 @@ options:
      type: str
    image_id:
      description:
-        - Image ID used to launch instances. Required when C(state=present) and creating new ECS instances.
+        - Image ID used to launch instances. Required when I(state=present) and creating new ECS instances.
      aliases: ['image']
      type: str
    instance_type:
      description:
-        - Instance type used to launch instances. Required when C(state=present) and creating new ECS instances.
+        - Instance type used to launch instances. Required when I(state=present) and creating new ECS instances.
      aliases: ['type']
      type: str
    security_groups:
@@ -89,7 +89,7 @@ options:
    max_bandwidth_out:
      description:
        - Maximum outgoing bandwidth to the public network, measured in Mbps (Megabits per second).
-          Required when C(allocate_public_ip=True). Ignored when C(allocate_public_ip=False).
+          Required when I(allocate_public_ip=true). Ignored when I(allocate_public_ip=false).
      default: 0
      type: int
    host_name:
@@ -153,7 +153,7 @@ options:
      type: str
    period:
      description:
-        - The charge duration of the instance, in month. Required when C(instance_charge_type=PrePaid).
+        - The charge duration of the instance, in months. Required when I(instance_charge_type=PrePaid).
        - The valid value are [1-9, 12, 24, 36].
      default: 1
      type: int
@@ -164,7 +164,7 @@ options:
      default: False
    auto_renew_period:
      description:
-        - The duration of the automatic renew the charge of the instance. Required when C(auto_renew=True).
+        - The duration of the automatic renew the charge of the instance. Required when I(auto_renew=true).
      choices: [1, 2, 3, 6, 12]
      type: int
    instance_ids:
@@ -216,31 +216,31 @@ options:
      version_added: '0.2.0'
    spot_strategy:
      description:
-         - The bidding mode of the pay-as-you-go instance. This parameter is valid when InstanceChargeType is set to PostPaid.
+        - The bidding mode of the pay-as-you-go instance. This parameter is valid when InstanceChargeType is set to PostPaid.
      choices: ['NoSpot', 'SpotWithPriceLimit', 'SpotAsPriceGo']
      default: 'NoSpot'
      type: str
      version_added: '0.2.0'
    period_unit:
      description:
-         - The duration unit that you will buy the resource. It is valid when C(instance_charge_type=PrePaid)
+        - The duration unit that you will buy the resource. It is valid when I(instance_charge_type=PrePaid).
      choices: ['Month', 'Week']
      default: 'Month'
      type: str
      version_added: '0.2.0'
    dry_run:
      description:
-         - Specifies whether to send a dry-run request.
-         - If I(dry_run=True), Only a dry-run request is sent and no instance is created. The system checks whether the
-           required parameters are set, and validates the request format, service permissions, and available ECS instances.
-           If the validation fails, the corresponding error code is returned. If the validation succeeds, the DryRunOperation error code is returned.
-         - If I(dry_run=False), A request is sent. If the validation succeeds, the instance is created.
+        - Specifies whether to send a dry-run request.
+        - If I(dry_run=true), Only a dry-run request is sent and no instance is created. The system checks whether the
+          required parameters are set, and validates the request format, service permissions, and available ECS instances.
+          If the validation fails, the corresponding error code is returned. If the validation succeeds, the DryRunOperation error code is returned.
+        - If I(dry_run=false), A request is sent. If the validation succeeds, the instance is created.
      default: False
      type: bool
      version_added: '0.2.0'
    include_data_disks:
      description:
-         - Whether to change instance disks charge type when changing instance charge type.
+        - Whether to change instance disks charge type when changing instance charge type.
      default: True
      type: bool
      version_added: '0.2.0'
--- a/plugins/modules/cloud/atomic/atomic_container.py
+++ b/plugins/modules/cloud/atomic/atomic_container.py
@@ -60,6 +60,7 @@ options:
            - The values specified here will be used at installation time as --set arguments for atomic install.
        type: list
        elements: str
+        default: []
 '''

 EXAMPLES = r'''
--- a/plugins/modules/cloud/dimensiondata/dimensiondata_vlan.py
+++ b/plugins/modules/cloud/dimensiondata/dimensiondata_vlan.py
@@ -44,6 +44,7 @@ options:
    description:
      - A description of the VLAN.
    type: str
+    default: ''
  network_domain:
    description:
      - The Id or name of the target network domain.
@@ -53,11 +54,13 @@ options:
    description:
        - The base address for the VLAN's IPv4 network (e.g. 192.168.1.0).
    type: str
+    default: ''
  private_ipv4_prefix_size:
    description:
        - The size of the IPv4 address space, e.g 24.
        - Required, if C(private_ipv4_base_address) is specified.
    type: int
+    default: 0
  state:
    description:
      - The desired state for the target VLAN.
--- a/plugins/modules/cloud/huawei/hwc_ecs_instance.py
+++ b/plugins/modules/cloud/huawei/hwc_ecs_instance.py
@@ -33,6 +33,7 @@ options:
        description:
            - The timeouts for each operations.
        type: dict
+        default: {}
        suboptions:
            create:
                description:
--- a/plugins/modules/cloud/huawei/hwc_evs_disk.py
+++ b/plugins/modules/cloud/huawei/hwc_evs_disk.py
@@ -33,6 +33,7 @@ options:
        description:
            - The timeouts for each operations.
        type: dict
+        default: {}
        suboptions:
            create:
                description:
--- a/plugins/modules/cloud/huawei/hwc_network_vpc.py
+++ b/plugins/modules/cloud/huawei/hwc_network_vpc.py
@@ -33,6 +33,7 @@ options:
        description:
            - The timeouts for each operations.
        type: dict
+        default: {}
        suboptions:
            create:
                description:
--- a/plugins/modules/cloud/huawei/hwc_vpc_eip.py
+++ b/plugins/modules/cloud/huawei/hwc_vpc_eip.py
@@ -33,6 +33,7 @@ options:
        description:
            - The timeouts for each operations.
        type: dict
+        default: {}
        suboptions:
            create:
                description:
--- a/plugins/modules/cloud/huawei/hwc_vpc_peering_connect.py
+++ b/plugins/modules/cloud/huawei/hwc_vpc_peering_connect.py
@@ -34,6 +34,7 @@ options:
        description:
            - The timeouts for each operations.
        type: dict
+        default: {}
        suboptions:
            create:
                description:
--- a/plugins/modules/cloud/huawei/hwc_vpc_port.py
+++ b/plugins/modules/cloud/huawei/hwc_vpc_port.py
@@ -33,6 +33,7 @@ options:
        description:
            - The timeouts for each operations.
        type: dict
+        default: {}
        suboptions:
            create:
                description:
--- a/plugins/modules/cloud/huawei/hwc_vpc_subnet.py
+++ b/plugins/modules/cloud/huawei/hwc_vpc_subnet.py
@@ -33,6 +33,7 @@ options:
        description:
            - The timeouts for each operations.
        type: dict
+        default: {}
        suboptions:
            create:
                description:
--- a/plugins/modules/cloud/linode/linode.py
+++ b/plugins/modules/cloud/linode/linode.py
@@ -36,6 +36,7 @@ options:
    description:
     - Add the instance to a Display Group in Linode Manager.
    type: str
+    default: ''
  linode_id:
    description:
     - Unique ID of a linode server. This value is read-only in the sense that
--- a/plugins/modules/cloud/lxd/lxd_container.py
+++ b/plugins/modules/cloud/lxd/lxd_container.py
@@ -191,10 +191,10 @@ notes:
    2.1, the later requires python to be installed in the instance which can
    be done with the command module.
  - You can copy a file from the host to the instance
-    with the Ansible M(ansible.builtin.copy) and M(ansible.builtin.template) module and the `lxd` connection plugin.
+    with the Ansible M(ansible.builtin.copy) and M(ansible.builtin.template) module and the C(community.general.lxd) connection plugin.
    See the example below.
  - You can copy a file in the created instance to the localhost
-    with `command=lxc file pull instance_name/dir/filename filename`.
+    with C(command=lxc file pull instance_name/dir/filename filename).
    See the first example below.
 '''

--- a/plugins/modules/cloud/memset/memset_dns_reload.py
+++ b/plugins/modules/cloud/memset/memset_dns_reload.py
@@ -111,7 +111,7 @@ def poll_reload_status(api_key=None, job_id=None, payload=None):
        memset_api = response.json()
        msg = None

-    return(memset_api, msg, stderr)
+    return memset_api, msg, stderr


 def reload_dns(args=None):
@@ -133,7 +133,7 @@ def reload_dns(args=None):
        retvals['failed'] = has_failed
        retvals['memset_api'] = response.json()
        retvals['msg'] = msg
-        return(retvals)
+        return retvals

    # set changed to true if the reload request was accepted.
    has_changed = True
@@ -153,7 +153,7 @@ def reload_dns(args=None):
        if val is not None:
            retvals[val] = eval(val)

-    return(retvals)
+    return retvals


 def main():
--- a/plugins/modules/cloud/memset/memset_memstore_info.py
+++ b/plugins/modules/cloud/memset/memset_memstore_info.py
@@ -127,7 +127,7 @@ def get_facts(args=None):
        retvals['failed'] = has_failed
        retvals['msg'] = msg
        retvals['stderr'] = "API returned an error: {0}" . format(response.status_code)
-        return(retvals)
+        return retvals

    # we don't want to return the same thing twice
    msg = None
@@ -139,7 +139,7 @@ def get_facts(args=None):
        if val is not None:
            retvals[val] = eval(val)

-    return(retvals)
+    return retvals


 def main():
--- a/plugins/modules/cloud/memset/memset_server_info.py
+++ b/plugins/modules/cloud/memset/memset_server_info.py
@@ -252,7 +252,7 @@ def get_facts(args=None):
        retvals['failed'] = has_failed
        retvals['msg'] = msg
        retvals['stderr'] = "API returned an error: {0}" . format(response.status_code)
-        return(retvals)
+        return retvals

    # we don't want to return the same thing twice
    msg = None
@@ -264,7 +264,7 @@ def get_facts(args=None):
        if val is not None:
            retvals[val] = eval(val)

-    return(retvals)
+    return retvals


 def main():
--- a/plugins/modules/cloud/memset/memset_zone.py
+++ b/plugins/modules/cloud/memset/memset_zone.py
@@ -43,6 +43,7 @@ options:
            - The default TTL for all records created in the zone. This must be a
              valid int from U(https://www.memset.com/apidocs/methods_dns.html#dns.zone_create).
        type: int
+        default: 0
        choices: [ 0, 300, 600, 900, 1800, 3600, 7200, 10800, 21600, 43200, 86400 ]
    force:
        required: false
@@ -139,7 +140,7 @@ def check(args=None):
    retvals['changed'] = has_changed
    retvals['failed'] = has_failed

-    return(retvals)
+    return retvals


 def create_zone(args=None, zone_exists=None, payload=None):
@@ -185,7 +186,7 @@ def create_zone(args=None, zone_exists=None, payload=None):
        _has_failed, _msg, response = memset_api_call(api_key=args['api_key'], api_method=api_method, payload=payload)
        memset_api = response.json()

-    return(has_failed, has_changed, memset_api, msg)
+    return has_failed, has_changed, memset_api, msg


 def delete_zone(args=None, zone_exists=None, payload=None):
@@ -233,7 +234,7 @@ def delete_zone(args=None, zone_exists=None, payload=None):
    else:
        has_failed, has_changed = False, False

-    return(has_failed, has_changed, memset_api, msg)
+    return has_failed, has_changed, memset_api, msg


 def create_or_delete(args=None):
@@ -255,7 +256,7 @@ def create_or_delete(args=None):
        retvals['failed'] = _has_failed
        retvals['msg'] = _msg

-        return(retvals)
+        return retvals

    zone_exists, _msg, counter, _zone_id = get_zone_id(zone_name=args['name'], current_zones=response.json())

@@ -271,7 +272,7 @@ def create_or_delete(args=None):
        if val is not None:
            retvals[val] = eval(val)

-    return(retvals)
+    return retvals


 def main():
--- a/plugins/modules/cloud/memset/memset_zone_domain.py
+++ b/plugins/modules/cloud/memset/memset_zone_domain.py
@@ -110,7 +110,7 @@ def check(args=None):
    retvals['changed'] = has_changed
    retvals['failed'] = has_failed

-    return(retvals)
+    return retvals


 def create_zone_domain(args=None, zone_exists=None, zone_id=None, payload=None):
@@ -138,7 +138,7 @@ def create_zone_domain(args=None, zone_exists=None, zone_id=None, payload=None):
        if not has_failed:
            has_changed = True

-    return(has_failed, has_changed, msg)
+    return has_failed, has_changed, msg


 def delete_zone_domain(args=None, payload=None):
@@ -165,7 +165,7 @@ def delete_zone_domain(args=None, payload=None):
            # unset msg as we don't want to return unnecessary info to the user.
            msg = None

-    return(has_failed, has_changed, memset_api, msg)
+    return has_failed, has_changed, memset_api, msg


 def create_or_delete_domain(args=None):
@@ -188,7 +188,7 @@ def create_or_delete_domain(args=None):
        retvals['failed'] = has_failed
        retvals['msg'] = msg
        retvals['stderr'] = "API returned an error: {0}" . format(response.status_code)
-        return(retvals)
+        return retvals

    zone_exists, msg, counter, zone_id = get_zone_id(zone_name=args['zone'], current_zones=response.json())

@@ -203,7 +203,7 @@ def create_or_delete_domain(args=None):

        retvals['failed'] = has_failed
        retvals['msg'] = stderr
-        return(retvals)
+        return retvals

    if args['state'] == 'present':
        has_failed, has_changed, msg = create_zone_domain(args=args, zone_exists=zone_exists, zone_id=zone_id, payload=payload)
@@ -217,7 +217,7 @@ def create_or_delete_domain(args=None):
        if val is not None:
            retvals[val] = eval(val)

-    return(retvals)
+    return retvals


 def main():
--- a/plugins/modules/cloud/memset/memset_zone_record.py
+++ b/plugins/modules/cloud/memset/memset_zone_record.py
@@ -43,11 +43,13 @@ options:
        description:
            - C(SRV) and C(TXT) record priority, in the range 0 > 999 (inclusive).
        type: int
+        default: 0
    record:
        required: false
        description:
            - The subdomain to create.
        type: str
+        default: ''
    type:
        required: true
        description:
@@ -64,6 +66,7 @@ options:
        description:
            - The record's TTL in seconds (will inherit zone's TTL if not explicitly set). This must be a
              valid int from U(https://www.memset.com/apidocs/methods_dns.html#dns.zone_record_create).
+        default: 0
        choices: [ 0, 300, 600, 900, 1800, 3600, 7200, 10800, 21600, 43200, 86400 ]
        type: int
    zone:
@@ -221,7 +224,7 @@ def create_zone_record(args=None, zone_id=None, records=None, payload=None):
                # nothing to do; record is already correct so we populate
                # the return var with the existing record's details.
                memset_api = zone_record
-                return(has_changed, has_failed, memset_api, msg)
+                return has_changed, has_failed, memset_api, msg
            else:
                # merge dicts ensuring we change any updated values
                payload = zone_record.copy()
@@ -231,7 +234,7 @@ def create_zone_record(args=None, zone_id=None, records=None, payload=None):
                    has_changed = True
                    # return the new record to the user in the returned var.
                    memset_api = new_record
-                    return(has_changed, has_failed, memset_api, msg)
+                    return has_changed, has_failed, memset_api, msg
                has_failed, msg, response = memset_api_call(api_key=args['api_key'], api_method=api_method, payload=payload)
                if not has_failed:
                    has_changed = True
@@ -246,7 +249,7 @@ def create_zone_record(args=None, zone_id=None, records=None, payload=None):
            has_changed = True
            # populate the return var with the new record's details.
            memset_api = new_record
-            return(has_changed, has_failed, memset_api, msg)
+            return has_changed, has_failed, memset_api, msg
        has_failed, msg, response = memset_api_call(api_key=args['api_key'], api_method=api_method, payload=payload)
        if not has_failed:
            has_changed = True
@@ -254,7 +257,7 @@ def create_zone_record(args=None, zone_id=None, records=None, payload=None):
            #  empty msg as we don't want to return a boatload of json to the user.
            msg = None

-    return(has_changed, has_failed, memset_api, msg)
+    return has_changed, has_failed, memset_api, msg


 def delete_zone_record(args=None, records=None, payload=None):
@@ -270,7 +273,7 @@ def delete_zone_record(args=None, records=None, payload=None):
        for zone_record in records:
            if args['check_mode']:
                has_changed = True
-                return(has_changed, has_failed, memset_api, msg)
+                return has_changed, has_failed, memset_api, msg
            payload['id'] = zone_record['id']
            api_method = 'dns.zone_record_delete'
            has_failed, msg, response = memset_api_call(api_key=args['api_key'], api_method=api_method, payload=payload)
@@ -280,7 +283,7 @@ def delete_zone_record(args=None, records=None, payload=None):
                #  empty msg as we don't want to return a boatload of json to the user.
                msg = None

-    return(has_changed, has_failed, memset_api, msg)
+    return has_changed, has_failed, memset_api, msg


 def create_or_delete(args=None):
@@ -304,7 +307,7 @@ def create_or_delete(args=None):
        retvals['failed'] = _has_failed
        retvals['msg'] = msg
        retvals['stderr'] = "API returned an error: {0}" . format(response.status_code)
-        return(retvals)
+        return retvals

    zone_exists, _msg, counter, zone_id = get_zone_id(zone_name=args['zone'], current_zones=response.json())

@@ -317,7 +320,7 @@ def create_or_delete(args=None):
        retvals['failed'] = has_failed
        retvals['msg'] = stderr
        retvals['stderr'] = stderr
-        return(retvals)
+        return retvals

    # get a list of all records ( as we can't limit records by zone)
    api_method = 'dns.zone_record_list'
@@ -339,7 +342,7 @@ def create_or_delete(args=None):
        if val is not None:
            retvals[val] = eval(val)

-    return(retvals)
+    return retvals


 def main():
--- a/plugins/modules/cloud/misc/proxmox.py
+++ b/plugins/modules/cloud/misc/proxmox.py
@@ -743,6 +743,8 @@ def main():
            module.fail_json(msg="restarting of VM %s failed with exception: %s" % (vmid, e))

    elif state == 'absent':
+        if not vmid:
+            module.exit_json(changed=False, msg='VM with hostname = %s is already absent' % hostname)
        try:
            vm = proxmox.get_vm(vmid, ignore_missing=True)
            if not vm:
--- a/plugins/modules/cloud/misc/proxmox_kvm.py
+++ b/plugins/modules/cloud/misc/proxmox_kvm.py
@@ -83,7 +83,7 @@ options:
    version_added: 1.3.0
  clone:
    description:
-      - Name of VM to be cloned. If C(vmid) is setted, C(clone) can take arbitrary value but required for initiating the clone.
+      - Name of VM to be cloned. If I(vmid) is set, I(clone) can take an arbitrary value but is required for initiating the clone.
    type: str
  cores:
    description:
@@ -1370,6 +1370,8 @@ def main():

    elif state == 'absent':
        status = {}
+        if not vmid:
+            module.exit_json(changed=False, msg='VM with name = %s is already absent' % name)
        try:
            vm = proxmox.get_vm(vmid, ignore_missing=True)
            if not vm:
--- a/plugins/modules/cloud/misc/rhevm.py
+++ b/plugins/modules/cloud/misc/rhevm.py
@@ -53,6 +53,7 @@ options:
        description:
            - The RHEV/oVirt cluster in which you want you VM to start.
        type: str
+        default: ''
    datacenter:
        description:
            - The RHEV/oVirt datacenter in which you want you VM to start.
@@ -1252,7 +1253,6 @@ def setChanged():


 def setMsg(message):
-    global failed
    msg.append(message)


--- a/plugins/modules/cloud/misc/serverless.py
+++ b/plugins/modules/cloud/misc/serverless.py
@@ -34,6 +34,7 @@ options:
      - The name of the serverless framework project stage to deploy to.
      - This uses the serverless framework default "dev".
    type: str
+    default: ''
  functions:
    description:
      - A list of specific functions to deploy.
@@ -41,12 +42,12 @@ options:
      - Deprecated parameter, it will be removed in community.general 5.0.0.
    type: list
    elements: str
-    default: []
  region:
    description:
      - AWS region to deploy the service to.
      - This parameter defaults to C(us-east-1).
    type: str
+    default: ''
  deploy:
    description:
      - Whether or not to deploy artifacts after building them.
@@ -115,7 +116,7 @@ state:
  returned: always
 command:
  type: str
-  description: Full `serverless` command run by this module, in case you want to re-run the command outside the module.
+  description: Full C(serverless) command run by this module, in case you want to re-run the command outside the module.
  returned: always
  sample: serverless deploy --stage production
 '''
--- a/Show More
+++ b/Show More