Compare commits

..

35 Commits

Author SHA1 Message Date
Felix Fontein
eec743f791 Release 1.3.12. 2021-08-31 07:28:59 +02:00
Felix Fontein
c6a3392bea Prepare 1.3.12 release. 2021-08-29 13:41:27 +02:00
patchback[bot]
403597da09 Update the .gitignore with the latest version (#3177) (#3182)
This because it contains new changes, e.g. ignore development
environments for Python projects.

(cherry picked from commit 429359e977)

Co-authored-by: Roy Lenferink <lenferinkroy@gmail.com>
2021-08-09 17:01:13 +02:00
patchback[bot]
49df4f4b81 contributing: make expected behavior clearer (#3168) (#3174)
* contributing: make expected behavior clearer

reformulate the preference of not having squashed commits clearer,
shorter and more precise.

https://github.com/ansible-collections/community.general/pull/3164#discussion_r684644504

* Update CONTRIBUTING.md

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 85bcef3f5a)

Co-authored-by: Sebastian <sebix@sebix.at>
2021-08-08 11:48:32 +02:00
patchback[bot]
12b7c5c584 Inform contributors on changelog fragments in CONTRIBUTING.md (#3167) (#3171)
* Inform contributors on changelog fragments.

* Mention docs-only PRs as well.

(cherry picked from commit 87ba15fa45)

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-08-08 11:47:53 +02:00
Felix Fontein
5336872b3e [stable-1] added supports_check_mode=True to info/facts modules (#3101)
* [stable-2] added supports_check_mode=True to info/facts modules (#3095)

* added supports_check_mode=True to info/facts modules (#3084)

* added supports_check_mode=True to info/facts modules

* added changelog fragment

* rolled back vertica_info

* rolled back utm_proxy_*_info

* updated changelog fragment with latest adjustments

* Update changelogs/fragments/3084-info-checkmode.yaml

Co-authored-by: Felix Fontein <felix@fontein.de>

* added check mode to xenserver_facts + oneview_*_info

* added check mode to utm_proxy_*_info

* updated changelog

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 7da2c16b4a)

* Also fix modules removed in 3.0.0.

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
(cherry picked from commit 0fda418702)

* Fix some more modules.
2021-07-28 09:59:36 +02:00
patchback[bot]
5cba378c75 Check targets (#3019) (#3020)
* Add extra sanity test to check aliases files.

* Remove invalid target name.

(cherry picked from commit 27ba98a68e)

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-07-16 20:09:28 +02:00
patchback[bot]
25ee06d5de Temporarily disable passwordstore lookup tests on macOS and OSX. (#2979) (#2980)
(cherry picked from commit 4ae392e5de)

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-07-10 13:49:39 +02:00
John R Barker
d526d96899 Update commit-rights.md (#2966)
aminvakil is no longer involved with the Ansible Community due to United
States export controls and economic sanctions laws apply to U.S.
persons, entities, and controlled software and technology that is of
U.S. origin or that enters the U.S., including open source software.

(cherry picked from commit 518ace2562)
2021-07-09 13:01:18 +01:00
Felix Fontein
d079384e75 Next release will be 1.3.12. 2021-06-28 22:17:55 +02:00
Felix Fontein
abc786bddd Release 1.3.11. 2021-06-28 21:02:01 +02:00
Felix Fontein
85a1eea4e6 Prepare 1.3.11 release. 2021-06-28 07:02:51 +02:00
Felix Fontein
ca385c8a45 [stable-1] fix CI (#2892)
* Make sure ruamel.yaml.clib 0.2.2 is used for Python 2.7.

* Also add to unit tests requirements.

* Don't install on Python 2.6.

* Another constraints file.
2021-06-27 15:44:37 +02:00
patchback[bot]
bb689550b3 Adjust example to remove unnecessary offensive language. (#2869) (#2870)
(cherry picked from commit d2a984ded1)

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-06-25 06:49:08 +02:00
patchback[bot]
41aacb1472 Dynamically add meta/runtime.yml redirects before integration tests. (#2633) (#2853)
ci_coverage

(cherry picked from commit 07085785a3)

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-06-22 09:13:49 +02:00
patchback[bot]
3f92a6b738 BOTMETA.yml: grant supershipit (#2807) (#2809)
(cherry picked from commit b1b34ee12e)

Co-authored-by: Andrew Klychkov <aklychko@redhat.com>
2021-06-15 19:11:18 +02:00
patchback[bot]
ebdd8c88ec BOTMETA.yml: supershipit to quidame (#2801) (#2804)
(cherry picked from commit bccf317814)

Co-authored-by: Andrew Klychkov <aklychko@redhat.com>
2021-06-14 20:59:08 +02:00
patchback[bot]
b24d27d4bd Make extra sanity test runner produce ansibullbot and JUnit output. (#2794) (#2798)
(cherry picked from commit a55c96d5c1)

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-06-14 07:58:00 +02:00
Felix Fontein
7b3319dd81 CI: Remove scripts that are no longer needed (#2793) (#2797)
* Remove scripts that are no longer needed.

ci_complete

* Remove sanity ignores.

(cherry picked from commit d4c4d00ad1)
2021-06-14 06:42:24 +02:00
patchback[bot]
94b2e9d9ca with great powers come great responsibility (#2755) (#2757)
(cherry picked from commit eef645c3f7)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
2021-06-08 11:04:26 +02:00
patchback[bot]
82060a7b21 Re-enable flatpak_remote tests (#2747) (#2750)
* Automate test repo creation, re-enable flatpak_remote tests.

* Linting.

* Another try.

(cherry picked from commit 4c50f1add7)

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-06-07 21:48:46 +02:00
patchback[bot]
580cced80a Remove aminvakil from supershipit section as it is not needed anymore (#2743) (#2744)
(cherry picked from commit 7c3f2ae4af)

Co-authored-by: Amin Vakil <info@aminvakil.com>
2021-06-07 17:03:32 +02:00
patchback[bot]
a4d1d064c8 Add aminvakil to committers (#2739) (#2740)
(cherry picked from commit 1e34df7ca0)

Co-authored-by: Amin Vakil <info@aminvakil.com>
2021-06-07 16:01:22 +02:00
patchback[bot]
4e3d85798c Stop mentioning Freenode. We're on Libera.chat. (#2666) (#2667)
(cherry picked from commit 14813a6287)

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-05-28 07:24:55 +02:00
patchback[bot]
28458b2477 Add CONTRIBUTING.md (#2602) (#2624)
* Initial file shamelessly copied from community.mysql

* Add some notes on pull requests

* Add CONTRIBUTING.md link to README.md

* Add quick-start development guide link

* Apply felixfontein's suggestions

Co-authored-by: Felix Fontein <felix@fontein.de>

* add note about rebasing and merge commits

Co-authored-by: Felix Fontein <felix@fontein.de>

* add note about easyfix and waiting_on_contributor tags

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit d0f8eac7fd)

Co-authored-by: Amin Vakil <info@aminvakil.com>
2021-05-26 10:00:14 +02:00
patchback[bot]
e21ddcb5b6 Massive adjustment in integration tests for changed and failed (#2577) (#2586)
* Replaced ".changed ==" with "is [not] changed". Same for failed

* Mr Quote refused to go

(cherry picked from commit d7e55db99b)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
2021-05-22 14:53:06 +02:00
patchback[bot]
4006db89bf Add missing author name (#2570) (#2574)
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 852e240525)

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
2021-05-21 19:44:17 +02:00
patchback[bot]
62557a0e10 removed supporting code for testing module "nuage" - no longer exists here (#2559) (#2561)
(cherry picked from commit 452a185a23)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
2021-05-19 22:44:32 +02:00
Felix Fontein
c305178950 Fix CI. 2021-05-19 12:23:01 +02:00
patchback[bot]
8ba08ae383 Clarify Windows (non-)support. (#2476) (#2480)
(cherry picked from commit 2e58dfe52a)

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-05-10 17:14:29 +02:00
Felix Fontein
ffafcb34b2 Remove shippable config. (#2440) (#2445)
(cherry picked from commit 1f41e66f09)
2021-05-03 23:07:56 +02:00
Felix Fontein
2ed03d7fb6 Copy schedule to stable branches. 2021-05-02 13:35:10 +02:00
patchback[bot]
a007eebba8 Remove programming error which prevents modules to work with devel. (#2381) (#2382)
(cherry picked from commit d9524bae93)

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-04-30 06:03:21 +02:00
patchback[bot]
a0a5a10c67 Use Ansible's codecov uploader. (#2377) (#2378)
(cherry picked from commit b3f436aa63)

Co-authored-by: Felix Fontein <felix@fontein.de>
2021-04-30 05:32:16 +02:00
Felix Fontein
f01ac6f31f Next expected release is 1.3.11. 2021-04-26 14:31:12 +02:00
155 changed files with 734 additions and 537 deletions

View File

@@ -14,12 +14,24 @@ pr:
schedules:
- cron: 0 8 * * *
displayName: Nightly
displayName: Nightly (main)
always: true
branches:
include:
- main
- stable-*
- cron: 0 10 * * *
displayName: Nightly (active stable branches)
always: true
branches:
include:
- stable-2
- stable-3
- cron: 0 11 * * 0
displayName: Weekly (old stable branches)
always: true
branches:
include:
- stable-1
variables:
- name: checkoutPath

View File

@@ -7,7 +7,7 @@ set -o pipefail -eu
output_path="$1"
curl --silent --show-error https://codecov.io/bash > codecov.sh
curl --silent --show-error https://ansible-ci-files.s3.us-east-1.amazonaws.com/codecov/codecov.sh > codecov.sh
for file in "${output_path}"/reports/coverage*.xml; do
name="${file}"

2
.github/BOTMETA.yml vendored
View File

@@ -1,7 +1,7 @@
automerge: true
files:
plugins/:
supershipit: aminvakil russoz
supershipit: quidame Ajpantuso
changelogs/fragments/:
support: community
$actions:

81
.gitignore vendored
View File

@@ -1,6 +1,6 @@
# Created by https://www.gitignore.io/api/git,linux,pydev,python,windows,pycharm+all,jupyternotebook,vim,webstorm,emacs,dotenv
# Edit at https://www.gitignore.io/?templates=git,linux,pydev,python,windows,pycharm+all,jupyternotebook,vim,webstorm,emacs,dotenv
# Created by https://www.toptal.com/developers/gitignore/api/git,linux,pydev,python,windows,pycharm+all,jupyternotebook,vim,webstorm,emacs,dotenv
# Edit at https://www.toptal.com/developers/gitignore?templates=git,linux,pydev,python,windows,pycharm+all,jupyternotebook,vim,webstorm,emacs,dotenv
### dotenv ###
.env
@@ -88,7 +88,7 @@ flycheck_*.el
.nfs*
### PyCharm+all ###
# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio and WebStorm
# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio, WebStorm and Rider
# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839
# User-specific stuff
@@ -98,6 +98,9 @@ flycheck_*.el
.idea/**/dictionaries
.idea/**/shelf
# AWS User-specific
.idea/**/aws.xml
# Generated files
.idea/**/contentModel.xml
@@ -118,6 +121,9 @@ flycheck_*.el
# When using Gradle or Maven with auto-import, you should exclude module files,
# since they will be recreated, and may cause churn. Uncomment if using
# auto-import.
# .idea/artifacts
# .idea/compiler.xml
# .idea/jarRepositories.xml
# .idea/modules.xml
# .idea/*.iml
# .idea/modules
@@ -198,7 +204,6 @@ parts/
sdist/
var/
wheels/
pip-wheel-metadata/
share/python-wheels/
*.egg-info/
.installed.cfg
@@ -225,13 +230,25 @@ htmlcov/
nosetests.xml
coverage.xml
*.cover
*.py,cover
.hypothesis/
.pytest_cache/
cover/
# Translations
*.mo
*.pot
# Django stuff:
*.log
local_settings.py
db.sqlite3
db.sqlite3-journal
# Flask stuff:
instance/
.webassets-cache
# Scrapy stuff:
.scrapy
@@ -239,9 +256,19 @@ coverage.xml
docs/_build/
# PyBuilder
.pybuilder/
target/
# Jupyter Notebook
.ipynb_checkpoints
# IPython
profile_default/
ipython_config.py
# pyenv
# For a library or package, you might want to ignore these files since the code is
# intended to run in multiple environments; otherwise, check them in:
.python-version
# pipenv
@@ -251,12 +278,24 @@ target/
# install all needed dependencies.
#Pipfile.lock
# celery beat schedule file
# PEP 582; used by e.g. github.com/David-OConnor/pyflow
__pypackages__/
# Celery stuff
celerybeat-schedule
celerybeat.pid
# SageMath parsed files
*.sage.py
# Environments
.venv
env/
venv/
ENV/
env.bak/
venv.bak/
# Spyder project settings
.spyderproject
.spyproject
@@ -264,10 +303,6 @@ celerybeat-schedule
# Rope project settings
.ropeproject
# Mr Developer
.mr.developer.cfg
.project
# mkdocs documentation
/site
@@ -279,9 +314,16 @@ dmypy.json
# Pyre type checker
.pyre/
# pytype static type analyzer
.pytype/
# Cython debug symbols
cython_debug/
### Vim ###
# Swap
[._]*.s[a-v][a-z]
!*.svg # comment out if you don't need vector files
[._]*.sw[a-p]
[._]s[a-rt-v][a-z]
[._]ss[a-gi-z]
@@ -299,11 +341,13 @@ tags
[._]*.un~
### WebStorm ###
# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio and WebStorm
# Covers JetBrains IDEs: IntelliJ, RubyMine, PhpStorm, AppCode, PyCharm, CLion, Android Studio, WebStorm and Rider
# Reference: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839
# User-specific stuff
# AWS User-specific
# Generated files
# Sensitive or high-churn files
@@ -314,6 +358,9 @@ tags
# When using Gradle or Maven with auto-import, you should exclude module files,
# since they will be recreated, and may cause churn. Uncomment if using
# auto-import.
# .idea/artifacts
# .idea/compiler.xml
# .idea/jarRepositories.xml
# .idea/modules.xml
# .idea/*.iml
# .idea/modules
@@ -349,15 +396,27 @@ tags
# *.ipr
# Sonarlint plugin
# https://plugins.jetbrains.com/plugin/7973-sonarlint
.idea/**/sonarlint/
# SonarQube Plugin
# https://plugins.jetbrains.com/plugin/7238-sonarqube-community-plugin
.idea/**/sonarIssues.xml
# Markdown Navigator plugin
# https://plugins.jetbrains.com/plugin/7896-markdown-navigator-enhanced
.idea/**/markdown-navigator.xml
.idea/**/markdown-navigator-enh.xml
.idea/**/markdown-navigator/
# Cache file creation bug
# See https://youtrack.jetbrains.com/issue/JBR-2257
.idea/$CACHE_FILE$
# CodeStream plugin
# https://plugins.jetbrains.com/plugin/12206-codestream
.idea/codestream.xml
### Windows ###
# Windows thumbnail cache files
Thumbs.db
@@ -384,4 +443,4 @@ $RECYCLE.BIN/
# Windows shortcuts
*.lnk
# End of https://www.gitignore.io/api/git,linux,pydev,python,windows,pycharm+all,jupyternotebook,vim,webstorm,emacs,dotenv
# End of https://www.toptal.com/developers/gitignore/api/git,linux,pydev,python,windows,pycharm+all,jupyternotebook,vim,webstorm,emacs,dotenv

View File

@@ -5,6 +5,84 @@ Community General Release Notes
.. contents:: Topics
v1.3.12
=======
Release Summary
---------------
Fix check mode support for ``_info`` and ``_facts`` modules.
Bugfixes
--------
- ali_instance_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- docker_stack_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3101).
- docker_stack_task_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3101).
- gcpubsub_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3101).
- gluster_heal_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- idrac_redfish_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- memset_memstore_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- memset_server_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- ome_device_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- oneview_datacenter_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- oneview_enclosure_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- oneview_ethernet_network_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- oneview_fc_network_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- oneview_fcoe_network_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- oneview_logical_interconnect_group_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- oneview_network_set_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- oneview_san_manager_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- ovirt_affinity_label_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_api_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_cluster_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_datacenter_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_disk_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_event_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_external_provider_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_group_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_host_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_host_storage_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_network_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_nic_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_permission_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_quota_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_scheduling_policy_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_snapshot_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_storage_domain_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_storage_template_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_storage_vm_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_tag_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_template_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_user_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_vm_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_vmpool_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- purefa_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- rax_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- redfish_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- smartos_image_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- snmp_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- utm_aaa_group_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- utm_ca_host_key_cert_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- utm_network_interface_address_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- utm_proxy_frontend_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- utm_proxy_location_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- xenserver_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- xfconf_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
v1.3.11
=======
Release Summary
---------------
Maintenance release.
Bugfixes
--------
- ovirt* modules - remove bad unnecessary import for current ansible-core development version (https://github.com/ansible-collections/community.general/pull/2381).
v1.3.10
=======

32
CONTRIBUTING.md Normal file
View File

@@ -0,0 +1,32 @@
# Contributing
We follow [Ansible Code of Conduct](https://docs.ansible.com/ansible/latest/community/code_of_conduct.html) in all our contributions and interactions within this repository.
If you are a committer, also refer to the [collection's committer guidelines](https://github.com/ansible-collections/community.general/blob/main/commit-rights.md).
## Issue tracker
Whether you are looking for an opportunity to contribute or you found a bug and already know how to solve it, please go to the [issue tracker](https://github.com/ansible-collections/community.general/issues).
There you can find feature ideas to implement, reports about bugs to solve, or submit an issue to discuss your idea before implementing it which can help choose a right direction at the beginning of your work and potentially save a lot of time and effort.
Also somebody may already have started discussing or working on implementing the same or a similar idea,
so you can cooperate to create a better solution together.
* If you are interested in starting with an easy issue, look for [issues with an `easyfix` label](https://github.com/ansible-collections/community.general/labels/easyfix).
* Often issues that are waiting for contributors to pick up have [the `waiting_on_contributor` label](https://github.com/ansible-collections/community.general/labels/waiting_on_contributor).
## Open pull requests
Look through currently [open pull requests](https://github.com/ansible-collections/community.general/pulls).
You can help by reviewing them. Reviews help move pull requests to merge state. Some good pull requests cannot be merged only due to a lack of reviews. And it is always worth saying that good reviews are often more valuable than pull requests themselves.
Note that reviewing does not only mean code review, but also offering comments on new interfaces added to existing plugins/modules, interfaces of new plugins/modules, improving language (not everyone is a native english speaker), or testing bugfixes and new features!
Also, consider taking up a valuable, reviewed, but abandoned pull request which you could politely ask the original authors to complete yourself.
* Try committing your changes with an informative but short commit message.
* Do not squash your commits and force-push to your branch if not needed. Reviews of your pull request are much easier with individual commits to comprehend the pull request history. All commits of your pull request branch will be squashed into one commit by GitHub upon merge.
* Do not add merge commits to your PR. The bot will complain and you will have to rebase ([instructions for rebasing](https://docs.ansible.com/ansible/latest/dev_guide/developing_rebasing.html)) to remove them before your PR can be merged. To avoid that git automatically does merges during pulls, you can configure it to do rebases instead by running `git config pull.rebase true` inside the respository checkout.
* Make sure your PR includes a [changelog fragment](https://docs.ansible.com/ansible/devel/community/development_process.html#changelogs-how-to). (You must not include a fragment for new modules or new plugins, except for test and filter plugins. Also you shouldn't include one for docs-only changes. If you're not sure, simply don't include one, we'll tell you whether one is needed or not :) )
You can also read [our Quick-start development guide](https://github.com/ansible/community-docs/blob/main/create_pr_quick_start_guide.rst).
If you find any inconsistencies or places in this document which can be improved, feel free to raise an issue or pull request to fix it.

View File

@@ -7,6 +7,8 @@ This repo contains the `community.general` Ansible Collection. The collection in
You can find [documentation for this collection on the Ansible docs site](https://docs.ansible.com/ansible/latest/collections/community/general/).
Please note that this collection does **not** support Windows targets. Only connection plugins included in this collection might support Windows targets, and will explicitly mention that in their documentation if they do so.
## Tested with Ansible
Tested with the current Ansible 2.9, ansible-base 2.10 and ansible-core 2.11 releases. Ansible versions before 2.9.10 are not supported.
@@ -48,6 +50,8 @@ export COLLECTIONS_PATH=$(pwd)/collections:$COLLECTIONS_PATH
You can find more information in the [developer guide for collections](https://docs.ansible.com/ansible/devel/dev_guide/developing_collections.html#contributing-to-collections), and in the [Ansible Community Guide](https://docs.ansible.com/ansible/latest/community/index.html).
Also for some notes specific to this collection see [our CONTRIBUTING documentation](https://github.com/ansible-collections/community.general/blob/main/CONTRIBUTING.md).
### Running tests
See [here](https://docs.ansible.com/ansible/devel/dev_guide/developing_collections.html#testing-collections).
@@ -56,10 +60,10 @@ See [here](https://docs.ansible.com/ansible/devel/dev_guide/developing_collectio
We have a dedicated Working Group for Ansible development.
You can find other people interested on the following Freenode IRC channels -
You can find other people interested on the following [Libera.chat](https://libera.chat/) IRC channels -
- `#ansible` - For general use questions and support.
- `#ansible-devel` - For discussions on developer topics and code related to features or bugs.
- `#ansible-community` - For discussions on community topics and community meetings.
- `#ansible-devel` - For discussions on developer topics and code related to features or bugs in ansible-core.
- `#ansible-community` - For discussions on community topics and community meetings, and for general development questions for community collections.
For more information about communities, meetings and agendas see [Community Wiki](https://github.com/ansible/community/wiki/Community).

View File

@@ -1719,6 +1719,77 @@ releases:
- 2340-jenkins_plugin-py2.yml
- allow_funcd_to_load.yml
release_date: '2021-04-26'
1.3.11:
changes:
bugfixes:
- ovirt* modules - remove bad unnecessary import for current ansible-core development
version (https://github.com/ansible-collections/community.general/pull/2381).
release_summary: Maintenance release.
fragments:
- 1.3.11.yml
- ovirt-fixup.yml
release_date: '2021-06-28'
1.3.12:
changes:
bugfixes:
- ali_instance_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- docker_stack_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3101).
- docker_stack_task_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3101).
- gcpubsub_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3101).
- gluster_heal_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- idrac_redfish_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- memset_memstore_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- memset_server_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- ome_device_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- oneview_datacenter_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- oneview_enclosure_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- oneview_ethernet_network_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- oneview_fc_network_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- oneview_fcoe_network_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- oneview_logical_interconnect_group_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- oneview_network_set_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- oneview_san_manager_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- ovirt_affinity_label_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_api_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_cluster_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_datacenter_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_disk_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_event_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_external_provider_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_group_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_host_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_host_storage_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_network_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_nic_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_permission_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_quota_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_scheduling_policy_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_snapshot_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_storage_domain_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_storage_template_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_storage_vm_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_tag_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_template_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_user_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_vm_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- ovirt_vmpool_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- purefa_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3095).
- rax_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- redfish_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- smartos_image_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- snmp_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- utm_aaa_group_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- utm_ca_host_key_cert_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- utm_network_interface_address_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- utm_proxy_frontend_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- utm_proxy_location_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- xenserver_facts - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
- xfconf_info - added support to check mode (https://github.com/ansible-collections/community.general/pull/3084).
release_summary: Fix check mode support for ``_info`` and ``_facts`` modules.
fragments:
- 1.3.12.yml
- 3084-info-checkmode.yaml
release_date: '2021-08-31'
1.3.2:
changes:
bugfixes:

View File

@@ -67,6 +67,7 @@ Individuals who have been asked to become a part of this group have generally be
| Name | GitHub ID | IRC Nick | Other |
| ------------------- | -------------------- | ------------------ | -------------------- |
| Alexei Znamensky | russoz | russoz | |
| Andrew Klychkov | andersson007 | andersson007_ | |
| Felix Fontein | felixfontein | felixfontein | |
| John R Barker | gundalow | gundalow | |

View File

@@ -1,6 +1,6 @@
namespace: community
name: general
version: 1.3.10
version: 1.3.12
readme: README.md
authors:
- Ansible (https://github.com/ansible)

View File

@@ -11,6 +11,8 @@ DOCUMENTATION = '''
plugin_type: inventory
short_description: StackPath Edge Computing inventory source
version_added: 1.2.0
author:
- UNKNOWN (@shayrybak)
extends_documentation_fragment:
- inventory_cache
- constructed

View File

@@ -201,7 +201,7 @@ class OneViewModuleBase(object):
resource_client = None
def __init__(self, additional_arg_spec=None, validate_etag_support=False):
def __init__(self, additional_arg_spec=None, validate_etag_support=False, supports_check_mode=False):
"""
OneViewModuleBase constructor.
@@ -210,7 +210,7 @@ class OneViewModuleBase(object):
"""
argument_spec = self._build_argument_spec(additional_arg_spec, validate_etag_support)
self.module = AnsibleModule(argument_spec=argument_spec, supports_check_mode=False)
self.module = AnsibleModule(argument_spec=argument_spec, supports_check_mode=supports_check_mode)
self._check_hpe_oneview_sdk()
self._create_oneview_client()

View File

@@ -382,7 +382,10 @@ def main():
filters=dict(type='dict')
)
)
module = AnsibleModule(argument_spec=argument_spec)
module = AnsibleModule(
argument_spec=argument_spec,
supports_check_mode=True,
)
if module._name in ('ali_instance_facts', 'community.general.ali_instance_facts'):
module.deprecate("The 'ali_instance_facts' module has been renamed to 'ali_instance_info'",
version='3.0.0', collection_name='community.general') # was Ansible 2.13

View File

@@ -56,7 +56,7 @@ def main():
module = AnsibleModule(
argument_spec={
},
supports_check_mode=False
supports_check_mode=True
)
rc, out, err = docker_stack_list(module)

View File

@@ -65,7 +65,7 @@ def main():
argument_spec={
'name': dict(type='str', required=True)
},
supports_check_mode=False
supports_check_mode=True
)
name = module.params['name']

View File

@@ -120,7 +120,7 @@ def main():
state=dict(choices=['list'], default='list'),
service_account_email=dict(),
credentials_file=dict(),
project_id=dict(), ),)
project_id=dict(), ), supports_check_mode=True)
if module._name in ('gcpubsub_facts', 'community.general.gcpubsub_facts'):
module.deprecate("The 'gcpubsub_facts' module has been renamed to 'gcpubsub_info'",
version='3.0.0', collection_name='community.general') # was Ansible 2.13

View File

@@ -149,7 +149,7 @@ def main():
api_key=dict(required=True, type='str', no_log=True),
name=dict(required=True, type='str')
),
supports_check_mode=False
supports_check_mode=True,
)
if module._name in ('memset_memstore_facts', 'community.general.memset_memstore_facts'):
module.deprecate("The 'memset_memstore_facts' module has been renamed to 'memset_memstore_info'",

View File

@@ -274,7 +274,7 @@ def main():
api_key=dict(required=True, type='str', no_log=True),
name=dict(required=True, type='str')
),
supports_check_mode=False
supports_check_mode=True,
)
if module._name in ('memset_server_facts', 'community.general.memset_server_facts'):
module.deprecate("The 'memset_server_facts' module has been renamed to 'memset_server_info'",

View File

@@ -243,7 +243,6 @@ except ImportError:
HAS_OVIRTSDK = False
from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils.common.removed import removed_module
# ------------------------------------------------------------------- #

View File

@@ -160,7 +160,9 @@ def get_srs(session):
def main():
module = AnsibleModule({})
module = AnsibleModule(
supports_check_mode=True,
)
if not HAVE_XENAPI:
module.fail_json(changed=False, msg="python xen api required for this module")

View File

@@ -111,7 +111,6 @@ ovirt_affinity_labels:
import fnmatch
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -128,7 +127,7 @@ def main():
host=dict(default=None),
vm=dict(default=None),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_affinity_label_facts', 'community.general.ovirt_affinity_label_facts')
if is_old_facts:
module.deprecate("The 'ovirt_affinity_label_facts' module has been renamed to 'ovirt_affinity_label_info', "

View File

@@ -52,7 +52,6 @@ ovirt_api:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -64,7 +63,7 @@ from ansible_collections.community.general.plugins.module_utils._ovirt import (
def main():
argument_spec = ovirt_info_full_argument_spec()
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_api_facts', 'community.general.ovirt_api_facts')
if is_old_facts:
module.deprecate("The 'ovirt_api_facts' module has been renamed to 'ovirt_api_info', "

View File

@@ -73,7 +73,6 @@ ovirt_clusters:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -87,7 +86,7 @@ def main():
argument_spec = ovirt_info_full_argument_spec(
pattern=dict(default='', required=False),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_cluster_facts', 'community.general.ovirt_cluster_facts')
if is_old_facts:
module.deprecate("The 'ovirt_cluster_facts' module has been renamed to 'ovirt_cluster_info', "

View File

@@ -56,7 +56,6 @@ ovirt_datacenters:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -70,7 +69,7 @@ def main():
argument_spec = ovirt_info_full_argument_spec(
pattern=dict(default='', required=False),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_datacenter_facts', 'community.general.ovirt_datacenter_facts')
if is_old_facts:
module.deprecate("The 'ovirt_datacenter_facts' module has been renamed to 'ovirt_datacenter_info', "

View File

@@ -72,7 +72,6 @@ ovirt_disks:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -86,7 +85,7 @@ def main():
argument_spec = ovirt_info_full_argument_spec(
pattern=dict(default='', required=False),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_disk_facts', 'community.general.ovirt_disk_facts')
if is_old_facts:
module.deprecate("The 'ovirt_disk_facts' module has been renamed to 'ovirt_disk_info', "

View File

@@ -103,7 +103,6 @@ ovirt_events:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -123,7 +122,7 @@ def main():
query=dict(default='', required=False),
wait=dict(default=True, type='bool', required=False)
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_event_facts', 'community.general.ovirt_event_facts')
if is_old_facts:
module.deprecate("The 'ovirt_event_facts' module has been renamed to 'ovirt_event_info', "

View File

@@ -87,7 +87,6 @@ ovirt_external_providers:
import fnmatch
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -117,7 +116,7 @@ def main():
aliases=['provider'],
),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_external_provider_facts', 'community.general.ovirt_external_provider_facts')
if is_old_facts:
module.deprecate("The 'ovirt_external_provider_facts' module has been renamed to 'ovirt_external_provider_info', "

View File

@@ -71,7 +71,6 @@ ovirt_groups:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -85,7 +84,7 @@ def main():
argument_spec = ovirt_info_full_argument_spec(
pattern=dict(default='', required=False),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_group_facts', 'community.general.ovirt_group_facts')
if is_old_facts:
module.deprecate("The 'ovirt_group_facts' module has been renamed to 'ovirt_group_info', "

View File

@@ -78,7 +78,6 @@ ovirt_hosts:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -105,7 +104,7 @@ def main():
all_content=dict(default=False, type='bool'),
cluster_version=dict(default=None, type='str'),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_host_facts', 'community.general.ovirt_host_facts')
if is_old_facts:
module.deprecate("The 'ovirt_host_facts' module has been renamed to 'ovirt_host_info', "

View File

@@ -92,7 +92,6 @@ try:
except ImportError:
pass
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -127,7 +126,7 @@ def main():
iscsi=dict(default=None, type='dict'),
fcp=dict(default=None, type='dict'),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_host_storage_facts', 'community.general.ovirt_host_storage_facts')
if is_old_facts:
module.deprecate("The 'ovirt_host_storage_facts' module has been renamed to 'ovirt_host_storage_info', "

View File

@@ -73,7 +73,6 @@ ovirt_networks:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -87,7 +86,7 @@ def main():
argument_spec = ovirt_info_full_argument_spec(
pattern=dict(default='', required=False),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_network_facts', 'community.general.ovirt_network_facts')
if is_old_facts:
module.deprecate("The 'ovirt_network_facts' module has been renamed to 'ovirt_network_info', "

View File

@@ -76,7 +76,6 @@ ovirt_nics:
import fnmatch
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -92,7 +91,7 @@ def main():
vm=dict(required=True),
name=dict(default=None),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_nic_facts', 'community.general.ovirt_nic_facts')
if is_old_facts:
module.deprecate("The 'ovirt_nic_facts' module has been renamed to 'ovirt_nic_info', "

View File

@@ -88,7 +88,6 @@ try:
except ImportError:
pass
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -129,7 +128,7 @@ def main():
group_name=dict(default=None),
namespace=dict(default=None),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_permission_facts', 'community.general.ovirt_permission_facts')
if is_old_facts:
module.deprecate("The 'ovirt_permission_facts' module has been renamed to 'ovirt_permission_info', "

View File

@@ -76,7 +76,6 @@ ovirt_quotas:
import fnmatch
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -92,7 +91,7 @@ def main():
data_center=dict(required=True),
name=dict(default=None),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_quota_facts', 'community.general.ovirt_quota_facts')
if is_old_facts:
module.deprecate("The 'ovirt_quota_facts' module has been renamed to 'ovirt_quota_info', "

View File

@@ -90,7 +90,7 @@ def main():
id=dict(default=None),
name=dict(default=None),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_scheduling_policy_facts', 'community.general.ovirt_scheduling_policy_facts')
if is_old_facts:
module.deprecate("The 'ovirt_scheduling_policy_facts' module has been renamed to 'ovirt_scheduling_policy_info', "

View File

@@ -65,7 +65,6 @@ ovirt_snapshots:
import fnmatch
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -82,7 +81,7 @@ def main():
description=dict(default=None),
snapshot_id=dict(default=None),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_snapshot_facts', 'community.general.ovirt_snapshot_facts')
if is_old_facts:
module.deprecate("The 'ovirt_snapshot_facts' module has been renamed to 'ovirt_snapshot_info', "

View File

@@ -74,7 +74,6 @@ ovirt_storage_domains:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -88,7 +87,7 @@ def main():
argument_spec = ovirt_info_full_argument_spec(
pattern=dict(default='', required=False),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_storage_domain_facts', 'community.general.ovirt_storage_domain_facts')
if is_old_facts:
module.deprecate("The 'ovirt_storage_domain_facts' module has been renamed to 'ovirt_storage_domain_info', "

View File

@@ -79,7 +79,6 @@ ovirt_storage_templates:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -96,7 +95,7 @@ def main():
max=dict(default=None, type='int'),
unregistered=dict(default=False, type='bool'),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_storage_template_facts', 'community.general.ovirt_storage_template_facts')
if is_old_facts:
module.deprecate("The 'ovirt_storage_template_facts' module has been renamed to 'ovirt_storage_template_info', "

View File

@@ -79,7 +79,6 @@ ovirt_storage_vms:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -96,7 +95,7 @@ def main():
max=dict(default=None, type='int'),
unregistered=dict(default=False, type='bool'),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_storage_vm_facts', 'community.general.ovirt_storage_vm_facts')
if is_old_facts:
module.deprecate("The 'ovirt_storage_vm_facts' module has been renamed to 'ovirt_storage_vm_info', "

View File

@@ -95,7 +95,6 @@ ovirt_tags:
import fnmatch
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -112,7 +111,7 @@ def main():
host=dict(default=None),
vm=dict(default=None),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_tag_facts', 'community.general.ovirt_tag_facts')
if is_old_facts:
module.deprecate("The 'ovirt_tag_facts' module has been renamed to 'ovirt_tag_info', "

View File

@@ -72,7 +72,6 @@ ovirt_templates:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -86,7 +85,7 @@ def main():
argument_spec = ovirt_info_full_argument_spec(
pattern=dict(default='', required=False),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_template_facts', 'community.general.ovirt_template_facts')
if is_old_facts:
module.deprecate("The 'ovirt_template_facts' module has been renamed to 'ovirt_template_info', "

View File

@@ -71,7 +71,6 @@ ovirt_users:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -85,7 +84,7 @@ def main():
argument_spec = ovirt_info_full_argument_spec(
pattern=dict(default='', required=False),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_user_facts', 'community.general.ovirt_user_facts')
if is_old_facts:
module.deprecate("The 'ovirt_user_facts' module has been renamed to 'ovirt_user_info', "

View File

@@ -102,7 +102,6 @@ ovirt_vms:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -120,7 +119,7 @@ def main():
case_sensitive=dict(default=True, type='bool'),
max=dict(default=None, type='int'),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_vm_facts', 'community.general.ovirt_vm_facts')
if is_old_facts:
module.deprecate("The 'ovirt_vm_facts' module has been renamed to 'ovirt_vm_info', "

View File

@@ -71,7 +71,6 @@ ovirt_vm_pools:
import traceback
from ansible.module_utils.common.removed import removed_module
from ansible.module_utils.basic import AnsibleModule
from ansible_collections.community.general.plugins.module_utils._ovirt import (
check_sdk,
@@ -85,7 +84,7 @@ def main():
argument_spec = ovirt_info_full_argument_spec(
pattern=dict(default='', required=False),
)
module = AnsibleModule(argument_spec)
module = AnsibleModule(argument_spec, supports_check_mode=True)
is_old_facts = module._name in ('ovirt_vmpool_facts', 'community.general.ovirt_vmpool_facts')
if is_old_facts:
module.deprecate("The 'ovirt_vmpool_facts' module has been renamed to 'ovirt_vmpool_info', "

View File

@@ -124,6 +124,7 @@ def main():
required_together=rax_required_together(),
mutually_exclusive=[['address', 'id', 'name']],
required_one_of=[['address', 'id', 'name']],
supports_check_mode=True,
)
if not HAS_PYRAX:

View File

@@ -99,7 +99,7 @@ def main():
argument_spec=dict(
filters=dict(default=None),
),
supports_check_mode=False,
supports_check_mode=True,
)
is_old_facts = module._name in ('smartos_image_facts', 'community.general.smartos_image_facts')
if is_old_facts:

View File

@@ -217,7 +217,7 @@ EXAMPLES = '''
datacenter: dal09
tags:
- ansible-module-test
- ansible-module-test-slaves
- ansible-module-test-replicas
hourly: yes
private: no
dedicated: no
@@ -235,7 +235,7 @@ EXAMPLES = '''
datacenter: dal09
tags:
- ansible-module-test
- ansible-module-test-slaves
- ansible-module-test-replicas
hourly: yes
private: no
dedicated: no

View File

@@ -276,7 +276,7 @@ def main():
['username', 'level', 'integrity', 'authkey'],
['privacy', 'privkey'],
),
supports_check_mode=False,
supports_check_mode=True,
)
m_args = module.params

View File

@@ -374,7 +374,7 @@ def main():
},
required_if=[['fact_subset', 'detailed_inventory', ['system_query_options']],
['fact_subset', 'subsystem_health', ['system_query_options']], ],
supports_check_mode=False)
supports_check_mode=True)
try:
_validate_inputs(module.params)

View File

@@ -114,7 +114,10 @@ class DatacenterInfoModule(OneViewModuleBase):
)
def __init__(self):
super(DatacenterInfoModule, self).__init__(additional_arg_spec=self.argument_spec)
super(DatacenterInfoModule, self).__init__(
additional_arg_spec=self.argument_spec,
supports_check_mode=True,
)
self.is_old_facts = self.module._name in ('oneview_datacenter_facts', 'community.general.oneview_datacenter_facts')
if self.is_old_facts:
self.module.deprecate("The 'oneview_datacenter_facts' module has been renamed to 'oneview_datacenter_info', "

View File

@@ -157,7 +157,10 @@ class EnclosureInfoModule(OneViewModuleBase):
argument_spec = dict(name=dict(type='str'), options=dict(type='list'), params=dict(type='dict'))
def __init__(self):
super(EnclosureInfoModule, self).__init__(additional_arg_spec=self.argument_spec)
super(EnclosureInfoModule, self).__init__(
additional_arg_spec=self.argument_spec,
supports_check_mode=True,
)
self.is_old_facts = self.module._name in ('oneview_enclosure_facts', 'community.general.oneview_enclosure_facts')
if self.is_old_facts:
self.module.deprecate("The 'oneview_enclosure_facts' module has been renamed to 'oneview_enclosure_info', "

View File

@@ -112,7 +112,10 @@ class EthernetNetworkInfoModule(OneViewModuleBase):
)
def __init__(self):
super(EthernetNetworkInfoModule, self).__init__(additional_arg_spec=self.argument_spec)
super(EthernetNetworkInfoModule, self).__init__(
additional_arg_spec=self.argument_spec,
supports_check_mode=True,
)
self.is_old_facts = self.module._name in ('oneview_ethernet_network_facts', 'community.general.oneview_ethernet_network_facts')
if self.is_old_facts:
self.module.deprecate("The 'oneview_ethernet_network_facts' module has been renamed to 'oneview_ethernet_network_info', "

View File

@@ -83,7 +83,10 @@ class FcNetworkInfoModule(OneViewModuleBase):
params=dict(required=False, type='dict')
)
super(FcNetworkInfoModule, self).__init__(additional_arg_spec=argument_spec)
super(FcNetworkInfoModule, self).__init__(
additional_arg_spec=argument_spec,
supports_check_mode=True,
)
self.is_old_facts = self.module._name in ('oneview_fc_network_facts', 'community.general.oneview_fc_network_facts')
if self.is_old_facts:
self.module.deprecate("The 'oneview_fc_network_facts' module has been renamed to 'oneview_fc_network_info', "

View File

@@ -82,7 +82,10 @@ class FcoeNetworkInfoModule(OneViewModuleBase):
params=dict(type='dict'),
)
super(FcoeNetworkInfoModule, self).__init__(additional_arg_spec=argument_spec)
super(FcoeNetworkInfoModule, self).__init__(
additional_arg_spec=argument_spec,
supports_check_mode=True,
)
self.is_old_facts = self.module._name in ('oneview_fcoe_network_facts', 'community.general.oneview_fcoe_network_facts')
if self.is_old_facts:
self.module.deprecate("The 'oneview_fcoe_network_facts' module has been renamed to 'oneview_fcoe_network_info', "

View File

@@ -96,7 +96,10 @@ class LogicalInterconnectGroupInfoModule(OneViewModuleBase):
params=dict(type='dict'),
)
super(LogicalInterconnectGroupInfoModule, self).__init__(additional_arg_spec=argument_spec)
super(LogicalInterconnectGroupInfoModule, self).__init__(
additional_arg_spec=argument_spec,
supports_check_mode=True,
)
self.is_old_facts = self.module._name in ('oneview_logical_interconnect_group_facts', 'community.general.oneview_logical_interconnect_group_facts')
if self.is_old_facts:
self.module.deprecate("The 'oneview_logical_interconnect_group_facts' module has been renamed to 'oneview_logical_interconnect_group_info', "

View File

@@ -133,7 +133,10 @@ class NetworkSetInfoModule(OneViewModuleBase):
)
def __init__(self):
super(NetworkSetInfoModule, self).__init__(additional_arg_spec=self.argument_spec)
super(NetworkSetInfoModule, self).__init__(
additional_arg_spec=self.argument_spec,
supports_check_mode=True,
)
self.is_old_facts = self.module._name in ('oneview_network_set_facts', 'community.general.oneview_network_set_facts')
if self.is_old_facts:
self.module.deprecate("The 'oneview_network_set_facts' module has been renamed to 'oneview_network_set_info', "

View File

@@ -90,7 +90,10 @@ class SanManagerInfoModule(OneViewModuleBase):
)
def __init__(self):
super(SanManagerInfoModule, self).__init__(additional_arg_spec=self.argument_spec)
super(SanManagerInfoModule, self).__init__(
additional_arg_spec=self.argument_spec,
supports_check_mode=True,
)
self.resource_client = self.oneview_client.san_managers
self.is_old_facts = self.module._name in ('oneview_san_manager_facts', 'community.general.oneview_san_manager_facts')
if self.is_old_facts:

View File

@@ -178,7 +178,7 @@ def main():
password=dict(required=True, no_log=True),
timeout=dict(type='int', default=10)
),
supports_check_mode=False
supports_check_mode=True,
)
is_old_facts = module._name in ('idrac_redfish_facts', 'community.general.idrac_redfish_facts')
if is_old_facts:

View File

@@ -305,7 +305,7 @@ def main():
password=dict(required=True, no_log=True),
timeout=dict(type='int', default=10)
),
supports_check_mode=False
supports_check_mode=True,
)
is_old_facts = module._name in ('redfish_facts', 'community.general.redfish_facts')
if is_old_facts:

View File

@@ -159,6 +159,7 @@ def main():
name=dict(type='str', required=True, aliases=['volume']),
status_filter=dict(type='str', default='self-heal', choices=['self-heal', 'rebalance']),
),
supports_check_mode=True,
)
is_old_facts = module._name in ('gluster_heal_facts', 'community.general.gluster_heal_facts')
if is_old_facts:

View File

@@ -797,7 +797,7 @@ def main():
gather_subset=dict(default='minimum', type='list',)
))
module = AnsibleModule(argument_spec, supports_check_mode=False)
module = AnsibleModule(argument_spec, supports_check_mode=True)
array = get_system(module)

View File

@@ -110,7 +110,8 @@ def main():
module = UTMModule(
argument_spec=dict(
name=dict(type='str', required=True)
)
),
supports_check_mode=True,
)
try:
UTM(module, endpoint, key_to_check_for_changes, info_only=True).execute()

View File

@@ -88,7 +88,8 @@ def main():
module = UTMModule(
argument_spec=dict(
name=dict(type='str', required=True)
)
),
supports_check_mode=True,
)
try:
# This is needed because the bool value only accepts int values in the backend

View File

@@ -84,7 +84,8 @@ def main():
module = UTMModule(
argument_spec=dict(
name=dict(type='str', required=True)
)
),
supports_check_mode=True,
)
try:
UTM(module, endpoint, key_to_check_for_changes, info_only=True).execute()

View File

@@ -128,8 +128,9 @@ def main():
key_to_check_for_changes = []
module = UTMModule(
argument_spec=dict(
name=dict(type='str', required=True)
)
name=dict(type='str', required=True),
),
supports_check_mode=True,
)
try:
UTM(module, endpoint, key_to_check_for_changes, info_only=True).execute()

View File

@@ -109,8 +109,9 @@ def main():
key_to_check_for_changes = []
module = UTMModule(
argument_spec=dict(
name=dict(type='str', required=True)
)
name=dict(type='str', required=True),
),
supports_check_mode=True,
)
try:
UTM(module, endpoint, key_to_check_for_changes, info_only=True).execute()

View File

@@ -1,43 +0,0 @@
language: python
env:
matrix:
- T=none
matrix:
exclude:
- env: T=none
include:
- env: T=2.11/sanity/1
- env: T=2.11/sanity/2
- env: T=2.11/sanity/3
- env: T=2.11/sanity/4
- env: T=2.10/sanity/1
- env: T=2.10/sanity/2
- env: T=2.10/sanity/3
- env: T=2.10/sanity/4
- env: T=2.9/sanity/1
- env: T=2.9/sanity/2
- env: T=2.9/sanity/3
- env: T=2.9/sanity/4
branches:
except:
- "*-patch-*"
- "revert-*-*"
- "patchback/backports/*"
build:
ci:
- tests/utils/shippable/timing.sh tests/utils/shippable/shippable.sh $T
integrations:
notifications:
- integrationName: email
type: email
on_success: never
on_failure: never
on_start: never
on_pull_request: never

View File

@@ -174,7 +174,7 @@
- name: Test that the file modes were changed
assert:
that:
- "archive_02_gz_stat.changed == False "
- archive_02_gz_stat is not changed
- "archive_02_gz_stat.stat.mode == '0600'"
- "'archived' in archive_bz2_result_02"
- "{{ archive_bz2_result_02['archived']| length}} == 3"
@@ -199,7 +199,7 @@
- name: Test that the file modes were changed
assert:
that:
- "archive_02_zip_stat.changed == False"
- archive_02_zip_stat is not changed
- "archive_02_zip_stat.stat.mode == '0600'"
- "'archived' in archive_zip_result_02"
- "{{ archive_zip_result_02['archived']| length}} == 3"
@@ -224,7 +224,7 @@
- name: Test that the file modes were changed
assert:
that:
- "archive_02_bz2_stat.changed == False"
- archive_02_bz2_stat is not changed
- "archive_02_bz2_stat.stat.mode == '0600'"
- "'archived' in archive_bz2_result_02"
- "{{ archive_bz2_result_02['archived']| length}} == 3"
@@ -248,7 +248,7 @@
- name: Test that the file modes were changed
assert:
that:
- "archive_02_xz_stat.changed == False"
- archive_02_xz_stat is not changed
- "archive_02_xz_stat.stat.mode == '0600'"
- "'archived' in archive_xz_result_02"
- "{{ archive_xz_result_02['archived']| length}} == 3"
@@ -294,7 +294,7 @@
- name: Assert that nonascii tests succeeded
assert:
that:
- "nonascii_result_0.changed == true"
- nonascii_result_0 is changed
- "nonascii_stat0.stat.exists == true"
- name: remove nonascii test
@@ -315,7 +315,7 @@
- name: Assert that nonascii tests succeeded
assert:
that:
- "nonascii_result_1.changed == true"
- nonascii_result_1 is changed
- "nonascii_stat_1.stat.exists == true"
- name: remove nonascii test
@@ -336,7 +336,7 @@
- name: Assert that nonascii tests succeeded
assert:
that:
- "nonascii_result_1.changed == true"
- nonascii_result_1 is changed
- "nonascii_stat_1.stat.exists == true"
- name: remove nonascii test
@@ -357,7 +357,7 @@
- name: Assert that nonascii tests succeeded
assert:
that:
- "nonascii_result_2.changed == true"
- nonascii_result_2 is changed
- "nonascii_stat_2.stat.exists == true"
- name: remove nonascii test

View File

@@ -13,7 +13,7 @@
- name: Verify addition of absent flatpak test result (check mode)
assert:
that:
- "addition_result.changed == true"
- addition_result is changed
msg: "Adding an absent flatpak shall mark module execution as changed"
- name: Test non-existent idempotency of addition of absent flatpak (check mode)
@@ -27,7 +27,7 @@
- name: Verify non-existent idempotency of addition of absent flatpak test result (check mode)
assert:
that:
- "double_addition_result.changed == true"
- double_addition_result is changed
msg: |
Adding an absent flatpak a second time shall still mark module execution
as changed in check mode
@@ -44,7 +44,7 @@
- name: Verify removal of absent flatpak test result (check mode)
assert:
that:
- "removal_result.changed == false"
- removal_result is not changed
msg: "Removing an absent flatpak shall mark module execution as not changed"
# state=present with url on absent flatpak
@@ -60,7 +60,7 @@
- name: Verify addition of absent flatpak with url test result (check mode)
assert:
that:
- "url_addition_result.changed == true"
- url_addition_result is changed
msg: "Adding an absent flatpak from URL shall mark module execution as changed"
- name: Test non-existent idempotency of addition of absent flatpak with url (check mode)
@@ -76,7 +76,7 @@
result (check mode)
assert:
that:
- "double_url_addition_result.changed == true"
- double_url_addition_result is changed
msg: |
Adding an absent flatpak from URL a second time shall still mark module execution
as changed in check mode
@@ -93,7 +93,7 @@
- name: Verify removal of absent flatpak with url test result (check mode)
assert:
that:
- "url_removal_result.changed == false"
- url_removal_result is not changed
msg: "Removing an absent flatpak shall mark module execution as not changed"
@@ -112,7 +112,7 @@
- name: Verify addition test result of present flatpak (check mode)
assert:
that:
- "addition_present_result.changed == false"
- addition_present_result is not changed
msg: "Adding an present flatpak shall mark module execution as not changed"
# state=absent on present flatpak
@@ -127,7 +127,7 @@
- name: Verify removal of present flatpak test result (check mode)
assert:
that:
- "removal_present_result.changed == true"
- removal_present_result is changed
msg: "Removing a present flatpak shall mark module execution as changed"
- name: Test non-existent idempotency of removal (check mode)
@@ -140,7 +140,7 @@
- name: Verify non-existent idempotency of removal (check mode)
assert:
that:
- "double_removal_present_result.changed == true"
- double_removal_present_result is changed
msg: |
Removing a present flatpak a second time shall still mark module execution
as changed in check mode
@@ -158,7 +158,7 @@
- name: Verify addition with url of present flatpak test result (check mode)
assert:
that:
- "url_addition_present_result.changed == false"
- url_addition_present_result is not changed
msg: "Adding a present flatpak from URL shall mark module execution as not changed"
# state=absent with url on present flatpak
@@ -173,7 +173,7 @@
- name: Verify removal with url of present flatpak test result (check mode)
assert:
that:
- "url_removal_present_result.changed == true"
- url_removal_present_result is changed
msg: "Removing an absent flatpak shall mark module execution as not changed"
- name: Test non-existent idempotency of removal with url of present flatpak (check mode)
@@ -189,5 +189,5 @@
flatpak test result (check mode)
assert:
that:
- "double_url_removal_present_result.changed == true"
- double_url_removal_present_result is changed
msg: Removing an absent flatpak a second time shall still mark module execution as changed

View File

@@ -40,8 +40,8 @@
- name: Verify executable override test result
assert:
that:
- "executable_override_result.failed == true"
- "executable_override_result.changed == false"
- executable_override_result is failed
- executable_override_result is not changed
msg: "Specifying non-existing executable shall fail module execution"
- import_tasks: check_mode.yml

View File

@@ -11,7 +11,7 @@
- name: Verify addition test result - {{ method }}
assert:
that:
- "addition_result.changed == true"
- addition_result is changed
msg: "state=present shall add flatpak when absent"
- name: Test idempotency of addition - {{ method }}
@@ -25,7 +25,7 @@
- name: Verify idempotency of addition test result - {{ method }}
assert:
that:
- "double_addition_result.changed == false"
- double_addition_result is not changed
msg: "state=present shall not do anything when flatpak is already present"
# state=absent
@@ -40,7 +40,7 @@
- name: Verify removal test result - {{ method }}
assert:
that:
- "removal_result.changed == true"
- removal_result is changed
msg: "state=absent shall remove flatpak when present"
- name: Test idempotency of removal - {{ method }}
@@ -53,7 +53,7 @@
- name: Verify idempotency of removal test result - {{ method }}
assert:
that:
- "double_removal_result.changed == false"
- double_removal_result is not changed
msg: "state=absent shall not do anything when flatpak is not present"
# state=present with url as name
@@ -69,7 +69,7 @@
- name: Verify addition test result - {{ method }}
assert:
that:
- "url_addition_result.changed == true"
- url_addition_result is changed
msg: "state=present with url as name shall add flatpak when absent"
- name: Test idempotency of addition with url - {{ method }}
@@ -83,7 +83,7 @@
- name: Verify idempotency of addition with url test result - {{ method }}
assert:
that:
- "double_url_addition_result.changed == false"
- double_url_addition_result is not changed
msg: "state=present with url as name shall not do anything when flatpak is already present"
# state=absent with url as name
@@ -98,7 +98,7 @@
- name: Verify removal test result - {{ method }}
assert:
that:
- "url_removal_result.changed == true"
- url_removal_result is changed
msg: "state=absent with url as name shall remove flatpak when present"
- name: Test idempotency of removal with url - {{ method }}
@@ -111,5 +111,5 @@
- name: Verify idempotency of removal with url test result - {{ method }}
assert:
that:
- "double_url_removal_result.changed == false"
- double_url_removal_result is not changed
msg: "state=absent with url as name shall not do anything when flatpak is not present"

View File

@@ -6,4 +6,3 @@ skip/osx
skip/macos
skip/rhel
needs/root
disabled # FIXME

View File

@@ -13,7 +13,7 @@
- name: Verify addition of absent flatpak remote test result (check mode)
assert:
that:
- "addition_result.changed == true"
- addition_result is changed
msg: "Adding an absent flatpak remote shall mark module execution as changed"
- name: Test non-existent idempotency of addition of absent flatpak remote (check mode)
@@ -29,7 +29,7 @@
test result (check mode)
assert:
that:
- "double_addition_result.changed == true"
- double_addition_result is changed
msg: |
Adding an absent flatpak remote a second time shall still mark module execution
as changed in check mode
@@ -46,7 +46,7 @@
- name: Verify removal of absent flatpak remote test result (check mode)
assert:
that:
- "removal_result.changed == false"
- removal_result is not changed
msg: "Removing an absent flatpak remote shall mark module execution as not changed"
@@ -65,7 +65,7 @@
- name: Verify addition of present flatpak remote test result (check mode)
assert:
that:
- "addition_result.changed == false"
- addition_result is not changed
msg: "Adding a present flatpak remote shall mark module execution as not changed"
# state=absent
@@ -80,7 +80,7 @@
- name: Verify removal of present flatpak remote test result (check mode)
assert:
that:
- "removal_result.changed == true"
- removal_result is changed
msg: "Removing a present flatpak remote shall mark module execution as changed"
- name: Test non-existent idempotency of removal of present flatpak remote (check mode)
@@ -95,7 +95,7 @@
test result (check mode)
assert:
that:
- "double_removal_result.changed == true"
- double_removal_result is changed
msg: |
Removing a present flatpak remote a second time shall still mark module execution
as changed in check mode

View File

@@ -40,8 +40,8 @@
- name: Verify executable override test result
assert:
that:
- "executable_override_result.failed == true"
- "executable_override_result.changed == false"
- executable_override_result is failed
- executable_override_result is not changed
msg: "Specifying non-existing executable shall fail module execution"
- import_tasks: check_mode.yml

View File

@@ -11,7 +11,7 @@
- name: Verify addition test result - {{ method }}
assert:
that:
- "addition_result.changed == true"
- addition_result is changed
msg: "state=present shall add flatpak when absent"
- name: Test idempotency of addition - {{ method }}
@@ -25,7 +25,7 @@
- name: Verify idempotency of addition test result - {{ method }}
assert:
that:
- "double_addition_result.changed == false"
- double_addition_result is not changed
msg: "state=present shall not do anything when flatpak is already present"
- name: Test updating remote url does not do anything - {{ method }}
@@ -39,7 +39,7 @@
- name: Verify updating remote url does not do anything - {{ method }}
assert:
that:
- "url_update_result.changed == false"
- url_update_result is not changed
msg: "Trying to update the URL of an existing flatpak remote shall not do anything"
@@ -55,7 +55,7 @@
- name: Verify removal test result - {{ method }}
assert:
that:
- "removal_result.changed == true"
- removal_result is changed
msg: "state=absent shall remove flatpak when present"
- name: Test idempotency of removal - {{ method }}
@@ -68,5 +68,5 @@
- name: Verify idempotency of removal test result - {{ method }}
assert:
that:
- "double_removal_result.changed == false"
- double_removal_result is not changed
msg: "state=absent shall not do anything when flatpak is not present"

View File

@@ -17,9 +17,9 @@
- name: assert set changed and value is correct
assert:
that:
- set_result.changed == true
- set_result is changed
- set_result.diff.before == "\n"
- set_result.diff.after == option_value + "\n"
- get_result.changed == false
- get_result is not changed
- get_result.config_value == option_value
...

View File

@@ -19,9 +19,9 @@
- name: assert set changed and value is correct with state=present
assert:
that:
- set_result.changed == true
- set_result is changed
- set_result.diff.before == "\n"
- set_result.diff.after == option_value + "\n"
- get_result.changed == false
- get_result is not changed
- get_result.config_value == option_value
...

View File

@@ -18,7 +18,7 @@
- name: assert unset changed and deleted value
assert:
that:
- unset_result.changed == true
- unset_result is changed
- unset_result.diff.before == option_value + "\n"
- unset_result.diff.after == "\n"
- get_result.config_value == ''

View File

@@ -18,7 +18,7 @@
- name: assert unset changed but dit not delete value
assert:
that:
- unset_result.changed == true
- unset_result is changed
- unset_result.diff.before == option_value + "\n"
- unset_result.diff.after == "\n"
- get_result.config_value == option_value

View File

@@ -17,7 +17,7 @@
- name: assert unsetting didn't change
assert:
that:
- unset_result.changed == false
- unset_result is not changed
- unset_result.msg == 'no setting to unset'
- get_result.config_value == ''
...

View File

@@ -17,7 +17,7 @@
- name: assert unset changed and deleted value
assert:
that:
- unset_result.changed == true
- unset_result is changed
- unset_result.diff.before == option_value + "\n"
- unset_result.diff.after == "\n"
- get_result.config_value == ''

View File

@@ -18,8 +18,8 @@
- assert:
that:
- "{{ get_status_0002.changed == True }}"
- "{{ get_status_0002.issue_status == 'closed' }}"
- get_status_0002 is changed
- get_status_0002.issue_status == 'closed'
- name: Check if GitHub issue is closed or not
github_issue:
@@ -32,6 +32,6 @@
- assert:
that:
- "{{ get_status_0003.changed == False }}"
- "{{ get_status_0003.failed == True }}"
- "{{ 'Failed' in get_status_0003.msg }}"
- get_status_0003 is not changed
- get_status_0003 is failed
- "'Failed' in get_status_0003.msg"

View File

@@ -167,8 +167,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#----------------------------------------------------------
- name: delete a instance (check mode)
hwc_ecs_instance:
@@ -277,8 +277,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#---------------------------------------------------------
# Post-test teardown
- name: delete a disk

View File

@@ -50,8 +50,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#----------------------------------------------------------
- name: delete a disk (check mode)
hwc_evs_disk:
@@ -92,7 +92,7 @@
- name: assert changed is false
assert:
that:
- result.changed == false
- result is not changed
# ----------------------------------------------------------------------------
- name: delete a disk that does not exist
hwc_evs_disk:
@@ -105,5 +105,5 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed

View File

@@ -62,8 +62,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#----------------------------------------------------------
- name: delete a vpc
hwc_network_vpc:
@@ -97,5 +97,5 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed

View File

@@ -44,8 +44,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#----------------------------------------------------------
- name: delete a smn topic
hwc_smn_topic:
@@ -77,5 +77,5 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed

View File

@@ -96,8 +96,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#----------------------------------------------------------
- name: delete a eip (check mode)
hwc_vpc_eip:
@@ -159,8 +159,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#---------------------------------------------------------
# Post-test teardown
- name: delete a port

View File

@@ -78,8 +78,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#----------------------------------------------------------
- name: delete a peering connect (check mode)
hwc_vpc_peering_connect:
@@ -133,8 +133,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#---------------------------------------------------------
# Post-test teardown
- name: delete a vpc

View File

@@ -69,8 +69,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#----------------------------------------------------------
- name: delete a port (check mode)
hwc_vpc_port:
@@ -116,8 +116,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#---------------------------------------------------------
# Post-test teardown
- name: delete a subnet

View File

@@ -70,8 +70,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#----------------------------------------------------------
- name: delete a private ip (check mode)
hwc_vpc_private_ip:
@@ -117,8 +117,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#---------------------------------------------------------
# Post-test teardown
- name: delete a subnet

View File

@@ -81,8 +81,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#----------------------------------------------------------
- name: delete a route (check mode)
hwc_vpc_route:
@@ -127,8 +127,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#---------------------------------------------------------
# Post-test teardown
- name: delete a peering connect

View File

@@ -51,8 +51,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#----------------------------------------------------------
- name: delete a security group (check mode)
hwc_vpc_security_group:
@@ -83,5 +83,5 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed

View File

@@ -85,8 +85,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#----------------------------------------------------------
- name: delete a security group rule (check mode)
hwc_vpc_security_group_rule:
@@ -151,8 +151,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#---------------------------------------------------------
# Post-test teardown
- name: delete a security group

View File

@@ -77,8 +77,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#----------------------------------------------------------
- name: delete a subnet (check mode)
hwc_vpc_subnet:
@@ -136,8 +136,8 @@
- name: assert changed is false
assert:
that:
- result.failed == 0
- result.changed == false
- result is not failed
- result is not changed
#---------------------------------------------------------
# Post-test teardown
- name: delete a vpc

View File

@@ -13,7 +13,7 @@
- name: Check that admin user adding succeeds with a change
assert:
that:
- add_admin_user.changed == true
- add_admin_user is changed
- name: Test add admin user
block:
@@ -24,7 +24,7 @@
- name: Check that admin user adding succeeds with a change
assert:
that:
- add_admin_user.changed == true
- add_admin_user is changed
- name: Test add admin user idempotence
block:
@@ -35,7 +35,7 @@
- name: Check that admin user adding succeeds without a change
assert:
that:
- add_admin_user.changed == false
- add_admin_user is not changed
- name: Enable authentication and restart service
block:
@@ -58,7 +58,7 @@
- name: Check that adding user with enabled authentication succeeds with a change
assert:
that:
- add_user_with_auth_enabled.changed == true
- add_user_with_auth_enabled is changed
- name: Test add user when authentication enabled
block:
@@ -69,7 +69,7 @@
- name: Check that adding user with enabled authentication succeeds with a change
assert:
that:
- add_user_with_auth_enabled.changed == true
- add_user_with_auth_enabled is changed
- name: Test add user when authentication enabled idempotence
block:
@@ -80,7 +80,7 @@
- name: Check that adding same user succeeds without a change
assert:
that:
- same_user.changed == false
- same_user is not changed
- name: Test change user password in check mode
block:
@@ -92,7 +92,7 @@
- name: Check that password changing succeeds with a change
assert:
that:
- change_password.changed == true
- change_password is changed
- name: Test change user password
block:
@@ -103,7 +103,7 @@
- name: Check that password changing succeeds with a change
assert:
that:
- change_password.changed == true
- change_password is changed
- name: Test remove user in check mode
block:
@@ -115,7 +115,7 @@
- name: Check that removing user succeeds with a change
assert:
that:
- remove_user.changed == true
- remove_user is changed
- name: Test remove user
block:
@@ -126,7 +126,7 @@
- name: Check that removing user succeeds with a change
assert:
that:
- remove_user.changed == true
- remove_user is changed
- name: Test remove user idempotence
block:
@@ -137,4 +137,4 @@
- name: Check that removing user succeeds without a change
assert:
that:
- remove_user.changed == false
- remove_user is not changed

View File

@@ -1 +1,2 @@
setuptools < 45 ; python_version <= '2.7' # setuptools 45 and later require python 3.5 or later
ruamel.yaml.clib <= 0.2.2 ; python_version <= '2.7' # 0.2.4 require python 3.5 or later, 0.2.3 is yanked

View File

@@ -41,6 +41,6 @@
- name: check if task was successful
assert:
that:
- "{{ external_ip.changed == false }}"
- "{{ external_ip['ansible_facts'] is defined }}"
- "{{ external_ip['ansible_facts']['ipify_public_ip'] is defined }}"
- external_ip is not changed
- external_ip.ansible_facts is defined
- external_ip.ansible_facts.ipify_public_ip is defined

View File

@@ -35,7 +35,7 @@
- debug: var=iso_file
- assert:
that:
- iso_result.changed == True
- iso_result is changed
- iso_file.stat.exists == False
- name: Create iso file with a specified file
@@ -54,7 +54,7 @@
- assert:
that:
- iso_result.changed == True
- iso_result is changed
- iso_file.stat.exists == True
- name: Create iso file with a specified file and folder
@@ -74,10 +74,10 @@
- assert:
that:
- iso_result.changed == True
- iso_result is changed
- iso_file.stat.exists == True
- name: Create iso file with volume identification string
- name: Create iso file with volume identification string
iso_create:
src_files:
- "{{ role_path }}/files/test1.cfg"
@@ -93,7 +93,7 @@
- assert:
that:
- iso_result.changed == True
- iso_result is changed
- iso_file.stat.exists == True
- name: Create iso file with Rock Ridge extention
@@ -112,7 +112,7 @@
- assert:
that:
- iso_result.changed == True
- iso_result is changed
- iso_file.stat.exists == True
- name: Create iso file with Joliet extention
@@ -131,7 +131,7 @@
- assert:
that:
- iso_result.changed == True
- iso_result is changed
- iso_file.stat.exists == True
- name: Create iso file with UDF enabled
@@ -150,5 +150,5 @@
- assert:
that:
- iso_result.changed == True
- iso_result is changed
- iso_file.stat.exists == True

View File

@@ -28,7 +28,7 @@
- assert:
that:
- iso_extract_test0 is changed == true
- iso_extract_test0 is changed
- name: Extract the iso again
iso_extract:
@@ -42,11 +42,11 @@
- name: Test iso_extract_test0_again (normal mode)
assert:
that:
- iso_extract_test0_again is changed == false
- iso_extract_test0_again is not changed
when: not in_check_mode
- name: Test iso_extract_test0_again (check-mode)
assert:
that:
- iso_extract_test0_again is changed == true
- iso_extract_test0_again is changed
when: in_check_mode

View File

@@ -3,3 +3,5 @@ destructive
skip/aix
skip/rhel
skip/python2.6 # lookups are controller only, and we no longer support Python 2.6 on the controller
skip/osx # FIXME https://github.com/ansible-collections/community.general/issues/2978
skip/macos # FIXME https://github.com/ansible-collections/community.general/issues/2978

Some files were not shown because too many files have changed in this diff Show More