internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-06 13:22:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

seport.py: fix the "change" indication

Browse Source
This commit is contained in:
Dan Keder
2015-05-27 16:30:49 +02:00
committed by Matt Clay
parent cda2aeb6c0
commit f7d1d35709
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/ansible/modules/extras/system/seport.py
View File

@@ -134,10 +134,12 @@ def semanage_port_add(module, ports, proto, setype, do_reload, serange='s0', ses
try:
seport = seobject.portRecords(sestore)
seport.set_reload(do_reload)
change = False
for port in ports:
change = not semanage_port_exists(seport, port, proto)
if change and not module.check_mode:
exists = semanage_port_exists(seport, port, proto)
if not exists and not module.check_mode:
seport.add(port, proto, serange, setype)
change = change or not exists
except ValueError as e:
module.fail_json(msg="%s: %s\n" % (e.__class__.__name__, str(e)))
@@ -177,10 +179,12 @@ def semanage_port_del(module, ports, proto, do_reload, sestore=''):
try:
seport = seobject.portRecords(sestore)
seport.set_reload(do_reload)
change = False
for port in ports:
change = not semanage_port_exists(seport, port, proto)
if change and not module.check_mode:
exists = semanage_port_exists(seport, port, proto)
if not exists and not module.check_mode:
seport.delete(port, proto)
change = change or not exists
except ValueError as e:
module.fail_json(msg="%s: %s\n" % (e.__class__.__name__, str(e)))