internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-06 13:22:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Indicate thirsty argument required if dest is dir.

Browse Source 
The check for the destination being a directory is now done before
checking if the file exists, that way the user is informed that the
thirsty argument is required.
This commit is contained in:
Ali Asad Lotia
2012-09-14 08:02:30 +01:00
parent 16bf3e15c7
commit 99746d4a83
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
library/get_url
View File

@@ -145,11 +145,10 @@ def main():
thirsty = module.boolean(module.params['thirsty'])
if not thirsty:
if os.path.exists(dest):
module.exit_json(msg="file already exists", changed=False)
if os.path.isdir(dest):
module.fail_json(msg="non-thirsty mode needs a filename for a destination, not a directory")
if os.path.exists(dest):
module.exit_json(msg="file already exists", changed=False)
# download to tmpsrc
tmpsrc, info = url_get(module, url, dest)