mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-05-06 13:22:48 +00:00
Provide a proper error when the provided port is not an integer
As reported on the mailinglist, the user received a ValueError when the port number was not templated (fixed in #1649) and therefore it was not an integer. This change will catch the exception and provide a proper error so it is more clear.
This commit is contained in:
@@ -382,6 +382,11 @@ class Runner(object):
|
||||
try:
|
||||
if actual_port is not None:
|
||||
actual_port = int(actual_port)
|
||||
except ValueError, e:
|
||||
result = dict(failed=True, msg="FAILED: Configured port \"%s\" is not a valid port, expected integer" % actual_port)
|
||||
return ReturnData(host=host, comm_ok=False, result=result)
|
||||
|
||||
try:
|
||||
conn = self.connector.connect(actual_host, actual_port)
|
||||
if delegate_to or host != actual_host:
|
||||
conn.delegate = host
|
||||
|
||||
Reference in New Issue
Block a user