internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-03-31 15:53:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add a note about the limitations of a namespace check

Browse Source
This commit is contained in:
Marko Stanković
2017-09-15 11:00:04 +02:00
committed by Dag Wieers
parent 16ca412bd7
commit 85649876d0
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/ansible/modules/files/xml.py
View File

@@ -546,6 +546,8 @@ def set_target_inner(module, tree, xpath, namespaces, attribute, value):
changed = check_or_make_target(module, tree, xpath, namespaces)
except Exception as e:
missing_namespace = ""
# NOTE: This checks only the namespaces defined in root element!
# TODO: Implement a more robust check to check for child namespaces' existance
if len(tree.getroot().nsmap) > 0 and ":" not in xpath:
missing_namespace = "XML document has namespace(s) defined, but no namespace prefix(es) used in xpath!\n"
module.fail_json(msg="%sXpath %s causes a failure: %s\n -- tree is %s" %