Improve types and make type checking happy.

This commit is contained in:
Felix Fontein
2025-12-01 07:30:13 +01:00
parent f4aeb65189
commit 6093707842
2 changed files with 8 additions and 12 deletions

View File

@@ -183,6 +183,7 @@ logs:
"""
import os
import typing as t
from urllib.parse import urlencode
from ansible.module_utils.basic import AnsibleModule
@@ -246,19 +247,16 @@ class LXDStoragePoolInfo:
self.trust_password = self.module.params["trust_password"]
def _fail_from_lxd_exception(self, exception: LXDClientException) -> None:
def _fail_from_lxd_exception(self, exception: LXDClientException) -> t.NoReturn:
"""Build failure parameters from LXDClientException and fail.
:param exception: The LXDClientException instance
:type exception: LXDClientException
"""
fail_params = {
"msg": exception.msg,
"changed": False,
}
fail_params = {}
if self.client.debug and "logs" in exception.kwargs:
fail_params["logs"] = exception.kwargs["logs"]
self.module.fail_json(**fail_params)
self.module.fail_json(msg=exception.msg, changed=False, **fail_params)
def _build_url(self, endpoint: str) -> str:
"""Build URL with project parameter if specified."""

View File

@@ -188,6 +188,7 @@ logs:
"""
import os
import typing as t
from urllib.parse import quote, urlencode
from ansible.module_utils.basic import AnsibleModule
@@ -252,19 +253,16 @@ class LXDStorageVolumeInfo:
self.trust_password = self.module.params["trust_password"]
def _fail_from_lxd_exception(self, exception: LXDClientException) -> None:
def _fail_from_lxd_exception(self, exception: LXDClientException) -> t.NoReturn:
"""Build failure parameters from LXDClientException and fail.
:param exception: The LXDClientException instance
:type exception: LXDClientException
"""
fail_params = {
"msg": exception.msg,
"changed": False,
}
fail_params = {}
if self.client.debug and "logs" in exception.kwargs:
fail_params["logs"] = exception.kwargs["logs"]
self.module.fail_json(**fail_params)
self.module.fail_json(msg=exception.msg, changed=False, **fail_params)
def _build_url(self, endpoint: str) -> str:
"""Build URL with project parameter if specified."""