internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-06 13:22:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

If the private_ip has been provided for the new network interface it shouldn't also be added to top level parameters for run_instances (#52579)

Browse Source 
changelog
This commit is contained in:
Sloane Hertel
2019-03-04 12:55:37 -06:00
committed by GitHub
parent 239fb1f68d
commit 4cf7854ca3
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
changelogs/fragments/ec2_fix_assigning_private_without_public_ip.yml Normal file
View File

@@ -0,0 +1,3 @@
bugfixes:
- ec2 - if the private_ip has been provided for the new network interface it shouldn't also be added to top level
parameters for run_instances()

2
lib/ansible/modules/cloud/amazon/ec2.py
View File

@@ -1112,7 +1112,7 @@ def create_instances(module, ec2, vpc, override_count=None):
# check to see if we're using spot pricing first before starting instances
if not spot_price:
if assign_public_ip and private_ip:
if assign_public_ip is not None and private_ip:
params.update(
dict(
min_count=count_remaining,