mirror of
https://github.com/ansible-collections/community.general.git
synced 2026-05-06 13:22:48 +00:00
Ensure that a download failure is properly raised before the read fails
Without this change, a download failure may bail out with the message:
"Failure downloading http://foo/bar, 'NoneType' object has no attribute 'read'"
whereas with this fix, you'd get a proper error like:
"Failure downloading http://foo/bar, Request failed: <urlopen error [Errno 113] No route to host>"
or one of the many other possible download errors that can occur.
This commit is contained in:
@@ -282,6 +282,9 @@ def main():
|
||||
package = os.path.join(tempdir, str(src.rsplit('/', 1)[1]))
|
||||
try:
|
||||
rsp, info = fetch_url(module, src)
|
||||
# If download fails, raise a proper exception
|
||||
if rsp is None:
|
||||
raise Exception(info['msg'])
|
||||
f = open(package, 'w')
|
||||
# Read 1kb at a time to save on ram
|
||||
while True:
|
||||
|
||||
Reference in New Issue
Block a user