internet/community.general
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.general.git synced 2026-05-06 05:12:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

cloudflare_dns: Improve error handling (#2470)

Browse Source 
Use the new "body" field of the info dict in case of a HTTPError.
This commit is contained in:
Michael Grüner
2016-06-23 22:15:55 +02:00
committed by Matt Clay
parent 6972df76ef
commit 1ecdb7061b
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/ansible/modules/extras/network/cloudflare_dns.py
View File

@@ -349,11 +349,17 @@ class CloudflareAPI(object):
result = None
try:
content = resp.read()
result = json.loads(content)
except AttributeError:
error_msg += "; The API response was empty"
except json.JSONDecodeError:
error_msg += "; Failed to parse API response: {0}".format(content)
if info['body']:
content = info['body']
else:
error_msg += "; The API response was empty"
if content:
try:
result = json.loads(content)
except json.JSONDecodeError:
error_msg += "; Failed to parse API response: {0}".format(content)
# received an error status but no data with details on what failed
if (info['status'] not in [200,304]) and (result is None):