Release 1.9.21.

Do extra docs validation; explicitly disallow semantic markup in docs (#593 ) (#594 )
* Do extra docs validation. Explicitly disallow semantic markup in docs. * Forgot to add new requirement. * Improve test. * TEMP - make CI fail. * Revert "TEMP - make CI fail." This reverts commit a71b8901c1. * Remove unnecessary import. * Make sure ANSIBLE_COLLECTIONS_PATH is set. * Make sure sanity tests from older Ansible versions don't complain. (cherry picked from commit ceabef7e58) Co-authored-by: Felix Fontein <felix@fontein.de>
2026-05-06 13:22:58 +00:00 · 2023-04-16 19:47:19 +02:00 · 2023-04-16 18:55:26 +02:00 · 2023-04-09 14:27:39 +02:00 · 2023-03-22 21:30:53 +01:00 · 2023-03-21 18:02:40 +01:00
29 changed files with 396 additions and 232 deletions
--- a/.azure-pipelines/azure-pipelines.yml
+++ b/.azure-pipelines/azure-pipelines.yml
@@ -71,39 +71,6 @@ stages:
              test: '2.12/sanity/1'
            - name: Units
              test: '2.12/units/1'
-  - stage: Ansible_2_11
-    displayName: Sanity & Units 2.11
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          targets:
-            - name: Sanity
-              test: '2.11/sanity/1'
-            - name: Units
-              test: '2.11/units/1'
-  - stage: Ansible_2_10
-    displayName: Sanity & Units 2.10
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          targets:
-            - name: Sanity
-              test: '2.10/sanity/1'
-            - name: Units
-              test: '2.10/units/1'
-  - stage: Ansible_2_9
-    displayName: Sanity & Units 2.9
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          targets:
-            - name: Sanity
-              test: '2.9/sanity/1'
-            - name: Units
-              test: '2.9/units/1'
 ### Docker
  - stage: Docker_2_13
    displayName: Docker 2.13
@@ -143,54 +110,6 @@ stages:
              test: opensuse15
            - name: Ubuntu 20.04
              test: ubuntu2004
-  - stage: Docker_2_11
-    displayName: Docker 2.11
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.11/linux/{0}/1
-          targets:
-            - name: CentOS 7
-              test: centos7
-            - name: Fedora 32
-              test: fedora32
-            - name: openSUSE 15 py2
-              test: opensuse15py2
-            - name: Ubuntu 18.04
-              test: ubuntu1804
-  - stage: Docker_2_10
-    displayName: Docker 2.10
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.10/linux/{0}/1
-          targets:
-            - name: CentOS 6
-              test: centos6
-            - name: Fedora 31
-              test: fedora31
-            - name: Ubuntu 16.04
-              test: ubuntu1604
-  - stage: Docker_2_9
-    displayName: Docker 2.9
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.9/linux/{0}/1
-          targets:
-            - name: CentOS 6
-              test: centos6
-            - name: CentOS 7
-              test: centos7
-            - name: Fedora 31
-              test: fedora31
-            - name: Ubuntu 16.04
-              test: ubuntu1604
-            - name: Ubuntu 18.04
-              test: ubuntu1804

 ### Remote
  - stage: Remote_2_13
@@ -225,42 +144,6 @@ stages:
              test: rhel/8.4
            - name: FreeBSD 13.0
              test: freebsd/13.0
-  - stage: Remote_2_11
-    displayName: Remote 2.11
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.11/{0}/1
-          targets:
-            - name: RHEL 7.9
-              test: rhel/7.9
-            - name: RHEL 8.3
-              test: rhel/8.3
-            - name: FreeBSD 12.2
-              test: freebsd/12.2
-  - stage: Remote_2_10
-    displayName: Remote 2.10
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.10/{0}/1
-          targets:
-            - name: OS X 10.11
-              test: osx/10.11
-            # - name: macOS 10.15
-            #   test: macos/10.15
-  - stage: Remote_2_9
-    displayName: Remote 2.9
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.9/{0}/1
-          targets:
-            - name: 'RHEL 7.8'
-              test: 'rhel/7.8'
 ### cloud
  - stage: Cloud_2_13
    displayName: Cloud 2.13
@@ -289,36 +172,6 @@ stages:
          targets:
            - test: 2.6
            - test: 3.9
-  - stage: Cloud_2_11
-    displayName: Cloud 2.11
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: 2.11/cloud/{0}/1
-          targets:
-            - test: 3.8
-  - stage: Cloud_2_10
-    displayName: Cloud 2.10
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: 2.10/cloud/{0}/1
-          targets:
-            - test: 3.6
-  - stage: Cloud_2_9
-    displayName: Cloud 2.9
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: Python {0}
-          testFormat: 2.9/cloud/{0}/1
-          targets:
-            - test: 2.7

  ## Finally

@@ -327,23 +180,11 @@ stages:
    dependsOn:
      - Ansible_2_13
      - Ansible_2_12
-      - Ansible_2_11
-      - Ansible_2_10
-      - Ansible_2_9
      - Remote_2_13
      - Remote_2_12
-      - Remote_2_11
-      - Remote_2_10
-      - Remote_2_9
      - Docker_2_13
      - Docker_2_12
-      - Docker_2_11
-      - Docker_2_10
-      - Docker_2_9
      - Cloud_2_13
      - Cloud_2_12
-      - Cloud_2_11
-      - Cloud_2_10
-      - Cloud_2_9
    jobs:
      - template: templates/coverage.yml
--- a/.github/workflows/ansible-test.yml
+++ b/.github/workflows/ansible-test.yml
@@ -0,0 +1,186 @@
+---
+# Copyright (c) Ansible Project
+# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
+# SPDX-License-Identifier: GPL-3.0-or-later
+
+name: EOL CI
+on:
+  # Run EOL CI against all pushes (direct commits, also merged PRs), Pull Requests
+  push:
+    branches:
+      - stable-1
+  pull_request:
+
+concurrency:
+  # Make sure there is at most one active run per PR, but do not cancel any non-PR runs
+  group: ${{ github.workflow }}-${{ (github.head_ref && github.event.number) || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  sanity:
+    name: EOL Sanity (Ⓐ${{ matrix.ansible }})
+    strategy:
+      matrix:
+        ansible:
+          - '2.9'
+          - '2.10'
+          - '2.11'
+    # Ansible-test on various stable branches does not yet work well with cgroups v2.
+    # Since ubuntu-latest now uses Ubuntu 22.04, we need to fall back to the ubuntu-20.04
+    # image for these stable branches. The list of branches where this is necessary will
+    # shrink over time, check out https://github.com/ansible-collections/news-for-maintainers/issues/28
+    # for the latest list.
+    runs-on: >-
+      ${{ contains(fromJson(
+          '["2.9", "2.10", "2.11"]'
+      ), matrix.ansible) && 'ubuntu-20.04' || 'ubuntu-latest' }}
+    steps:
+      - name: Perform sanity testing
+        uses: felixfontein/ansible-test-gh-action@main
+        with:
+          ansible-core-version: stable-${{ matrix.ansible }}
+          coverage: ${{ github.event_name == 'schedule' && 'always' || 'never' }}
+          pull-request-change-detection: 'true'
+          testing-type: sanity
+
+  units:
+    # Ansible-test on various stable branches does not yet work well with cgroups v2.
+    # Since ubuntu-latest now uses Ubuntu 22.04, we need to fall back to the ubuntu-20.04
+    # image for these stable branches. The list of branches where this is necessary will
+    # shrink over time, check out https://github.com/ansible-collections/news-for-maintainers/issues/28
+    # for the latest list.
+    runs-on: >-
+      ${{ contains(fromJson(
+          '["2.9", "2.10", "2.11"]'
+      ), matrix.ansible) && 'ubuntu-20.04' || 'ubuntu-latest' }}
+    name: EOL Units (Ⓐ${{ matrix.ansible }})
+    strategy:
+      # As soon as the first unit test fails, cancel the others to free up the CI queue
+      fail-fast: true
+      matrix:
+        ansible:
+          - '2.9'
+          - '2.10'
+          - '2.11'
+
+    steps:
+      - name: >-
+          Perform unit testing against
+          Ansible version ${{ matrix.ansible }}
+        uses: felixfontein/ansible-test-gh-action@main
+        with:
+          ansible-core-version: stable-${{ matrix.ansible }}
+          coverage: ${{ github.event_name == 'schedule' && 'always' || 'never' }}
+          pull-request-change-detection: 'true'
+          testing-type: units
+
+  integration:
+    # Ansible-test on various stable branches does not yet work well with cgroups v2.
+    # Since ubuntu-latest now uses Ubuntu 22.04, we need to fall back to the ubuntu-20.04
+    # image for these stable branches. The list of branches where this is necessary will
+    # shrink over time, check out https://github.com/ansible-collections/news-for-maintainers/issues/28
+    # for the latest list.
+    runs-on: >-
+      ${{ contains(fromJson(
+          '["2.9", "2.10", "2.11"]'
+      ), matrix.ansible) && 'ubuntu-20.04' || 'ubuntu-latest' }}
+    name: EOL I (Ⓐ${{ matrix.ansible }}+${{ matrix.docker }}+py${{ matrix.python }}:${{ matrix.target }})
+    strategy:
+      fail-fast: false
+      matrix:
+        ansible:
+          - ''
+        docker:
+          - ''
+        python:
+          - ''
+        target:
+          - ''
+        exclude:
+          - ansible: ''
+        include:
+          # 2.9
+          - ansible: '2.9'
+            docker: centos6
+            python: ''
+            target: shippable/posix/group1/
+          - ansible: '2.9'
+            docker: centos7
+            python: ''
+            target: shippable/posix/group1/
+          - ansible: '2.9'
+            docker: fedora31
+            python: ''
+            target: shippable/posix/group1/
+          - ansible: '2.9'
+            docker: ubuntu1604
+            python: ''
+            target: shippable/posix/group1/
+          - ansible: '2.9'
+            docker: ubuntu1804
+            python: ''
+            target: shippable/posix/group1/
+          - ansible: '2.9'
+            docker: default
+            python: '2.7'
+            target: shippable/cloud/group1/
+          # 2.10
+          - ansible: '2.10'
+            docker: centos6
+            python: ''
+            target: shippable/posix/group1/
+          - ansible: '2.10'
+            docker: fedora31
+            python: ''
+            target: shippable/posix/group1/
+          - ansible: '2.10'
+            docker: ubuntu1604
+            python: ''
+            target: shippable/posix/group1/
+          - ansible: '2.10'
+            docker: default
+            python: '3.6'
+            target: shippable/cloud/group1/
+          # 2.11
+          - ansible: '2.11'
+            docker: centos7
+            python: ''
+            target: shippable/posix/group1/
+          - ansible: '2.11'
+            docker: fedora32
+            python: ''
+            target: shippable/posix/group1/
+          - ansible: '2.11'
+            docker: opensuse15py2
+            python: ''
+            target: shippable/posix/group1/
+          - ansible: '2.11'
+            docker: ubuntu1804
+            python: ''
+            target: shippable/posix/group1/
+          - ansible: '2.11'
+            docker: default
+            python: '3.8'
+            target: shippable/cloud/group1/
+
+    steps:
+      - name: >-
+          Perform integration testing against
+          Ansible version ${{ matrix.ansible }}
+          under Python ${{ matrix.python }}
+        uses: felixfontein/ansible-test-gh-action@main
+        with:
+          ansible-core-version: stable-${{ matrix.ansible }}
+          coverage: ${{ github.event_name == 'schedule' && 'always' || 'never' }}
+          docker-image: ${{ matrix.docker }}
+          integration-continue-on-error: 'false'
+          integration-diff: 'false'
+          integration-retry-on-error: 'true'
+          pre-test-cmd: >-
+            git clone --depth=1 --single-branch https://github.com/ansible-collections/community.internal_test_tools.git ../../community/internal_test_tools
+            ;
+            git clone --depth=1 --single-branch https://github.com/ansible-collections/community.general.git ../../community/general
+          pull-request-change-detection: 'true'
+          target: ${{ matrix.target }}
+          target-python-version: ${{ matrix.python }}
+          testing-type: integration
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -5,6 +5,46 @@ Community Crypto Release Notes
 .. contents:: Topics


+v1.9.21
+=======
+
+Release Summary
+---------------
+
+Bugfix release.
+
+Bugfixes
+--------
+
+- action plugin helper - fix handling of deprecations for ansible-core 2.14.2 (https://github.com/ansible-collections/community.crypto/pull/572).
+- openssl_csr, openssl_csr_pipe - prevent invalid values for ``crl_distribution_points`` that do not have one of ``full_name``, ``relative_name``, and ``crl_issuer`` (https://github.com/ansible-collections/community.crypto/pull/560).
+
+v1.9.20
+=======
+
+Release Summary
+---------------
+
+Bugfix release.
+
+Bugfixes
+--------
+
+- openssl_publickey_info - do not crash with internal error when public key cannot be parsed (https://github.com/ansible-collections/community.crypto/pull/551).
+
+v1.9.19
+=======
+
+Release Summary
+---------------
+
+Bugfix release.
+
+Bugfixes
+--------
+
+- openssl_privatekey_pipe - ensure compatibility with newer versions of ansible-core (https://github.com/ansible-collections/community.crypto/pull/515).
+
 v1.9.18
 =======

--- a/changelogs/changelog.yaml
+++ b/changelogs/changelog.yaml
@@ -660,6 +660,16 @@ releases:
    - 1.9.18.yml
    - 487-openssl_pkcs12-other-certs-crash.yml
    release_date: '2022-07-09'
+  1.9.19:
+    changes:
+      bugfixes:
+      - openssl_privatekey_pipe - ensure compatibility with newer versions of ansible-core
+        (https://github.com/ansible-collections/community.crypto/pull/515).
+      release_summary: Bugfix release.
+    fragments:
+    - 1.9.19.yml
+    - 515-action-module-compat.yml
+    release_date: '2022-11-01'
  1.9.2:
    changes:
      release_summary: Bugfix release to fix the changelog. No other change compared
@@ -667,6 +677,30 @@ releases:
    fragments:
    - 1.9.2.yml
    release_date: '2021-08-30'
+  1.9.20:
+    changes:
+      bugfixes:
+      - openssl_publickey_info - do not crash with internal error when public key
+        cannot be parsed (https://github.com/ansible-collections/community.crypto/pull/551).
+      release_summary: Bugfix release.
+    fragments:
+    - 1.9.20.yml
+    - 551-publickey-info.yml
+    release_date: '2023-01-01'
+  1.9.21:
+    changes:
+      bugfixes:
+      - action plugin helper - fix handling of deprecations for ansible-core 2.14.2
+        (https://github.com/ansible-collections/community.crypto/pull/572).
+      - openssl_csr, openssl_csr_pipe - prevent invalid values for ``crl_distribution_points``
+        that do not have one of ``full_name``, ``relative_name``, and ``crl_issuer``
+        (https://github.com/ansible-collections/community.crypto/pull/560).
+      release_summary: Bugfix release.
+    fragments:
+    - 1.9.21.yml
+    - 560-openssl_csr-crl_distribution_points.yml
+    - 572-action-module.yml
+    release_date: '2023-04-16'
  1.9.3:
    changes:
      bugfixes:
--- a/galaxy.yml
+++ b/galaxy.yml
@@ -1,6 +1,6 @@
 namespace: community
 name: crypto
-version: 1.9.18
+version: 1.9.21
 readme: README.md
 authors:
  - Ansible (github.com/ansible)
--- a/plugins/doc_fragments/module_certificate.py
+++ b/plugins/doc_fragments/module_certificate.py
@@ -45,7 +45,7 @@ options:
        type: path
    privatekey_content:
        description:
-            - Path to the private key to use when signing the certificate.
+            - Content of the private key to use when signing the certificate.
            - This is mutually exclusive with I(privatekey_path).
        type: str

--- a/plugins/module_utils/crypto/module_backends/csr.py
+++ b/plugins/module_utils/crypto/module_backends/csr.py
@@ -452,8 +452,12 @@ def parse_crl_distribution_points(module, crl_distribution_points):
                reasons=None,
            )
            if parse_crl_distribution_point['full_name'] is not None:
+                if not parse_crl_distribution_point['full_name']:
+                    raise OpenSSLObjectError('full_name must not be empty')
                params['full_name'] = [cryptography_get_name(name, 'full name') for name in parse_crl_distribution_point['full_name']]
            if parse_crl_distribution_point['relative_name'] is not None:
+                if not parse_crl_distribution_point['relative_name']:
+                    raise OpenSSLObjectError('relative_name must not be empty')
                try:
                    params['relative_name'] = cryptography_parse_relative_distinguished_name(parse_crl_distribution_point['relative_name'])
                except Exception:
@@ -462,6 +466,8 @@ def parse_crl_distribution_points(module, crl_distribution_points):
                        raise OpenSSLObjectError('Cannot specify relative_name for cryptography < 1.6')
                    raise
            if parse_crl_distribution_point['crl_issuer'] is not None:
+                if not parse_crl_distribution_point['crl_issuer']:
+                    raise OpenSSLObjectError('crl_issuer must not be empty')
                params['crl_issuer'] = [cryptography_get_name(name, 'CRL issuer') for name in parse_crl_distribution_point['crl_issuer']]
            if parse_crl_distribution_point['reasons'] is not None:
                reasons = []
@@ -469,7 +475,7 @@ def parse_crl_distribution_points(module, crl_distribution_points):
                    reasons.append(REVOCATION_REASON_MAP[reason])
                params['reasons'] = frozenset(reasons)
            result.append(cryptography.x509.DistributionPoint(**params))
-        except OpenSSLObjectError as e:
+        except (OpenSSLObjectError, ValueError) as e:
            raise OpenSSLObjectError('Error while parsing CRL distribution point #{index}: {error}'.format(index=index, error=e))
    return result

@@ -851,7 +857,8 @@ def get_csr_argument_spec():
                        'aa_compromise',
                    ]),
                ),
-                mutually_exclusive=[('full_name', 'relative_name')]
+                mutually_exclusive=[('full_name', 'relative_name')],
+                required_one_of=[('full_name', 'relative_name', 'crl_issuer')],
            ),
            select_crypto_backend=dict(type='str', default='auto', choices=['auto', 'cryptography', 'pyopenssl']),
        ),
--- a/plugins/module_utils/crypto/module_backends/publickey_info.py
+++ b/plugins/module_utils/crypto/module_backends/publickey_info.py
@@ -215,7 +215,7 @@ class PublicKeyInfoRetrieval(object):
            try:
                self.key = load_publickey(content=self.content, backend=self.backend)
            except OpenSSLObjectError as e:
-                raise PublicKeyParseError(to_native(e))
+                raise PublicKeyParseError(to_native(e), {})

        pk = self._get_public_key(binary=True)
        result['fingerprints'] = get_fingerprint_of_bytes(
--- a/plugins/modules/acme_account_info.py
+++ b/plugins/modules/acme_account_info.py
@@ -101,7 +101,7 @@ account:
      returned: always
      type: list
      elements: str
-      sample: "['mailto:me@example.com', 'tel:00123456789']"
+      sample: ['mailto:me@example.com', 'tel:00123456789']
    status:
      description: the account's status
      returned: always
--- a/plugins/modules/acme_certificate.py
+++ b/plugins/modules/acme_certificate.py
@@ -467,7 +467,20 @@ authorizations:
    - Maps an identifier to ACME authorization objects. See U(https://tools.ietf.org/html/rfc8555#section-7.1.4).
  returned: changed
  type: dict
-  sample: '{"example.com":{...}}'
+  sample:
+    example.com:
+      identifier:
+        type: dns
+        value: example.com
+      status: valid
+      expires: '2022-08-04T01:02:03.45Z'
+      challenges:
+        - url: https://example.org/acme/challenge/12345
+          type: http-01
+          status: valid
+          token: A5b1C3d2E9f8G7h6
+          validated: '2022-08-01T01:01:02.34Z'
+      wildcard: false
 order_uri:
  description: ACME order URI.
  returned: changed
--- a/plugins/modules/acme_inspect.py
+++ b/plugins/modules/acme_inspect.py
@@ -183,7 +183,7 @@ directory:
  description: The ACME directory's content
  returned: always
  type: dict
-  sample: |
+  sample:
    {
      "a85k3x9f91A4": "https://community.letsencrypt.org/t/adding-random-entries-to-the-directory/33417",
      "keyChange": "https://acme-v02.api.letsencrypt.org/acme/key-change",
@@ -203,7 +203,7 @@ headers:
  description: The request's HTTP headers (with lowercase keys)
  returned: always
  type: dict
-  sample: |
+  sample:
    {
      "boulder-requester": "12345",
      "cache-control": "max-age=0, no-cache, no-store",
@@ -214,7 +214,7 @@ headers:
      "cookies_string": "",
      "date": "Wed, 07 Nov 2018 12:34:56 GMT",
      "expires": "Wed, 07 Nov 2018 12:44:56 GMT",
-      "link": "<https://letsencrypt.org/documents/LE-SA-v1.2-November-15-2017.pdf>;rel=\"terms-of-service\"",
+      "link": '<https://letsencrypt.org/documents/LE-SA-v1.2-November-15-2017.pdf>;rel="terms-of-service"',
      "msg": "OK (904 bytes)",
      "pragma": "no-cache",
      "replay-nonce": "1234567890abcdefghijklmnopqrstuvwxyzABCDEFGH",
--- a/plugins/modules/openssl_csr.py
+++ b/plugins/modules/openssl_csr.py
@@ -177,7 +177,7 @@ subject:
    returned: changed or success
    type: list
    elements: list
-    sample: "[('CN', 'www.ansible.com'), ('O', 'Ansible')]"
+    sample: [['CN', 'www.ansible.com'], ['O', 'Ansible']]
 subjectAltName:
    description: The alternative names this CSR is valid for
    returned: changed or success
@@ -329,9 +329,10 @@ def main():
    if not os.path.isdir(base_dir):
        module.fail_json(name=base_dir, msg='The directory %s does not exist or the file is not a directory' % base_dir)

-    backend = module.params['select_crypto_backend']
-    backend, module_backend = select_backend(module, backend)
    try:
+        backend = module.params['select_crypto_backend']
+        backend, module_backend = select_backend(module, backend)
+
        csr = CertificateSigningRequestModule(module, module_backend)
        if module.params['state'] == 'present':
            csr.generate(module)
--- a/plugins/modules/openssl_csr_info.py
+++ b/plugins/modules/openssl_csr_info.py
@@ -85,7 +85,7 @@ basic_constraints:
    returned: success
    type: list
    elements: str
-    sample: "[CA:TRUE, pathlen:1]"
+    sample: ['CA:TRUE', 'pathlen:1']
 basic_constraints_critical:
    description: Whether the C(basic_constraints) extension is critical.
    returned: success
@@ -95,7 +95,7 @@ extended_key_usage:
    returned: success
    type: list
    elements: str
-    sample: "[Biometric Info, DVCS, Time Stamping]"
+    sample: [Biometric Info, DVCS, Time Stamping]
 extended_key_usage_critical:
    description: Whether the C(extended_key_usage) extension is critical.
    returned: success
@@ -114,12 +114,12 @@ extensions_by_oid:
            returned: success
            type: str
            sample: "MAMCAQU="
-    sample: '{"1.3.6.1.5.5.7.1.24": { "critical": false, "value": "MAMCAQU="}}'
+    sample: {"1.3.6.1.5.5.7.1.24": { "critical": false, "value": "MAMCAQU="}}
 key_usage:
    description: Entries in the C(key_usage) extension, or C(none) if extension is not present.
    returned: success
    type: str
-    sample: "[Key Agreement, Data Encipherment]"
+    sample: [Key Agreement, Data Encipherment]
 key_usage_critical:
    description: Whether the C(key_usage) extension is critical.
    returned: success
@@ -129,7 +129,7 @@ subject_alt_name:
    returned: success
    type: list
    elements: str
-    sample: "[DNS:www.ansible.com, IP:1.2.3.4]"
+    sample: ["DNS:www.ansible.com", "IP:1.2.3.4"]
 subject_alt_name_critical:
    description: Whether the C(subject_alt_name) extension is critical.
    returned: success
@@ -171,13 +171,13 @@ subject:
        - Note that for repeated values, only the last one will be returned.
    returned: success
    type: dict
-    sample: '{"commonName": "www.example.com", "emailAddress": "test@example.com"}'
+    sample: {"commonName": "www.example.com", "emailAddress": "test@example.com"}
 subject_ordered:
    description: The CSR's subject as an ordered list of tuples.
    returned: success
    type: list
    elements: list
-    sample: '[["commonName", "www.example.com"], ["emailAddress": "test@example.com"]]'
+    sample: [["commonName", "www.example.com"], ["emailAddress": "test@example.com"]]
 public_key:
    description: CSR's public key in PEM format
    returned: success
@@ -285,14 +285,14 @@ authority_cert_issuer:
    returned: success and if the pyOpenSSL backend is I(not) used
    type: list
    elements: str
-    sample: "[DNS:www.ansible.com, IP:1.2.3.4]"
+    sample: ["DNS:www.ansible.com", "IP:1.2.3.4"]
 authority_cert_serial_number:
    description:
        - The CSR's authority cert serial number.
        - Is C(none) if the C(AuthorityKeyIdentifier) extension is not present.
    returned: success and if the pyOpenSSL backend is I(not) used
    type: int
-    sample: '12345'
+    sample: 12345
 '''


--- a/plugins/modules/openssl_csr_pipe.py
+++ b/plugins/modules/openssl_csr_pipe.py
@@ -66,7 +66,7 @@ subject:
    returned: changed or success
    type: list
    elements: list
-    sample: "[('CN', 'www.ansible.com'), ('O', 'Ansible')]"
+    sample: [['CN', 'www.ansible.com'], ['O', 'Ansible']]
 subjectAltName:
    description: The alternative names this CSR is valid for
    returned: changed or success
@@ -160,9 +160,10 @@ def main():
        supports_check_mode=True,
    )

-    backend = module.params['select_crypto_backend']
-    backend, module_backend = select_backend(module, backend)
    try:
+        backend = module.params['select_crypto_backend']
+        backend, module_backend = select_backend(module, backend)
+
        csr = CertificateSigningRequestModule(module, module_backend)
        csr.generate(module)
        result = csr.dump()
--- a/plugins/modules/openssl_publickey.py
+++ b/plugins/modules/openssl_publickey.py
@@ -13,8 +13,9 @@ DOCUMENTATION = r'''
 module: openssl_publickey
 short_description: Generate an OpenSSL public key from its private key.
 description:
-    - This module allows one to (re)generate OpenSSL public keys from their private keys.
-    - Keys are generated in PEM or OpenSSH format.
+    - This module allows one to (re)generate public keys from their private keys.
+    - Public keys are generated in PEM or OpenSSH format. Private keys must be OpenSSL PEM keys.
+      OpenSSH private keys are not supported, use the M(community.crypto.openssh_keypair) module to manage these.
    - "The module can use the cryptography Python library, or the pyOpenSSL Python
      library. By default, it tries to detect which one is available. This can be
      overridden with the I(select_crypto_backend) option. When I(format) is C(OpenSSH),
--- a/plugins/modules/x509_certificate_info.py
+++ b/plugins/modules/x509_certificate_info.py
@@ -129,7 +129,7 @@ basic_constraints:
    returned: success
    type: list
    elements: str
-    sample: "[CA:TRUE, pathlen:1]"
+    sample: ["CA:TRUE", "pathlen:1"]
 basic_constraints_critical:
    description: Whether the C(basic_constraints) extension is critical.
    returned: success
@@ -139,7 +139,7 @@ extended_key_usage:
    returned: success
    type: list
    elements: str
-    sample: "[Biometric Info, DVCS, Time Stamping]"
+    sample: [Biometric Info, DVCS, Time Stamping]
 extended_key_usage_critical:
    description: Whether the C(extended_key_usage) extension is critical.
    returned: success
@@ -158,12 +158,12 @@ extensions_by_oid:
            returned: success
            type: str
            sample: "MAMCAQU="
-    sample: '{"1.3.6.1.5.5.7.1.24": { "critical": false, "value": "MAMCAQU="}}'
+    sample: {"1.3.6.1.5.5.7.1.24": { "critical": false, "value": "MAMCAQU="}}
 key_usage:
    description: Entries in the C(key_usage) extension, or C(none) if extension is not present.
    returned: success
    type: str
-    sample: "[Key Agreement, Data Encipherment]"
+    sample: [Key Agreement, Data Encipherment]
 key_usage_critical:
    description: Whether the C(key_usage) extension is critical.
    returned: success
@@ -173,7 +173,7 @@ subject_alt_name:
    returned: success
    type: list
    elements: str
-    sample: "[DNS:www.ansible.com, IP:1.2.3.4]"
+    sample: ["DNS:www.ansible.com", "IP:1.2.3.4"]
 subject_alt_name_critical:
    description: Whether the C(subject_alt_name) extension is critical.
    returned: success
@@ -192,36 +192,36 @@ issuer:
        - Note that for repeated values, only the last one will be returned.
    returned: success
    type: dict
-    sample: '{"organizationName": "Ansible", "commonName": "ca.example.com"}'
+    sample: {"organizationName": "Ansible", "commonName": "ca.example.com"}
 issuer_ordered:
    description: The certificate's issuer as an ordered list of tuples.
    returned: success
    type: list
    elements: list
-    sample: '[["organizationName", "Ansible"], ["commonName": "ca.example.com"]]'
+    sample: [["organizationName", "Ansible"], ["commonName": "ca.example.com"]]
 subject:
    description:
        - The certificate's subject as a dictionary.
        - Note that for repeated values, only the last one will be returned.
    returned: success
    type: dict
-    sample: '{"commonName": "www.example.com", "emailAddress": "test@example.com"}'
+    sample: {"commonName": "www.example.com", "emailAddress": "test@example.com"}
 subject_ordered:
    description: The certificate's subject as an ordered list of tuples.
    returned: success
    type: list
    elements: list
-    sample: '[["commonName", "www.example.com"], ["emailAddress": "test@example.com"]]'
+    sample: [["commonName", "www.example.com"], ["emailAddress": "test@example.com"]]
 not_after:
    description: C(notAfter) date as ASN.1 TIME.
    returned: success
    type: str
-    sample: 20190413202428Z
+    sample: '20190413202428Z'
 not_before:
    description: C(notBefore) date as ASN.1 TIME.
    returned: success
    type: str
-    sample: 20190331202428Z
+    sample: '20190331202428Z'
 public_key:
    description: Certificate's public key in PEM format.
    returned: success
@@ -359,14 +359,14 @@ authority_cert_issuer:
    returned: success and if the pyOpenSSL backend is I(not) used
    type: list
    elements: str
-    sample: "[DNS:www.ansible.com, IP:1.2.3.4]"
+    sample: ["DNS:www.ansible.com", "IP:1.2.3.4"]
 authority_cert_serial_number:
    description:
        - The certificate's authority cert serial number.
        - Is C(none) if the C(AuthorityKeyIdentifier) extension is not present.
    returned: success and if the pyOpenSSL backend is I(not) used
    type: int
-    sample: '12345'
+    sample: 12345
 ocsp_uri:
    description: The OCSP responder URI, if included in the certificate. Will be
                 C(none) if no OCSP responder URI is included.
--- a/plugins/modules/x509_crl.py
+++ b/plugins/modules/x509_crl.py
@@ -286,13 +286,13 @@ issuer:
        - Note that for repeated values, only the last one will be returned.
    returned: success
    type: dict
-    sample: '{"organizationName": "Ansible", "commonName": "ca.example.com"}'
+    sample: {"organizationName": "Ansible", "commonName": "ca.example.com"}
 issuer_ordered:
    description: The CRL's issuer as an ordered list of tuples.
    returned: success
    type: list
    elements: list
-    sample: '[["organizationName", "Ansible"], ["commonName": "ca.example.com"]]'
+    sample: [["organizationName", "Ansible"], ["commonName": "ca.example.com"]]
 last_update:
    description: The point in time from which this CRL can be trusted as ASN.1 TIME.
    returned: success
@@ -326,7 +326,7 @@ revoked_certificates:
            description: The certificate's issuer.
            type: list
            elements: str
-            sample: '["DNS:ca.example.org"]'
+            sample: ["DNS:ca.example.org"]
        issuer_critical:
            description: Whether the certificate issuer extension is critical.
            type: bool
--- a/plugins/modules/x509_crl_info.py
+++ b/plugins/modules/x509_crl_info.py
@@ -78,23 +78,23 @@ issuer:
        - Note that for repeated values, only the last one will be returned.
    returned: success
    type: dict
-    sample: '{"organizationName": "Ansible", "commonName": "ca.example.com"}'
+    sample: {"organizationName": "Ansible", "commonName": "ca.example.com"}
 issuer_ordered:
    description: The CRL's issuer as an ordered list of tuples.
    returned: success
    type: list
    elements: list
-    sample: '[["organizationName", "Ansible"], ["commonName": "ca.example.com"]]'
+    sample: [["organizationName", "Ansible"], ["commonName": "ca.example.com"]]
 last_update:
    description: The point in time from which this CRL can be trusted as ASN.1 TIME.
    returned: success
    type: str
-    sample: 20190413202428Z
+    sample: '20190413202428Z'
 next_update:
    description: The point in time from which a new CRL will be issued and the client has to check for it as ASN.1 TIME.
    returned: success
    type: str
-    sample: 20190413202428Z
+    sample: '20190413202428Z'
 digest:
    description: The signature algorithm used to sign the CRL.
    returned: success
@@ -113,12 +113,12 @@ revoked_certificates:
        revocation_date:
            description: The point in time the certificate was revoked as ASN.1 TIME.
            type: str
-            sample: 20190413202428Z
+            sample: '20190413202428Z'
        issuer:
            description: The certificate's issuer.
            type: list
            elements: str
-            sample: '["DNS:ca.example.org"]'
+            sample: ["DNS:ca.example.org"]
        issuer_critical:
            description: Whether the certificate issuer extension is critical.
            type: bool
@@ -140,7 +140,7 @@ revoked_certificates:
                The point in time it was known/suspected that the private key was compromised
                or that the certificate otherwise became invalid as ASN.1 TIME.
            type: str
-            sample: 20190413202428Z
+            sample: '20190413202428Z'
        invalidity_date_critical:
            description: Whether the invalidity date extension is critical.
            type: bool
--- a/plugins/plugin_utils/action_module.py
+++ b/plugins/plugin_utils/action_module.py
@@ -115,13 +115,12 @@ class AnsibleActionModule(object):
        self.required_by = required_by
        self._diff = self.__action_plugin._play_context.diff
        self._verbosity = self.__action_plugin._display.verbosity
-        self._string_conversion_action = C.STRING_CONVERSION_ACTION

        self.aliases = {}
        self._legal_inputs = []
        self._options_context = list()

-        self.params = copy.deepcopy(action_plugin._task.args)
+        self.params = copy.deepcopy(self.__action_plugin._task.args)
        self.no_log_values = set()
        if HAS_ARGSPEC_VALIDATOR:
            self._validator = ArgumentSpecValidator(
@@ -145,9 +144,14 @@ class AnsibleActionModule(object):
            # warnings and deprecations that do not work in plugins. This is a copy of that code adjusted
            # for our use-case:
            for d in self._validation_result._deprecations:
-                self.deprecate(
-                    "Alias '{name}' is deprecated. See the module docs for more information".format(name=d['name']),
-                    version=d.get('version'), date=d.get('date'), collection_name=d.get('collection_name'))
+                # Before ansible-core 2.14.2, deprecations were always for aliases:
+                if 'name' in d:
+                    self.deprecate(
+                        "Alias '{name}' is deprecated. See the module docs for more information".format(name=d['name']),
+                        version=d.get('version'), date=d.get('date'), collection_name=d.get('collection_name'))
+                # Since ansible-core 2.14.2, a message is present that can be directly printed:
+                if 'msg' in d:
+                    self.deprecate(d['msg'], version=d.get('version'), date=d.get('date'), collection_name=d.get('collection_name'))

            for w in self._validation_result._warnings:
                self.warn('Both option {option} and its alias {alias} are set.'.format(option=w['option'], alias=w['alias']))
@@ -444,7 +448,7 @@ class AnsibleActionModule(object):
        }

        # Ignore, warn, or error when converting to a string.
-        allow_conversion = opts.get(self._string_conversion_action, True)
+        allow_conversion = opts.get(C.STRING_CONVERSION_ACTION, True)
        try:
            return check_type_str(value, allow_conversion)
        except TypeError:
@@ -459,10 +463,10 @@ class AnsibleActionModule(object):
                from_msg = '{0}: {1!r}'.format(param, value)
                to_msg = '{0}: {1!r}'.format(param, to_text(value))

-            if self._string_conversion_action == 'error':
+            if C.STRING_CONVERSION_ACTION == 'error':
                msg = common_msg.capitalize()
                raise TypeError(to_native(msg))
-            elif self._string_conversion_action == 'warn':
+            elif C.STRING_CONVERSION_ACTION == 'warn':
                msg = ('The value "{0}" (type {1.__class__.__name__}) was converted to "{2}" (type string). '
                       'If this does not look like what you expect, {3}').format(from_msg, value, to_msg, common_msg)
                self.warn(to_native(msg))
--- a/tests/integration/targets/acme_inspect/tasks/impl.yml
+++ b/tests/integration/targets/acme_inspect/tasks/impl.yml
@@ -158,7 +158,7 @@
    method: get
  register: validation_result
  loop: "{{ http01challenge.results | map(attribute='output_json') | list }}"
-  until: "validation_result.output_json.status != 'pending'"
+  until: "validation_result.output_json.status not in ['pending', 'processing']"
  retries: 20
  delay: 1
 - debug: var=validation_result
--- a/tests/integration/targets/acme_inspect/tests/validate.yml
+++ b/tests/integration/targets/acme_inspect/tests/validate.yml
@@ -107,7 +107,7 @@
    - "'headers' in item"
    - "'output_text' in item"
    - "'output_json' in item"
-    - item.output_json.status == 'pending'
+    - item.output_json.status in ['pending', 'processing']
    - item.output_json.type == 'http-01'
    - item.output_json.url == item.invocation.module_args.url
    - "'token' in item.output_json"
--- a/tests/integration/targets/luks_device/tasks/tests/options.yml
+++ b/tests/integration/targets/luks_device/tasks/tests/options.yml
@@ -6,6 +6,7 @@
    keyfile: "{{ remote_tmp_dir }}/keyfile1"
    keysize: 256
    pbkdf:
+      algorithm: pbkdf2
      iteration_count: 1000
  become: yes
  register: create_with_keysize
@@ -16,6 +17,7 @@
    keyfile: "{{ remote_tmp_dir }}/keyfile1"
    keysize: 256
    pbkdf:
+      algorithm: pbkdf2
      iteration_count: 1000
  become: yes
  register: create_idem_with_keysize
@@ -26,6 +28,7 @@
    keyfile: "{{ remote_tmp_dir }}/keyfile1"
    keysize: 512
    pbkdf:
+      algorithm: pbkdf2
      iteration_count: 1000
  become: yes
  register: create_idem_with_diff_keysize
@@ -36,6 +39,7 @@
    keyfile: "{{ remote_tmp_dir }}/keyfile1"
    passphrase: "{{ cryptfile_passphrase1 }}"
    pbkdf:
+      algorithm: pbkdf2
      iteration_count: 1000
  ignore_errors: yes
  become: yes
--- a/tests/integration/targets/openssl_csr/tasks/impl.yml
+++ b/tests/integration/targets/openssl_csr/tasks/impl.yml
@@ -924,7 +924,6 @@
              - CN=ca.example.com
            reasons:
              - certificate_hold
-          - {}
        select_crypto_backend: '{{ select_crypto_backend }}'
      register: crl_distribution_endpoints_1

@@ -947,7 +946,6 @@
              - CN=ca.example.com
            reasons:
              - certificate_hold
-          - {}
        select_crypto_backend: '{{ select_crypto_backend }}'
      register: crl_distribution_endpoints_2

@@ -958,9 +956,7 @@
        subject:
          commonName: www.ansible.com
        crl_distribution_points:
-          - full_name:
-              - "URI:https://ca.example.com/revocations.crl"
-            crl_issuer:
+          - crl_issuer:
              - "URI:https://ca.example.com/"
            reasons:
              - key_compromise
--- a/tests/integration/targets/setup_remote_tmp_dir/tasks/default.yml
+++ b/tests/integration/targets/setup_remote_tmp_dir/tasks/default.yml
@@ -1,7 +1,18 @@
+---
+# Copyright (c) Ansible Project
+# GNU General Public License v3.0+ (see LICENSES/GPL-3.0-or-later.txt or https://www.gnu.org/licenses/gpl-3.0.txt)
+# SPDX-License-Identifier: GPL-3.0-or-later
+
+- name: create ~/tmp
+  file:
+    path: '~/tmp'
+    state: directory
+
 - name: create temporary directory
  tempfile:
    state: directory
    suffix: .test
+    path: '~/tmp'
  register: remote_tmp_dir
  notify:
    - delete temporary directory
--- a/tests/integration/targets/setup_ssh_agent/meta/main.yml
+++ b/tests/integration/targets/setup_ssh_agent/meta/main.yml
@@ -1,2 +1,3 @@
 dependencies:
  - setup_ssh_keygen
+  - prepare_jinja2_compat
--- a/tests/integration/targets/setup_ssh_agent/tasks/main.yml
+++ b/tests/integration/targets/setup_ssh_agent/tasks/main.yml
@@ -5,13 +5,22 @@
 ####################################################################

 - name: Start an ssh agent to use for tests
-  shell: eval $(ssh-agent)>/dev/null&&echo "${SSH_AGENT_PID};${SSH_AUTH_SOCK}"
-  register: openssh_agent_env_vars
+  shell: ssh-agent -c | grep "^setenv"
+  register: openssh_agent_stdout
+
+- name: Convert output to dictionary
+  set_fact:
+    openssh_agent_env: >-
+      {{
+        openssh_agent_stdout.stdout_lines | map('regex_replace', '^setenv ([^ ]+) ([^ ]+);', '\1')
+          | zip(openssh_agent_stdout.stdout_lines | map('regex_replace', '^setenv ([^ ]+) ([^ ]+);', '\2'))
+          | list | items2dict(key_name=0, value_name=1)
+      }}

 - name: Register ssh agent facts
  set_fact:
-    openssh_agent_pid: "{{ openssh_agent_env_vars.stdout.split(';')[0] }}"
-    openssh_agent_sock: "{{ openssh_agent_env_vars.stdout.split(';')[1] }}"
+    openssh_agent_pid: "{{ openssh_agent_env.SSH_AGENT_PID }}"
+    openssh_agent_sock: "{{ openssh_agent_env.SSH_AUTH_SOCK }}"

 - name: stat agent socket
  stat:
--- a/tests/integration/targets/x509_certificate-acme/tasks/main.yml
+++ b/tests/integration/targets/x509_certificate-acme/tasks/main.yml
@@ -67,6 +67,13 @@
  get_url:
    url: https://raw.githubusercontent.com/diafygi/acme-tiny/master/acme_tiny.py
    dest: "{{ remote_tmp_dir }}/acme-tiny"
+  when: ansible_python_version is version('2.7', '>=')
+
+- name: Get hold of acme-tiny executable (Python 2.6)
+  command:
+    cmd: >-
+      curl https://raw.githubusercontent.com/diafygi/acme-tiny/master/acme_tiny.py --output "{{ remote_tmp_dir }}/acme-tiny"
+  when: ansible_python_version is version('2.7', '<')

 - name: Make sure acme-tiny is executable
  file:
--- a/tests/sanity/extra/extra-docs.json
+++ b/tests/sanity/extra/extra-docs.json
@@ -1,10 +1,13 @@
 {
    "include_symlinks": false,
    "prefixes": [
-        "docs/docsite/"
+        "docs/docsite/",
+        "plugins/",
+        "roles/"
    ],
    "output": "path-line-column-message",
    "requirements": [
+        "ansible-core",
        "antsibull-docs"
    ]
 }
--- a/tests/sanity/extra/extra-docs.py
+++ b/tests/sanity/extra/extra-docs.py
@@ -12,9 +12,14 @@ import subprocess

 def main():
    """Main entry point."""
-    if not os.path.isdir(os.path.join('docs', 'docsite')):
-        return
-    p = subprocess.run(['antsibull-docs', 'lint-collection-docs', '.'], check=False)
+    env = os.environ.copy()
+    suffix = ':{env}'.format(env=env["ANSIBLE_COLLECTIONS_PATH"]) if 'ANSIBLE_COLLECTIONS_PATH' in env else ''
+    env['ANSIBLE_COLLECTIONS_PATH'] = '{root}{suffix}'.format(root=os.path.dirname(os.path.dirname(os.path.dirname(os.getcwd()))), suffix=suffix)
+    p = subprocess.run(
+        ['antsibull-docs', 'lint-collection-docs', '--plugin-docs', '--disallow-semantic-markup', '--skip-rstcheck', '.'],
+        env=env,
+        check=False,
+    )
    if p.returncode not in (0, 3):
        print('{0}:0:0: unexpected return code {1}'.format(sys.argv[0], p.returncode))
Author	SHA1	Message	Date
Felix Fontein	f10504e95f	Release 1.9.21.	2023-04-16 19:47:19 +02:00
patchback[bot]	7fbe649dc6	Do extra docs validation; explicitly disallow semantic markup in docs (#593 ) (#594 ) * Do extra docs validation. Explicitly disallow semantic markup in docs. * Forgot to add new requirement. * Improve test. * TEMP - make CI fail. * Revert "TEMP - make CI fail." This reverts commit `a71b8901c1`. * Remove unnecessary import. * Make sure ANSIBLE_COLLECTIONS_PATH is set. * Make sure sanity tests from older Ansible versions don't complain. (cherry picked from commit `ceabef7e58`) Co-authored-by: Felix Fontein <felix@fontein.de>	2023-04-16 18:55:26 +02:00
Felix Fontein	11e7232bd6	For some reason some 2.9 tests were still running in AZP.	2023-04-09 14:27:39 +02:00
patchback[bot]	9fc27e74f8	Use curl instead of get_url on Python 2.6. (#585 ) (#586 ) (cherry picked from commit `0829bc641e`) Co-authored-by: Felix Fontein <felix@fontein.de>	2023-03-22 21:30:53 +01:00
patchback[bot]	1572c10384	fix(doc): privatekey_content docs were the same as privatekey_path (#583 ) (#584 ) (cherry picked from commit `b997773139`) Co-authored-by: Thomas Anderson <tnyeanderson@users.noreply.github.com>	2023-03-21 18:02:40 +01:00
Felix Fontein	553f3c2ee0	Cancel concurrent workflow runs in PRs. (cherry picked from commit `5a3e21788d`)	2023-02-23 09:57:25 +01:00
patchback[bot]	837733b4c2	Fix deprecation handling. (#572 ) (#573 ) (cherry picked from commit `70c4585b88`) Co-authored-by: Felix Fontein <felix@fontein.de>	2023-02-09 16:25:26 +01:00
patchback[bot]	3468628f1f	Fix acme_inspect tests. (#565 ) (#566 ) (cherry picked from commit `c6429eae4f`) Co-authored-by: Felix Fontein <felix@fontein.de>	2023-01-23 06:41:21 +01:00
patchback[bot]	eee646b636	openssl_csr: fix bad tests, avoid accepting invalid crl_distribution_points records (#560 ) (#561 ) * Improve error handling. * Remove invalid tests. * Add changelog fragment. * Fix tests. * Improve exception catching. Co-authored-by: Kristian Heljas <11139388+kristianheljas@users.noreply.github.com> * Prevent empty full_name. * Fix condition. Make sure errors are caught. * Add more checks. Co-authored-by: Kristian Heljas <11139388+kristianheljas@users.noreply.github.com> (cherry picked from commit `ddfb18b609`) Co-authored-by: Felix Fontein <felix@fontein.de>	2023-01-02 17:28:28 +01:00
Felix Fontein	e78318c4cb	Next release will be 1.9.21.	2023-01-01 08:52:43 +01:00
Felix Fontein	8ccab3ab80	Release 1.9.20.	2023-01-01 08:14:32 +01:00
patchback[bot]	e2ecd14d86	Fix crash when public key cannot be parsed. (#551 ) (#552 ) (cherry picked from commit `5d24d04adf`) Co-authored-by: Felix Fontein <felix@fontein.de>	2022-12-28 20:53:02 +01:00
patchback[bot]	6f8131a628	Make sure that iteration_count=1000 is not used with algorithm=argon* (which is SLOW and takes around 10 minutes). (#546 ) (#547 ) (cherry picked from commit `242c15bf4c`) Co-authored-by: Felix Fontein <felix@fontein.de>	2022-12-20 20:16:20 +01:00
Felix Fontein	5761ca12b6	Disable broken CI platforms. (#469 ) (cherry picked from commit `f7bc3aa77c`)	2022-12-20 07:24:19 +01:00
Felix Fontein	bfe181ac1f	Move tests with EOL versions of Ansible from AZP to GHA. (#543 )	2022-12-20 06:58:28 +01:00
Felix Fontein	f5632c27f4	[TEMP] Create temp remote directory in ~. (#504 ) (cherry picked from commit `d0d99c31b0`)	2022-12-11 18:12:53 +01:00
Felix Fontein	6bec0b402c	Be more precise about which private keys are supported in openssl_publickey. (#532 ) (cherry picked from commit `1097371cf4`)	2022-11-27 18:19:42 +01:00
Felix Fontein	b0262bf8f1	Prepare 1.9.20 release.	2022-11-01 21:14:17 +01:00
Felix Fontein	c57822b3b3	Release 1.9.19.	2022-11-01 20:53:52 +01:00
patchback[bot]	c313bbd83d	Action plugin support code: ensure compatibility with newer versions of ansible-core (#515 ) (#516 ) * Only access C.STRING_CONVERSION_ACTION for old ansible-base / Ansible versions. * Always use self.__xxx instead of xxx directly. (cherry picked from commit `b3f589df62`) Co-authored-by: Felix Fontein <felix@fontein.de>	2022-09-23 07:33:48 +02:00
patchback[bot]	b9e8bb70eb	Fix docs (#497 ) (#498 ) * Fix docs. * Fix YAML. * Prevent crashes with older pyyaml versions. (cherry picked from commit `2dafef1fab`) Co-authored-by: Felix Fontein <felix@fontein.de>	2022-08-04 20:17:55 +02:00
patchback[bot]	62da550c6c	Fix ssh-agent tests (#493 ) (#494 ) * Work around stupid ssh-agent output format. * Workaround for Ansible 2.9. * Old jinja2... * Jinja2 on CentOS 6 is really annoying. (cherry picked from commit `e4ebca0945`) Co-authored-by: Felix Fontein <felix@fontein.de>	2022-07-22 14:00:53 +02:00
Felix Fontein	3d9fb17d17	Fix typo.	2022-07-09 13:54:52 +02:00
Felix Fontein	2fd7aa6de7	Prepare 1.9.19.	2022-07-09 13:51:12 +02:00