Avoid sanity excludes so that users can run ansible-test sanity --docker and it usually passes. (#41)

tests/sanity/ignore-2.10.txt

@@ -13,4 +13,6 @@ tests/unit/plugins/module_utils/conftest.py metaclass-boilerplate
 tests/unit/plugins/modules/conftest.py future-import-boilerplate
 tests/unit/plugins/modules/conftest.py metaclass-boilerplate
 tests/unit/plugins/modules/utils.py future-import-boilerplate
-tests/unit/plugins/modules/utils.py metaclass-boilerplate
+tests/unit/plugins/modules/utils.py metaclass-boilerplate
+tests/utils/shippable/check_matrix.py replace-urlopen
+tests/utils/shippable/timing.py shebang

tests/sanity/ignore-2.9.txt

@@ -12,3 +12,5 @@ tests/unit/plugins/modules/conftest.py future-import-boilerplate
 tests/unit/plugins/modules/conftest.py metaclass-boilerplate
 tests/unit/plugins/modules/utils.py future-import-boilerplate
 tests/unit/plugins/modules/utils.py metaclass-boilerplate
+tests/utils/shippable/check_matrix.py replace-urlopen
+tests/utils/shippable/timing.py shebang

tests/utils/shippable/sanity.sh

@@ -2,11 +2,6 @@
 
 set -o pipefail -eux
 
-declare -a args
-IFS='/:' read -ra args <<< "$1"
-
-group="${args[1]}"
-
 if [ "${BASE_BRANCH:-}" ]; then
     base_branch="origin/${BASE_BRANCH}"
 else
@@ -16,5 +11,4 @@ fi
 # shellcheck disable=SC2086
 ansible-test sanity --color -v --junit ${COVERAGE:+"$COVERAGE"} ${CHANGED:+"$CHANGED"} \
     --docker --base-branch "${base_branch}" \
-    --exclude shippable.yml --exclude tests/utils/ \
     --allow-disabled

tests/utils/shippable/shippable.sh

@@ -35,6 +35,7 @@ python -V
 
 function retry
 {
+    # shellcheck disable=SC2034
     for repetition in 1 2 3; do
         set +e
         "$@"
@@ -43,9 +44,9 @@ function retry
         if [ ${result} == 0 ]; then
             return ${result}
         fi
-        echo "$@ -> ${result}"
+        echo "@* -> ${result}"
     done
-    echo "Command '$@' failed 3 times!"
+    echo "Command '@*' failed 3 times!"
     exit -1
 }
 

tests/utils/shippable/units.sh

@@ -6,7 +6,6 @@ declare -a args
 IFS='/:' read -ra args <<< "$1"
 
 version="${args[1]}"
-group="${args[2]}"
 
 if [[ "${COVERAGE:-}" == "--coverage" ]]; then
     timeout=90