internet/community.crypto
3
0
Fork 0
mirror of https://github.com/ansible-collections/community.crypto.git synced 2026-05-06 13:22:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

acme_challenge_cert_helper: fail better to avoid crashes in Ansible (#282)

Browse Source 
* Prevent acme_challenge_cert_helper triggering a bug in Ansible.

* Add changelog fragment.
This commit is contained in:
Felix Fontein
2021-09-17 19:35:43 +02:00
committed by GitHub
parent 598cdf0a21
commit 63f4598737
2 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/282-acme_challenge_cert_helper-error.yml Normal file
View File

@@ -0,0 +1,2 @@
bugfixes:
- "acme_challenge_cert_helper - only return exception when cryptography is not installed, not when a too old version of it is installed. This prevents Ansible's callback to crash (https://github.com/ansible-collections/community.crypto/pull/281)."

5
plugins/modules/acme_challenge_cert_helper.py
View File

@@ -202,7 +202,10 @@ def main():
),
)
if not HAS_CRYPTOGRAPHY:
module.fail_json(msg=missing_required_lib('cryptography >= 1.3'), exception=CRYPTOGRAPHY_IMP_ERR)
# Some callbacks die when exception is provided with value None
if CRYPTOGRAPHY_IMP_ERR:
module.fail_json(msg=missing_required_lib('cryptography >= 1.3'), exception=CRYPTOGRAPHY_IMP_ERR)
module.fail_json(msg=missing_required_lib('cryptography >= 1.3'))
try:
# Get parameters