internet/ansible-freeipa
4
0
Fork 0
mirror of https://github.com/freeipa/ansible-freeipa.git synced 2026-06-09 18:25:53 +00:00
Code Issues Projects Releases Wiki Activity
1,483 Commits 12 Branches 63 Tags
f406de14e8e85ced09e11d1b0fbad28b98ac52ae
Commit Graph

1483 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Thomas Woerner
f406de14e8 ipaclient_get_facts: Fix closing bracket does not match indentation 
This patch is needed to pass Automation Hub tests.
 2021-11-24 10:07:02 +01:00
Thomas Woerner
a86970efe1 Remove "’" from yaml files 
This patch is needed to pass Automation Hub tests.
 2021-11-24 10:07:02 +01:00
Thomas Woerner
0af208d271 Replace asserts with raise AssertionError 
This patch is needed to pass Automation Hub tests.
 2021-11-24 10:07:02 +01:00
Thomas Woerner
10b16a3bbf Remove non-module shebang 
This patch is needed to pass Automation Hub tests.
 2021-11-24 10:07:02 +01:00
Thomas Woerner
5c871242a7 Add __future__ imports and __metaclass__ for automationhub 
This patch is needed to pass Automation Hub tests.
 2021-11-24 10:07:02 +01:00
Thomas Woerner
d6eaf91225 Merge pull request #670 from rjeffman/ipapermission_fixes 
ipaprivilege: Fix permissions handling.
 2021-11-12 13:19:41 +01:00
Thomas Woerner
cb95248ef5 Merge pull request #665 from rjeffman/fix_sudorule_idempotency 
sudorule: Fix runas with external users and groups.
 2021-11-12 13:09:58 +01:00
Rafael Guterres Jeffman
22f31d02f2 sudorule: Fix runas with external users and groups. 
When setting 'runasuser' or 'runasgroup' for a sudorule, either IPA or
external users and groups can be used, but only IPA users and groups
were being searched for when modifying the attributes, making this task
not idempotent if an external group or user was used..

This patch fixes this issue by comparing users and groups to the IPA
and external setting.

The IPA CLI commands are slightly confusing, as the sudorule-add and
sudorule-mod display separate options for internal and external users
and groups, but these options are deprecated and do not work anymore,
in favor of sudorule-add-runasuser and sudorule-add-runasgroup, which
don't diferentiate between internal and external users, from the CLI
user perspective.
 2021-11-03 15:49:09 -03:00
Thomas Woerner
5e9a2e8c2e Merge pull request #667 from rjeffman/fix_service_principal_idempotent_issue 
ipaservice: Fix idempotent behavior for principal aliases.
 2021-11-03 15:52:07 +01:00
Rafael Guterres Jeffman
0757bfee0a ipaprivilege: Fix module execution in check_mode. 
This patch removes the custom command result handler in favor of the
IPAAnsibleModule default member handler and fixes creation of add and
del lists of permissions, fixing the behavior of the moudule execution
when 'check_mode: yes'.
 2021-10-26 11:37:07 -03:00
Rafael Guterres Jeffman
1eff04a09a ipaprivilege: fix creation of add/del lists for permissions. 
A wrong parameter 'member_permission' was being used to obtain the
existing permissions, and was changed to 'memberof_permission'.
 2021-10-26 09:43:13 -03:00
Rafael Guterres Jeffman
f43831407b ipaservice: Fix idempotent behavior for principal aliases. 
When creating the lists to add/remove principal aliases, if the realm
was not specified, the alias would be used as it did not matched the
existing one, which has the realm part.

This patch fixes the add/del list creation by adding the current API
realm to each alias that does not have the realm part and then use
this modified list to be compared against the existing principal list.

This change also allows the use of the whole list in a single call to
the IPA API to add/remove the principals, instead of a call for every
one item in the list.
 2021-10-25 16:15:16 -03:00
Thomas Woerner
17dd8e4ec6 Merge pull request #659 from t-woerner/fix_galaxyfy_module_examples 
galaxyfy: Fix newline issue in module examples
v0.4.2 		2021-10-12 16:40:58 +02:00
Thomas Woerner
0d57d69a99 galaxyfy: Fix newline issue in module examples 
The newlines in module examples have been removed due to wrong strip for
the input lines.
 2021-10-12 16:18:57 +02:00
Thomas Woerner
d1c3ecc95d Merge pull request #658 from t-woerner/fix_galaxyfy_roles_after_vars 
galaxyfy: Fix roles after vars
v0.4.1 		2021-10-12 15:27:51 +02:00
Thomas Woerner
c92e9a5ca1 galaxyfy: Fix roles after vars 
If roles have been used after vars, the name of the role was not changed
as the "vars:" section was turning off changeable. A "roles:" section is
now turning on changeable.
 2021-10-12 10:56:58 +02:00
Rafael Guterres Jeffman
be78368eb0 Merge pull request #657 from t-woerner/galaxy_action_fix 
build-galaxy-release.sh: Use proper action plugins path plugins/action
 2021-10-11 12:57:50 -03:00
Thomas Woerner
7ee6fc3238 build-galaxy-release.sh: Use proper action plugins path plugins/action 
The action plugins path was wrong. It was "plugins/action_plugins" and
should have been "plugins/action".
 2021-10-11 17:06:17 +02:00
Thomas Woerner
48d0b2f5a2 Merge pull request #654 from rjeffman/templates_variables_invtest 
Fix module templates README and invalid parameter tests.
v0.4.0 		2021-10-04 21:41:02 +02:00
Rafael Guterres Jeffman
e54b4677e8 Merge pull request #653 from t-woerner/galaxy_fix_doc_fragments 
utils/build-galaxy-release: Fix doc_fragment prefix for galaxy
 2021-10-04 15:01:09 -03:00
Rafael Guterres Jeffman
2a169ceb46 templates: Add IPA API connection variables to README. 
All modules should use the same description for IPA API connection
variables. This change add description for ipaapi_context and
ipaapi_ldap_cache variable to the module README templates.
 2021-10-04 14:11:04 -03:00
Rafael Guterres Jeffman
aa8648425b templates: Use IPAAnsibleModule params_fail_used_invalid. 
Modify new module templates to use IPAAnsibleModule method
`params_fail_used_invalid` to check for invalid parameter use for
a given state/action.
 2021-10-04 14:06:43 -03:00
Thomas Woerner
53476687be utils/build-galaxy-release: Fix doc_fragment prefix for galaxy 
The items in extends_documentation_fragments of the modules need to
have the proper galaxy prefix.

The documentation fragment

  - ipamodule_base_docs

needs to be changed to

  - ${collection_prefix}.ipamodule_base_docs
 2021-10-04 18:35:06 +02:00
Thomas Woerner
ee2942598c Merge pull request #652 from rjeffman/ipaansiblemodule_fail_if_invalid 
Standardize algorithm to verify if invalid argument was used.
 2021-10-04 16:37:04 +02:00
Thomas Woerner
4b77b274ae Merge pull request #645 from rjeffman/baseclass_ldapcache 
Add support for ldap_cache and IPA API configuration.
 2021-10-04 16:17:48 +02:00
Rafael Guterres Jeffman
469fef1365 Documentation: Update modules README with ldap_cache variable. 
This patch adds documentation for ldap_cache variable to all modules.
 2021-10-01 11:01:03 -03:00
Rafael Guterres Jeffman
1049a6c8c6 IPAAnsibleModule: add support for ldap_cache configuration. 
This patch adds support for configuring IPA API connection use of
LDAP cache. It adds a new variable 'ipaapi_ldap_cache' to the base
module, and provides the variable documentation in its doc fragment.
 2021-10-01 11:01:03 -03:00
Rafael Guterres Jeffman
e4d2a7b353 api_connect: Allow configuration of IPA API connection. 
This change adds a keyword parameter to api_connect() which can be
used to configure IPA API connection, for example, controlling the
use of LDAP cache, by passing 'ldap_cache' as an argument.

Also, IPAAnsibleModule is modified to automatically filter all
parameters of the module starting with 'ipaapi_' to be used as
arguments to configure api_connect(). The argument name will have
the same name as the module parameter with 'ipaapi_' stripped off.
 2021-10-01 11:01:03 -03:00
Rafael Guterres Jeffman
0fac277ec8 vault: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
2ec65e91df user: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
5a67aa7714 sudorule: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
14c9f308d8 sudocmdgroup: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
7f80a3f140 sudocmd: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
81672bdf62 service: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
f9851f0a33 server: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
970d6c12da selfservice: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
1ae2c1eb39 role: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
efa67303ac pwpolicy: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
08f9259295 privilege: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
53defc9eec permission: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
fc3f64f0f1 location: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
9bf2def20b hostgroup: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
c497c8c4e1 host: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
952f62cd83 hbacsvcgroup: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
43d1a06b86 hbacsvc: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
7564250614 hbacrule: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
602f3a0ff3 group: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
089400dbd0 dnszone: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
6f7b514e02 dnsrecord: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00
Rafael Guterres Jeffman
67282b1a6a dnsforwardzone: Use IPAAnsibleModule method to validate arguments. 
Use the IPAAnsibleModule.params_fail_if_used method to validate
arguments provided by user.
 2021-10-01 09:50:00 -03:00