Thomas Woerner
93baf68439
test_dnszone_mod.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
8eaa362732
test_dnszone.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
3d436677a5
test_dnsrecord_full_records.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
6911514d08
test_dnsrecord.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
b6cbc4d7f3
test_dnsforwardzone.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:40 +02:00
Thomas Woerner
7f0d367f78
test_dnsconfig.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:40 +02:00
Thomas Woerner
eb5c12f136
test_config.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:40 +02:00
Thomas Woerner
a30d8a27eb
test_dnszone.yml: Add failed_when and idempotency test
...
For test zones test1, test2 and test3 there is no verification if the
task is setting changed flag and also is not failing. Also the repeated
tests for idempotency are missing.
2021-05-26 16:10:40 +02:00
Thomas Woerner
3c357a2f07
test_dnsforwardzone.yml: Add failed_when and repeated tests
...
One task is missing the verification of the test result, some other
tasks are not repeated to verify idempotency.
2021-05-26 16:10:40 +02:00
Thomas Woerner
0e11119f4e
test_dnsrecord.yml: Add failed_when test for A rec with reverse, NS record
...
The test to make sure that the task set the changed flag and did not
fail was missing. Also the repeated task to make sure that the task did
not set the change flag.
2021-05-26 16:10:40 +02:00
Thomas Woerner
df97de31b5
test_sudorule.yml: Add failed_when for sudorule disabled test
...
The sudorule disabled test is lacking the register and failed_when
lines. The lines have been added to make sure that it is verified
that the task set the changed flag and does not fail.
2021-05-26 16:10:40 +02:00
Rafael Guterres Jeffman
d843399c75
Merge pull request #562 from chr15p/typos
...
fix minor documentation typos in sudo modules
2021-05-26 09:34:49 -03:00
Rafael Guterres Jeffman
5364ace101
Merge pull request #548 from t-woerner/user_fix_nomembers_always_triggers_mod
...
user: Fix no modifications to be performed error
2021-05-26 09:21:35 -03:00
chrisp
f51107e878
fix minor documentation typos in sudo modules
2021-05-26 13:16:49 +01:00
Thomas Woerner
ea823518e8
Merge pull request #532 from rjeffman/pylint_fixes
...
Add partial support for Pylint.
2021-05-26 10:10:08 +02:00
Rafael Guterres Jeffman
f7698271bd
Enable pylint in utils/lint_check.sh
...
The script utils/lint_check.sh should be used before push commits
to the repository. This change enables pylint to be executed by
the script.
2021-05-25 18:42:02 -03:00
Rafael Guterres Jeffman
967f9c7474
Fix, by disabling, pylint's warning on unnecessary pass.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
bf30d4b5f8
Fix, by disabling, pylint's warning on too few public methods.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
9c591de3cd
Fix anomalous use of '\' in reguluar expression.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
a12275bc0e
Fix, by disabling, pylint's error too-many-function-args (E1121).
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
9e00273864
Add pylint to Github lint workflow.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
dc9bb626f0
Add pre-commit configuration for pylint.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
3beb041ec1
Fix setup.cfg formatting.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
61c6680fdc
Fix unnecessary usage of if.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
2545f9702b
Fix excessive number of returns.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
95cdd43a0a
Fix iteration over dictionaire to not use "keys()" method.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
b610285958
Disable pylint warning no-self-use for is_valid_nsec3param_rec.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
14c4b60aae
Disable pylint warnings we don't care.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
4f2b8000ce
Fix usage of superfluous parens.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
3acb9333f4
Disable pylint's c-extension-no-member.
2021-05-25 14:13:42 -03:00
Rafael Guterres Jeffman
121dbe6925
Fix pylint warning consider-merging-isinstance.
2021-05-25 14:13:42 -03:00
Rafael Guterres Jeffman
544474a593
Disable pylint's super-with-arguments.
...
We still need to support Python 2.
2021-05-25 14:13:42 -03:00
Rafael Guterres Jeffman
e7b9e97a84
Fix pylint warnings for name redefinition.
2021-05-25 14:13:42 -03:00
Rafael Guterres Jeffman
afb64419d5
Disable pylint's too-many-lines for modules.
2021-05-25 14:13:42 -03:00
Rafael Guterres Jeffman
b5429618f1
Disable pylint's warnings on import order ang grouping.
2021-05-25 14:13:42 -03:00
Rafael Guterres Jeffman
43c4a6d91f
Fix or disable pylint's no-else-return.
...
Fixed usage of `else` right after return, or disable pylint
evaluation when it would play against code readability.
2021-05-25 14:13:42 -03:00
Rafael Guterres Jeffman
07abd6c12e
Disable pylint's too-many-arguments.
...
This is a style decision for ansible-freeipa, and in use by most
modules.
2021-05-25 13:55:21 -03:00
Rafael Guterres Jeffman
87504eaa2c
Disable pylint's too-many-statements.
...
This is expected for most modules `main()` function.
2021-05-25 13:55:21 -03:00
Rafael Guterres Jeffman
f1ecc5d986
Disable pylint error no-name-in-module.
...
All instances related to `ansible.module_utils.ansible_freeipa_module`,
which works. Future occurrences, if they happen, will likely not to be
a problem.
2021-05-25 13:55:21 -03:00
Rafael Guterres Jeffman
59d4d1b146
Fix or disable pylint warnings for inconsistent return.
...
In some places, disabling the warnings rather than fixing it required
less changes, without compromising readability.
2021-05-25 13:55:21 -03:00
Rafael Guterres Jeffman
482bd05b62
Disable pylint's protected-access warning.
...
Protected access is required for AnsibleModule.
2021-05-25 13:55:21 -03:00
Rafael Guterres Jeffman
0dabcd402f
Disable pylint's too-many-locals and too-many-branches.
...
Although both warnings are relevant, the code style choosen for
ansible-freeipa currently require them to be disable.
2021-05-25 13:55:21 -03:00
Rafael Guterres Jeffman
b3a6c9ebe1
Disable pylint broad-except warning.
...
This should be enabled in the future, but currently, nearly all
modules rely on `Exception`, and the changes would be too invasive.
2021-05-25 13:55:21 -03:00
Rafael Guterres Jeffman
b37045bd41
Disable pylint duplicate code verification.
...
Although it is an interesting setup, it currently has too many false
positives, disable comments are not working for duplicate-code, and
there are some expected duplications in the modules.
2021-05-25 13:55:21 -03:00
Rafael Guterres Jeffman
fa9e11363a
Disable pylint warning for wrong import position.
2021-05-25 13:55:21 -03:00
Rafael Guterres Jeffman
efce0bdc05
Disable pylint warnings for missing docstrings.
2021-05-25 13:55:21 -03:00
Rafael Guterres Jeffman
935956b610
Fix pylint's warning invalid-name.
2021-05-25 13:55:21 -03:00
Rafael Guterres Jeffman
3e3f82c461
Fix pylint warning W0613: unused-argument.
2021-05-25 13:39:50 -03:00
Thomas Woerner
2bbf245b70
Merge pull request #555 from rjeffman/fix_usage_ipalib_errors
...
Fix usage of ipalib errors.
2021-05-25 18:33:14 +02:00
Thomas Woerner
95a968da2c
Merge pull request #552 from frozencemetery/spellcheck
...
Various spelling/style fixes in README.md
2021-05-25 18:29:38 +02:00
