Thomas Woerner
91cc8de6b1
test_sudorule.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
74e4e2da1a
test_sudocmdgroup.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
a26e38c880
test_sudocmd.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
dd39368314
test_role_service_member.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
af844d7bbc
test_role.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
Only renamed again may not use failed_when result.failed as the rename
can not be idempotent.
2021-05-26 16:10:41 +02:00
Thomas Woerner
ef9ddcc750
test_pwpolicy.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
e546374f8f
test_hostgroup_rename.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
903f00d512
test_hostgroup_membermanager.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
failed_when result.failed can not be used for the unknown user test
with membermanager_user as this needs to fail.
2021-05-26 16:10:41 +02:00
Thomas Woerner
cb0301b311
test_hostgroup.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
b7b4f2291d
test_hosts_principal.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
591d3b0799
test_hosts_managedby_host.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
49f473ce57
test_hosts.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
For the duplicate names in hosts test failed_when: not result.failed has
been added as this test needs to fail.
2021-05-26 16:10:41 +02:00
Thomas Woerner
41940304da
test_host_reverse.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
b8b89b8b1b
test_host_random.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
5c66c5bd95
test_host_principal.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
2c37580cec
test_host_managedby_host.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
b04f9f58f7
test_host_ipaddresses.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
2d40183cb2
test_host_bool_params.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
54293d3b93
test_host_allow_retrieve_keytab.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
20c0a8eaba
test_host_allow_create_keytab.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
1d61128c9c
test_host.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
d95029bbc0
test_hosts_certificate.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
399a376451
test_host_certificate.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
aa57aa56f4
test_hbacsvcgroup.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
defd6d2e08
test_hbacsvc.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
29d565e3d2
test_hbacrule_categories.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
762c6e4f35
test_hbacrule.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
35d133fc3b
test_group_membermanager.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
c7e54628e3
test_group.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
6d04f99cc9
test_dnszone_name_from_ip.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
93baf68439
test_dnszone_mod.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
8eaa362732
test_dnszone.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
3d436677a5
test_dnsrecord_full_records.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
6911514d08
test_dnsrecord.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:41 +02:00
Thomas Woerner
b6cbc4d7f3
test_dnsforwardzone.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:40 +02:00
Thomas Woerner
7f0d367f78
test_dnsconfig.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:40 +02:00
Thomas Woerner
eb5c12f136
test_config.yml: Use result.failed also for failed_when
...
For failed_when result.failed should be used to make sure that
the task fails if there was an error.
2021-05-26 16:10:40 +02:00
Thomas Woerner
a30d8a27eb
test_dnszone.yml: Add failed_when and idempotency test
...
For test zones test1, test2 and test3 there is no verification if the
task is setting changed flag and also is not failing. Also the repeated
tests for idempotency are missing.
2021-05-26 16:10:40 +02:00
Thomas Woerner
3c357a2f07
test_dnsforwardzone.yml: Add failed_when and repeated tests
...
One task is missing the verification of the test result, some other
tasks are not repeated to verify idempotency.
2021-05-26 16:10:40 +02:00
Thomas Woerner
0e11119f4e
test_dnsrecord.yml: Add failed_when test for A rec with reverse, NS record
...
The test to make sure that the task set the changed flag and did not
fail was missing. Also the repeated task to make sure that the task did
not set the change flag.
2021-05-26 16:10:40 +02:00
Thomas Woerner
df97de31b5
test_sudorule.yml: Add failed_when for sudorule disabled test
...
The sudorule disabled test is lacking the register and failed_when
lines. The lines have been added to make sure that it is verified
that the task set the changed flag and does not fail.
2021-05-26 16:10:40 +02:00
Rafael Guterres Jeffman
d843399c75
Merge pull request #562 from chr15p/typos
...
fix minor documentation typos in sudo modules
2021-05-26 09:34:49 -03:00
Rafael Guterres Jeffman
5364ace101
Merge pull request #548 from t-woerner/user_fix_nomembers_always_triggers_mod
...
user: Fix no modifications to be performed error
2021-05-26 09:21:35 -03:00
chrisp
f51107e878
fix minor documentation typos in sudo modules
2021-05-26 13:16:49 +01:00
Thomas Woerner
ea823518e8
Merge pull request #532 from rjeffman/pylint_fixes
...
Add partial support for Pylint.
2021-05-26 10:10:08 +02:00
Rafael Guterres Jeffman
f7698271bd
Enable pylint in utils/lint_check.sh
...
The script utils/lint_check.sh should be used before push commits
to the repository. This change enables pylint to be executed by
the script.
2021-05-25 18:42:02 -03:00
Rafael Guterres Jeffman
967f9c7474
Fix, by disabling, pylint's warning on unnecessary pass.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
bf30d4b5f8
Fix, by disabling, pylint's warning on too few public methods.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
9c591de3cd
Fix anomalous use of '\' in reguluar expression.
2021-05-25 14:13:43 -03:00
Rafael Guterres Jeffman
a12275bc0e
Fix, by disabling, pylint's error too-many-function-args (E1121).
2021-05-25 14:13:43 -03:00