internet/ansible-freeipa
4
0
Fork 0
mirror of https://github.com/freeipa/ansible-freeipa.git synced 2026-03-26 21:33:05 +00:00
Code Issues Projects Releases Wiki Activity

Missing admin passwords in location module.

Browse Source 
Tests for module ipalocation failed due to missing ipaadmin_password.

Added the variable to the playbooks, and also fixed the examples and
documentation. Some playbooks had identation fixed to two spaces
instead of one for consistency with other modules.
This commit is contained in:
Rafael Guterres Jeffman
2020-08-14 12:32:51 -03:00
parent 33db65374b
commit b7722a476f
5 changed files with 31 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
README-location.md
View File

@@ -49,6 +49,7 @@ Example playbook to make sure location "my_location1" is present:
tasks:
- ipalocation:
ipaadmin_password: SomeADMINpassword
name: my_location1
description: My Location 1
```
@@ -64,6 +65,7 @@ Example playbook to make sure location "my_location1" is absent:
tasks:
- ipalocation:
ipaadmin_password: SomeADMINpassword
name: my_location1
state: absent
```

5
playbooks/location/location-absent.yml
View File

@@ -6,5 +6,6 @@
tasks:
- name: Ensure location my_location1 is absent
ipalocation:
name: my_location1
state: absent
ipaadmin_password: SomeADMINpassword
name: my_location1
state: absent

3
playbooks/location/location-present.yml
View File

@@ -6,4 +6,5 @@
tasks:
- name: Ensure location my_location1 is present
ipalocation:
name: my_location1
ipaadmin_password: SomeADMINpassword
name: my_location1

2
plugins/modules/ipalocation.py
View File

@@ -55,11 +55,13 @@ options:
EXAMPLES = """
# Ensure location my_location1 is present
- ipalocation:
ipaadmin_password: SomeADMINpassword
name: my_location1
description: My location 1
# Ensure location my_location1 is absent
- ipalocation:
ipaadmin_password: SomeADMINpassword
name: my_location1
state: absent
"""

36
tests/location/test_location.yml
View File

@@ -9,8 +9,9 @@
- name: Ensure location my_location1 is absent
ipalocation:
name: my_location1
state: absent
ipaadmin_password: SomeADMINpassword
name: my_location1
state: absent
# CREATE TEST ITEMS
@@ -18,41 +19,47 @@
- name: Ensure location my_location1 is present
ipalocation:
name: my_location1
ipaadmin_password: SomeADMINpassword
name: my_location1
register: result
failed_when: not result.changed or result.failed
- name: Ensure location my_location1 is present again
ipalocation:
name: my_location1
ipaadmin_password: SomeADMINpassword
name: my_location1
register: result
failed_when: result.changed or result.failed
- name: Ensure location my_location1 is present with description
ipalocation:
name: my_location1
description: My Location 1
ipaadmin_password: SomeADMINpassword
name: my_location1
description: My Location 1
register: result
failed_when: not result.changed or result.failed
- name: Ensure location my_location1 is present again with description
ipalocation:
name: my_location1
description: My Location 1
ipaadmin_password: SomeADMINpassword
name: my_location1
description: My Location 1
register: result
failed_when: result.changed or result.failed
- name: Ensure location my_location1 is absent
ipalocation:
name: my_location1
state: absent
ipaadmin_password: SomeADMINpassword
name: my_location1
state: absent
register: result
failed_when: not result.changed or result.failed
- name: Ensure location my_location1 is absent again
ipalocation:
name: my_location1
state: absent
ipaadmin_password: SomeADMINpassword
name: my_location1
state: absent
register: result
failed_when: result.changed or result.failed
@@ -60,5 +67,6 @@
- name: Ensure location my_location1 is absent
ipalocation:
name: my_location1
state: absent
ipaadmin_password: SomeADMINpassword
name: my_location1
state: absent