ipa[server,replica]: Renamed X_no_firewalld to X_setup_firewalld

The use of the _no_ prefix was not good and has been fixed now.

The X_setup_firewalld settings default to yes.

roles/ipareplica/defaults/main.yml

@@ -39,4 +39,5 @@ ipareplica_ignore_last_of_role: no
 ### additional ###
 ### packages ###
 ipareplica_install_packages: yes
-ipareplica_no_firewalld: no
+### firewalld ###
+ipareplica_setup_firewalld: yes

roles/ipareplica/tasks/install.yml

@@ -95,7 +95,7 @@
       --add-service=freeipa-replication
       {{ "--add-service=dns" if ipareplica_setup_dns | bool else "" }}
       {{ "--add-service=ntp" if not ipaclient_no_ntp | bool else "" }}
-    when: not ipareplica_no_firewalld | bool
+    when: ipareplica_setup_firewalld | bool
 
   - name: Install - Configure firewalld runtime
     command: >
@@ -105,7 +105,7 @@
       --add-service=freeipa-replication
       {{ "--add-service=dns" if ipareplica_setup_dns | bool else "" }}
       {{ "--add-service=ntp" if not ipaclient_no_ntp | bool else "" }}
-    when: not ipareplica_no_firewalld | bool
+    when: ipareplica_setup_firewalld | bool
 
   - name: Install - Replica preparation
     ipareplica_prepare:

roles/ipaserver/defaults/main.yml

@@ -33,7 +33,7 @@ ipaserver_setup_ca: yes
 ### packages ###
 ipaserver_install_packages: yes
 ### firewalld ###
-ipaserver_no_firewalld: no
+ipaserver_setup_firewalld: yes
 
 ### additional ###
 ipaserver_allow_missing: [ ]

roles/ipaserver/tasks/install.yml

@@ -378,7 +378,7 @@
       --add-service=freeipa-ldaps
       {{ "--add-service=dns" if ipaserver_setup_dns | bool else "" }}
       {{ "--add-service=ntp" if not ipaclient_no_ntp | bool else "" }}
-    when: not ipaserver_no_firewalld | bool
+    when: ipaserver_setup_firewalld | bool
 
   - name: Install - Configure firewalld runtime
     command: >
@@ -387,4 +387,4 @@
       --add-service=freeipa-ldaps
       {{ "--add-service=dns" if ipaserver_setup_dns | bool else "" }}
       {{ "--add-service=ntp" if not ipaclient_no_ntp | bool else "" }}
-    when: not ipaserver_no_firewalld | bool
+    when: ipaserver_setup_firewalld | bool