Merge pull request #582 from rjeffman/dnszone_add_check_mode_support

ipadnszone: add check mode support

plugins/module_utils/ansible_freeipa_module.py

@@ -962,6 +962,10 @@ else:
 
         def _run_ipa_commands(self):
             """Execute commands in self.ipa_commands."""
+            if self.check_mode:
+                self.changed = len(self.ipa_commands) > 0
+                return
+
             result = None
 
             for name, command, args in self.ipa_commands:

plugins/modules/ipadnszone.py

@@ -537,6 +537,7 @@ def main():
         argument_spec=get_argument_spec(),
         mutually_exclusive=[["name", "name_from_ip"]],
         required_one_of=[["name", "name_from_ip"]],
+        supports_check_mode=True,
     ).ipa_run()
 
 

tests/dnszone/test_dnszone.yml

@@ -11,6 +11,24 @@
     include_tasks: env_setup.yml
 
   # Tests
+  - name: Check if zone is present, when in shouldn't be.
+    ipadnszone:
+      ipaadmin_password: SomeADMINpassword
+      name: testzone.local
+      state: present
+    check_mode: yes
+    register: result
+    failed_when: not result.changed or result.failed
+
+  - name: Check if zone is present again, when in shouldn't be.
+    ipadnszone:
+      ipaadmin_password: SomeADMINpassword
+      name: testzone.local
+      state: present
+    check_mode: yes
+    register: result
+    failed_when: not result.changed or result.failed
+
   - name: Ensure zone is present.
     ipadnszone:
       ipaadmin_password: SomeADMINpassword
@@ -19,6 +37,15 @@
     register: result
     failed_when: not result.changed or result.failed
 
+  - name: Check if zone is present, when in should be.
+    ipadnszone:
+      ipaadmin_password: SomeADMINpassword
+      name: testzone.local
+      state: present
+    check_mode: yes
+    register: result
+    failed_when: result.changed or result.failed
+
   - name: Ensure zone is present, again.
     ipadnszone:
       ipaadmin_password: SomeADMINpassword