Merge "Change the pipeline of releasing to tag pipeline"

Because zuul pre-release pipeline is pep400 compliant, but no
semver compliant, we can't push pre-release tags. Galaxy expects
from tags to be pure semver (not pep440).
Change the pipeline to be 'tag' and be triggered by any tag.

Change-Id: Ia288452668179723e35452d6e9579fb1dd0c4c3a

.zuul.yaml

@@ -453,6 +453,6 @@
         - ansible-collections-openstack-functional-devstack-rocky-ansible-2.11
         - ansible-collections-openstack-functional-devstack-queens-ansible-devel
 
-    pre-release:
+    tag:
       jobs:
         - ansible-collections-openstack-release

ci/publish/publish_collection.yml

@@ -24,6 +24,20 @@
         msg: "No tag was found in Zuul vars!"
       when: version_tag == 'no_version'
 
+    # Ansible Galaxy can accept only pure semver versions
+    # see https://semver.org for details
+    - name: Check that tag is proper semver
+      debug:
+        msg: >-
+          {{ version_tag is version('999.999.999', 'lt', version_type='semver') }}
+      ignore_errors: true
+      register: test_semver
+
+    - name: Fail if tag is not proper semver
+      fail:
+        msg: "Error is: {{ test_semver.msg }}"
+      when: test_semver is failed
+
     - name: Create a directory for collection
       file:
         state: "{{ item }}"

plugins/modules/loadbalancer.py

@@ -296,6 +296,35 @@ from ansible_collections.openstack.cloud.plugins.module_utils.openstack import O
 
 class LoadBalancerModule(OpenStackModule):
 
+    def _wait_for_pool(self, pool, provisioning_status, operating_status, failures, interval=5):
+        """Wait for pool to be in a particular provisioning and operating status."""
+        timeout = self.params['timeout']  # reuse loadbalancer timeout
+
+        total_sleep = 0
+        if failures is None:
+            failures = []
+
+        while total_sleep < timeout:
+            pool = self.conn.load_balancer.find_pool(name_or_id=pool.id)
+            if pool:
+                if pool.provisioning_status == provisioning_status and pool.operating_status == operating_status:
+                    return None
+                if pool.provisioning_status in failures:
+                    self.fail_json(
+                        msg="Pool %s transitioned to failure state %s" %
+                            (pool.id, pool.provisioning_status)
+                    )
+            else:
+                if provisioning_status == "DELETED":
+                    return None
+                else:
+                    self.fail_json(
+                        msg="Pool %s transitioned to DELETED" % pool.id
+                    )
+
+            time.sleep(interval)
+            total_sleep += interval
+
     def _wait_for_lb(self, lb, status, failures, interval=5):
         """Wait for load balancer to be in a particular provisioning status."""
         timeout = self.params['timeout']
@@ -497,6 +526,7 @@ class LoadBalancerModule(OpenStackModule):
                                 protocol=protocol,
                                 lb_algorithm=lb_algorithm
                             )
+                            self._wait_for_pool(pool, "ACTIVE", "ONLINE", ["ERROR"])
                             changed = True
 
                     # Ensure members in the pool
@@ -538,6 +568,7 @@ class LoadBalancerModule(OpenStackModule):
                                 protocol_port=protocol_port,
                                 subnet_id=subnet_id
                             )
+                            self._wait_for_pool(pool, "ACTIVE", "ONLINE", ["ERROR"])
                             changed = True
 
                 # Associate public ip to the load balancer VIP. If