Commit Graph

80 Commits

Author SHA1 Message Date
Sagi Shnaidman
fbd03d187c Don't fetch subunit in jobs
Depends-On: https://review.opendev.org/#/c/714302/
Change-Id: I006051ec0aa7b4c98cc41cda097d085f6eea62c9
2020-03-23 03:33:21 +02:00
Sagi Shnaidman
42fbc640ee Add rocky, stein jobs
Add rocky and stein jobs to check and gate
and remove non voting jobs of ansible devel from gates.
Change-Id: Ib231a50fa5e8427ef39077bc49ac806aa0a5732e
2020-03-20 12:48:00 +02:00
Sagi Shnaidman
f982797b94 Add dependencies for long jobs on linters
Run long jobs only if linters passed
Change-Id: I374bbdd2111073d4f6a9ace22bf11f58afe1c21b
2020-03-20 12:42:24 +02:00
Sagi Shnaidman
290c5329cc Add ansible 2.9 and openstacksdk train jobs
Change-Id: I5e096c056291b7abf5355ab366b3ba25a0f68385
2020-03-19 12:23:55 +00:00
Monty Taylor
cf7011a742 Cleanup functional tests
Use the openstacksdk base functional test instead of going all
the way back to devstack for our base. Also - defining a job
starting with openstacksdk in this repo is not ok - but that
probably just came from the original copy-pasta coming from the
sdk repo.

Use tox-siblings more and stop doing tox requirements of ../
things. The system is there and we can use it.

Add jobs to test against released openstacksdk and ansible, as well
as a non-voting to test against ansible devel branch.

Add openstacksdk to the test-requirements because it's super
required.

Move zuul.yaml to .zuul.yaml. This isn't a zuul jobs repo so
we should just make it a hidden file rather than a non-hidden.

Change-Id: I658bd1728629cd358bc17a7f00d282d04530d8fe
2020-03-19 12:05:57 +00:00
Monty Taylor
75cc5012e3 Update os_client_config to use openstacksdk
This never got migrated but should. os-client-config is only
on life support.

Change-Id: I2d77c9f7d147900b79a410c17cce197108c0a69b
2020-03-17 13:35:45 -05:00
Mark Chappell
e39c5d0a9a Fixup elements related sanity failures
Change-Id: I6f2bba929af5a148a1f52df26916e00efcc14a07
2020-03-16 15:49:49 +01:00
Mark Chappell
63e444a324 Ensure documented choices match spec
Change-Id: Ia40e846f970a05a894601a7a37af0231f136bab6
2020-03-16 14:15:04 +01:00
Mark Chappell
f52598dd90 Use dict rather than complex for os_quota return type.
Change-Id: Ib8275a88eefb46ace471ddd12fadb018b4adbf9b
2020-03-16 13:56:58 +01:00
Mark Chappell
f16eda89dd Ensure defaults match spec
Change-Id: Ie5c499d7e035a0e9c3ac32e5dc5d57151c1745ed
2020-03-16 13:56:58 +01:00
Mark Chappell
aeb0e78148 Clean up doc-required-mismatch
Change-Id: Ia1449c50295f6b3551f176edf9bd439ace65ec90
2020-03-16 13:56:58 +01:00
Mark Chappell
1849f8bd47 Add missing type information to docs
Change-Id: Iac23d54512b23f031460d1b7281ccb8d93e20cad
2020-03-16 13:56:58 +01:00
Mark Chappell
9e9dacdf3c Fix doc requirements, and consistently require python 3.6+
Change-Id: I43f4ba5718422f75f553e3cae88fa887722aa044
2020-03-16 10:32:21 +01:00
Mark Chappell
400e9c4873 Move default availability_zone docs into doc_fragment
If availability_zone is defined in the module this will override the fragment

Change-Id: I4f6abcbfee89a53480134dc64ca06782c8e6d094
2020-03-16 10:32:20 +01:00
Zuul
8e64c96e48 Merge "os_nova_host_aggregate: Add support for not 'purging' missing hosts" 2020-03-13 17:43:06 +00:00
Zuul
3224e68ca2 Merge "os_nova_host_aggregate: Fixup sanity test failures" 2020-03-13 17:37:20 +00:00
Zuul
9580a65090 Merge "Remove MANIFEST.json before building" 2020-03-13 17:14:32 +00:00
Mark Chappell
c5cd1a0e9f os_nova_host_aggregate: Add support for not 'purging' missing hosts
Change-Id: I3ac44e49ef2b8b05b2a182916e2ba5a0a980692f
Depends-On: https://review.opendev.org/712917
2020-03-13 16:49:20 +01:00
Mark Chappell
d39f3ae5b0 os_nova_host_aggregate: Fixup sanity test failures
Change-Id: I40cc48c8b04713a63ab8fd8c71b785a824cf3715
2020-03-13 16:49:20 +01:00
Monty Taylor
852f385889 Remove MANIFEST.json before building
For reasons surpassing understanding this doesn't seem to get
overwritten.

Change-Id: Ib4d6b38757112908dbf58d70015482831a8c2e95
2020-03-13 10:14:58 -05:00
Sagi Shnaidman
67466513da Add option for modules_default groups
It's possible in Ansible to set options for modules with
modules_default keyword[1]. For some of modules it's possible
to do with module_default groups, like cloud modules[2]
Add this option to OS modules.

[1]
https://docs.ansible.com/ansible/latest/user_guide/playbooks_module_defaults.html#module-defaults

[2]
https://docs.ansible.com/ansible/latest/user_guide/playbooks_module_defaults.html#module-defaults-groups

Change-Id: I31e36f3a6d600815152a116afb37f8e3e21bc282
2020-03-10 14:06:06 +02:00
Zuul
a451edcb5c Merge "Add Openstack guidelines spec from Ansible" 2020-03-05 16:39:08 +00:00
Sagi Shnaidman
31b113d402 Add Openstack guidelines spec from Ansible
These may not be 100% perfect, but they are a good
starting place and we can improve them over time.

Change-Id: Ifb21554d67863b4e4e964f3e98263c3dafcb607f
2020-03-05 15:40:51 +00:00
Monty Taylor
1553d34b02 Clean up minor build quibbles
collection build produces FILES.json and METADATA.json, so add them
to the .gitignore. Also, remove the version line from galaxy.yml.in
since it's generated.

Change-Id: I2ea0b04c8e56b3b7186ac2e9c475144340067636
2020-03-05 15:08:44 +00:00
Monty Taylor
e0200e9faf Fix license metadata
The galaxy upload rejects GPLv3 and requires a valid SPDX license
tag. The file headers list:

  GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

which is a way of saying "3 or later" - so use that SPDX tag.

Also - the license headers refer to the file being COPYING, so
rename the file and update it in the galaxy metadata to match.

Change-Id: I6c82b49d7ce5ea8c9cde939d5d37ff54b969a598
2020-03-05 15:08:38 +00:00
Monty Taylor
97eb24ac4d Deal with collection build modifying tree
ansible-galaxy collection build modifies the contents of the tree.
Let's not go in to why this is bad, but instead just deal with it.
The issue in question is that is removes the +x bit from files in
the tree, which means you can't run a build twice in a row locally.
Shrug. Just roll with the -x and update our usage to reflect it.

Change-Id: I0f82531e99a98d656b60079fd3e94d4e3a1dbb6b
2020-03-05 15:08:32 +00:00
Zuul
c9d2866b57 Merge "Test with and assert support for python3" 2020-03-04 22:27:00 +00:00
Zuul
11331d7f1f Merge "Remove from __future__ lines" 2020-03-04 22:26:59 +00:00
Zuul
fba0eda1d8 Merge "Fix H236 and remove exclusion" 2020-03-04 22:22:02 +00:00
Zuul
4b27e9bafd Merge "Just use shutil.rmtree in build.py" 2020-03-03 16:38:46 +00:00
Monty Taylor
53affc3220 Test with and assert support for python3
Collections are new. openstacksdk as of now doesn't support python2.
We shouldn't pretend to support python2 either. If you're using
ansible new enough to use collections, you can use python3.

This release of openstacksdk only supports 3.6 and onwards, so
set that as our min.

Change-Id: I34d544ce48f25bffde8e6e0cf82cdf9a85e681c3
2020-03-03 09:28:43 -06:00
Zuul
17cdcee058 Merge "os_coe_cluster: Retrive id/uuid correctly" 2020-03-02 18:36:17 +00:00
Bharat Kunwar
050acb6c03 os_coe_cluster: Retrive id/uuid correctly
Fix https://github.com/ansible/ansible/issues/67576

Change-Id: I59b07a8733d549015ed1999e30970d1131c82f99
Signed-off-by: Bharat Kunwar <brtknr@bath.edu>
2020-03-02 17:09:30 +00:00
Zuul
79b2b1001a Merge "Fix F401 and remove exclusion" 2020-03-02 13:31:36 +00:00
Zuul
4b6c60ff14 Merge "Fix W504 and remove exclusion" 2020-03-02 13:31:35 +00:00
Zuul
d2674e42b2 Merge "Fix E128 and remove exclusion" 2020-03-02 13:31:35 +00:00
Zuul
a2cd8aaf6f Merge "Remove F403 and F405 exclusions" 2020-03-02 13:31:34 +00:00
Zuul
32905ea099 Merge "Fix F841 and remove exclusion" 2020-03-02 13:31:33 +00:00
Zuul
a86bcbe9ed Merge "Run flake8 in linters" 2020-03-02 13:31:32 +00:00
Zuul
006b7a0b75 Merge "Remove old artifacts when building new ones" 2020-03-02 13:27:49 +00:00
Monty Taylor
96a5914eb6 Remove from __future__ lines
We only support python3

Change-Id: Ieb82eb3369c4ac73f3595dc84ca11e1f11766a79
2020-03-01 06:26:03 -06:00
Monty Taylor
9d29e8c847 Fix H236 and remove exclusion
We haven't needed this in a VERY long time.

Change-Id: I35041c2c6ae421e7caaef3c04ffca92e2ff10e35
2020-03-01 06:22:58 -06:00
Monty Taylor
4df2fdb4fe Just use shutil.rmtree in build.py
Turns out there's a stdlib function for this.

Change-Id: I38885c4b6d973b2a7083a04acb3f5cea9ad78ad9
2020-03-01 06:17:35 -06:00
Zuul
c1f610dac9 Merge "Add a tool to build collections with pbr" 2020-02-29 14:50:44 +00:00
Zuul
584220fdd3 Merge "fix constructed compose" 2020-02-27 23:38:05 +00:00
Zuul
bb73bafd9a Merge "Add tests for os_user_role in multidomain context" 2020-02-27 23:33:26 +00:00
Monty Taylor
86670bcec9 Fix F401 and remove exclusion
Change-Id: Id2dbff06925ed8326e4a214aabc19d4ada5db69c
2020-02-27 13:56:48 -06:00
Monty Taylor
92d7d7caeb Fix W504 and remove exclusion
This is a topic where there are two points of view. While neither
is fundamentally better than the other in reality, what's best is
to not have any arguments about it. The tox.ini comments about 503
and 504 that were in place make the argument that:

  - 503 is intended to be disabled and 504 enabled by default
  - Donald Knuth believes 504 is the right way

Since Donald Knuth is smarter than all of us, align with 504, match
the comments in the file and turn on enforcement to keep it that way.

Change-Id: I92d4d1e82935e30ae42a0e14e641cbe36fd6e811
2020-02-27 13:56:48 -06:00
Monty Taylor
72ba76f156 Fix E128 and remove exclusion
Change-Id: I0517c0ed09d7834df763c745936793739e88ef9d
2020-02-27 13:56:48 -06:00
Monty Taylor
2527faec28 Remove F403 and F405 exclusions
Importing from * is not a thing that should be done, as it masks
errors and makes code hard to understand. There are some copy-pasta
files that violate this. Mark them with noqa for now, because we don't
actually care about them.

Change-Id: I790f88c75ea546d83e347e42df0050ad36211936
2020-02-27 13:56:48 -06:00