Commit Graph

72 Commits

Author SHA1 Message Date
Zuul
4a930cf0ec Merge "keypair: make use of OpenStackModule class" 2020-07-09 14:30:16 +00:00
Gonéri Le Bouder
9600baec6e security_group_rule: use OpenStackModule class
Refactoring of security_group_rule to depend on the OpenStackModule
class.

See: I487e79fe18c0b9a75df7dacd224ab40ed7f4e1ab

Change-Id: Ide09bdd6a57324a0e1d2ec29c4c49db8dc1c3843
2020-07-02 19:23:15 +00:00
Gonéri Le Bouder
abebbe722c keypair: make use of OpenStackModule class
Convert the keypair module to use the OpenStackModule class.

See: I487e79fe18c0b9a75df7dacd224ab40ed7f4e1ab

Change-Id: I60cd5811f1926f53a7f88b19889fba9ca39c6184
2020-07-02 13:59:36 -04:00
Monty Taylor
a96d28dfbc Update author lines
We don't use github, so having @ mentions of specific humans is
not valuable. Also, we are a team and own the modules as a team,
so calling out individual authors is philosophically contrary.

We landed a patch upstream to special-case this author string.

Change-Id: I38b4e68f14bbba6e13e8a50e2b202874ab74e3bc
2020-06-23 21:50:43 +03:00
Sagi Shnaidman
5e3a91a7c6 Add OpenstackModule to os_server_action
Redesign the module for more OOP
Add tests for server_action
Change-Id: I054de32ee3ff34988db53fc87b1cb63b8e551ae3
2020-06-17 12:59:23 +00:00
Zuul
f8c768ae61 Merge "Don't pass tenant_id for remote group" 2020-06-13 16:34:06 +00:00
Sagi Shnaidman
c75ab0924a Fix ansible-devel sanity tests for deprecations
Change-Id: I02c3f2cb5a8bb4c891a8f0e36628925208251bf7
2020-06-11 12:55:43 +03:00
Sagi Shnaidman
8e2e5966b7 Don't pass tenant_id for remote group
When security group is from different project, don't pass tenant
Fixes https://github.com/ansible/ansible/issues/69673
Change-Id: I230c41d1ace179390744287102fead5ddf420157
2020-06-07 18:12:30 +00:00
Sagi Shnaidman
f3610ad0e1 Redesign OpenstackModule class
don't inherit OpenstackModule class from AnsibleModule class to
prevent occasional overriding Ansible methods or vars and failing
module.

Change-Id: Ic34fff0c938eb87cc0d2c5e98fbafed64bf349f6
2020-06-04 13:49:48 +03:00
Sagi Shnaidman
7e4fbcf568 Fix ansible-tests for devel branch
Ignore for now deprecation warnings
(see https://github.com/ansible-collections/overview/issues/45#issuecomment-628262697)
Current there are bugs in ansible-test that prevent to run these
tests.

Change-Id: I9829bb23a45699e61d7b0af5ecc3e1a94bbbca85
2020-06-03 00:05:07 +03:00
Matt Parkinson
d206ea000a Minor spelling fixes in floating_ip documentation
Change-Id: Ib888b4890ff91a9bccaaa1e8b582a478243e47a3
2020-05-25 13:38:25 +10:00
Sagi Shnaidman
ad7d6ea668 Fix broken server_info module and add tests
Fix server_info module. Add tests because it wasn't executed in
tests at all.

Change-Id: I50435f3a3103501bc0eccf8fdfced3179b991bb8
2020-05-21 20:56:13 +03:00
Sagi Shnaidman
572fe85894 Remove ANSIBLE_METADATA from all modules
It's not required for collections,
for more details:
https://github.com/ansible-collections/overview/issues/57
Change-Id: I954eef25bb9837c9282665ad5586dbe37f4f4424
2020-05-14 17:00:01 +03:00
Monty Taylor
e47c4671c7 Rename all of the modules
This is separate from the previous patch - it's just the results
of running the script so we can review the two a little independently.
We should probably squash them.

Change-Id: I838f15cf4a32455a5be20033c8ddc27db6ca15c0
2020-05-12 10:20:50 -05:00
Zuul
1906b85668 Merge "Updated allocation pool checks" 2020-05-10 14:21:01 +00:00
Ken Dreyer
25ad4882b0 os_server_action: pass imageRef to rebuild
Prior to this change, the os_server_action module could not rebuild
servers, because it passed no arguments to the "rebuild" object.

The imageRef parameter is mandatory. If the client does not specify
imageRef, Nova takes no action to rebuild the server.

Change-Id: I0edbdb634feb90d4c54476a4089fcb014c0b83b2
2020-04-29 14:56:49 -06:00
rawat
95dcd82cbb Updated allocation pool checks
As per the REST Networking API v2.0 (Subnet) docs, if subnets pools
are not specified, OpenStack networking automatically allocates pools
covering all IP addresses in the CIDR.

In custom vendor specific environments, subnets can be created without
allocation pools via UI due to which subnets will not have any existing
allocation pools. Under this scenario, module throws an
"IndexError: list index out of range" error.

Also, allow to add more allocation pools on top of existing allocation
pools.

Change-Id: Ib8becf5e958f1bc8e5c9fd76f1722536bf1c9f1a
2020-04-27 07:19:56 +10:00
Sagi Shnaidman
b824bf1c38 Convert os_server_info to use OpenStackModule
Change-Id: I864c767ff06d32dd79b72826cfc09e7203e5291d
2020-04-21 19:08:46 +03:00
Zuul
d1ad72a068 Merge "Add properties for os_project" 2020-04-16 19:33:48 +00:00
Duc Truong
c1a2496e0f Add properties for os_project
Keystone supports setting custom properties for projects.  This changes add
properties to os_project to enable setting of custom properties.

Depends-On: https://review.opendev.org/715255
Change-Id: I23e2834d6b9d40ce86db4b32a0ed8bf76b3d9879
2020-04-14 10:11:12 -07:00
Zuul
2b51a58da2 Merge "New Module: os_keystone_federation_protocol_info" 2020-04-03 16:13:26 +00:00
Zuul
0424bb8ac1 Merge "New Module: os_keystone_federation_protocol" 2020-04-03 16:12:45 +00:00
Mark Chappell
583770f597 New Module: os_keystone_federation_protocol_info
Add support for getting information about Keystone federation Protocols

Change-Id: Id389b094465967a2a8a0eff428f1f6679865c6f6
2020-04-02 17:27:06 +02:00
Mark Chappell
8729b8da72 New Module: os_keystone_federation_protocol
Add support for Keystone federation Protocols

Depends-On: https://review.opendev.org/714431
Depends-On: https://review.opendev.org/713461
Change-Id: I6dff6cebe72106e601834976e369e08583391c55
2020-04-02 17:26:31 +02:00
Mark Chappell
54c189063f os_keystone_mapping: fixup some minor nits found in followup reviews
Change-Id: I0c8995e8d52a993395e674c06c84f6398473754c
2020-04-02 17:23:27 +02:00
Zuul
bf4af7b1b9 Merge "New Module: os_keystone_identity_provider_info" 2020-04-02 14:42:08 +00:00
Zuul
9e2eeedaf3 Merge "New Module: os_keystone_identity_provider" 2020-04-02 14:42:08 +00:00
Zuul
d2379cd284 Merge "New module: os_keystone_mapping_info" 2020-04-02 14:35:51 +00:00
Mark Chappell
c85817dac9 New Module: os_keystone_identity_provider_info
Add support for fetching the information about federation IDPs

Change-Id: I36b7fa264866689e09b020b13b7bdc3843bfacfb
2020-04-02 13:59:14 +02:00
Mark Chappell
b74791754b New Module: os_keystone_identity_provider
Add support for Keystone Identity Providers

Depends-On: https://review.opendev.org/714122
Depends-On: https://review.opendev.org/713461
Change-Id: I9d4ba6b9e7b1e618f985a8264fb0238fe3cbc7bd
2020-04-02 13:59:14 +02:00
Mark Chappell
1b7ecc7a4a New module: os_keystone_mapping_info
Change-Id: I716c00b7f3cde7df6a220c20a8c0652ccbe8bdce
Depends-On: https://review.opendev.org/716908
2020-04-02 13:43:31 +02:00
Sagi Shnaidman
347347b46e Fix ansible sanity linter tests
Change-Id: I2d08fdc77d930378be515da697c1cf975dd8b4d2
2020-04-02 13:20:01 +02:00
Mark Chappell
cde068ca70 New Module: os_keystone_mapping
Depends-On: https://review.opendev.org/713633
Depends-On: https://review.opendev.org/713461
Change-Id: I6842b7d10fca292a6779043b50fb95bd0d93e584
2020-03-26 07:18:46 +01:00
Monty Taylor
75cc5012e3 Update os_client_config to use openstacksdk
This never got migrated but should. os-client-config is only
on life support.

Change-Id: I2d77c9f7d147900b79a410c17cce197108c0a69b
2020-03-17 13:35:45 -05:00
Mark Chappell
e39c5d0a9a Fixup elements related sanity failures
Change-Id: I6f2bba929af5a148a1f52df26916e00efcc14a07
2020-03-16 15:49:49 +01:00
Mark Chappell
63e444a324 Ensure documented choices match spec
Change-Id: Ia40e846f970a05a894601a7a37af0231f136bab6
2020-03-16 14:15:04 +01:00
Mark Chappell
f52598dd90 Use dict rather than complex for os_quota return type.
Change-Id: Ib8275a88eefb46ace471ddd12fadb018b4adbf9b
2020-03-16 13:56:58 +01:00
Mark Chappell
f16eda89dd Ensure defaults match spec
Change-Id: Ie5c499d7e035a0e9c3ac32e5dc5d57151c1745ed
2020-03-16 13:56:58 +01:00
Mark Chappell
aeb0e78148 Clean up doc-required-mismatch
Change-Id: Ia1449c50295f6b3551f176edf9bd439ace65ec90
2020-03-16 13:56:58 +01:00
Mark Chappell
1849f8bd47 Add missing type information to docs
Change-Id: Iac23d54512b23f031460d1b7281ccb8d93e20cad
2020-03-16 13:56:58 +01:00
Mark Chappell
9e9dacdf3c Fix doc requirements, and consistently require python 3.6+
Change-Id: I43f4ba5718422f75f553e3cae88fa887722aa044
2020-03-16 10:32:21 +01:00
Mark Chappell
400e9c4873 Move default availability_zone docs into doc_fragment
If availability_zone is defined in the module this will override the fragment

Change-Id: I4f6abcbfee89a53480134dc64ca06782c8e6d094
2020-03-16 10:32:20 +01:00
Mark Chappell
c5cd1a0e9f os_nova_host_aggregate: Add support for not 'purging' missing hosts
Change-Id: I3ac44e49ef2b8b05b2a182916e2ba5a0a980692f
Depends-On: https://review.opendev.org/712917
2020-03-13 16:49:20 +01:00
Mark Chappell
d39f3ae5b0 os_nova_host_aggregate: Fixup sanity test failures
Change-Id: I40cc48c8b04713a63ab8fd8c71b785a824cf3715
2020-03-13 16:49:20 +01:00
Zuul
c9d2866b57 Merge "Test with and assert support for python3" 2020-03-04 22:27:00 +00:00
Zuul
11331d7f1f Merge "Remove from __future__ lines" 2020-03-04 22:26:59 +00:00
Zuul
fba0eda1d8 Merge "Fix H236 and remove exclusion" 2020-03-04 22:22:02 +00:00
Monty Taylor
53affc3220 Test with and assert support for python3
Collections are new. openstacksdk as of now doesn't support python2.
We shouldn't pretend to support python2 either. If you're using
ansible new enough to use collections, you can use python3.

This release of openstacksdk only supports 3.6 and onwards, so
set that as our min.

Change-Id: I34d544ce48f25bffde8e6e0cf82cdf9a85e681c3
2020-03-03 09:28:43 -06:00
Zuul
17cdcee058 Merge "os_coe_cluster: Retrive id/uuid correctly" 2020-03-02 18:36:17 +00:00
Bharat Kunwar
050acb6c03 os_coe_cluster: Retrive id/uuid correctly
Fix https://github.com/ansible/ansible/issues/67576

Change-Id: I59b07a8733d549015ed1999e30970d1131c82f99
Signed-off-by: Bharat Kunwar <brtknr@bath.edu>
2020-03-02 17:09:30 +00:00