Commit Graph

156 Commits

Author SHA1 Message Date
Zuul
4a930cf0ec Merge "keypair: make use of OpenStackModule class" 2020-07-09 14:30:16 +00:00
Zuul
e1fe3f6067 Merge "security_group_rule: use OpenStackModule class" 2020-07-09 14:24:08 +00:00
Baptiste Mille-Mathias
bbe1d84448 Add a link for issue report and feature request
Change-Id: I00511b314bbc8a6c03a2ee1e6c626147bfe8f49d
2020-07-04 11:31:30 +02:00
Gonéri Le Bouder
9600baec6e security_group_rule: use OpenStackModule class
Refactoring of security_group_rule to depend on the OpenStackModule
class.

See: I487e79fe18c0b9a75df7dacd224ab40ed7f4e1ab

Change-Id: Ide09bdd6a57324a0e1d2ec29c4c49db8dc1c3843
2020-07-02 19:23:15 +00:00
Gonéri Le Bouder
abebbe722c keypair: make use of OpenStackModule class
Convert the keypair module to use the OpenStackModule class.

See: I487e79fe18c0b9a75df7dacd224ab40ed7f4e1ab

Change-Id: I60cd5811f1926f53a7f88b19889fba9ca39c6184
2020-07-02 13:59:36 -04:00
Zuul
94e518e42c Merge "Update author lines" 2020-06-24 15:30:26 +00:00
Monty Taylor
a96d28dfbc Update author lines
We don't use github, so having @ mentions of specific humans is
not valuable. Also, we are a team and own the modules as a team,
so calling out individual authors is philosophically contrary.

We landed a patch upstream to special-case this author string.

Change-Id: I38b4e68f14bbba6e13e8a50e2b202874ab74e3bc
2020-06-23 21:50:43 +03:00
Artem Goncharov
32ef77d9fd Add more useful information from exception
When the module faces API exception we can give much more useful
information to the user. Let us do this for the modules inheriting from
the base class, since all modules should do this at some point in time

Change-Id: I5f1ef01765829900334aa2ecae5dab3ba96f1a49
2020-06-23 18:43:09 +00:00
Sagi Shnaidman
4b64ebe623 Fix typos in job definitions
Change-Id: I654751a879482b1996c863470a6cf68f254eefbb
2020-06-23 16:23:54 +03:00
Sagi Shnaidman
01c2499fb6 New CI jobs configuration
Change-Id: Ib6850184faf1bc0808502c098d610a5e2f41f47e
2020-06-23 12:27:04 +03:00
Sagi Shnaidman
5e3a91a7c6 Add OpenstackModule to os_server_action
Redesign the module for more OOP
Add tests for server_action
Change-Id: I054de32ee3ff34988db53fc87b1cb63b8e551ae3
2020-06-17 12:59:23 +00:00
Sagi Shnaidman
fc852da4bc Fixes for modules generation script
Change-Id: Iffbb8e9f9106860f3d896f65831d2b9283ad1e7b
2020-06-17 13:35:10 +03:00
Sagi Shnaidman
5717f05102 Move action_group to runtime
from https://github.com/openstack/ansible-collections-openstack/pull/2

Change-Id: I82c68c31bccd54d5c2624bf2081820c09791b466
2020-06-17 10:17:23 +00:00
Sagi Shnaidman
4d0df9f022 Fix ansible-test errors
Add tox to requirements
Use only 3.6 python
Set ansible-test 2.9 as a gate job

Change-Id: I40757e1efc3ee297b44cda6c35cdce4c64ebaa4f
2020-06-17 12:53:05 +03:00
Zuul
f8c768ae61 Merge "Don't pass tenant_id for remote group" 2020-06-13 16:34:06 +00:00
Sagi Shnaidman
4d1017d5d9 Add note about py3 in readme
Change-Id: I7ac15d84d54e9ebc1260b633326e19b612a83170
2020-06-11 14:24:03 +00:00
Sagi Shnaidman
c75ab0924a Fix ansible-devel sanity tests for deprecations
Change-Id: I02c3f2cb5a8bb4c891a8f0e36628925208251bf7
2020-06-11 12:55:43 +03:00
Sagi Shnaidman
dfa7983a78 Add notes to README about deps and versions
Change-Id: Ied2ac325af5aee174fc0d20d9aada67a859fa81b
2020-06-09 14:33:40 +00:00
Sagi Shnaidman
8e2e5966b7 Don't pass tenant_id for remote group
When security group is from different project, don't pass tenant
Fixes https://github.com/ansible/ansible/issues/69673
Change-Id: I230c41d1ace179390744287102fead5ddf420157
2020-06-07 18:12:30 +00:00
Sagi Shnaidman
c9da50e7e7 Add setup.py for install with pip
Make possible installation with pip.
Change-Id: I8eec015142c4f29eadff0dac2781782b76dea308
2020-06-04 14:23:23 +00:00
Sagi Shnaidman
f3610ad0e1 Redesign OpenstackModule class
don't inherit OpenstackModule class from AnsibleModule class to
prevent occasional overriding Ansible methods or vars and failing
module.

Change-Id: Ic34fff0c938eb87cc0d2c5e98fbafed64bf349f6
2020-06-04 13:49:48 +03:00
Sagi Shnaidman
7e4fbcf568 Fix ansible-tests for devel branch
Ignore for now deprecation warnings
(see https://github.com/ansible-collections/overview/issues/45#issuecomment-628262697)
Current there are bugs in ansible-test that prevent to run these
tests.

Change-Id: I9829bb23a45699e61d7b0af5ecc3e1a94bbbca85
2020-06-03 00:05:07 +03:00
Zuul
f89644973d Merge "Add template for generation of artibtrary module" 2020-05-28 19:55:17 +00:00
Zuul
b4f015ebd7 Merge "Remove unnecessary requirements file" 2020-05-25 18:12:16 +00:00
Sagi Shnaidman
f0da22da7e Remove unnecessary requirements file
for reference:
https://github.com/ansible-collections/overview/issues/43
Change-Id: I0136b4d173cb7e1d45a2b4535d8772c68f8d5783
2020-05-25 14:43:18 +03:00
Matt Parkinson
d206ea000a Minor spelling fixes in floating_ip documentation
Change-Id: Ib888b4890ff91a9bccaaa1e8b582a478243e47a3
2020-05-25 13:38:25 +10:00
Sagi Shnaidman
5667600420 Add template for generation of artibtrary module
One is for resource changing module, like server start or delete,
second one is for info collection about a specific resource.

Change-Id: I78b35075111731fff2fd50837fa4e6e0c61c55a0
2020-05-25 02:27:40 +03:00
Sagi Shnaidman
98ce765383 Exclude docs and text files form CI jobs
Change-Id: I9645d05a65d8608d7e53ae107eed1f53cca0b0e9
2020-05-24 20:44:10 +03:00
Sagi Shnaidman
ad7d6ea668 Fix broken server_info module and add tests
Fix server_info module. Add tests because it wasn't executed in
tests at all.

Change-Id: I50435f3a3103501bc0eccf8fdfced3179b991bb8
1.0.1
2020-05-21 20:56:13 +03:00
Monty Taylor
ddc1a78705 Ignore a few more things
The ignores can just list the directory and from them it will
ignore the directory too.

Add .gitreview and .gitignore and the importer_result.json.

Change-Id: Ibe5e56ccd3fc54695bf64dd696adb2ec2bb0f3c2
1.0.0
2020-05-19 11:59:11 -05:00
Monty Taylor
a033a0804b Validate that we can upload build collection
Run galaxy-importer on the built artifact and fail if galaxy is
going to fail.

Remove license_file entry in galaxy.yml

Change-Id: I6c2ac22ccb56f52f8efcefc5891b10875ae8c0b5
2020-05-19 11:13:22 -05:00
Monty Taylor
6ab290839b Rename routing.yml to runtime.yml
The collection routing implementation for 2.10:

   https://github.com/ansible/ansible/pull/67684

just update the filename to be meta/runtime.yml.

Change-Id: I858f53e66bef2c40fb7ec2821d412bd966417106
2020-05-16 07:43:29 -05:00
Monty Taylor
8a928ef70d Build collection with 2.10 and ignore things more better
We need 2.10 for building collection tarballs with build_ignore.
Also, build_ignore takes globs, not leading filepaths, so add
globs to the dirs in our list so that we properly don't include
these.

Change-Id: I809e100fa80bffafda4002487590a6dcd6aea0c1
2020-05-15 07:48:36 -05:00
Zuul
02f14ed227 Merge "Remove ANSIBLE_METADATA from all modules" 2020-05-14 16:07:46 +00:00
Sagi Shnaidman
572fe85894 Remove ANSIBLE_METADATA from all modules
It's not required for collections,
for more details:
https://github.com/ansible-collections/overview/issues/57
Change-Id: I954eef25bb9837c9282665ad5586dbe37f4f4424
2020-05-14 17:00:01 +03:00
Sagi Shnaidman
8aa0412e75 Update README with additional information
Change-Id: Icf45bf7ecb00a2afe9d076e413a212b1e8399ad1
2020-05-14 08:39:47 +03:00
Zuul
5ff16c9420 Merge "Link to Contributing file in README" 2020-05-13 19:03:46 +00:00
Zuul
372ad83429 Merge "Improve ansible-test sanity for collection" 2020-05-13 15:19:00 +00:00
Monty Taylor
370b9b9dae Link to Contributing file in README
Change-Id: If18253fec2a4df735835c2a7b47c69069bf667d0
2020-05-13 09:18:33 -05:00
Monty Taylor
c0ded1303b Add contributing file
Change-Id: Iae015eae0931c5cd0d77990964fa57c5594e4bb6
2020-05-13 08:07:01 -05:00
Sagi Shnaidman
bcdf749938 Improve ansible-test sanity for collection
Check only things we build into collection.
Ignore sanity files from full CI jobs.
Add queens to gate because it's voting.
Add files to ignoring when building collection.
Remove non-required lines from ignorign sanity files.

Change-Id: I0dde756efa133cf75b67d072af78a1f8307ce932
2020-05-13 13:31:29 +03:00
Monty Taylor
e47c4671c7 Rename all of the modules
This is separate from the previous patch - it's just the results
of running the script so we can review the two a little independently.
We should probably squash them.

Change-Id: I838f15cf4a32455a5be20033c8ddc27db6ca15c0
2020-05-12 10:20:50 -05:00
Monty Taylor
52905480b8 Remove all of the os_ prefixes
The 2.10 transition has a routing.yml file that points each
individual module from ansible/ansible to a new location. That means
we can put:

    os_server:
      redirect: openstack.cloud.server

into lib/ansible/config/routing.yml in ansible/ansible and have
the result be the end user's playbooks still working with the
old names while providing new names that are less ugly.

This adds a routing file to our collection repo, as well as the
script used to generate the new mapping.

Change-Id: Ia5d18282b14ad0d86a347343be8bb477ae47130a
2020-05-12 10:19:28 -05:00
Monty Taylor
238387f2f8 Remove incorrect os_ prefix in documentation
The parameteres are project_domain_name and user_domain_name.

Change-Id: I509ae5d398ff8a93d3cbcd09edb21118a1ff03c3
2020-05-12 10:10:57 -05:00
Monty Taylor
6271268567 Run linters in a temp dir instead of an install
We can't run linters in an install because installs expand
symlinks to regular files so the ansible-test code that detects
symlinks can't work so it looks at docs for symlink aliases
as if they were real.

Change-Id: I0a5659a1f693261a21a5b29528f950b846205f2e
2020-05-12 09:04:54 +00:00
Zuul
7e027cb532 Merge "Ensure modules work with queens devstack" 2020-05-11 13:01:30 +00:00
Zuul
1906b85668 Merge "Updated allocation pool checks" 2020-05-10 14:21:01 +00:00
Sagi Shnaidman
47ac938475 Ensure modules work with queens devstack
Using master branch of openstackSDK

Change-Id: I43f260bbb26aa1d8e328911d9798316445849d7d
2020-05-10 13:07:55 +00:00
Ken Dreyer
25ad4882b0 os_server_action: pass imageRef to rebuild
Prior to this change, the os_server_action module could not rebuild
servers, because it passed no arguments to the "rebuild" object.

The imageRef parameter is mandatory. If the client does not specify
imageRef, Nova takes no action to rebuild the server.

Change-Id: I0edbdb634feb90d4c54476a4089fcb014c0b83b2
2020-04-29 14:56:49 -06:00
rawat
95dcd82cbb Updated allocation pool checks
As per the REST Networking API v2.0 (Subnet) docs, if subnets pools
are not specified, OpenStack networking automatically allocates pools
covering all IP addresses in the CIDR.

In custom vendor specific environments, subnets can be created without
allocation pools via UI due to which subnets will not have any existing
allocation pools. Under this scenario, module throws an
"IndexError: list index out of range" error.

Also, allow to add more allocation pools on top of existing allocation
pools.

Change-Id: Ib8becf5e958f1bc8e5c9fd76f1722536bf1c9f1a
2020-04-27 07:19:56 +10:00