Mark Chappell
d39f3ae5b0
os_nova_host_aggregate: Fixup sanity test failures
...
Change-Id: I40cc48c8b04713a63ab8fd8c71b785a824cf3715
2020-03-13 16:49:20 +01:00
Zuul and Gerrit Code Review
c9d2866b57
Merge "Test with and assert support for python3"
2020-03-04 22:27:00 +00:00
Zuul and Gerrit Code Review
11331d7f1f
Merge "Remove from __future__ lines"
2020-03-04 22:26:59 +00:00
Zuul and Gerrit Code Review
fba0eda1d8
Merge "Fix H236 and remove exclusion"
2020-03-04 22:22:02 +00:00
Monty Taylor
53affc3220
Test with and assert support for python3
...
Collections are new. openstacksdk as of now doesn't support python2.
We shouldn't pretend to support python2 either. If you're using
ansible new enough to use collections, you can use python3.
This release of openstacksdk only supports 3.6 and onwards, so
set that as our min.
Change-Id: I34d544ce48f25bffde8e6e0cf82cdf9a85e681c3
2020-03-03 09:28:43 -06:00
Zuul and Gerrit Code Review
17cdcee058
Merge "os_coe_cluster: Retrive id/uuid correctly"
2020-03-02 18:36:17 +00:00
Bharat Kunwar
050acb6c03
os_coe_cluster: Retrive id/uuid correctly
...
Fix https://github.com/ansible/ansible/issues/67576
Change-Id: I59b07a8733d549015ed1999e30970d1131c82f99
Signed-off-by: Bharat Kunwar <brtknr@bath.edu >
2020-03-02 17:09:30 +00:00
Zuul and Gerrit Code Review
79b2b1001a
Merge "Fix F401 and remove exclusion"
2020-03-02 13:31:36 +00:00
Zuul and Gerrit Code Review
4b6c60ff14
Merge "Fix W504 and remove exclusion"
2020-03-02 13:31:35 +00:00
Zuul and Gerrit Code Review
d2674e42b2
Merge "Fix E128 and remove exclusion"
2020-03-02 13:31:35 +00:00
Zuul and Gerrit Code Review
32905ea099
Merge "Fix F841 and remove exclusion"
2020-03-02 13:31:33 +00:00
Monty Taylor
96a5914eb6
Remove from __future__ lines
...
We only support python3
Change-Id: Ieb82eb3369c4ac73f3595dc84ca11e1f11766a79
2020-03-01 06:26:03 -06:00
Monty Taylor
9d29e8c847
Fix H236 and remove exclusion
...
We haven't needed this in a VERY long time.
Change-Id: I35041c2c6ae421e7caaef3c04ffca92e2ff10e35
2020-03-01 06:22:58 -06:00
Zuul and Gerrit Code Review
584220fdd3
Merge "fix constructed compose"
2020-02-27 23:38:05 +00:00
Monty Taylor
86670bcec9
Fix F401 and remove exclusion
...
Change-Id: Id2dbff06925ed8326e4a214aabc19d4ada5db69c
2020-02-27 13:56:48 -06:00
Monty Taylor
92d7d7caeb
Fix W504 and remove exclusion
...
This is a topic where there are two points of view. While neither
is fundamentally better than the other in reality, what's best is
to not have any arguments about it. The tox.ini comments about 503
and 504 that were in place make the argument that:
- 503 is intended to be disabled and 504 enabled by default
- Donald Knuth believes 504 is the right way
Since Donald Knuth is smarter than all of us, align with 504, match
the comments in the file and turn on enforcement to keep it that way.
Change-Id: I92d4d1e82935e30ae42a0e14e641cbe36fd6e811
2020-02-27 13:56:48 -06:00
Monty Taylor
72ba76f156
Fix E128 and remove exclusion
...
Change-Id: I0517c0ed09d7834df763c745936793739e88ef9d
2020-02-27 13:56:48 -06:00
Monty Taylor
15f7f7fc7b
Fix F841 and remove exclusion
...
Change-Id: I92802ced580d42781cfd875389daa232aa8a64a5
2020-02-27 13:56:48 -06:00
Zuul and Gerrit Code Review
df5bbd9fd3
Merge "Make an OpenStackModule base class"
2020-02-26 16:25:32 +00:00
Zuul and Gerrit Code Review
78937f4d41
Merge "Add os_routers_info module"
2020-02-19 12:15:07 +00:00
Bram Verschueren
72944f1a3a
Add os_routers_info module
...
Introduces a new os_routers_info module.
original github PR: https://github.com/ansible/ansible/pull/63731
Change-Id: I7fe56cfe862b2b8209675acf0f87fbad99e09546
2020-02-19 10:21:06 +01:00
Zuul and Gerrit Code Review
7bd15ba000
Merge "Bump min openstacksdk version for os_network/{port_security_enabled,mtu}"
2020-02-18 19:26:19 +00:00
Jesse Pretorius (odyssey4me)
0f196864b3
Bump min openstacksdk version for os_network/{port_security_enabled,mtu}
...
To make use of the port_security_enabled [a] and mtu [b] parameters,
[c] and [d] need to be present in the openstacksdk or the os_network
module with return an error like:
TypeError: create_network() got an unexpected keyword argument 'port_security_enabled'
or:
TypeError: create_network() got an unexpected keyword argument 'mtu'
To handle this, we fail the module if one of the arguments are used
and the minimum openstacksdk version for that argument is not met.
[a] https://github.com/ansible/ansible/commit/eaf238b033a0504c48440cf85982a2b89851059d
[b] https://github.com/ansible/ansible/commit/c6a8e99d34eeacd84b097bb0bd2ba9a0d7fb230d
[c] https://github.com/openstack/openstacksdk/commit/8eb788af07ed88166db7b8a58ce1fecacd7a29b1
[d] https://github.com/openstack/openstacksdk/commit/a1fc820a2f3669f64d222506c17be99c4d6be7b7
Fixes: https://github.com/ansible/ansible/issues/62062
Change-Id: I2b80dc721a08bbdb530af3705ae99cf1b579d9f0
2020-02-18 12:46:00 +00:00
Zuul and Gerrit Code Review
1846cbd1b4
Merge "Support json type for the ironic_node config_drive parameter"
2020-02-17 17:20:16 +00:00
Abhijeet Kasurde
fcab7a9963
os_ironic: Correct parameter name
...
since inception skip_update_of_masked_password is misspelled
as skip_update_of_driver_password in the documentation.
Change-Id: I439f672b82385b4e317f2442755a81ef9c7c6bda
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
2020-02-17 15:05:00 +05:30
Sagi Shnaidman and Artem Goncharov
ae0303d482
Make an OpenStackModule base class
...
In module_utils we have a bunch of factory functions that we expect
people to use in a certain combination to build a module, then we
pass around a reference to the SDK and to the connection we created.
That's largely just due to how this stuff grew organically.
Instead, create a base class to be used in the modules. For now it
allows us to clean things up a bit. But as a follow on - it should
maybe help us put in things like richer logging collection which
would otherwise need to be done with helper methods and whatnot.
Change-Id: I487e79fe18c0b9a75df7dacd224ab40ed7f4e1ab
2020-02-17 08:50:17 +00:00
Abhijeet Kasurde
b455295f92
Update root hint documentation link
...
Root hint documentation link points to non-existing link.
This patch corrects this link.
Fixes: https://github.com/ansible/ansible/issues/67357
Change-Id: I1ad77ca2b1007ed1660ac938c6fee7f4059a979c
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
2020-02-13 14:29:30 +05:30
Jeffrey Zhang
bcfa2aa095
Support json type for the ironic_node config_drive parameter
...
Since patch[0], ironic config_drive parameter support json type.
[0] https://review.opendev.org/639050
Change-Id: Ieecb9e6125a182a3da41002aea26233a98aecc8c
2020-02-08 18:26:39 +08:00
Jesse Pretorius (odyssey4me)
1a597c2b03
Bump minimum openstacksdk version when using os_network/dns_domain
...
With the addition of [a], the minimum openstacksdk version needs to
be bumped to include [b], or the os_network module will return the
error:
TypeError: create_network() got an unexpected keyword argument 'dns_domain'
To handle this, we fail the module if the dns_domain argument is used
and the minimum openstacksdk version for that argument is not met.
[a] https://github.com/ansible/ansible/commit/6c74e29618a6872bc0da66e4992cfcd9cebf6acc
[b] https://github.com/openstack/openstacksdk/commit/a3e846e2b9301f4ae725e97b21b4313bfcc81d10
Fixes : #64495
Fixes : #64841
Change-Id: I8c41e505d5c1949ddc535c78933da06405c47299
2020-01-30 17:40:03 +00:00
willtome
7d46ce9c51
fix constructed compose
...
Fixes ansible/ansible#59680 and ansible/ansible#48309 . add support for strict parameter for constructed.
Change-Id: I08cba2d9ee372071f3899c7c9b74d9351dfdb5d4
Signed-off-by: willtome <willtome@gmail.com >
2020-01-28 09:46:13 -06:00
Zuul and Gerrit Code Review
d36da2d1ce
Merge "Fix argument spec for os_subnet and os_zone"
2020-01-28 01:22:42 +00:00
Bram Verschueren
c7506b5b10
fix os_user_role for groups in multidomain context
...
This fixes searching for a group in multi-domain context by passing the
domain_id in the call to get_groups.
original github PR: https://github.com/ansible/ansible/pull/62858
Change-Id: Ia2216728c15cc9d9a5e29bfe6b9fc63d2c6982ce
Task: 38375
Story: 2007209
2020-01-23 08:22:46 +01:00
Abhijeet Kasurde and Sagi Shnaidman
ead550d34e
Fix argument spec for os_subnet and os_zone
...
Ansible argument spec provides facility to provide choices
for the given parameter.
Module os_subnet and os_zone spells 'choices' incorrectly.
This change fixes these modules, by changing 'choice' to 'choices'.
Original Upstream PR: https://github.com/ansible/ansible/pull/65497
Change-Id: I3eed5feeef1234996f22bf8dfe7ecec0bc8eb298
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com >
2020-01-22 13:19:00 +02:00
Valery Tschopp and Sagi Shnaidman
4c03ae0c16
Fix os_user_role issue to grant a role in a domain
...
Set domain_id when domain is set or project/domain is set.
Change-Id: I0f189647cd9b97252f29055506f75dfd8398dee4
Task: 38309
Story: 2007184
2020-01-21 16:56:16 +00:00
Sagi Shnaidman
6ac08e7f0e
Migrate openstack modules as a collection
...
Migrate accordin to Ansible guidelines [1[]] and tool
migrate.py [2]
Also fixed ALL ansible-test sanity issues
Add pep8 and linter job with runs ansible-test sanity test.
[1] https://etherpad.openstack.org/p/openstack-ansible-modules
[2] https://github.com/ansible-community/collection_migration
Change-Id: Ib2b1c8f23aacfca95304132bfe5c4cdedbea0520
2020-01-17 14:07:24 +00:00