These may not be 100% perfect, but they are a good
starting place and we can improve them over time.
Change-Id: Ifb21554d67863b4e4e964f3e98263c3dafcb607f
collection build produces FILES.json and METADATA.json, so add them
to the .gitignore. Also, remove the version line from galaxy.yml.in
since it's generated.
Change-Id: I2ea0b04c8e56b3b7186ac2e9c475144340067636
The galaxy upload rejects GPLv3 and requires a valid SPDX license
tag. The file headers list:
GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
which is a way of saying "3 or later" - so use that SPDX tag.
Also - the license headers refer to the file being COPYING, so
rename the file and update it in the galaxy metadata to match.
Change-Id: I6c82b49d7ce5ea8c9cde939d5d37ff54b969a598
ansible-galaxy collection build modifies the contents of the tree.
Let's not go in to why this is bad, but instead just deal with it.
The issue in question is that is removes the +x bit from files in
the tree, which means you can't run a build twice in a row locally.
Shrug. Just roll with the -x and update our usage to reflect it.
Change-Id: I0f82531e99a98d656b60079fd3e94d4e3a1dbb6b
Collections are new. openstacksdk as of now doesn't support python2.
We shouldn't pretend to support python2 either. If you're using
ansible new enough to use collections, you can use python3.
This release of openstacksdk only supports 3.6 and onwards, so
set that as our min.
Change-Id: I34d544ce48f25bffde8e6e0cf82cdf9a85e681c3
This is a topic where there are two points of view. While neither
is fundamentally better than the other in reality, what's best is
to not have any arguments about it. The tox.ini comments about 503
and 504 that were in place make the argument that:
- 503 is intended to be disabled and 504 enabled by default
- Donald Knuth believes 504 is the right way
Since Donald Knuth is smarter than all of us, align with 504, match
the comments in the file and turn on enforcement to keep it that way.
Change-Id: I92d4d1e82935e30ae42a0e14e641cbe36fd6e811
Importing from * is not a thing that should be done, as it masks
errors and makes code hard to understand. There are some copy-pasta
files that violate this. Mark them with noqa for now, because we don't
actually care about them.
Change-Id: I790f88c75ea546d83e347e42df0050ad36211936
For local dev, multiple iterations can wind up with multiple
files in the build_artifact dir. Remove them when building so
that the ls command works.
Change-Id: Id309c34679d2c0b6d9380665a381af4b52495d19
OpenStack in general uses git tags to drive versioning of artifacts.
This is important because of our code review driven workflow, since
patches don't necessarily land in a predictable sequence, so flows
requiring a version number in a file to be updated at a specific
time are problematic.
By having pbr generate the correct version number then putting that
into the galaxy.yml file, we can match the behavior without too much
undue burden.
Also ignore build_artifact directory.
Change-Id: Id02fee682fb5a4b6fd6dcb0644848e6d1269e19b
The unit test requirements were copied as part of the migration from the
Ansible repo. This removes requirements that are not used in the
OpenStack Ansible collections unit tests.
Change-Id: I8b8914ffa327b4914169e79625972d4c67e406cb
To make use of the port_security_enabled [a] and mtu [b] parameters,
[c] and [d] need to be present in the openstacksdk or the os_network
module with return an error like:
TypeError: create_network() got an unexpected keyword argument 'port_security_enabled'
or:
TypeError: create_network() got an unexpected keyword argument 'mtu'
To handle this, we fail the module if one of the arguments are used
and the minimum openstacksdk version for that argument is not met.
[a] eaf238b033
[b] c6a8e99d34
[c] 8eb788af07
[d] a1fc820a2f
Fixes: https://github.com/ansible/ansible/issues/62062
Change-Id: I2b80dc721a08bbdb530af3705ae99cf1b579d9f0
since inception skip_update_of_masked_password is misspelled
as skip_update_of_driver_password in the documentation.
Change-Id: I439f672b82385b4e317f2442755a81ef9c7c6bda
Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
In module_utils we have a bunch of factory functions that we expect
people to use in a certain combination to build a module, then we
pass around a reference to the SDK and to the connection we created.
That's largely just due to how this stuff grew organically.
Instead, create a base class to be used in the modules. For now it
allows us to clean things up a bit. But as a follow on - it should
maybe help us put in things like richer logging collection which
would otherwise need to be done with helper methods and whatnot.
Change-Id: I487e79fe18c0b9a75df7dacd224ab40ed7f4e1ab
