32 Commits
Author SHA1 Message Date
Monty TaylorandSagi Shnaidman a96d28dfbc Update author lines
We don't use github, so having @ mentions of specific humans is
not valuable. Also, we are a team and own the modules as a team,
so calling out individual authors is philosophically contrary.

We landed a patch upstream to special-case this author string.

Change-Id: I38b4e68f14bbba6e13e8a50e2b202874ab74e3bc
2020-06-23 21:50:43 +03:00
Monty Taylor ddc1a78705 Ignore a few more things
The ignores can just list the directory and from them it will
ignore the directory too.

Add .gitreview and .gitignore and the importer_result.json.

Change-Id: Ibe5e56ccd3fc54695bf64dd696adb2ec2bb0f3c2
2020-05-19 11:59:11 -05:00
Monty Taylor a033a0804b Validate that we can upload build collection
Run galaxy-importer on the built artifact and fail if galaxy is
going to fail.

Remove license_file entry in galaxy.yml

Change-Id: I6c2ac22ccb56f52f8efcefc5891b10875ae8c0b5
2020-05-19 11:13:22 -05:00
Monty Taylor 6ab290839b Rename routing.yml to runtime.yml
The collection routing implementation for 2.10:

   https://github.com/ansible/ansible/pull/67684

just update the filename to be meta/runtime.yml.

Change-Id: I858f53e66bef2c40fb7ec2821d412bd966417106
2020-05-16 07:43:29 -05:00
Monty Taylor 8a928ef70d Build collection with 2.10 and ignore things more better
We need 2.10 for building collection tarballs with build_ignore.
Also, build_ignore takes globs, not leading filepaths, so add
globs to the dirs in our list so that we properly don't include
these.

Change-Id: I809e100fa80bffafda4002487590a6dcd6aea0c1
2020-05-15 07:48:36 -05:00
Monty Taylor 370b9b9dae Link to Contributing file in README
Change-Id: If18253fec2a4df735835c2a7b47c69069bf667d0
2020-05-13 09:18:33 -05:00
Monty Taylor c0ded1303b Add contributing file
Change-Id: Iae015eae0931c5cd0d77990964fa57c5594e4bb6
2020-05-13 08:07:01 -05:00
Monty Taylor e47c4671c7 Rename all of the modules
This is separate from the previous patch - it's just the results
of running the script so we can review the two a little independently.
We should probably squash them.

Change-Id: I838f15cf4a32455a5be20033c8ddc27db6ca15c0
2020-05-12 10:20:50 -05:00
Monty Taylor 52905480b8 Remove all of the os_ prefixes
The 2.10 transition has a routing.yml file that points each
individual module from ansible/ansible to a new location. That means
we can put:

    os_server:
      redirect: openstack.cloud.server

into lib/ansible/config/routing.yml in ansible/ansible and have
the result be the end user's playbooks still working with the
old names while providing new names that are less ugly.

This adds a routing file to our collection repo, as well as the
script used to generate the new mapping.

Change-Id: Ia5d18282b14ad0d86a347343be8bb477ae47130a
2020-05-12 10:19:28 -05:00
Monty Taylor 238387f2f8 Remove incorrect os_ prefix in documentation
The parameteres are project_domain_name and user_domain_name.

Change-Id: I509ae5d398ff8a93d3cbcd09edb21118a1ff03c3
2020-05-12 10:10:57 -05:00
Monty TaylorandSagi Shnaidman 6271268567 Run linters in a temp dir instead of an install
We can't run linters in an install because installs expand
symlinks to regular files so the ansible-test code that detects
symlinks can't work so it looks at docs for symlink aliases
as if they were real.

Change-Id: I0a5659a1f693261a21a5b29528f950b846205f2e
2020-05-12 09:04:54 +00:00
Monty Taylor a55f3fd1ca Ignore more things for the final artifact
We don't need tox or ci scripts in the collection, only in git.

Change-Id: Ie96dab9b7d9adac878e8c2e753a08f7ed794fc10
2020-03-26 15:22:14 -05:00
Monty Taylor 8ab6942d12 Update the badge shown in galaxy
Galaxy shows the README, which currently shows a "failing" badge
pointing at github actions. That's obviously not right for us.

Update this by using the zuul:gated badge and pointing to the
builds for the repo in the Zuul Dashboard.

Change-Id: I7f1254f882486514cd29a52bf05ebf5a972da490
2020-03-24 18:31:17 -05:00
Monty Taylor 0a6894e9de Add ansible-collections-openstack to the required-projects
When this is run outside of the repo, we need this repo itself
in the job content.

Change-Id: Id75617b1a723bd310c86b3e6ea45b274652b9d9b
2020-03-24 17:18:31 -05:00
Monty TaylorandSagi Shnaidman cf7011a742 Cleanup functional tests
Use the openstacksdk base functional test instead of going all
the way back to devstack for our base. Also - defining a job
starting with openstacksdk in this repo is not ok - but that
probably just came from the original copy-pasta coming from the
sdk repo.

Use tox-siblings more and stop doing tox requirements of ../
things. The system is there and we can use it.

Add jobs to test against released openstacksdk and ansible, as well
as a non-voting to test against ansible devel branch.

Add openstacksdk to the test-requirements because it's super
required.

Move zuul.yaml to .zuul.yaml. This isn't a zuul jobs repo so
we should just make it a hidden file rather than a non-hidden.

Change-Id: I658bd1728629cd358bc17a7f00d282d04530d8fe
2020-03-19 12:05:57 +00:00
Monty Taylor 75cc5012e3 Update os_client_config to use openstacksdk
This never got migrated but should. os-client-config is only
on life support.

Change-Id: I2d77c9f7d147900b79a410c17cce197108c0a69b
2020-03-17 13:35:45 -05:00
Monty Taylor 852f385889 Remove MANIFEST.json before building
For reasons surpassing understanding this doesn't seem to get
overwritten.

Change-Id: Ib4d6b38757112908dbf58d70015482831a8c2e95
2020-03-13 10:14:58 -05:00
Monty Taylor 1553d34b02 Clean up minor build quibbles
collection build produces FILES.json and METADATA.json, so add them
to the .gitignore. Also, remove the version line from galaxy.yml.in
since it's generated.

Change-Id: I2ea0b04c8e56b3b7186ac2e9c475144340067636
2020-03-05 15:08:44 +00:00
Monty Taylor e0200e9faf Fix license metadata
The galaxy upload rejects GPLv3 and requires a valid SPDX license
tag. The file headers list:

  GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)

which is a way of saying "3 or later" - so use that SPDX tag.

Also - the license headers refer to the file being COPYING, so
rename the file and update it in the galaxy metadata to match.

Change-Id: I6c82b49d7ce5ea8c9cde939d5d37ff54b969a598
2020-03-05 15:08:38 +00:00
Monty Taylor 97eb24ac4d Deal with collection build modifying tree
ansible-galaxy collection build modifies the contents of the tree.
Let's not go in to why this is bad, but instead just deal with it.
The issue in question is that is removes the +x bit from files in
the tree, which means you can't run a build twice in a row locally.
Shrug. Just roll with the -x and update our usage to reflect it.

Change-Id: I0f82531e99a98d656b60079fd3e94d4e3a1dbb6b
2020-03-05 15:08:32 +00:00
Monty Taylor 53affc3220 Test with and assert support for python3
Collections are new. openstacksdk as of now doesn't support python2.
We shouldn't pretend to support python2 either. If you're using
ansible new enough to use collections, you can use python3.

This release of openstacksdk only supports 3.6 and onwards, so
set that as our min.

Change-Id: I34d544ce48f25bffde8e6e0cf82cdf9a85e681c3
2020-03-03 09:28:43 -06:00
Monty Taylor 96a5914eb6 Remove from __future__ lines
We only support python3

Change-Id: Ieb82eb3369c4ac73f3595dc84ca11e1f11766a79
2020-03-01 06:26:03 -06:00
Monty Taylor 9d29e8c847 Fix H236 and remove exclusion
We haven't needed this in a VERY long time.

Change-Id: I35041c2c6ae421e7caaef3c04ffca92e2ff10e35
2020-03-01 06:22:58 -06:00
Monty Taylor 4df2fdb4fe Just use shutil.rmtree in build.py
Turns out there's a stdlib function for this.

Change-Id: I38885c4b6d973b2a7083a04acb3f5cea9ad78ad9
2020-03-01 06:17:35 -06:00
Monty Taylor 86670bcec9 Fix F401 and remove exclusion
Change-Id: Id2dbff06925ed8326e4a214aabc19d4ada5db69c
2020-02-27 13:56:48 -06:00
Monty Taylor 92d7d7caeb Fix W504 and remove exclusion
This is a topic where there are two points of view. While neither
is fundamentally better than the other in reality, what's best is
to not have any arguments about it. The tox.ini comments about 503
and 504 that were in place make the argument that:

  - 503 is intended to be disabled and 504 enabled by default
  - Donald Knuth believes 504 is the right way

Since Donald Knuth is smarter than all of us, align with 504, match
the comments in the file and turn on enforcement to keep it that way.

Change-Id: I92d4d1e82935e30ae42a0e14e641cbe36fd6e811
2020-02-27 13:56:48 -06:00
Monty Taylor 72ba76f156 Fix E128 and remove exclusion
Change-Id: I0517c0ed09d7834df763c745936793739e88ef9d
2020-02-27 13:56:48 -06:00
Monty Taylor 2527faec28 Remove F403 and F405 exclusions
Importing from * is not a thing that should be done, as it masks
errors and makes code hard to understand. There are some copy-pasta
files that violate this. Mark them with noqa for now, because we don't
actually care about them.

Change-Id: I790f88c75ea546d83e347e42df0050ad36211936
2020-02-27 13:56:48 -06:00
Monty Taylor 15f7f7fc7b Fix F841 and remove exclusion
Change-Id: I92802ced580d42781cfd875389daa232aa8a64a5
2020-02-27 13:56:48 -06:00
Monty Taylor 90e68f2e8e Run flake8 in linters
We should run flake8 when we run the other checks. This
repo is mostly python.

Change-Id: I3cbecf9ef24f784c072841656b55c4162673dcaa
2020-02-27 13:56:48 -06:00
Monty Taylor 40fe366727 Remove old artifacts when building new ones
For local dev, multiple iterations can wind up with multiple
files in the build_artifact dir. Remove them when building so
that the ls command works.

Change-Id: Id309c34679d2c0b6d9380665a381af4b52495d19
2020-02-27 13:56:27 -06:00
Monty Taylor 5936a8f691 Add a tool to build collections with pbr
OpenStack in general uses git tags to drive versioning of artifacts.
This is important because of our code review driven workflow, since
patches don't necessarily land in a predictable sequence, so flows
requiring a version number in a file to be updated at a specific
time are problematic.

By having pbr generate the correct version number then putting that
into the galaxy.yml file, we can match the behavior without too much
undue burden.

Also ignore build_artifact directory.

Change-Id: Id02fee682fb5a4b6fd6dcb0644848e6d1269e19b
2020-02-27 08:20:43 -06:00