Merge "Ensure coe_cluster_template compare labels properly"

This commit is contained in:
Zuul
2024-10-10 17:03:16 +00:00
committed by Gerrit Code Review
3 changed files with 16 additions and 0 deletions

View File

@@ -0,0 +1,7 @@
---
bugfixes:
- |
coe_cluster_template - now labels are converted to strings by module that
fixes module idempotence in case label values defined by users are
integers or booleans.

View File

@@ -26,6 +26,9 @@
keypair_id: '{{ keypair.keypair.id }}'
name: k8s
state: present
labels:
docker_volume_size: 10
cloud_provider_tag: v1.23.1
register: coe_cluster_template
- name: Assert return values of coe_cluster_template module
@@ -43,6 +46,9 @@
keypair_id: '{{ keypair.keypair.id }}'
name: k8s
state: present
labels:
docker_volume_size: 10
cloud_provider_tag: v1.23.1
register: coe_cluster_template
- name: Assert return values of coe_cluster_template module

View File

@@ -433,6 +433,9 @@ class COEClusterTemplateModule(OpenStackModule):
if isinstance(labels, str):
labels = dict([tuple(kv.split(":"))
for kv in labels.split(",")])
elif isinstance(labels, dict):
labels = dict({str(k): str(v)
for k, v in labels.items()})
if labels != cluster_template['labels']:
non_updateable_keys.append('labels')