Merge f087d58cbe into 44a2151dbf

fix bugs
add check mode tests, add comments
2026-05-12 12:32:00 +00:00 · 2025-03-05 00:40:06 +00:00 · 2025-03-05 00:39:46 +00:00 · 2025-03-05 00:33:11 +00:00 · 2024-12-10 08:59:03 +00:00 · 2024-12-10 17:30:22 +09:00
26 changed files with 128 additions and 238 deletions
--- a/.ansible-lint
+++ b/.ansible-lint
@@ -4,8 +4,7 @@
 # SPDX-FileCopyrightText: 2024, Ansible Project

 skip_list:
-  - meta-runtime[unsupported-version]  # This rule doesn't make any sense
+  - meta-runtime[unsupported-version]  # Tis rule doesn't make any sense
  - fqcn[deep]  # This rule produces false positives for files in tests/unit/plugins/action/fixtures/
-  - sanity[cannot-ignore]  # This rule is skipped to keep backward compatibility with Python 2
 exclude_paths:
  - changelogs/
--- a/.azure-pipelines/azure-pipelines.yml
+++ b/.azure-pipelines/azure-pipelines.yml
@@ -37,13 +37,13 @@ variables:
 resources:
  containers:
    - container: default
-      image: quay.io/ansible/azure-pipelines-test-container:7.0.0
+      image: quay.io/ansible/azure-pipelines-test-container:6.0.0

 pool: Standard

 stages:
  - stage: Sanity_devel
-    displayName: Ansible devel Sanity & Units & Lint
+    displayName: Ansible devel sanity
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
@@ -57,38 +57,8 @@ stages:
              test: units
            - name: Lint
              test: lint
-  - stage: Sanity_2_20
-    displayName: Ansible 2.20 Sanity & Units & Lint
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: "{0}"
-          testFormat: 2.20/{0}
-          targets:
-            - name: Sanity
-              test: sanity
-            - name: Units
-              test: units
-            - name: Lint
-              test: lint
-  - stage: Sanity_2_19
-    displayName: Ansible 2.19 Sanity & Units & Lint
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          nameFormat: "{0}"
-          testFormat: 2.19/{0}
-          targets:
-            - name: Sanity
-              test: sanity
-            - name: Units
-              test: units
-            - name: Lint
-              test: lint
  - stage: Sanity_2_18
-    displayName: Ansible 2.18 Sanity & Units & Lint
+    displayName: Ansible 2.18 sanity
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
@@ -103,7 +73,7 @@ stages:
            - name: Lint
              test: lint
  - stage: Sanity_2_17
-    displayName: Ansible 2.17 Sanity & Units & Lint
+    displayName: Ansible 2.17 sanity
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
@@ -118,7 +88,7 @@ stages:
            - name: Lint
              test: lint
  - stage: Sanity_2_16
-    displayName: Ansible 2.16 Sanity & Units & Lint
+    displayName: Ansible 2.16 sanity
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
@@ -130,8 +100,19 @@ stages:
              test: sanity
            - name: Units
              test: units
-            - name: Lint
-              test: lint
+  - stage: Sanity_2_15
+    displayName: Ansible 2.15 sanity
+    dependsOn: []
+    jobs:
+      - template: templates/matrix.yml
+        parameters:
+          nameFormat: "{0}"
+          testFormat: 2.15/{0}
+          targets:
+            - name: Sanity
+              test: sanity
+            - name: Units
+              test: units
  ## Docker
  - stage: Docker_devel
    displayName: Docker devel
@@ -141,42 +122,14 @@ stages:
        parameters:
          testFormat: devel/linux/{0}/1
          targets:
-            - name: Fedora 42
-              test: fedora42
-            - name: Ubuntu 22.04
-              test: ubuntu2204
-            - name: Ubuntu 24.04
-              test: ubuntu2404
-  - stage: Docker_2_20
-    displayName: Docker 2.20
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.20/linux/{0}/1
-          targets:
-            - name: Fedora 42
-              test: fedora42
-            - name: Ubuntu 22.04
-              test: ubuntu2204
-            - name: Ubuntu 24.04
-              test: ubuntu2404
-  - stage: Docker_2_19
-    displayName: Docker 2.19
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.19/linux/{0}/1
-          targets:
-            - name: Fedora 41
-              test: fedora41
+            - name: Fedora 40
+              test: fedora40
            - name: Ubuntu 22.04
              test: ubuntu2204
            - name: Ubuntu 24.04
              test: ubuntu2404
  - stage: Docker_2_18
-    displayName: Docker 2.18
+    displayName: Docker devel
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
@@ -199,6 +152,8 @@ stages:
          targets:
            - name: Fedora 39
              test: fedora39
+            - name: Ubuntu 20.04
+              test: ubuntu2004
            - name: Ubuntu 22.04
              test: ubuntu2204
  - stage: Docker_2_16
@@ -213,6 +168,27 @@ stages:
              test: centos7
            - name: Fedora 38
              test: fedora38
+            - name: Ubuntu 20.04
+              test: ubuntu2004
+            - name: Ubuntu 22.04
+              test: ubuntu2204
+
+  - stage: Docker_2_15
+    displayName: Docker 2.15
+    dependsOn: []
+    jobs:
+      - template: templates/matrix.yml
+        parameters:
+          testFormat: 2.15/linux/{0}/1
+          targets:
+            - name: CentOS 7
+              test: centos7
+            - name: Fedora 37
+              test: fedora37
+            - name: openSUSE 15 py3
+              test: opensuse15
+            - name: Ubuntu 20.04
+              test: ubuntu2004
            - name: Ubuntu 22.04
              test: ubuntu2204

@@ -225,60 +201,24 @@ stages:
        parameters:
          testFormat: devel/{0}/1
          targets:
-            - name: RHEL 10.0
-              test: rhel/10.0
-            - name: RHEL 9.6
-              test: rhel/9.6
-            - name: FreeBSD 14.3
-              test: freebsd/14.3
-            - name: FreeBSD 13.5
-              test: freebsd/13.5
-  - stage: Remote_2_20
-    displayName: Remote 2.20
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.20/{0}/1
-          targets:
-            - name: RHEL 10.0
-              test: rhel/10.0
-            - name: RHEL 9.6
-              test: rhel/9.6
-            - name: FreeBSD 14.3
-              test: freebsd/14.3
-            - name: FreeBSD 13.5
-              test: freebsd/13.5
-  - stage: Remote_2_19
-    displayName: Remote 2.19
-    dependsOn: []
-    jobs:
-      - template: templates/matrix.yml
-        parameters:
-          testFormat: 2.19/{0}/1
-          targets:
-            - name: RHEL 10.0
-              test: rhel/10.0
-            - name: RHEL 9.5
-              test: rhel/9.5
-            - name: FreeBSD 14.2
-              test: freebsd/14.2
-            - name: FreeBSD 13.5
-              test: freebsd/13.5
+            - name: RHEL 9.4
+              test: rhel/9.4
+            - name: FreeBSD 14.1
+              test: freebsd/14.1
+            - name: FreeBSD 13.4
+              test: freebsd/13.4
  - stage: Remote_2_18
-    displayName: Remote 2.18
+    displayName: Remote devel
    dependsOn: []
    jobs:
      - template: templates/matrix.yml
        parameters:
          testFormat: 2.18/{0}/1
          targets:
-            - name: RHEL 10.0
-              test: rhel/10.0
            - name: RHEL 9.4
              test: rhel/9.4
-            - name: FreeBSD 13.5
-              test: freebsd/13.5
+            - name: FreeBSD 13.3
+              test: freebsd/13.3
  - stage: Remote_2_17
    displayName: Remote 2.17
    dependsOn: []
@@ -287,11 +227,10 @@ stages:
        parameters:
          testFormat: 2.17/{0}/1
          targets:
-            # 2.17 remote target doesn't have RHEL 9 image
-            - name: RHEL 10.0
-              test: rhel/10.0
-            - name: FreeBSD 13.5
-              test: freebsd/13.5
+            - name: RHEL 9.3
+              test: rhel/9.3
+            - name: FreeBSD 13.3
+              test: freebsd/13.3
  - stage: Remote_2_16
    displayName: Remote 2.16
    dependsOn: []
@@ -300,15 +239,38 @@ stages:
        parameters:
          testFormat: 2.16/{0}/1
          targets:
-            # 2.16 remote target only has RHEL 9.6 image
-            - name: RHEL 9.6
-              test: rhel/9.6
+            - name: RHEL 8.8
+              test: rhel/8.8
+            - name: RHEL 9.2
+              test: rhel/9.2
+            - name: FreeBSD 13.2
+              test: freebsd/13.2
+
+  - stage: Remote_2_15
+    displayName: Remote 2.15
+    dependsOn: []
+    jobs:
+      - template: templates/matrix.yml
+        parameters:
+          testFormat: 2.15/{0}/1
+          targets:
+            - name: RHEL 7.9
+              test: rhel/7.9
+            - name: RHEL 8.7
+              test: rhel/8.7
+            - name: RHEL 9.1
+              test: rhel/9.1
+            - name: FreeBSD 13.2
+              test: freebsd/13.2

  ## Finally

  - stage: Summary
    condition: succeededOrFailed()
    dependsOn:
+      - Sanity_2_15
+      - Remote_2_15
+      - Docker_2_15
      - Sanity_2_16
      - Remote_2_16
      - Docker_2_16
@@ -318,12 +280,6 @@ stages:
      - Sanity_2_18
      - Remote_2_18
      - Docker_2_18
-      - Sanity_2_19
-      - Remote_2_19
-      - Docker_2_19
-      - Sanity_2_20
-      - Remote_2_20
-      - Docker_2_20
      - Sanity_devel
      - Remote_devel
      - Docker_devel
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -4,27 +4,6 @@ ansible.posix Release Notes

 .. contents:: Topics

-v2.1.0
-======
-
-Release Summary
---------------
-
-This is the minor release of the ``ansible.posix`` collection.
-This changelog contains all changes to the modules and plugins
-in the stable-2 branch that have been added after the release of
-``ansible.posix`` 2.0.0
-
-Minor Changes
-------------
-
- profile_tasks and profile_roles callback plugins - avoid deleted/deprecated callback functions, instead use modern interface that was introduced a longer time ago (https://github.com/ansible-collections/ansible.posix/issues/650).
-
-Bugfixes
--------
-
- ansible.posix.cgroup_perf_recap - fixes json module load path (https://github.com/ansible-collections/ansible.posix/issues/630).
-
 v2.0.0
 ======

--- a/README.md
+++ b/README.md
@@ -21,7 +21,7 @@ An Ansible Collection of modules and plugins that target POSIX UNIX/Linux and de
 * Python:
  * The Python interpreter version must meet Ansible Core's requirements.
 * Ansible Core:
-  - ansible-core 2.16 or later
+  - ansible-core 2.15 or later

 ## Installation

@@ -46,10 +46,10 @@ To upgrade the collection to the latest available version, run the following com
 ansible-galaxy collection install ansible.posix --upgrade
 ```

-You can also install a specific version of the collection, for example, if you need to downgrade when something is broken in the latest version (please report an issue in this repository). Use the following syntax to install version 2.0.0:
+You can also install a specific version of the collection, for example, if you need to downgrade when something is broken in the latest version (please report an issue in this repository). Use the following syntax to install version 1.0.0:

 ```shell
-ansible-galaxy collection install ansible.posix:==2.0.0
+ansible-galaxy collection install ansible.posix:==1.0.0
 ```

 See [using Ansible collections](https://docs.ansible.com/ansible/devel/user_guide/collections_using.html) for more details.
@@ -78,10 +78,11 @@ ansible-doc -t callback ansible.posix.profile_tasks

 The following ansible-core versions have been tested with this collection:

- ansible-core 2.20 (devel)
- ansible-core 2.19 (stable) *
- ansible-core 2.18 (stable)
+- ansible-core 2.19 (devel)
+- ansible-core 2.18 (stable) *
 - ansible-core 2.17 (stable)
+- ansible-core 2.16 (stable)
+- ansible-core 2.15 (stable)

 ## Contributing

--- a/changelogs/changelog.yaml
+++ b/changelogs/changelog.yaml
@@ -490,25 +490,3 @@ releases:
    - 597_remove_fstab_comment_on_updating.yml
    - 598_icmp_block_inversion.yml
    release_date: '2024-12-04'
-  2.1.0:
-    changes:
-      bugfixes:
-      - ansible.posix.cgroup_perf_recap - fixes json module load path (https://github.com/ansible-collections/ansible.posix/issues/630).
-      minor_changes:
-      - profile_tasks and profile_roles callback plugins - avoid deleted/deprecated
-        callback functions, instead use modern interface that was introduced a longer
-        time ago (https://github.com/ansible-collections/ansible.posix/issues/650).
-      release_summary: 'This is the minor release of the ``ansible.posix`` collection.
-
-        This changelog contains all changes to the modules and plugins
-
-        in the stable-2 branch that have been added after the release of
-
-        ``ansible.posix`` 2.0.0'
-    fragments:
-    - 2.1.0.yml
-    - 631_fixes_module_path.yml
-    - 642_ci_add_rhel10.yml
-    - 650-profile_tasks_roles.yml
-    - 654_ci_bump_core_version.yml
-    release_date: '2025-07-16'
--- a/changelogs/fragments/603_bump_version_3.yml
+++ b/changelogs/fragments/603_bump_version_3.yml
@@ -0,0 +1,2 @@
+trivial:
+  - Bump version to 3.0.0 for the next release (https://github.com/ansible-collections/ansible.posix/issues/603).
--- a/changelogs/fragments/660_ci_azp_syntax.yml
+++ b/changelogs/fragments/660_ci_azp_syntax.yml
@@ -1,2 +0,0 @@
-trivial:
-  - AZP - fixed syntax error in CI test.
--- a/changelogs/fragments/665_update_readme_20250728.yml
+++ b/changelogs/fragments/665_update_readme_20250728.yml
@@ -1,3 +0,0 @@
---
-trivial:
-  - README - Update README to reflect Ansible Core 2.19 release.
--- a/changelogs/fragments/666_azp_update_20250728.yml
+++ b/changelogs/fragments/666_azp_update_20250728.yml
@@ -1,3 +0,0 @@
---
-trivial:
-  - AZP - Update AZP matrix to follow ansible-test changes.
--- a/changelogs/fragments/673_update_ci_20250805.yml
+++ b/changelogs/fragments/673_update_ci_20250805.yml
@@ -1,2 +0,0 @@
-trivial:
-  - Update AZP CI matrix (https://github.com/ansible-collections/ansible.posix/issues/673).
--- a/changelogs/fragments/682_update_ci_20250929.yml
+++ b/changelogs/fragments/682_update_ci_20250929.yml
@@ -1,4 +0,0 @@
-trivial:
-  - Updatng AZP CI matrix to ignore ansible-bad-import-from on six(https://github.com/ansible-collections/ansible.posix/pull/682).
-  - Skipped sanity[cannot-ignore] to keep backward compatibility with Python2.
-  - Consolidate all ansible-lint option locations into .ansible-lint file.
--- a/changelogs/fragments/693_azp_update_20251205.yml
+++ b/changelogs/fragments/693_azp_update_20251205.yml
@@ -1,5 +0,0 @@
---
-trivial:
-  - AZP - Update AZP matrix to follow ansible-test changes.
-  - Add ignore file for Ansible Core 2.21.
-  - Remove ignore lines for ansible-bad-import-from in 2.20 sanity tests.
--- a/galaxy.yml
+++ b/galaxy.yml
@@ -1,7 +1,7 @@
 ---
 namespace: ansible
 name: posix
-version: 2.1.0
+version: 3.0.0
 readme: README.md
 authors:
  - Ansible (github.com/ansible)
--- a/meta/runtime.yml
+++ b/meta/runtime.yml
@@ -1,2 +1,2 @@
 ---
-requires_ansible: ">=2.16.0"
+requires_ansible: ">=2.15.0"
--- a/plugins/callback/cgroup_perf_recap.py
+++ b/plugins/callback/cgroup_perf_recap.py
@@ -132,7 +132,6 @@ DOCUMENTATION = '''

 import csv
 import datetime
-import json
 import os
 import time
 import threading
@@ -143,7 +142,7 @@ from functools import partial

 from ansible.module_utils._text import to_bytes, to_text
 from ansible.module_utils.six import with_metaclass
-from ansible.parsing.ajson import AnsibleJSONEncoder
+from ansible.parsing.ajson import AnsibleJSONEncoder, json
 from ansible.plugins.callback import CallbackBase


--- a/plugins/callback/profile_roles.py
+++ b/plugins/callback/profile_roles.py
@@ -124,7 +124,10 @@ class CallbackModule(CallbackBase):
    def v2_playbook_on_handler_task_start(self, task):
        self._record_task(task)

-    def v2_playbook_on_stats(self, stats):
+    def playbook_on_setup(self):
+        self._display_tasktime()
+
+    def playbook_on_stats(self, stats):
        # Align summary report header with other callback plugin summary
        self._display.banner("ROLES RECAP")

--- a/plugins/callback/profile_tasks.py
+++ b/plugins/callback/profile_tasks.py
@@ -189,7 +189,10 @@ class CallbackModule(CallbackBase):
    def v2_playbook_on_handler_task_start(self, task):
        self._record_task(task)

-    def v2_playbook_on_stats(self, stats):
+    def playbook_on_setup(self):
+        self._display_tasktime()
+
+    def playbook_on_stats(self, stats):
        # Align summary report header with other callback plugin summary
        self._display.banner("TASKS RECAP")

--- a/tests/integration/targets/acl/tasks/acl.yml
+++ b/tests/integration/targets/acl/tasks/acl.yml
@@ -46,12 +46,6 @@
    path: "{{ test_dir }}"
    state: directory
    mode: "0755"
-
- name: Install acl package
-  ansible.builtin.package:
-    name: acl
-    state: present
-
 ##############################################################################
 - name: Grant ansible user read access to a file
  ansible.posix.acl:
--- a/tests/integration/targets/firewalld/aliases
+++ b/tests/integration/targets/firewalld/aliases
@@ -1,5 +1,3 @@
-needs/privileged
-needs/root
 destructive
 shippable/posix/group1
 skip/aix
--- a/tests/integration/targets/mount/tasks/main.yml
+++ b/tests/integration/targets/mount/tasks/main.yml
@@ -134,7 +134,7 @@
  register: bind_result_freebsd_dry_run
  check_mode: true

- name: Attempt to stat bind mounted file
+- name: attempt to stat bind mounted file
  ansible.builtin.stat:
    path: '{{ output_dir }}/mount_dest/test_file'
  when: ansible_system in ('FreeBSD', 'Linux')
@@ -143,7 +143,11 @@
 - name: Assert the bind mount did not take place
  ansible.builtin.assert:
    that:
+      - linux_and_changed or freebsd_and_changed
      - not dest_stat['stat']['exists']
+  vars:
+    linux_and_changed: "{{ ansible_system == 'Linux' and bind_result_linux_dry_run['changed'] }}"
+    freebsd_and_changed: "{{ ansible_system == 'FreeBSD' and bind_result_freebsd['changed'] }}"
  when: ansible_system in ('FreeBSD', 'Linux')

 # bind mount
@@ -326,12 +330,12 @@
  when: ansible_system in ('FreeBSD', 'Linux')

 # SWAP #############################################################
- name: Swap
+- name: swap
  when: ansible_system in ('Linux')
  block:
    # mount swap check mode
    - name: Stat /etc/fstab
-      ansible.builtin.stat:
+      stat:
        path: /etc/fstab
      register: stat_fstab_before

@@ -345,7 +349,7 @@
      check_mode: true

    - name: Stat /etc/fstab
-      ansible.builtin.stat:
+      stat:
        path: /etc/fstab
      register: stat_fstab_after

@@ -406,7 +410,7 @@

    # remove swap check mode
    - name: Stat /etc/fstab
-      ansible.builtin.stat:
+      stat:
        path: /etc/fstab
      register: stat_fstab_before

@@ -418,7 +422,7 @@
      check_mode: true

    - name: Stat /etc/fstab
-      ansible.builtin.stat:
+      stat:
        path: /etc/fstab
      register: stat_fstab_after

@@ -470,7 +474,7 @@
          - not swap2_removed_again['changed']

 # FIXUP #############################################################
- name: Fix incomplete entry already present in fstab
+- name: fix incomplete entry already present in fstab
  when: ansible_system == 'Linux'
  block:
    - name: Create fstab record with missing last two fields
@@ -807,7 +811,7 @@
        path: '{{ ephemeral_fstab }}'
      register: fstab_stat_before_mount

-    - name: Mount the FS A with ephemeral state (check mode)
+    - name: Mount the FS A with ephemeral state
      ansible.posix.mount:
        path: /tmp/myfs
        src: '{{ ephemeral_device_a }}'
@@ -830,7 +834,7 @@
      failed_when: false
      changed_when: false

-    - name: Assert the mount occurred and the fstab is unchanged
+    - name: Assert the mount occured and the fstab is unchanged
      ansible.builtin.assert:
        that:
          - check_mountinfo.stdout|int == 0
--- a/tests/integration/targets/seboolean/tasks/main.yml
+++ b/tests/integration/targets/seboolean/tasks/main.yml
@@ -20,4 +20,5 @@
  ansible.builtin.include_tasks: seboolean.yml
  when:
    - ansible_selinux is defined
+    - ansible_selinux
    - ansible_selinux.status == 'enabled'
--- a/tests/integration/targets/selinux/tasks/main.yml
+++ b/tests/integration/targets/selinux/tasks/main.yml
@@ -19,21 +19,23 @@
 - name: Debug message for when SELinux is disabled
  ansible.builtin.debug:
    msg: SELinux is disabled
-  when: ansible_selinux is defined and ansible_selinux.status == 'disabled'
+  when: ansible_selinux is defined and not ansible_selinux

 - name: Debug message for when SELinux is enabled and not disabled
  ansible.builtin.debug:
    msg: SELinux is {{ ansible_selinux.status }}
-  when: ansible_selinux is defined
+  when: ansible_selinux is defined and ansible_selinux

 - name: Include_tasks for when SELinux is enabled
  ansible.builtin.include_tasks: selinux.yml
  when:
    - ansible_selinux is defined
+    - ansible_selinux
    - ansible_selinux.status == 'enabled'

 - name: Include tasks for selogin when SELinux is enabled
  ansible.builtin.include_tasks: selogin.yml
  when:
    - ansible_selinux is defined
+    - ansible_selinux
    - ansible_selinux.status == 'enabled'
--- a/tests/sanity/ignore-2.20.txt
+++ b/tests/sanity/ignore-2.20.txt
@@ -1 +0,0 @@
-tests/utils/shippable/timing.py shebang
--- a/tests/sanity/ignore-2.21.txt
+++ b/tests/sanity/ignore-2.21.txt
@@ -1,10 +0,0 @@
-tests/utils/shippable/timing.py shebang
-plugins/action/synchronize.py pylint:ansible-bad-import-from
-plugins/callback/cgroup_perf_recap.py pylint:ansible-bad-import-from
-plugins/modules/mount.py pylint:ansible-bad-import-from
-plugins/modules/sysctl.py pylint:ansible-bad-import-from
-plugins/shell/csh.py pylint:ansible-bad-import-from
-plugins/shell/fish.py pylint:ansible-bad-import-from
-tests/unit/mock/procenv.py pylint:ansible-bad-import-from
-tests/unit/mock/yaml_helper.py pylint:ansible-bad-import-from
-tests/unit/modules/conftest.py pylint:ansible-bad-import-from
--- a/tests/utils/shippable/lint.sh
+++ b/tests/utils/shippable/lint.sh
@@ -9,5 +9,6 @@ command -v ansible
 pip install --upgrade --user pip
 pip install --upgrade --user ansible-lint

-# To specify additional options, you can specify them into .ansible-lint file.
-PATH="${PATH/\~/${HOME}}" ansible-lint
+PATH="${PATH/\~/${HOME}}" ansible-lint \
+                                    --exclude changelogs/ \
+                                    --profile=production
--- a/tests/utils/shippable/shippable.sh
+++ b/tests/utils/shippable/shippable.sh
@@ -62,15 +62,15 @@ else
    retry pip install "https://github.com/ansible/ansible/archive/stable-${ansible_version}.tar.gz" --disable-pip-version-check
 fi

-export ANSIBLE_COLLECTIONS_PATH="${PWD}/../../../"
+export ANSIBLE_COLLECTIONS_PATHS="${PWD}/../../../"

 # START: HACK install dependencies
 if [ "${ansible_version}" == "2.9" ] || [ "${ansible_version}" == "2.10" ]; then
    # Note: Since community.general 5.x, Ansible Core versions prior to 2.11 are not supported.
    # So we need to use 4.8.1 for Ansible 2.9 and Ansible Engine 2.10.
-    retry git clone --depth=1 --single-branch -b 4.8.1 https://github.com/ansible-collections/community.general.git "${ANSIBLE_COLLECTIONS_PATH}/ansible_collections/community/general"
+    retry git clone --depth=1 --single-branch -b 4.8.1 https://github.com/ansible-collections/community.general.git "${ANSIBLE_COLLECTIONS_PATHS}/ansible_collections/community/general"
 else
-    retry git clone --depth=1 --single-branch https://github.com/ansible-collections/community.general.git "${ANSIBLE_COLLECTIONS_PATH}/ansible_collections/community/general"
+    retry git clone --depth=1 --single-branch https://github.com/ansible-collections/community.general.git "${ANSIBLE_COLLECTIONS_PATHS}/ansible_collections/community/general"
 fi
 # Note:  we're installing with git to work around Galaxy being a huge PITA (https://github.com/ansible/galaxy/issues/2429)
 # END: HACK
Author	SHA1	Message	Date
simonLeary42	5cd2060d11	Merge `f087d58cbe` into `44a2151dbf`	2025-03-05 00:40:06 +00:00
Simon Leary	f087d58cbe	fix bugs	2025-03-05 00:39:46 +00:00
Simon Leary	eb740e97d4	add check mode tests, add comments	2025-03-05 00:33:11 +00:00
softwarefactory-project-zuul[bot]	44a2151dbf	Merge pull request #604 from saito-hideki/pr/bump_up_version_3.0.0 Bump version to 3.0.0 for the next release SUMMARY Bump version to 3.0.0 for the next release on main branch: Fixes #603 ISSUE TYPE Feature Pull Request COMPONENT NAME ansible.posix ADDITIONAL INFORMATION None	2024-12-10 08:59:03 +00:00
Hideki Saito	83288b9020	Bump version to 3.0.0 for the next release * Fixes #603 Signed-off-by: Hideki Saito <saito@fgrep.org>	2024-12-10 17:30:22 +09:00
softwarefactory-project-zuul[bot]	4c6898ee6e	Merge pull request #600 from saito-hideki/release_2.0.0 Release 2.0.0 commit SUMMARY Release 2.0.0 commit Release Plan #149 ISSUE TYPE Feature Pull Request COMPONENT NAME ansible.posix ADDITIONAL INFORMATION This will be merged on 5 December if there are no problems Reviewed-by: Adam Miller <admiller@redhat.com> Reviewed-by: Andrew Klychkov <aklychko@redhat.com>	2024-12-05 00:48:30 +00:00
Hideki Saito	f5eae12146	Release 2.0.0 commit Signed-off-by: Hideki Saito <saito@fgrep.org>	2024-12-04 09:46:44 +09:00
softwarefactory-project-zuul[bot]	f632fad9d4	Merge pull request #598 from saito-hideki/issue/586 [Breaking Change] [firewalld] Change type of icmp_block_inversion option from str to bool SUMMARY Changed the type of icmp_block_inversion option from str to bool Fixes #586 ISSUE TYPE Bugfix Pull Request COMPONENT NAME ansible.posix.firewalld ADDITIONAL INFORMATION Related #582 and #584 Reviewed-by: Adam Miller <admiller@redhat.com> Reviewed-by: Andrew Klychkov <aklychko@redhat.com>	2024-12-02 23:50:26 +00:00
softwarefactory-project-zuul[bot]	74edb72249	Merge pull request #597 from vbotka/mount-fix-comment Remove comment from fstab entry on updating. SUMMARY Fix #595. ISSUE TYPE Bugfix Pull Request COMPONENT NAME ansible.posix.mount ADDITIONAL INFORMATION Reviewed-by: Hideki Saito <saito@fgrep.org> Reviewed-by: Vladimir Botka <vbotka@gmail.com>	2024-11-29 02:59:28 +00:00
Vladimir Botka	91129ed381	Fix changelog fragment module name.	2024-11-29 03:34:14 +01:00
Vladimir Botka	7b8d627552	Changelog fragment added.	2024-11-28 08:17:41 +01:00
Hideki Saito	6175a5028b	Change type of icmp_block_inversion option from str to bool * Fixes #586 Signed-off-by: Hideki Saito <saito@fgrep.org>	2024-11-28 14:19:20 +09:00
Vladimir Botka	8e34860d6c	Fix #595 . Remove comment from fstab entry on updating.	2024-11-21 20:54:27 +01:00