The docs workflow copied the collection to ~/.ansible/collections and ran
the docs action there. actions/checkout v6 stopped writing the token into
.git/config and now keeps it in a separate file referenced by an
includeIf.gitdir entry scoped to the workspace path (PR actions/checkout#2286).
The copy inherits the includeIf entry but not the matching gitdir, so it
had no credentials and the gh-pages push failed.
Put the workspace on the collections path instead. The checkout already
has the ansible_collections/kubevirt/core layout, so the docs build can
run in it directly, which also means checkout's own credentials apply to
the gh-pages push. This removes the manual credential setup added in
38a2548, a13ef97 and 04ae38b.
Verified on a fork: docs build and gh-pages push both succeed.
Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
The docs workflow copies the checkout to a work directory before the
credential setup step runs. The action then operates on the copy, so
--local config on the original checkout is not visible. Switch to
--global so credentials apply to all git operations on the runner.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
The credential helper approach fails because GITHUB_TOKEN env var is
not available when git push runs inside collection-docs-action. Switch
to http.extraheader which embeds the auth as a static git config value,
matching the approach checkout v4 used.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
actions/checkout v7 changed credential persistence from http.extraheader
to includeIf.gitdir-scoped config files. The collection-docs-action does
not pick up the new credential format, breaking git push to gh-pages.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
The docs workflow fails because ansible_basic_sphinx_ext uses
pkg_resources which was removed in recent setuptools versions.
The package is archived and deprecated - its functionality is
already covered by sphinx_antsibull_ext and ansible-pygments.
Also remove the Python version pin to use the runner default.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
Python 3.14 removed pkg_resources, which breaks
ansible_basic_sphinx_ext. Pin to 3.13 until the
upstream dependency is updated.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
Cleanup the .github actions:
- Use the same syntax and/or commands where possible
- Drop unnecessary parameters and steps / commands
- In the all-green job ensure that all CI jobs passed
- Update the naming of jobs
- Review permissions and grant write permission only where
necessary (repo is set to read-only by default)
- Review installed dependencies (try to fix the failing docs job)
- Run yamllint and fix findings
- Replace deprecated set-output syntax
Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
Use Python 3.9 - 3.12 and Ansible 2.14 - 2.16, devel and milestone to run
tests of the collection. Use the latest stable python version in test setups
where sensible. Instead of using the integration.yml workflog from main
use it from the same commit as the test runs instead.
Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
Bump the versions of all used actions to the latest stable version and
try to use the same config across files and defaults where sensible.
Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
The workflows committed in the first commit were missing the
installation of required dependencies and other fixes.
Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>