internet/kubevirt.core
3
0
Fork 0
mirror of https://github.com/kubevirt/kubevirt.core.git synced 2026-08-01 20:34:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup(kubevirt_vm): Simplify tests

Browse Source 
Simplify kubevirt_vm tests by not using fixtures if not needed.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
This commit is contained in:
Felix Matouschek
2024-07-11 16:29:11 +02:00
parent a2de465d1f
commit 501bd3d52f
1 changed files with 404 additions and 501 deletions
Download Patch File Download Diff File Expand all files Collapse all files

293
tests/unit/plugins/modules/test_kubevirt_vm.py
View File

@@ -20,9 +20,14 @@ from ansible_collections.kubevirt.core.tests.unit.utils.ansible_module_mock impo
)
@pytest.fixture(scope="module")
def vm_definition_create():
return {
def test_module_fails_when_required_args_missing(mocker):
mocker.patch.object(AnsibleModule, "fail_json", fail_json)
with pytest.raises(AnsibleFailJson):
set_module_args({})
kubevirt_vm.main()
VM_DEFINITION_CREATE = {
"apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine",
"metadata": {
@@ -60,12 +65,9 @@ def vm_definition_create():
},
},
},
}
}
@pytest.fixture(scope="module")
def vm_definition_running():
return {
VM_DEFINITION_RUNNING = {
"apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine",
"metadata": {
@@ -80,12 +82,9 @@ def vm_definition_running():
},
},
},
}
}
@pytest.fixture(scope="module")
def vm_definition_stopped():
return {
VM_DEFINITION_STOPPED = {
"apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine",
"metadata": {
@@ -100,12 +99,9 @@ def vm_definition_stopped():
},
},
},
}
}
@pytest.fixture(scope="module")
def module_params_default():
return {
MODULE_PARAMS_DEFAULT = {
"api_version": "kubevirt.io/v1",
"annotations": None,
"labels": None,
@@ -136,12 +132,9 @@ def module_params_default():
"state": "present",
"force": False,
"delete_options": None,
}
}
@pytest.fixture(scope="module")
def module_params_create(module_params_default):
return module_params_default | {
MODULE_PARAMS_CREATE = MODULE_PARAMS_DEFAULT | {
"name": "testvm",
"namespace": "default",
"labels": {"service": "loadbalancer", "environment": "staging"},
@@ -167,117 +160,82 @@ def module_params_create(module_params_default):
"domain": {"devices": {}},
"terminationGracePeriodSeconds": 180,
},
}
}
@pytest.fixture(scope="module")
def module_params_running(module_params_default):
return module_params_default | {
MODULE_PARAMS_RUNNING = MODULE_PARAMS_DEFAULT | {
"name": "testvm",
"namespace": "default",
"running": True,
}
}
@pytest.fixture(scope="module")
def module_params_stopped(module_params_default):
return module_params_default | {
MODULE_PARAMS_STOPPED = MODULE_PARAMS_DEFAULT | {
"name": "testvm",
"namespace": "default",
"running": False,
}
}
@pytest.fixture(scope="module")
def module_params_delete(module_params_default):
return module_params_default | {
MODULE_PARAMS_DELETE = MODULE_PARAMS_DEFAULT | {
"name": "testvm",
"namespace": "default",
"state": "absent",
"wait": True,
}
}
@pytest.fixture(scope="module")
def k8s_module_params_create(module_params_create, vm_definition_create):
return module_params_create | {
K8S_MODULE_PARAMS_CREATE = MODULE_PARAMS_CREATE | {
"generate_name": None,
"resource_definition": vm_definition_create,
"resource_definition": VM_DEFINITION_CREATE,
"wait_condition": {"type": "Ready", "status": True},
}
}
@pytest.fixture(scope="module")
def k8s_module_params_running(module_params_running, vm_definition_running):
return module_params_running | {
K8S_MODULE_PARAMS_RUNNING = MODULE_PARAMS_RUNNING | {
"generate_name": None,
"resource_definition": vm_definition_running,
"resource_definition": VM_DEFINITION_RUNNING,
"wait_condition": {"type": "Ready", "status": True},
}
}
@pytest.fixture(scope="module")
def k8s_module_params_stopped(module_params_stopped, vm_definition_stopped):
return module_params_stopped | {
K8S_MODULE_PARAMS_STOPPED = MODULE_PARAMS_STOPPED | {
"generate_name": None,
"resource_definition": vm_definition_stopped,
"resource_definition": VM_DEFINITION_STOPPED,
"wait_condition": {"type": "Ready", "status": False, "reason": "VMINotExists"},
}
}
@pytest.fixture(scope="module")
def k8s_module_params_delete(module_params_delete, vm_definition_running):
return module_params_delete | {
K8S_MODULE_PARAMS_DELETE = MODULE_PARAMS_DELETE | {
"generate_name": None,
"resource_definition": vm_definition_running,
"resource_definition": VM_DEFINITION_RUNNING,
"wait_condition": {"type": "Ready", "status": True},
}
def test_module_fails_when_required_args_missing(mocker):
mocker.patch.object(AnsibleModule, "fail_json", fail_json)
with pytest.raises(AnsibleFailJson):
set_module_args({})
kubevirt_vm.main()
}
@pytest.mark.parametrize(
"module_params,k8s_module_params,vm_definition,method",
[
(
"module_params_create",
"k8s_module_params_create",
"vm_definition_create",
MODULE_PARAMS_CREATE,
K8S_MODULE_PARAMS_CREATE,
VM_DEFINITION_CREATE,
"create",
),
(
"module_params_running",
"k8s_module_params_running",
"vm_definition_running",
MODULE_PARAMS_RUNNING,
K8S_MODULE_PARAMS_RUNNING,
VM_DEFINITION_RUNNING,
"update",
),
(
"module_params_stopped",
"k8s_module_params_stopped",
"vm_definition_stopped",
MODULE_PARAMS_STOPPED,
K8S_MODULE_PARAMS_STOPPED,
VM_DEFINITION_STOPPED,
"update",
),
(
"module_params_delete",
"k8s_module_params_delete",
"vm_definition_running",
MODULE_PARAMS_DELETE,
K8S_MODULE_PARAMS_DELETE,
VM_DEFINITION_RUNNING,
"delete",
),
],
)
def test_module(
request,
mocker,
module_params,
k8s_module_params,
vm_definition,
method,
):
def test_module(mocker, module_params, k8s_module_params, vm_definition, method):
mocker.patch.object(AnsibleModule, "exit_json", exit_json)
mocker.patch.object(runner, "get_api_client")
@@ -292,56 +250,39 @@ def test_module(
)
with pytest.raises(AnsibleExitJson):
set_module_args(request.getfixturevalue(module_params))
set_module_args(module_params)
kubevirt_vm.main()
perform_action.assert_called_once_with(
mocker.ANY,
request.getfixturevalue(vm_definition),
request.getfixturevalue(k8s_module_params),
vm_definition,
k8s_module_params,
)
@pytest.fixture(scope="module")
def create_vm_params():
return {
CREATE_VM_PARAMS = {
"api_version": "kubevirt.io/v1",
"running": True,
"namespace": "default",
}
}
@pytest.fixture(scope="module")
def create_vm_params_annotations(create_vm_params):
return create_vm_params | {
CREATE_VM_PARAMS_ANNOTATIONS = CREATE_VM_PARAMS | {
"annotations": {"test": "test"},
}
}
@pytest.fixture(scope="module")
def create_vm_params_labels(create_vm_params):
return create_vm_params | {
CREATE_VM_PARAMS_LABELS = CREATE_VM_PARAMS | {
"labels": {"test": "test"},
}
}
@pytest.fixture(scope="module")
def create_vm_params_instancetype(create_vm_params):
return create_vm_params | {
CREATE_VM_PARAMS_INSTANCETYPE = CREATE_VM_PARAMS | {
"instancetype": {"name": "u1.medium"},
}
}
@pytest.fixture(scope="module")
def create_vm_params_preference(create_vm_params):
return create_vm_params | {
CREATE_VM_PARAMS_PREFERENCE = CREATE_VM_PARAMS | {
"preference": {"name": "fedora"},
}
}
@pytest.fixture(scope="module")
def create_vm_params_datavolumetemplate(create_vm_params):
return create_vm_params | {
CREATE_VM_PARAMS_DATAVOLUMETEMPLATE = CREATE_VM_PARAMS | {
"data_volume_templates": [
{
"metadata": {"name": "testdv"},
@@ -358,26 +299,17 @@ def create_vm_params_datavolumetemplate(create_vm_params):
},
},
],
}
}
@pytest.fixture(scope="module")
def create_vm_params_name(create_vm_params):
return create_vm_params | {
CREATE_VM_PARAMS_NAME = CREATE_VM_PARAMS | {
"name": "testvm",
}
}
@pytest.fixture(scope="module")
def create_vm_params_generate_name(create_vm_params):
return create_vm_params | {
CREATE_VM_PARAMS_GENERATE_NAME = CREATE_VM_PARAMS | {
"generate_name": "testvm-1234",
}
}
@pytest.fixture(scope="module")
def create_vm_params_specs(create_vm_params):
return create_vm_params | {
CREATE_VM_PARAMS_SPECS = CREATE_VM_PARAMS | {
"spec": {
"domain": {
"devices": {
@@ -389,12 +321,9 @@ def create_vm_params_specs(create_vm_params):
}
}
}
}
}
@pytest.fixture(scope="module")
def created_vm():
return {
CREATED_VM = {
"apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine",
"metadata": {
@@ -410,12 +339,9 @@ def created_vm():
},
},
},
}
}
@pytest.fixture(scope="module")
def created_vm_labels():
return {
CREATED_VM_LABELS = {
"apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine",
"metadata": {
@@ -437,12 +363,9 @@ def created_vm_labels():
},
},
},
}
}
@pytest.fixture(scope="module")
def created_vm_annotations():
return {
CREATED_VM_ANNOTATIONS = {
"apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine",
"metadata": {
@@ -464,12 +387,9 @@ def created_vm_annotations():
},
},
},
}
}
@pytest.fixture(scope="module")
def created_vm_instancetype():
return {
CREATED_VM_INSTANCETYPE = {
"apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine",
"metadata": {
@@ -486,12 +406,9 @@ def created_vm_instancetype():
},
},
},
}
}
@pytest.fixture(scope="module")
def created_vm_preference():
return {
CREATED_VM_PREFERENCE = {
"apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine",
"metadata": {
@@ -508,12 +425,9 @@ def created_vm_preference():
},
},
},
}
}
@pytest.fixture(scope="module")
def created_vm_datavolumetemplate():
return {
CREATED_VM_DATAVOLUMETEMPLATE = {
"apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine",
"metadata": {
@@ -545,12 +459,9 @@ def created_vm_datavolumetemplate():
},
},
},
}
}
@pytest.fixture(scope="module")
def created_vm_name():
return {
CREATED_VM_NAME = {
"apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine",
"metadata": {
@@ -567,12 +478,9 @@ def created_vm_name():
},
},
},
}
}
@pytest.fixture(scope="module")
def created_vm_generate_name():
return {
CREATED_VM_GENERATE_NAME = {
"apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine",
"metadata": {
@@ -589,12 +497,9 @@ def created_vm_generate_name():
},
},
},
}
}
@pytest.fixture(scope="module")
def created_vm_specs():
return {
CREATED_VM_SPECS = {
"apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine",
"metadata": {
@@ -616,24 +521,22 @@ def created_vm_specs():
},
},
},
}
}
@pytest.mark.parametrize(
"params,expected",
[
("create_vm_params", "created_vm"),
("create_vm_params_annotations", "created_vm_annotations"),
("create_vm_params_labels", "created_vm_labels"),
("create_vm_params_instancetype", "created_vm_instancetype"),
("create_vm_params_preference", "created_vm_preference"),
("create_vm_params_datavolumetemplate", "created_vm_datavolumetemplate"),
("create_vm_params_name", "created_vm_name"),
("create_vm_params_generate_name", "created_vm_generate_name"),
("create_vm_params_specs", "created_vm_specs"),
(CREATE_VM_PARAMS, CREATED_VM),
(CREATE_VM_PARAMS_ANNOTATIONS, CREATED_VM_ANNOTATIONS),
(CREATE_VM_PARAMS_LABELS, CREATED_VM_LABELS),
(CREATE_VM_PARAMS_INSTANCETYPE, CREATED_VM_INSTANCETYPE),
(CREATE_VM_PARAMS_PREFERENCE, CREATED_VM_PREFERENCE),
(CREATE_VM_PARAMS_DATAVOLUMETEMPLATE, CREATED_VM_DATAVOLUMETEMPLATE),
(CREATE_VM_PARAMS_NAME, CREATED_VM_NAME),
(CREATE_VM_PARAMS_GENERATE_NAME, CREATED_VM_GENERATE_NAME),
(CREATE_VM_PARAMS_SPECS, CREATED_VM_SPECS),
],
)
def test_create_vm(request, params, expected):
assert kubevirt_vm.create_vm(
request.getfixturevalue(params)
) == request.getfixturevalue(expected)
def test_create_vm(params, expected):
assert kubevirt_vm.create_vm(params) == expected