internet/kubevirt.core
3
0
Fork 0
mirror of https://github.com/kubevirt/kubevirt.core.git synced 2026-07-30 03:14:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

cleanup(kubevirt_vm): Simplify tests

Browse Source 
Simplify kubevirt_vm tests by not using fixtures if not needed.

Signed-off-by: Felix Matouschek <fmatouschek@redhat.com>
This commit is contained in:
Felix Matouschek
2024-07-11 16:29:11 +02:00
parent a2de465d1f
commit 501bd3d52f
1 changed files with 404 additions and 501 deletions
Download Patch File Download Diff File Expand all files Collapse all files

293
tests/unit/plugins/modules/test_kubevirt_vm.py
View File

@@ -20,9 +20,14 @@ from ansible_collections.kubevirt.core.tests.unit.utils.ansible_module_mock impo
) )
@pytest.fixture(scope="module") def test_module_fails_when_required_args_missing(mocker):
def vm_definition_create(): mocker.patch.object(AnsibleModule, "fail_json", fail_json)
return { with pytest.raises(AnsibleFailJson):
set_module_args({})
kubevirt_vm.main()
VM_DEFINITION_CREATE = {
"apiVersion": "kubevirt.io/v1", "apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine", "kind": "VirtualMachine",
"metadata": { "metadata": {
@@ -60,12 +65,9 @@ def vm_definition_create():
}, },
}, },
}, },
} }
VM_DEFINITION_RUNNING = {
@pytest.fixture(scope="module")
def vm_definition_running():
return {
"apiVersion": "kubevirt.io/v1", "apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine", "kind": "VirtualMachine",
"metadata": { "metadata": {
@@ -80,12 +82,9 @@ def vm_definition_running():
}, },
}, },
}, },
} }
VM_DEFINITION_STOPPED = {
@pytest.fixture(scope="module")
def vm_definition_stopped():
return {
"apiVersion": "kubevirt.io/v1", "apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine", "kind": "VirtualMachine",
"metadata": { "metadata": {
@@ -100,12 +99,9 @@ def vm_definition_stopped():
}, },
}, },
}, },
} }
MODULE_PARAMS_DEFAULT = {
@pytest.fixture(scope="module")
def module_params_default():
return {
"api_version": "kubevirt.io/v1", "api_version": "kubevirt.io/v1",
"annotations": None, "annotations": None,
"labels": None, "labels": None,
@@ -136,12 +132,9 @@ def module_params_default():
"state": "present", "state": "present",
"force": False, "force": False,
"delete_options": None, "delete_options": None,
} }
MODULE_PARAMS_CREATE = MODULE_PARAMS_DEFAULT | {
@pytest.fixture(scope="module")
def module_params_create(module_params_default):
return module_params_default | {
"name": "testvm", "name": "testvm",
"namespace": "default", "namespace": "default",
"labels": {"service": "loadbalancer", "environment": "staging"}, "labels": {"service": "loadbalancer", "environment": "staging"},
@@ -167,117 +160,82 @@ def module_params_create(module_params_default):
"domain": {"devices": {}}, "domain": {"devices": {}},
"terminationGracePeriodSeconds": 180, "terminationGracePeriodSeconds": 180,
}, },
} }
MODULE_PARAMS_RUNNING = MODULE_PARAMS_DEFAULT | {
@pytest.fixture(scope="module")
def module_params_running(module_params_default):
return module_params_default | {
"name": "testvm", "name": "testvm",
"namespace": "default", "namespace": "default",
"running": True, "running": True,
} }
MODULE_PARAMS_STOPPED = MODULE_PARAMS_DEFAULT | {
@pytest.fixture(scope="module")
def module_params_stopped(module_params_default):
return module_params_default | {
"name": "testvm", "name": "testvm",
"namespace": "default", "namespace": "default",
"running": False, "running": False,
} }
MODULE_PARAMS_DELETE = MODULE_PARAMS_DEFAULT | {
@pytest.fixture(scope="module")
def module_params_delete(module_params_default):
return module_params_default | {
"name": "testvm", "name": "testvm",
"namespace": "default", "namespace": "default",
"state": "absent", "state": "absent",
"wait": True, "wait": True,
} }
K8S_MODULE_PARAMS_CREATE = MODULE_PARAMS_CREATE | {
@pytest.fixture(scope="module")
def k8s_module_params_create(module_params_create, vm_definition_create):
return module_params_create | {
"generate_name": None, "generate_name": None,
"resource_definition": vm_definition_create, "resource_definition": VM_DEFINITION_CREATE,
"wait_condition": {"type": "Ready", "status": True}, "wait_condition": {"type": "Ready", "status": True},
} }
K8S_MODULE_PARAMS_RUNNING = MODULE_PARAMS_RUNNING | {
@pytest.fixture(scope="module")
def k8s_module_params_running(module_params_running, vm_definition_running):
return module_params_running | {
"generate_name": None, "generate_name": None,
"resource_definition": vm_definition_running, "resource_definition": VM_DEFINITION_RUNNING,
"wait_condition": {"type": "Ready", "status": True}, "wait_condition": {"type": "Ready", "status": True},
} }
K8S_MODULE_PARAMS_STOPPED = MODULE_PARAMS_STOPPED | {
@pytest.fixture(scope="module")
def k8s_module_params_stopped(module_params_stopped, vm_definition_stopped):
return module_params_stopped | {
"generate_name": None, "generate_name": None,
"resource_definition": vm_definition_stopped, "resource_definition": VM_DEFINITION_STOPPED,
"wait_condition": {"type": "Ready", "status": False, "reason": "VMINotExists"}, "wait_condition": {"type": "Ready", "status": False, "reason": "VMINotExists"},
} }
K8S_MODULE_PARAMS_DELETE = MODULE_PARAMS_DELETE | {
@pytest.fixture(scope="module")
def k8s_module_params_delete(module_params_delete, vm_definition_running):
return module_params_delete | {
"generate_name": None, "generate_name": None,
"resource_definition": vm_definition_running, "resource_definition": VM_DEFINITION_RUNNING,
"wait_condition": {"type": "Ready", "status": True}, "wait_condition": {"type": "Ready", "status": True},
} }
def test_module_fails_when_required_args_missing(mocker):
mocker.patch.object(AnsibleModule, "fail_json", fail_json)
with pytest.raises(AnsibleFailJson):
set_module_args({})
kubevirt_vm.main()
@pytest.mark.parametrize( @pytest.mark.parametrize(
"module_params,k8s_module_params,vm_definition,method", "module_params,k8s_module_params,vm_definition,method",
[ [
( (
"module_params_create", MODULE_PARAMS_CREATE,
"k8s_module_params_create", K8S_MODULE_PARAMS_CREATE,
"vm_definition_create", VM_DEFINITION_CREATE,
"create", "create",
), ),
( (
"module_params_running", MODULE_PARAMS_RUNNING,
"k8s_module_params_running", K8S_MODULE_PARAMS_RUNNING,
"vm_definition_running", VM_DEFINITION_RUNNING,
"update", "update",
), ),
( (
"module_params_stopped", MODULE_PARAMS_STOPPED,
"k8s_module_params_stopped", K8S_MODULE_PARAMS_STOPPED,
"vm_definition_stopped", VM_DEFINITION_STOPPED,
"update", "update",
), ),
( (
"module_params_delete", MODULE_PARAMS_DELETE,
"k8s_module_params_delete", K8S_MODULE_PARAMS_DELETE,
"vm_definition_running", VM_DEFINITION_RUNNING,
"delete", "delete",
), ),
], ],
) )
def test_module( def test_module(mocker, module_params, k8s_module_params, vm_definition, method):
request,
mocker,
module_params,
k8s_module_params,
vm_definition,
method,
):
mocker.patch.object(AnsibleModule, "exit_json", exit_json) mocker.patch.object(AnsibleModule, "exit_json", exit_json)
mocker.patch.object(runner, "get_api_client") mocker.patch.object(runner, "get_api_client")
@@ -292,56 +250,39 @@ def test_module(
) )
with pytest.raises(AnsibleExitJson): with pytest.raises(AnsibleExitJson):
set_module_args(request.getfixturevalue(module_params)) set_module_args(module_params)
kubevirt_vm.main() kubevirt_vm.main()
perform_action.assert_called_once_with( perform_action.assert_called_once_with(
mocker.ANY, mocker.ANY,
request.getfixturevalue(vm_definition), vm_definition,
request.getfixturevalue(k8s_module_params), k8s_module_params,
) )
@pytest.fixture(scope="module") CREATE_VM_PARAMS = {
def create_vm_params():
return {
"api_version": "kubevirt.io/v1", "api_version": "kubevirt.io/v1",
"running": True, "running": True,
"namespace": "default", "namespace": "default",
} }
CREATE_VM_PARAMS_ANNOTATIONS = CREATE_VM_PARAMS | {
@pytest.fixture(scope="module")
def create_vm_params_annotations(create_vm_params):
return create_vm_params | {
"annotations": {"test": "test"}, "annotations": {"test": "test"},
} }
CREATE_VM_PARAMS_LABELS = CREATE_VM_PARAMS | {
@pytest.fixture(scope="module")
def create_vm_params_labels(create_vm_params):
return create_vm_params | {
"labels": {"test": "test"}, "labels": {"test": "test"},
} }
CREATE_VM_PARAMS_INSTANCETYPE = CREATE_VM_PARAMS | {
@pytest.fixture(scope="module")
def create_vm_params_instancetype(create_vm_params):
return create_vm_params | {
"instancetype": {"name": "u1.medium"}, "instancetype": {"name": "u1.medium"},
} }
CREATE_VM_PARAMS_PREFERENCE = CREATE_VM_PARAMS | {
@pytest.fixture(scope="module")
def create_vm_params_preference(create_vm_params):
return create_vm_params | {
"preference": {"name": "fedora"}, "preference": {"name": "fedora"},
} }
CREATE_VM_PARAMS_DATAVOLUMETEMPLATE = CREATE_VM_PARAMS | {
@pytest.fixture(scope="module")
def create_vm_params_datavolumetemplate(create_vm_params):
return create_vm_params | {
"data_volume_templates": [ "data_volume_templates": [
{ {
"metadata": {"name": "testdv"}, "metadata": {"name": "testdv"},
@@ -358,26 +299,17 @@ def create_vm_params_datavolumetemplate(create_vm_params):
}, },
}, },
], ],
} }
CREATE_VM_PARAMS_NAME = CREATE_VM_PARAMS | {
@pytest.fixture(scope="module")
def create_vm_params_name(create_vm_params):
return create_vm_params | {
"name": "testvm", "name": "testvm",
} }
CREATE_VM_PARAMS_GENERATE_NAME = CREATE_VM_PARAMS | {
@pytest.fixture(scope="module")
def create_vm_params_generate_name(create_vm_params):
return create_vm_params | {
"generate_name": "testvm-1234", "generate_name": "testvm-1234",
} }
CREATE_VM_PARAMS_SPECS = CREATE_VM_PARAMS | {
@pytest.fixture(scope="module")
def create_vm_params_specs(create_vm_params):
return create_vm_params | {
"spec": { "spec": {
"domain": { "domain": {
"devices": { "devices": {
@@ -389,12 +321,9 @@ def create_vm_params_specs(create_vm_params):
} }
} }
} }
} }
CREATED_VM = {
@pytest.fixture(scope="module")
def created_vm():
return {
"apiVersion": "kubevirt.io/v1", "apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine", "kind": "VirtualMachine",
"metadata": { "metadata": {
@@ -410,12 +339,9 @@ def created_vm():
}, },
}, },
}, },
} }
CREATED_VM_LABELS = {
@pytest.fixture(scope="module")
def created_vm_labels():
return {
"apiVersion": "kubevirt.io/v1", "apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine", "kind": "VirtualMachine",
"metadata": { "metadata": {
@@ -437,12 +363,9 @@ def created_vm_labels():
}, },
}, },
}, },
} }
CREATED_VM_ANNOTATIONS = {
@pytest.fixture(scope="module")
def created_vm_annotations():
return {
"apiVersion": "kubevirt.io/v1", "apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine", "kind": "VirtualMachine",
"metadata": { "metadata": {
@@ -464,12 +387,9 @@ def created_vm_annotations():
}, },
}, },
}, },
} }
CREATED_VM_INSTANCETYPE = {
@pytest.fixture(scope="module")
def created_vm_instancetype():
return {
"apiVersion": "kubevirt.io/v1", "apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine", "kind": "VirtualMachine",
"metadata": { "metadata": {
@@ -486,12 +406,9 @@ def created_vm_instancetype():
}, },
}, },
}, },
} }
CREATED_VM_PREFERENCE = {
@pytest.fixture(scope="module")
def created_vm_preference():
return {
"apiVersion": "kubevirt.io/v1", "apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine", "kind": "VirtualMachine",
"metadata": { "metadata": {
@@ -508,12 +425,9 @@ def created_vm_preference():
}, },
}, },
}, },
} }
CREATED_VM_DATAVOLUMETEMPLATE = {
@pytest.fixture(scope="module")
def created_vm_datavolumetemplate():
return {
"apiVersion": "kubevirt.io/v1", "apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine", "kind": "VirtualMachine",
"metadata": { "metadata": {
@@ -545,12 +459,9 @@ def created_vm_datavolumetemplate():
}, },
}, },
}, },
} }
CREATED_VM_NAME = {
@pytest.fixture(scope="module")
def created_vm_name():
return {
"apiVersion": "kubevirt.io/v1", "apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine", "kind": "VirtualMachine",
"metadata": { "metadata": {
@@ -567,12 +478,9 @@ def created_vm_name():
}, },
}, },
}, },
} }
CREATED_VM_GENERATE_NAME = {
@pytest.fixture(scope="module")
def created_vm_generate_name():
return {
"apiVersion": "kubevirt.io/v1", "apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine", "kind": "VirtualMachine",
"metadata": { "metadata": {
@@ -589,12 +497,9 @@ def created_vm_generate_name():
}, },
}, },
}, },
} }
CREATED_VM_SPECS = {
@pytest.fixture(scope="module")
def created_vm_specs():
return {
"apiVersion": "kubevirt.io/v1", "apiVersion": "kubevirt.io/v1",
"kind": "VirtualMachine", "kind": "VirtualMachine",
"metadata": { "metadata": {
@@ -616,24 +521,22 @@ def created_vm_specs():
}, },
}, },
}, },
} }
@pytest.mark.parametrize( @pytest.mark.parametrize(
"params,expected", "params,expected",
[ [
("create_vm_params", "created_vm"), (CREATE_VM_PARAMS, CREATED_VM),
("create_vm_params_annotations", "created_vm_annotations"), (CREATE_VM_PARAMS_ANNOTATIONS, CREATED_VM_ANNOTATIONS),
("create_vm_params_labels", "created_vm_labels"), (CREATE_VM_PARAMS_LABELS, CREATED_VM_LABELS),
("create_vm_params_instancetype", "created_vm_instancetype"), (CREATE_VM_PARAMS_INSTANCETYPE, CREATED_VM_INSTANCETYPE),
("create_vm_params_preference", "created_vm_preference"), (CREATE_VM_PARAMS_PREFERENCE, CREATED_VM_PREFERENCE),
("create_vm_params_datavolumetemplate", "created_vm_datavolumetemplate"), (CREATE_VM_PARAMS_DATAVOLUMETEMPLATE, CREATED_VM_DATAVOLUMETEMPLATE),
("create_vm_params_name", "created_vm_name"), (CREATE_VM_PARAMS_NAME, CREATED_VM_NAME),
("create_vm_params_generate_name", "created_vm_generate_name"), (CREATE_VM_PARAMS_GENERATE_NAME, CREATED_VM_GENERATE_NAME),
("create_vm_params_specs", "created_vm_specs"), (CREATE_VM_PARAMS_SPECS, CREATED_VM_SPECS),
], ],
) )
def test_create_vm(request, params, expected): def test_create_vm(params, expected):
assert kubevirt_vm.create_vm( assert kubevirt_vm.create_vm(params) == expected
request.getfixturevalue(params)
) == request.getfixturevalue(expected)