Release 2.1.1 (#152)

* Check that auth value is not None

The previous check for truth prevented the verify_ssl param from being
set to false, thus forcing ssl verfication in every case.

* Add changelog fragment

* Fix linting

CHANGELOG.rst

@@ -5,6 +5,14 @@ Kubernetes Collection Release Notes
 .. contents:: Topics
 
 
+v2.1.1
+======
+
+Bugfixes
+--------
+
+- check auth params for existence, not whether they are true (https://github.com/ansible-collections/kubernetes.core/pull/151).
+
 v2.1.0
 ======
 

Makefile

@@ -1,5 +1,5 @@
 # Also needs to be updated in galaxy.yml
-VERSION = 2.1.0
+VERSION = 2.1.1
 
 TEST_ARGS ?= ""
 PYTHON_VERSION ?= `python -c 'import platform; print("{0}.{1}".format(platform.python_version_tuple()[0], platform.python_version_tuple()[1]))'`

README.md

@@ -82,7 +82,7 @@ You can also include it in a `requirements.yml` file and install it via `ansible
 ---
 collections:
   - name: kubernetes.core
-    version: 2.1.0
+    version: 2.1.1
 ```
 
 ### Installing the Kubernetes Python Library

changelogs/changelog.yaml

@@ -422,3 +422,10 @@ releases:
     - 148-remove-cloud-common-dependency.yaml
     - 149-disable-turbo-mode.yaml
     release_date: '2021-06-23'
+  2.1.1:
+    changes:
+      bugfixes:
+      - check auth params for existence, not whether they are true (https://github.com/ansible-collections/kubernetes.core/pull/151).
+    fragments:
+    - 151-check-auth-params-for-existence.yaml
+    release_date: '2021-06-24'

galaxy.yml

@@ -25,7 +25,7 @@ tags:
   - openshift
   - okd
   - cluster
-version: 2.1.0
+version: 2.1.1
 build_ignore:
   - .DS_Store
   - '*.tar.gz'

molecule/default/tasks/gc.yml

@@ -37,19 +37,25 @@
       k8s:
         definition: "{{ job_definition }}"
 
-    - name: Test that job's pod is running
+    - name: Wait Job's pod
       k8s_info:
         kind: Pod
         namespace: "{{ gc_namespace }}"
         label_selectors:
           - "job=gc"
-        wait: yes
-        wait_timeout: 100
-      register: job
-      until: job.resources[0].status.phase == "Running"
+      register: wait_job
+      until: wait_job.resources
       retries: 5
       delay: 10
 
+    - name: Wait job's pod running
+      k8s_info:
+        kind: Pod
+        namespace: "{{ gc_namespace }}"
+        name: "{{ wait_job.resources[0].metadata.name }}"
+        wait: yes
+      register: job
+
     - name: Assert job's pod is running
       assert:
         that: job.resources[0].status.phase == "Running"
@@ -81,19 +87,25 @@
       k8s:
         definition: "{{ job_definition }}"
 
-    - name: Test that job's pod is running
+    - name: Wait Job's pod
       k8s_info:
         kind: Pod
         namespace: "{{ gc_namespace }}"
         label_selectors:
           - "job=gc"
-        wait: yes
-        wait_timeout: 100
-      register: job
-      until: job.resources[0].status.phase == "Running"
+      register: wait_job
+      until: wait_job.resources
       retries: 5
       delay: 10
 
+    - name: Wait job's pod running
+      k8s_info:
+        kind: Pod
+        namespace: "{{ gc_namespace }}"
+        name: "{{ wait_job.resources[0].metadata.name }}"
+        wait: yes
+      register: job
+
     - name: Assert job's pod is running
       assert:
         that: job.resources[0].status.phase == "Running"
@@ -126,19 +138,25 @@
       k8s:
         definition: "{{ job_definition }}"
 
-    - name: Test that job's pod is running
+    - name: Wait Job's pod
       k8s_info:
         kind: Pod
         namespace: "{{ gc_namespace }}"
         label_selectors:
           - "job=gc"
-        wait: yes
-        wait_timeout: 100
-      register: job
-      until: job.resources[0].status.phase == "Running"
+      register: wait_job
+      until: wait_job.resources
       retries: 5
       delay: 10
 
+    - name: Wait job's pod running
+      k8s_info:
+        kind: Pod
+        namespace: "{{ gc_namespace }}"
+        name: "{{ wait_job.resources[0].metadata.name }}"
+        wait: yes
+      register: job
+
     - name: Assert job's pod is running
       assert:
         that: job.resources[0].status.phase == "Running"

plugins/module_utils/common.py

@@ -124,7 +124,7 @@ def get_api_client(module=None, **kwargs):
 
     # If authorization variables aren't defined, look for them in environment variables
     for true_name, arg_name in AUTH_ARG_MAP.items():
-        if module and module.params.get(arg_name):
+        if module and module.params.get(arg_name) is not None:
             auth[true_name] = module.params.get(arg_name)
         elif arg_name in kwargs and kwargs.get(arg_name) is not None:
             auth[true_name] = kwargs.get(arg_name)