Release 2.1.1 (#152)

* Check that auth value is not None

The previous check for truth prevented the verify_ssl param from being
set to false, thus forcing ssl verfication in every case.

* Add changelog fragment

* Fix linting

CHANGELOG.rst

@@ -5,6 +5,23 @@ Kubernetes Collection Release Notes
 .. contents:: Topics
 
 
+v2.1.1
+======
+
+Bugfixes
+--------
+
+- check auth params for existence, not whether they are true (https://github.com/ansible-collections/kubernetes.core/pull/151).
+
+v2.1.0
+======
+
+Minor Changes
+-------------
+
+- remove cloud.common as default dependency (https://github.com/ansible-collections/kubernetes.core/pull/148).
+- temporarily disable turbo mode (https://github.com/ansible-collections/kubernetes.core/pull/149).
+
 v2.0.2
 ======
 

Makefile

@@ -1,5 +1,5 @@
 # Also needs to be updated in galaxy.yml
-VERSION = 2.0.2
+VERSION = 2.1.1
 
 TEST_ARGS ?= ""
 PYTHON_VERSION ?= `python -c 'import platform; print("{0}.{1}".format(platform.python_version_tuple()[0], platform.python_version_tuple()[1]))'`

README.md

@@ -82,7 +82,7 @@ You can also include it in a `requirements.yml` file and install it via `ansible
 ---
 collections:
   - name: kubernetes.core
-    version: 2.0.2
+    version: 2.1.1
 ```
 
 ### Installing the Kubernetes Python Library
@@ -159,11 +159,6 @@ If upgrading older playbooks which were built prior to Ansible 2.10 and this col
 
 For documentation on how to use individual modules and other content included in this collection, please see the links in the 'Included content' section earlier in this README.
 
-## Ansible Turbo mode
-
-The ``kubernetes.core`` collection supports Ansible Turbo mode via ``cloud.common`` collection. Please read more about Ansible Turbo mode - [here](https://github.com/ansible-collections/kubernetes.core/blob/main/docs/ansible_turbo_mode.rst).
-
-
 ## Testing and Development
 
 If you want to develop new content for this collection or improve what's already here, the easiest way to work on the collection is to clone it into one of the configured [`COLLECTIONS_PATHS`](https://docs.ansible.com/ansible/latest/reference_appendices/config.html#collections-paths), and work on it there.

changelogs/changelog.yaml

@@ -413,3 +413,19 @@ releases:
     - 129-k8s-fix-apply-array-with-empty-dict.yml
     - 135-rename-apply-function.yml
     release_date: '2021-06-16'
+  2.1.0:
+    changes:
+      minor_changes:
+      - remove cloud.common as default dependency (https://github.com/ansible-collections/kubernetes.core/pull/148).
+      - temporarily disable turbo mode (https://github.com/ansible-collections/kubernetes.core/pull/149).
+    fragments:
+    - 148-remove-cloud-common-dependency.yaml
+    - 149-disable-turbo-mode.yaml
+    release_date: '2021-06-23'
+  2.1.1:
+    changes:
+      bugfixes:
+      - check auth params for existence, not whether they are true (https://github.com/ansible-collections/kubernetes.core/pull/151).
+    fragments:
+    - 151-check-auth-params-for-existence.yaml
+    release_date: '2021-06-24'

galaxy.yml

@@ -8,8 +8,6 @@ authors:
   - willthames (https://github.com/willthames)
   - mmazur (https://github.com/mmazur)
   - jamescassell (https://github.com/jamescassell)
-dependencies:
-  cloud.common: '>=2.0.1'
 description: Kubernetes Collection for Ansible.
 documentation: ''
 homepage: ''
@@ -27,7 +25,7 @@ tags:
   - openshift
   - okd
   - cluster
-version: 2.0.2
+version: 2.1.1
 build_ignore:
   - .DS_Store
   - '*.tar.gz'

molecule/default/tasks/gc.yml

@@ -37,14 +37,23 @@
       k8s:
         definition: "{{ job_definition }}"
 
-    - name: Test that job's pod is running
+    - name: Wait Job's pod
       k8s_info:
         kind: Pod
         namespace: "{{ gc_namespace }}"
         label_selectors:
           - "job=gc"
+      register: wait_job
+      until: wait_job.resources
+      retries: 5
+      delay: 10
+
+    - name: Wait job's pod running
+      k8s_info:
+        kind: Pod
+        namespace: "{{ gc_namespace }}"
+        name: "{{ wait_job.resources[0].metadata.name }}"
         wait: yes
-        wait_timeout: 100
       register: job
 
     - name: Assert job's pod is running
@@ -78,14 +87,23 @@
       k8s:
         definition: "{{ job_definition }}"
 
-    - name: Test that job's pod is running
+    - name: Wait Job's pod
       k8s_info:
         kind: Pod
         namespace: "{{ gc_namespace }}"
         label_selectors:
           - "job=gc"
+      register: wait_job
+      until: wait_job.resources
+      retries: 5
+      delay: 10
+
+    - name: Wait job's pod running
+      k8s_info:
+        kind: Pod
+        namespace: "{{ gc_namespace }}"
+        name: "{{ wait_job.resources[0].metadata.name }}"
         wait: yes
-        wait_timeout: 100
       register: job
 
     - name: Assert job's pod is running
@@ -120,14 +138,23 @@
       k8s:
         definition: "{{ job_definition }}"
 
-    - name: Test that job's pod is running
+    - name: Wait Job's pod
       k8s_info:
         kind: Pod
         namespace: "{{ gc_namespace }}"
         label_selectors:
           - "job=gc"
+      register: wait_job
+      until: wait_job.resources
+      retries: 5
+      delay: 10
+
+    - name: Wait job's pod running
+      k8s_info:
+        kind: Pod
+        namespace: "{{ gc_namespace }}"
+        name: "{{ wait_job.resources[0].metadata.name }}"
         wait: yes
-        wait_timeout: 100
       register: job
 
     - name: Assert job's pod is running

plugins/module_utils/ansiblemodule.py

@@ -3,10 +3,4 @@ from __future__ import (absolute_import, division, print_function)
 __metaclass__ = type
 
 
-try:
-    from ansible_collections.cloud.common.plugins.module_utils.turbo.module import (
-        AnsibleTurboModule as AnsibleModule,
-    )  # noqa: F401
-    AnsibleModule.collection_name = "kubernetes.core"
-except ImportError:
-    from ansible.module_utils.basic import AnsibleModule  # noqa: F401
+from ansible.module_utils.basic import AnsibleModule  # noqa: F401

plugins/module_utils/common.py

@@ -124,7 +124,7 @@ def get_api_client(module=None, **kwargs):
 
     # If authorization variables aren't defined, look for them in environment variables
     for true_name, arg_name in AUTH_ARG_MAP.items():
-        if module and module.params.get(arg_name):
+        if module and module.params.get(arg_name) is not None:
             auth[true_name] = module.params.get(arg_name)
         elif arg_name in kwargs and kwargs.get(arg_name) is not None:
             auth[true_name] = kwargs.get(arg_name)

requirements.yml

@@ -1,2 +0,0 @@
-collections:
-  - cloud.common