From fdddb6f78f3003361513fbbde35e738bc5615973 Mon Sep 17 00:00:00 2001 From: Mike Graves Date: Wed, 8 Jun 2022 13:20:12 -0400 Subject: [PATCH] helm_repository: Silence false no_log warning (#423) (#473) [backport/2.3] helm_repository: Silence false no_log warning (#423) Depends-on: ansible/ansible-zuul-jobs#1563 helm_repository: Silence false no_log warning Depends-On: #424 SUMMARY Apply no_log=True to pass_credentials to silence false positive warning. Fixes: #412 Signed-off-by: Abhijeet Kasurde akasurde@redhat.com ISSUE TYPE Bugfix Pull Request COMPONENT NAME changelogs/fragments/412_pass_creds.yml plugins/modules/helm_repository.py Reviewed-by: Mike Graves mgraves@redhat.com (cherry picked from commit d311ac7) SUMMARY ISSUE TYPE Bugfix Pull Request Docs Pull Request Feature Pull Request New Module Pull Request COMPONENT NAME ADDITIONAL INFORMATION --- changelogs/fragments/412_pass_creds.yml | 3 +++ plugins/modules/helm_repository.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/412_pass_creds.yml diff --git a/changelogs/fragments/412_pass_creds.yml b/changelogs/fragments/412_pass_creds.yml new file mode 100644 index 00000000..59b665c6 --- /dev/null +++ b/changelogs/fragments/412_pass_creds.yml @@ -0,0 +1,3 @@ +--- +minor_changes: +- helm_repository - mark `pass_credentials` as no_log=True to silence false warning (https://github.com/ansible-collections/kubernetes.core/issues/412). diff --git a/plugins/modules/helm_repository.py b/plugins/modules/helm_repository.py index 22b532b5..1125e5e6 100644 --- a/plugins/modules/helm_repository.py +++ b/plugins/modules/helm_repository.py @@ -228,7 +228,7 @@ def main(): repo_state=dict( default="present", choices=["present", "absent"], aliases=["state"] ), - pass_credentials=dict(type="bool", default=False), + pass_credentials=dict(type="bool", default=False, no_log=True), # Generic auth key host=dict(type="str", fallback=(env_fallback, ["K8S_AUTH_HOST"])), ca_cert=dict(