internet/kubernetes.core
3
0
Fork 0
mirror of https://github.com/ansible-collections/kubernetes.core.git synced 2026-03-27 05:43:02 +00:00
Code Issues Projects Releases Wiki Activity

helm_pull: Silence false no_log warning (#796)

Browse Source 
SUMMARY
Apply no_log=True to pass_credentials to silence false positive warning.
Fixes similar issue to: #423
ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME
changelog/fragements/796-false-positive-helmull.yaml
plugins/modules/helm_pull.py

Reviewed-by: Yuriy Novostavskiy
Reviewed-by: Mike Graves <mgraves@redhat.com>
Reviewed-by: Irum Malik
This commit is contained in:
Irum Malik
2025-01-17 15:52:58 +00:00
committed by GitHub
parent bc0de24cba
commit ecc64cace1
3 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/796-false-positive-helmull.yaml Normal file
View File

@@ -0,0 +1,2 @@
bugfixes:
- helm_pull - Apply no_log=True to pass_credentials to silence false positive warning.. (https://github.com/ansible-collections/kubernetes.core/pull/796).

2
plugins/modules/helm_pull.py
View File

@@ -189,7 +189,7 @@ def main():
repo_password=dict( repo_password=dict(
type="str", no_log=True, aliases=["password", "chart_repo_password"] type="str", no_log=True, aliases=["password", "chart_repo_password"]
), ),
pass_credentials=dict(type="bool", default=False), pass_credentials=dict(type="bool", default=False, no_log=False),
skip_tls_certs_check=dict(type="bool", default=False), skip_tls_certs_check=dict(type="bool", default=False),
chart_devel=dict(type="bool"), chart_devel=dict(type="bool"),
untar_chart=dict(type="bool", default=False), untar_chart=dict(type="bool", default=False),

1
tests/integration/targets/helm_pull/tasks/main.yml
View File

@@ -180,6 +180,7 @@
- '"--username ansible" in _result.command' - '"--username ansible" in _result.command'
- '"--password ***" in _result.command' - '"--password ***" in _result.command'
- '"--keyring pubring.gpg" in _result.command' - '"--keyring pubring.gpg" in _result.command'
- '"Module did not set no_log for pass_credentials" not in _result.stderr'
- name: Download chart using chart_ref - name: Download chart using chart_ref
helm_pull: helm_pull: