mirror of
https://github.com/ansible-collections/kubernetes.core.git
synced 2026-11-21 14:48:37 +00:00
Handle empty template output gracefully (#1044)
* Handle empty template output gracefully * Add changelog fragment for empty template output fix * refactor: reduce cognitive complexity of ActionModule.run Extract compound boolean condition to a variable to reduce the cognitive complexity from 16 to the allowed maximum of 15. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * refactor: extract duplicated error handling into _fail_with_error Replace two identical error-handling blocks in ActionModule.run() with a shared _fail_with_error static method to address SonarQube code duplication finding. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * refactor: reduce code duplication in action plugin and tests Revert _fail_with_error extraction that increased duplication on new code. Consolidate duplicate integration test tasks for conditional template into a single looped task. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: aubin bikouo <abikouo@redhat.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
co-authored by
aubin bikouo
Claude Opus 4.6
parent
08a761fc17
commit
ec8942dd90
@@ -35,7 +35,11 @@ def _from_yaml_to_definition(buffer):
|
||||
import yaml
|
||||
except ImportError:
|
||||
raise AnsibleError("Failed to import the required Python library (PyYAML).")
|
||||
return list(yaml.safe_load_all(buffer))
|
||||
|
||||
# Handle empty template output
|
||||
if buffer is None:
|
||||
return []
|
||||
return [doc for doc in yaml.safe_load_all(buffer) if doc is not None]
|
||||
|
||||
|
||||
ENV_KUBECONFIG_PATH_SEPARATOR = ";" if platform.system() == "Windows" else ":"
|
||||
@@ -380,10 +384,15 @@ class ActionModule(ActionBase):
|
||||
template = self._task.args.get("template", None)
|
||||
if template:
|
||||
self.load_template(template, new_module_args, task_vars)
|
||||
# If template rendered to empty definition, return early with no changes
|
||||
if not new_module_args.get("definition"):
|
||||
result["changed"] = False
|
||||
return self._ensure_invocation(result)
|
||||
|
||||
local_path = self._task.args.get("local_path")
|
||||
state = self._task.args.get("state", None)
|
||||
if local_path and state == "to_pod" and not remote_transport:
|
||||
is_local_pod_upload = local_path and state == "to_pod" and not remote_transport
|
||||
if is_local_pod_upload:
|
||||
new_module_args["local_path"] = self.get_file_realpath(local_path)
|
||||
|
||||
# Execute the k8s_* module.
|
||||
|
||||
Reference in New Issue
Block a user