From e754a6cd3126d2ae3ba8cdb34bb0466a54df5c37 Mon Sep 17 00:00:00 2001
From: abikouo <79859644+abikouo@users.noreply.github.com>
Date: Tue, 4 May 2021 15:05:18 +0200
Subject: [PATCH] ``helm_plugin`` and ``helm_plugin_info`` remove unused
 parameter ``release_namespace`` (#85)

* remove unused parameter release_namespace from documentation

* Update changelogs/fragments/85_helm_plugin.yaml

Co-authored-by: Mike Graves <mgraves@redhat.com>
---
 changelogs/fragments/85_helm_plugin.yaml              | 3 +++
 molecule/default/roles/helm/tasks/tests_helm_diff.yml | 2 --
 plugins/modules/helm_plugin.py                        | 8 --------
 plugins/modules/helm_plugin_info.py                   | 8 --------
 4 files changed, 3 insertions(+), 18 deletions(-)
 create mode 100644 changelogs/fragments/85_helm_plugin.yaml

diff --git a/changelogs/fragments/85_helm_plugin.yaml b/changelogs/fragments/85_helm_plugin.yaml
new file mode 100644
index 00000000..bfe54558
--- /dev/null
+++ b/changelogs/fragments/85_helm_plugin.yaml
@@ -0,0 +1,3 @@
+breaking_changes:
+- helm_plugin - remove unused ``release_namespace`` parameter.
+- helm_plugin_info - remove unused ``release_namespace`` parameter.
diff --git a/molecule/default/roles/helm/tasks/tests_helm_diff.yml b/molecule/default/roles/helm/tasks/tests_helm_diff.yml
index 511c7bf6..c461be6d 100644
--- a/molecule/default/roles/helm/tasks/tests_helm_diff.yml
+++ b/molecule/default/roles/helm/tasks/tests_helm_diff.yml
@@ -6,7 +6,6 @@
   block:
     - name: Install helm diff
       helm_plugin:
-        namespace: "{{ helm_namespace }}"
         state: present
         plugin_path: https://github.com/databus23/helm-diff
 
@@ -137,7 +136,6 @@
 
     - name: Uninstall helm diff
       helm_plugin:
-        namespace: "{{ helm_namespace }}"
         state: absent
         plugin_name: diff
       ignore_errors: yes
diff --git a/plugins/modules/helm_plugin.py b/plugins/modules/helm_plugin.py
index 357ee817..222ab8f8 100644
--- a/plugins/modules/helm_plugin.py
+++ b/plugins/modules/helm_plugin.py
@@ -20,13 +20,6 @@ requirements:
 description:
   -  Manages Helm plugins.
 options:
-  # TODO: (akasurde) Remove this in version 2.0
-  release_namespace:
-    description:
-      - Kubernetes namespace where the helm plugin should be installed.
-    type: str
-    aliases: [ namespace ]
-
 #Helm options
   state:
     description:
@@ -108,7 +101,6 @@ def main():
     module = AnsibleModule(
         argument_spec=dict(
             binary_path=dict(type='path'),
-            release_namespace=dict(type='str', aliases=['namespace']),
             state=dict(type='str', default='present', choices=['present', 'absent']),
             plugin_path=dict(type='str',),
             plugin_name=dict(type='str',),
diff --git a/plugins/modules/helm_plugin_info.py b/plugins/modules/helm_plugin_info.py
index b1b86b17..9d43c594 100644
--- a/plugins/modules/helm_plugin_info.py
+++ b/plugins/modules/helm_plugin_info.py
@@ -20,13 +20,6 @@ requirements:
 description:
   -  Gather information about Helm plugins installed in namespace.
 options:
-  # TODO: (akasurde) Remove this in version 2.0
-  release_namespace:
-    description:
-      - Kubernetes namespace where the helm plugins are installed.
-    type: str
-    aliases: [ namespace ]
-
 #Helm options
   plugin_name:
     description:
@@ -88,7 +81,6 @@ def main():
     module = AnsibleModule(
         argument_spec=dict(
             binary_path=dict(type='path'),
-            release_namespace=dict(type='str', aliases=['namespace']),
             plugin_name=dict(type='str',),
             # Helm options
             context=dict(type='str', aliases=['kube_context'], fallback=(env_fallback, ['K8S_AUTH_CONTEXT'])),