Ensure compatibility with Helm v4 for the collection (#1090)

SUMMARY

Ensure compatibility with Helm v4 for modules helm_plugin and helm_plugin_info
Partially addresses #1038

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

helm_plugin
helm_plugin_info
helm_info
helm_pull
helm_registry_auth
helm
helm_template

Reviewed-by: Bianca Henderson <beeankha@gmail.com>
Reviewed-by: Yuriy Novostavskiy <yuriy@novostavskiy.kyiv.ua>
Reviewed-by: Alina Buzachis

tests/integration/targets/helm_kubeconfig/defaults/main.yml

@@ -1,7 +1,10 @@
 ---
-helm_binary: "/tmp/helm/{{ ansible_system | lower }}-amd64/helm"
 default_kubeconfig_path: "~/.kube/config"
 test_namespace:
   - "helm-in-memory-kubeconfig"
   - "helm-kubeconfig-with-ca-cert"
   - "helm-kubeconfig-with-insecure-skip-tls-verify"
+helm_versions:
+  - v3.10.3
+  - v3.16.4
+  - v4.0.0

tests/integration/targets/helm_kubeconfig/meta/main.yml

@@ -1,4 +0,0 @@
----
-dependencies:
-  - remove_namespace
-  - install_helm

tests/integration/targets/helm_kubeconfig/tasks/from_kubeconfig_with_cacert.yml

@@ -57,7 +57,7 @@
       assert:
         that:
           - _install is failed
-          - '"Error: Kubernetes cluster unreachable" in _install.msg'
+          - '"error: kubernetes cluster unreachable" in _install.msg | lower()'
 
     - name: Test helm modules using in-memory kubeconfig
       include_tasks: "tests_helm_auth.yml"

tests/integration/targets/helm_kubeconfig/tasks/from_kubeconfig_with_validate_certs.yml

@@ -48,7 +48,7 @@
       assert:
         that:
           - _install is failed
-          - '"Error: Kubernetes cluster unreachable" in _install.msg'
+          - '"error: kubernetes cluster unreachable" in _install.msg | lower()'
 
     - name: Test helm modules using in-memory kubeconfig
       include_tasks: "tests_helm_auth.yml"

tests/integration/targets/helm_kubeconfig/tasks/main.yml

@@ -1,21 +1,5 @@
 ---
-- name: Test helm with in-memory kubeconfig
-  include_tasks: "from_in_memory_kubeconfig.yml"
+- ansible.builtin.include_tasks: run_tests.yml
+  loop: "{{ helm_versions }}"
   loop_control:
-    loop_var: test_helm_version
-  with_items:
-    - "v3.10.3"
-
-- name: Test helm with custom kubeconfig and validate_certs=false
-  include_tasks: "from_kubeconfig_with_validate_certs.yml"
-  loop_control:
-    loop_var: test_helm_version
-  with_items:
-    - "v3.10.3"
-
-- name: Test helm with custom kubeconfig and ca_cert
-  include_tasks: "from_kubeconfig_with_cacert.yml"
-  loop_control:
-    loop_var: test_helm_version
-  with_items:
-    - "v3.10.3"
+    loop_var: helm_version

tests/integration/targets/helm_kubeconfig/tasks/run_tests.yml

@@ -0,0 +1,15 @@
+---
+- name: Run tests with helm version "{{ helm_version }}"
+  block:
+    - name: "Install Helm"
+      ansible.builtin.include_role:
+        name: install_helm
+
+    - name: Test helm with in-memory kubeconfig
+      ansible.builtin.include_tasks: "from_in_memory_kubeconfig.yml"
+
+    - name: Test helm with custom kubeconfig and validate_certs=false
+      include_tasks: "from_kubeconfig_with_validate_certs.yml"
+
+    - name: Test helm with custom kubeconfig and ca_cert
+      include_tasks: "from_kubeconfig_with_cacert.yml"

tests/integration/targets/helm_kubeconfig/tasks/tests_helm_auth.yml

@@ -5,16 +5,6 @@
     suffix: .helm
   register: _dir
 
-- name: Install helm binary
-  block:
-    - name: "Install {{ test_helm_version }}"
-      include_role:
-        name: install_helm
-      vars:
-        helm_version: "{{ test_helm_version }}"
-
-  when: test_helm_version is defined
-
 - set_fact:
     saved_kubeconfig_path: "{{ _dir.path }}/config"
 
@@ -44,6 +34,7 @@
         ca_cert: "{{ test_ca_cert | default(omit) }}"
         state: present
         plugin_path: https://github.com/hydeenoble/helm-subenv
+        verify: false
       register: plugin
 
     - assert: