Ensure compatibility with Helm v4 for the collection (#1090)

SUMMARY

Ensure compatibility with Helm v4 for modules helm_plugin and helm_plugin_info
Partially addresses #1038

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

helm_plugin
helm_plugin_info
helm_info
helm_pull
helm_registry_auth
helm
helm_template

Reviewed-by: Bianca Henderson <beeankha@gmail.com>
Reviewed-by: Yuriy Novostavskiy <yuriy@novostavskiy.kyiv.ua>
Reviewed-by: Alina Buzachis

tests/integration/targets/helm/library/helm_test_pending.py

@@ -52,7 +52,9 @@ import json
 import subprocess
 import time
 
-from ansible.module_utils.basic import AnsibleModule
+from ansible_collections.kubernetes.core.plugins.module_utils.helm import (
+    AnsibleHelmModule,
+)
 
 
 class HelmReleaseNotFoundError(Exception):
@@ -60,7 +62,9 @@ class HelmReleaseNotFoundError(Exception):
         super().__init__(message)
 
 
-def create_pending_install_release(helm_binary, chart_ref, chart_release, namespace):
+def create_pending_install_release(
+    module, helm_binary, chart_ref, chart_release, namespace
+):
     # create pending-install release
     command = [
         helm_binary,
@@ -78,13 +82,14 @@ def create_pending_install_release(helm_binary, chart_ref, chart_release, namesp
     command = [
         helm_binary,
         "list",
-        "--all",
         "--output=json",
         "--namespace",
         namespace,
         "--filter",
         chart_release,
     ]
+    if not module.is_helm_v4():
+        command.append("--all")
     cmd = subprocess.Popen(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
     out, err = cmd.communicate()
 
@@ -92,11 +97,11 @@ def create_pending_install_release(helm_binary, chart_ref, chart_release, namesp
     if not data:
         error = "Release %s not found." % chart_release
         raise HelmReleaseNotFoundError(message=error)
-    return data[0]["status"] == "pending-install", data[0]["status"]
+    return data[0]["status"] in ("pending-install", "failed"), data[0]["status"]
 
 
 def main():
-    module = AnsibleModule(
+    module = AnsibleHelmModule(
         argument_spec=dict(
             binary_path=dict(type="path", required=True),
             chart_ref=dict(type="str", required=True),
@@ -106,6 +111,7 @@ def main():
     )
 
     params = dict(
+        module=module,
         helm_binary=module.params.get("binary_path"),
         chart_release=module.params.get("chart_release"),
         chart_ref=module.params.get("chart_ref"),
@@ -116,7 +122,7 @@ def main():
         result, status = create_pending_install_release(**params)
         if not result:
             module.fail_json(
-                msg="unable to create pending-install release, current status is %s"
+                msg="unable to create pending-install/failed release, current status is %s"
                 % status
             )
         module.exit_json(changed=True, msg="Release created with status '%s'" % status)