fix(helm): skip Helm's OCI registry progress messages on stdout (#1223) (#1247)

* fix(helm): skip OCI registry progress messages on stdout

Helm 4.2.1 moved the registry client's progress messages from stderr to
stdout (helm/helm#32056), so on an OCI reference they now precede the real
output. helm parses the stdout of `helm show chart` and helm_template
returns the stdout of `helm template`, and neither can detect this from the
return code because both commands exit 0.

Helm rewrites '+' to '_' in OCI tags, which makes it also print a free-text
explanation. That is not valid YAML, so a chart version carrying semver
build metadata failed outright. Without the '+' the messages parse as a
mapping instead, silently adding Pulled/Digest keys to the chart info.

Match helm's message verbatim rather than seeking the start of the real
output: the payload has three shapes and can be empty, whereas the messages
are always at the front and byte-identical. A reworded message then fails
loudly instead of consuming a line of real output.

Fixes: #1222

* test(helm): cover OCI charts whose version has build metadata

Pushes a chart versioned 1.0.0+build.1 to the local registry and asserts
that helm installs it idempotently with the version reported verbatim, and
that helm_template returns only rendered manifests. A second version without
build metadata covers the case where the registry messages parse as YAML.

Pinned to Helm 4.2.4: the target is only meaningful on >= 4.2.1, which is
where the messages moved to stdout. The rest of the helm matrix tops out at
v4.0.0, which is why this went unnoticed.

Verified to fail on the parent commit and pass on the fix.

* test(helm): drop Go template from chart fixture

The yamllint sanity test parses chart templates with libyaml, where
`{{ default "test" .Values.myValue }}` is an unhashable mapping key. The
existing chart fixtures carry a yamllint!skip entry in every
tests/sanity/ignore-*.txt for exactly this, but the target never renders
the chart with values, so the template served no purpose. Making the
fixture plain YAML keeps the ignore lists from growing.

* test(ci): empty commit to re-trigger CI

(cherry picked from commit c098ecc8c8)

Co-authored-by: Yuriy Novostavskiy <yuriy@novostavskiy.kyiv.ua>
This commit is contained in:
patchback[bot]
2026-09-14 14:33:17 +01:00
committed by GitHub
co-authored by Yuriy Novostavskiy
parent e620b92b49
commit b40a401ec2
11 changed files with 364 additions and 1 deletions
@@ -0,0 +1,111 @@
# -*- coding: utf-8 -*-
# Copyright: (c) 2026, Ansible Project
# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt)
from __future__ import absolute_import, division, print_function
__metaclass__ = type
import pytest
import yaml
from ansible_collections.kubernetes.core.plugins.module_utils.helm import (
strip_registry_progress,
)
# What helm's registry client prints, verbatim. Since helm 4.2.1 this goes to
# stdout ahead of the command's real output (helm/helm#32056).
PULLED = "Pulled: registry.example.com/charts/demochart:109.0.1_up1.0.2\n"
DIGEST = (
"Digest: sha256:41e9b37f85fa7f5df5fc7f2b7b068eb56ae1592784eee28f535563b599850249\n"
)
PUSHED = "Pushed: registry.example.com/charts/demochart:109.0.1_up1.0.2\n"
UNDERSCORE_WARNING = (
"registry.example.com/charts/demochart:109.0.1_up1.0.2 contains an underscore.\n"
"\n"
"OCI artifact references (e.g. tags) do not support the plus sign (+). To support\n"
"storing semantic versions, Helm adopts the convention of changing plus (+) to\n"
"an underscore (_) in chart version tags when pushing to a registry and back to\n"
"a plus (+) when pulling from a registry.\n"
)
# 'helm show chart' output. Note that helm marshals Chart.yaml with sorted keys, so
# 'annotations' precedes 'apiVersion' and the metadata does not reliably start with
# a fixed key.
CHART_YAML = (
"annotations:\n"
" category: Demo\n"
"apiVersion: v2\n"
"appVersion: 1.16.0\n"
"description: A Helm chart for Kubernetes\n"
"name: demochart\n"
"type: application\n"
"version: 109.0.1+up1.0.2\n"
)
# 'helm template' output.
MANIFESTS = (
"---\n"
"# Source: demochart/templates/serviceaccount.yaml\n"
"apiVersion: v1\n"
"kind: ServiceAccount\n"
"metadata:\n"
" name: rel-demochart\n"
)
# 'helm template --output-dir' output.
WROTE = (
"wrote outdir/demochart/templates/serviceaccount.yaml\n"
"wrote outdir/demochart/templates/service.yaml\n"
)
@pytest.mark.parametrize(
"payload",
[CHART_YAML, MANIFESTS, WROTE, ""],
ids=["show_chart", "template", "template_output_dir", "empty"],
)
@pytest.mark.parametrize(
"progress",
[
"",
PULLED + DIGEST,
PULLED + DIGEST + UNDERSCORE_WARNING,
PUSHED + DIGEST + UNDERSCORE_WARNING,
],
ids=["none", "pulled_digest", "with_warning", "pushed_with_warning"],
)
def test_progress_is_stripped_and_payload_is_untouched(progress, payload):
assert strip_registry_progress(progress + payload) == payload
def test_show_chart_output_is_parseable_once_stripped():
# Unstripped, the free-text warning makes this invalid YAML.
out = PULLED + DIGEST + UNDERSCORE_WARNING + CHART_YAML
with pytest.raises(yaml.YAMLError):
yaml.safe_load(out)
chart_info = yaml.safe_load(strip_registry_progress(out))
assert chart_info["name"] == "demochart"
assert chart_info["version"] == "109.0.1+up1.0.2"
assert chart_info["annotations"] == {"category": "Demo"}
def test_pulled_and_digest_alone_parse_as_yaml_but_pollute_the_result():
# Without the warning the output is still valid YAML, so the pollution is silent.
assert yaml.safe_load(PULLED + DIGEST + CHART_YAML)["Pulled"]
assert "Pulled" not in yaml.safe_load(
strip_registry_progress(PULLED + DIGEST + CHART_YAML)
)
def test_reworded_warning_is_left_alone():
# A message helm no longer emits verbatim must not be partially consumed: better
# to fail loudly than to silently drop a line of real output.
reworded = UNDERSCORE_WARNING.replace("plus sign (+)", "plus character (+)")
out = PULLED + DIGEST + reworded + CHART_YAML
assert strip_registry_progress(out) == reworded + CHART_YAML
def test_progress_like_lines_inside_the_payload_are_kept():
payload = "description: |\n Digest: not a helm message\n" + CHART_YAML
assert strip_registry_progress(PULLED + payload) == payload