Ensure compatibility with Helm v4 for the collection (#1090) (#1096)

This is a backport of PR #1090 as merged into main (e6076e5).
SUMMARY

Ensure compatibility with Helm v4 for modules helm_plugin and helm_plugin_info
Partially addresses #1038

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

helm_plugin
helm_plugin_info
helm_info
helm_pull
helm_registry_auth
helm
helm_template

Reviewed-by: Bikouo Aubin
Reviewed-by: Matthew Johnson

tests/integration/targets/helm_set_values/defaults/main.yml

@@ -1,3 +1,5 @@
 ---
-helm_binary: "/tmp/helm/{{ ansible_system | lower }}-amd64/helm"
 helm_namespace: helm-set-values
+helm_versions:
+  - v3.10.3
+  - v4.0.0

tests/integration/targets/helm_set_values/tasks/main.yml

@@ -25,79 +25,14 @@
     - user_values.status["release_values"]["phase"] == "integration"
     - user_values.status["release_values"]["versioned"] is false
 
-# install chart using set_values and release_values
-- name: Install helm binary (> 3.10.0) requires to use set-json
-  include_role:
-    name: install_helm
-  vars:
-    helm_version: "v3.10.3"
-
-- name: Install helm using set_values parameters
-  helm:
-    binary_path: "{{ helm_binary }}"
-    chart_ref: oci://registry-1.docker.io/bitnamicharts/apache
-    release_name: test-apache
-    release_namespace: "{{ helm_namespace }}"
-    create_namespace: true
-    set_values:
-    - value: 'master.image={"registry": "docker.io", "repository": "bitnami/apache", "tag": "2.4.54-debian-11-r74"}'
-      value_type: json
-    release_values:
-      replicaCount: 3
-
-- name: Get release info
-  helm_info:
-    binary_path: "{{ helm_binary }}"
-    release_name: test-apache
-    release_namespace: "{{ helm_namespace }}"
-  register: values
-
-- name: Assert that release was created with user-defined variables
-  assert:
-    that:
-    - values.status["release_values"].replicaCount == 3
-    - values.status["release_values"].master.image.registry == "docker.io"
-    - values.status["release_values"].master.image.repository == "bitnami/apache"
-    - values.status["release_values"].master.image.tag == "2.4.54-debian-11-r74"
-
-# install chart using set_values and values_files
-- name: create temporary file to save values in
-  tempfile:
-    suffix: .yml
-  register: ymlfile
-
 - block:
-  - name: copy content into values file
-    copy:
-      content: |
-        ---
-        mode: distributed
-      dest: "{{ ymlfile.path }}"
+  - name: create temporary file to save values in
+    tempfile:
+      suffix: .yml
+    register: ymlfile
 
-  - name: Install helm using set_values parameters
-    helm:
-      binary_path: "{{ helm_binary }}"
-      chart_ref: oci://registry-1.docker.io/bitnamicharts/minio
-      release_name: test-minio
-      release_namespace: "{{ helm_namespace }}"
-      create_namespace: true
-      set_values:
-      - value: 'disableWebUI=true'
-      values_files:
-      - "{{ ymlfile.path }}"
-
-  - name: Get release info
-    helm_info:
-      binary_path: "{{ helm_binary }}"
-      release_name: test-minio
-      release_namespace: "{{ helm_namespace }}"
-    register: values
-
-  - name: Assert that release was created with user-defined variables
-    assert:
-      that:
-      - values.status["release_values"].mode == "distributed"
-      - values.status["release_values"].disableWebUI is true
+  - ansible.builtin.include_tasks: run_tests.yml
+    loop: "{{ helm_versions }}"
 
   always:
   - name: Delete temporary file

tests/integration/targets/helm_set_values/tasks/run_tests.yml

@@ -0,0 +1,68 @@
+---
+# install chart using set_values and release_values
+- name: 'Install helm binary (> 3.10.0) requires to use set-json (helm_version={{ item }})'
+  include_role:
+    name: install_helm
+  vars:
+    helm_version: "{{ item }}"
+
+- name: Install helm using set_values parameters
+  helm:
+    binary_path: "{{ helm_binary }}"
+    chart_ref: oci://registry-1.docker.io/bitnamicharts/apache
+    release_name: 'test-apache-{{ item }}'
+    release_namespace: "{{ helm_namespace }}"
+    create_namespace: true
+    set_values:
+    - value: 'master.image={"registry": "docker.io", "repository": "bitnami/apache", "tag": "2.4.54-debian-11-r74"}'
+      value_type: json
+    release_values:
+      replicaCount: 3
+
+- name: Get release info
+  helm_info:
+    binary_path: "{{ helm_binary }}"
+    release_name: 'test-apache-{{ item }}'
+    release_namespace: "{{ helm_namespace }}"
+  register: values
+
+- name: Assert that release was created with user-defined variables
+  assert:
+    that:
+    - values.status["release_values"].replicaCount == 3
+    - values.status["release_values"].master.image.registry == "docker.io"
+    - values.status["release_values"].master.image.repository == "bitnami/apache"
+    - values.status["release_values"].master.image.tag == "2.4.54-debian-11-r74"
+
+# install chart using set_values and values_files
+- name: copy content into values file
+  copy:
+    content: |
+      ---
+      mode: distributed
+    dest: "{{ ymlfile.path }}"
+
+- name: Install helm using set_values parameters
+  helm:
+    binary_path: "{{ helm_binary }}"
+    chart_ref: oci://registry-1.docker.io/bitnamicharts/minio
+    release_name: 'test-minio-{{ item }}'
+    release_namespace: "{{ helm_namespace }}"
+    create_namespace: true
+    set_values:
+    - value: 'disableWebUI=true'
+    values_files:
+    - "{{ ymlfile.path }}"
+
+- name: Get release info
+  helm_info:
+    binary_path: "{{ helm_binary }}"
+    release_name: 'test-minio-{{ item }}'
+    release_namespace: "{{ helm_namespace }}"
+  register: values
+
+- name: Assert that release was created with user-defined variables
+  assert:
+    that:
+    - values.status["release_values"].mode == "distributed"
+    - values.status["release_values"].disableWebUI is true