From 9a529fc8f3bd82ec8955f752bad1a90397e2cfaf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gon=C3=A9ri=20Le=20Bouder?= Date: Thu, 22 Apr 2021 10:30:38 -0400 Subject: [PATCH] helm: accept context and validate_certs (#74) I've got the following environment variable set: - `K8S_AUTH_VERIFY_SSL=False` Helm's `validate_certs` parameter fallback on this environment variable. Which means, on my system, the `validate_certs` will already be set. So we cannot make this parameter exclusive wih another one. --- changelogs/fragments/helm_validate_certs_not_exclusive.yaml | 3 +++ plugins/modules/helm.py | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 changelogs/fragments/helm_validate_certs_not_exclusive.yaml diff --git a/changelogs/fragments/helm_validate_certs_not_exclusive.yaml b/changelogs/fragments/helm_validate_certs_not_exclusive.yaml new file mode 100644 index 00000000..a3eed341 --- /dev/null +++ b/changelogs/fragments/helm_validate_certs_not_exclusive.yaml @@ -0,0 +1,3 @@ +--- +bugfixes: +- "helm - Accept ``validate_certs`` with a ``context`` (https://github.com/ansible-collections/kubernetes.core/pull/74)." diff --git a/plugins/modules/helm.py b/plugins/modules/helm.py index 89863225..708f33c0 100644 --- a/plugins/modules/helm.py +++ b/plugins/modules/helm.py @@ -519,9 +519,7 @@ def main(): ], mutually_exclusive=[ ("context", "ca_cert"), - ("context", "validate_certs"), ("kubeconfig", "ca_cert"), - ("kubeconfig", "validate_certs") ], supports_check_mode=True, )