From 8640c16cd41c3713d33fdcb97ba022b7587c4988 Mon Sep 17 00:00:00 2001 From: Paul Voss Date: Mon, 3 Apr 2023 20:46:03 +0200 Subject: [PATCH] fix post_renderer argument breaking the helm deploy_command (#586) fix post_renderer arguments breaking the helm deploy_command SUMMARY The post_renderer setting is broken and resets the deploy_command instead of appending an argument. Diff should be self explanatory. ISSUE TYPE Bugfix Pull Request COMPONENT NAME kubernetes.core.helm ADDITIONAL INFORMATION Reviewed-by: Mike Graves --- changelogs/fragments/586-helm-fix-post-renderer-arg.yml | 3 +++ plugins/modules/helm.py | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/586-helm-fix-post-renderer-arg.yml diff --git a/changelogs/fragments/586-helm-fix-post-renderer-arg.yml b/changelogs/fragments/586-helm-fix-post-renderer-arg.yml new file mode 100644 index 00000000..2582a486 --- /dev/null +++ b/changelogs/fragments/586-helm-fix-post-renderer-arg.yml @@ -0,0 +1,3 @@ +--- +bugfixes: + - helm - fix post_renderer argument breaking the helm deploy_command (https://github.com/ansible-collections/kubernetes.core/pull/586). diff --git a/plugins/modules/helm.py b/plugins/modules/helm.py index baa12813..db3aae31 100644 --- a/plugins/modules/helm.py +++ b/plugins/modules/helm.py @@ -560,7 +560,7 @@ def deploy( module.add_cleanup_file(path) if post_renderer: - deploy_command = " --post-renderer=" + post_renderer + deploy_command += " --post-renderer=" + post_renderer if skip_crds: deploy_command += " --skip-crds"