internet/kubernetes.core
3
0
Fork 0
mirror of https://github.com/ansible-collections/kubernetes.core.git synced 2026-05-13 21:12:05 +00:00
Code Issues Projects Releases Wiki Activity

helm_template: add optional show_only and release_namespace arguments (#388)

Browse Source 
helm_template: add optional show_only and release_namespace arguments

SUMMARY

This PR adds the "show_only" and "release_namespace" as optional arguments to the helm_template module.
It does some work towards #313.

ISSUE TYPE


Feature Pull Request

COMPONENT NAME

changelogs/fragments/313-helm-template-add-support-for-show-only-and-release-namespace.yml
plugins/modules/helm_template.py
tests/unit/modules/test_helm_template.py
ADDITIONAL INFORMATION


The PR does include unit tests instead of integration test.
Reasoning:
The existing integration tests already include a task based on helm_template. So we know that the module does a proper job of using the command line generated inside the module to call helm.
As I trust helm itself to "do its job" correctly, all that should be necessary is to test the correct generation of the command line itself. The included unit tests hopefully do a proper job.
With regards of the pretty long testing times for the module, I really prefer unit tests, if at all possible.
Please let me know if this fits.

Reviewed-by: Abhijeet Kasurde <None>
Reviewed-by: Mike Graves <mgraves@redhat.com>
This commit is contained in:
Christian von Stebut
2022-03-01 19:57:17 +01:00
committed by GitHub
parent 7031829897
commit 73499d9a09
3 changed files with 134 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
changelogs/fragments/313-helm-template-add-support-for-show-only-and-release-namespace.yml Normal file
View File

@@ -0,0 +1,3 @@
---
minor_changes:
- helm_template - add show_only and release_namespace as module arguments (https://github.com/ansible-collections/kubernetes.core/issues/313).