internet/kubernetes.core
3
0
Fork 0
mirror of https://github.com/ansible-collections/kubernetes.core.git synced 2026-05-14 21:42:21 +00:00
Code Issues Projects Releases Wiki Activity

fix(helm_repository): strip trailing slashes from repo_url (#1121) (#1126)

Browse Source 
Helm normalizes repository URLs internally, so a URL supplied with a
trailing slash and the same URL without one are treated as different
entries. This causes the module to fail every run when the user
provides a trailing slash, even though the repository is already
correctly registered.

Strip the trailing slash from repo_url before comparing against the
existing repository list so repeated runs with the same input are
idempotent.

Fixes #480

(cherry picked from commit 8a58d3b6de)

Co-authored-by: Yuriy Novostavskiy <yuriy@novostavskiy.kiev.ua>
This commit is contained in:
patchback[bot]
2026-05-14 10:56:28 -04:00
committed by GitHub
parent 2fb6546b03
commit 714c2f6711
2 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
changelogs/fragments/20260506-improve_idempotency_for_helm_repository.yaml Normal file
View File

@@ -0,0 +1,2 @@
bugfixes:
- helm_repository - correct handling of repository URLs with trailing slashes (https://github.com/ansible-collections/kubernetes.core/pull/1121).

2
plugins/modules/helm_repository.py
View File

@@ -302,6 +302,8 @@ def main():
repo_name = module.params.get("repo_name") repo_name = module.params.get("repo_name")
repo_url = module.params.get("repo_url") repo_url = module.params.get("repo_url")
if repo_url:
repo_url = repo_url.rstrip("/")
repo_username = module.params.get("repo_username") repo_username = module.params.get("repo_username")
repo_password = module.params.get("repo_password") repo_password = module.params.get("repo_password")
repo_state = module.params.get("repo_state") repo_state = module.params.get("repo_state")