From 5148ee5f749cc53ef8a96662cb5cdee9190a7918 Mon Sep 17 00:00:00 2001 From: Bianca Henderson Date: Mon, 11 Aug 2025 12:46:40 -0400 Subject: [PATCH] Reapply "Remove kubeconfig value from module invocation log (#826)" (#899) (#978) This reverts commit 1705ced (i.e., reapplies the changes from #826); this is a temporary fix for #782 as it will re-introduce #870, which will need to be re-opened. Reviewed-by: Alina Buzachis Reviewed-by: GomathiselviS --- changelogs/fragments/20250411-kubeconfig-no_log-revert.yaml | 3 --- plugins/module_utils/args_common.py | 2 +- plugins/module_utils/helm_args_common.py | 1 + 3 files changed, 2 insertions(+), 4 deletions(-) delete mode 100644 changelogs/fragments/20250411-kubeconfig-no_log-revert.yaml diff --git a/changelogs/fragments/20250411-kubeconfig-no_log-revert.yaml b/changelogs/fragments/20250411-kubeconfig-no_log-revert.yaml deleted file mode 100644 index 0dd34e21..00000000 --- a/changelogs/fragments/20250411-kubeconfig-no_log-revert.yaml +++ /dev/null @@ -1,3 +0,0 @@ ---- -bugfixes: - - kubeconfig option should return the full manifest output (https://github.com/ansible-collections/kubernetes.core/issues/870). diff --git a/plugins/module_utils/args_common.py b/plugins/module_utils/args_common.py index 27f4eacc..c3114f3c 100644 --- a/plugins/module_utils/args_common.py +++ b/plugins/module_utils/args_common.py @@ -18,7 +18,7 @@ AUTH_PROXY_HEADERS_SPEC = dict( ) AUTH_ARG_SPEC = { - "kubeconfig": {"type": "raw"}, + "kubeconfig": {"type": "raw", "no_log": True}, "context": {}, "host": {}, "api_key": {"no_log": True}, diff --git a/plugins/module_utils/helm_args_common.py b/plugins/module_utils/helm_args_common.py index ebf8e9f5..277be01d 100644 --- a/plugins/module_utils/helm_args_common.py +++ b/plugins/module_utils/helm_args_common.py @@ -16,6 +16,7 @@ HELM_AUTH_ARG_SPEC = dict( type="raw", aliases=["kubeconfig_path"], fallback=(env_fallback, ["K8S_AUTH_KUBECONFIG"]), + no_log=True, ), host=dict(type="str", fallback=(env_fallback, ["K8S_AUTH_HOST"])), ca_cert=dict(