From 43ae9664fc0bcdb1c147b271d9786d944bd2af55 Mon Sep 17 00:00:00 2001 From: Will Thames Date: Tue, 9 Jun 2020 18:54:48 +1000 Subject: [PATCH] W504 Move binary operator to start of line from end of line PEP8 prefers binary operators at the start of a line https://www.python.org/dev/peps/pep-0008/#should-a-line-break-before-or-after-a-binary-operator --- plugins/module_utils/common.py | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/plugins/module_utils/common.py b/plugins/module_utils/common.py index f9562011..9120116d 100644 --- a/plugins/module_utils/common.py +++ b/plugins/module_utils/common.py @@ -325,21 +325,21 @@ class KubernetesAnsibleModule(AnsibleModule, K8sAnsibleMixin): # Scaling up means that we also need to check that we're not in a # situation where status.replicas == status.availableReplicas # but spec.replicas != status.replicas - return (deployment.status and - deployment.spec.replicas == (deployment.status.replicas or 0) and - deployment.status.availableReplicas == deployment.status.replicas and - deployment.status.observedGeneration == deployment.metadata.generation and - not deployment.status.unavailableReplicas) + return (deployment.status + and deployment.spec.replicas == (deployment.status.replicas or 0) + and deployment.status.availableReplicas == deployment.status.replicas + and deployment.status.observedGeneration == deployment.metadata.generation + and not deployment.status.unavailableReplicas) def _pod_ready(pod): - return (pod.status and pod.status.containerStatuses is not None and - all([container.ready for container in pod.status.containerStatuses])) + return (pod.status and pod.status.containerStatuses is not None + and all([container.ready for container in pod.status.containerStatuses])) def _daemonset_ready(daemonset): - return (daemonset.status and daemonset.status.desiredNumberScheduled is not None and - daemonset.status.numberReady == daemonset.status.desiredNumberScheduled and - daemonset.status.observedGeneration == daemonset.metadata.generation and - not daemonset.status.unavailableReplicas) + return (daemonset.status and daemonset.status.desiredNumberScheduled is not None + and daemonset.status.numberReady == daemonset.status.desiredNumberScheduled + and daemonset.status.observedGeneration == daemonset.metadata.generation + and not daemonset.status.unavailableReplicas) def _custom_condition(resource): if not resource.status or not resource.status.conditions: